On Wed, 2017-05-03 at 10:33 -0400, Mike Snitzer wrote:
> On Tue, May 02 2017 at 11:33pm -0400,
> Nicholas A. Bellinger wrote:
>
> > On Tue, 2017-05-02 at 09:23 +0200, h...@lst.de wrote:
> > > On Tue, May 02, 2017 at 12:16:13AM -0700, Nicholas A. Bellinger wrote:
> > > > Or, another options is use
On Thu, 2017-05-04 at 18:13 -0500, Bryant G. Ly wrote:
>
>
> Sorry Nick, but can you hold off on this patch. We are still getting extra
> responses but in a small timing window.
>
> The majority of the aborts work but if we get an abort between LIO calling
> queue_state and LIO calling release_
From: Xiubo Li
The fifo type waiter list will hold the udevs who are waiting for the
blocks from the data global pool. The unmap thread will try to feed the
first udevs in waiter list, if the global free blocks available are
not enough, it will stop traversing the list and abort waking up the
oth
On 5/3/17 1:55 PM, Bryant G. Ly wrote:
On 5/3/17 11:38 AM, Bryant G. Ly wrote:
Hi Nick,
On 5/2/17 10:43 PM, Nicholas A. Bellinger wrote:
On Tue, 2017-05-02 at 13:54 -0500, Bryant G. Ly wrote:
The driver is sending a response to the actual scsi op that was
aborted by an abort task TM, whil
Reviewed-by: Scott Benesh
Reviewed-by: Scott Teel
Reviewed-by: Kevin Barnett
Signed-off-by: Don Brace
---
drivers/scsi/hpsa.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 9a631e3..9934947 100644
--- a/drivers/scsi/hpsa.c
- Block I/O requests with 0 length transfers which go down
the ioaccel path. This causes lockup issues down in the basecode.
- These issues have been fixed, but there are customers who are
experiencing the issues when running older firmware.
Reviewed-by: Scott Benesh
Reviewed-by: Scot
- call scsi_done when the command completes.
Reviewed-by: Scott Benesh
Reviewed-by: Scott Teel
Reviewed-by: Kevin Barnett
Signed-off-by: Don Brace
---
drivers/scsi/hpsa.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 53
- simplify the driver
- there are a lot of quirky racy conditions not handled
- causes more aborts/resets when the number of commands to
be aborted is large, such as in multi-path fail-overs.
- has been turned off in our internal driver since 8/31/2015
Reviewed-by: Scott Benesh
Reviewed-by
- queue depth assignment not in correct place, had no effect.
Reviewed-by: Scott Benesh
Reviewed-by: Scott Teel
Reviewed-by: Kevin Barnett
Signed-off-by: Don Brace
---
drivers/scsi/hpsa.c | 22 ++
drivers/scsi/hpsa.h |1 +
2 files changed, 11 insertions(+), 12 delet
From: Scott Teel
create new worker thread to monitor controller events
- both the rescan and event monitor workers can cause a
rescan to occur however for multipath we have found
that we need to respond faster than the normal scheduled
rescan interval for path fail-overs.
- getting con
Prevent enclosure resets.
Reviewed-by: Scott Benesh
Reviewed-by: Scott Teel
Reviewed-by: Kevin Barnett
Signed-off-by: Don Brace
---
drivers/scsi/hpsa.c |3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 9fb30c4..2990897 100644
--- a/drive
- schedule another scan.
- mark current scan as completed
Reviewed-by: Scott Benesh
Reviewed-by: Scott Teel
Reviewed-by: Kevin Barnett
Signed-off-by: Don Brace
---
drivers/scsi/hpsa.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 2990
- mark device state sooner.
Reviewed-by: Scott Benesh
Reviewed-by: Scott Teel
Reviewed-by: Kevin Barnett
Signed-off-by: Don Brace
---
drivers/scsi/hpsa.c | 59 +++
drivers/scsi/hpsa.h |1 +
2 files changed, 46 insertions(+), 14 deletions(
Use the return from TUR as a check for the
device state.
Reviewed-by: Scott Benesh
Reviewed-by: Scott Teel
Reviewed-by: Kevin Barnett
Signed-off-by: Don Brace
---
drivers/scsi/hpsa.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa
These patches are based on Linus's tree
These patches are for:
- RedHat BZ: 1404073 - [HPE 7.3 Bug] multipath failover not reliable
- Multipath failover support in general.
The changes are:
- update identify physical device structure
- align with FW
- stop getting enclosure info for extern
- align with latest spec.
- added __attribute((aligned(512)))
Reviewed-by: Scott Teel
Reviewed-by: Scott Benesh
Reviewed-by: Kevin Barnett
Signed-off-by: Don Brace
---
drivers/scsi/hpsa_cmd.h | 20 ++--
1 file changed, 14 insertions(+), 6 deletions(-)
diff --git a/drivers
external shelves do not support BMICs.
Reviewed-by: Scott Benesh
Reviewed-by: Scott Teel
Reviewed-by: Kevin Barnett
Signed-off-by: Don Brace
---
drivers/scsi/hpsa.c |5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 73daace..8e22aed 100
On 05/03/2017 09:29 AM, Colin King wrote:
> From: Colin Ian King
>
> The 2nd check to see if request_size is less than zero is redundant
> because the first check takes error exit path on this condition. So,
> since it is redundant, remove it.
>
> Detected by CoverityScan, CID#146149 ("Logically
Reviewed-by: Scott Benesh
Reviewed-by: Scott Teel
Reviewed-by: Kevin Barnett
Signed-off-by: Don Brace
---
drivers/scsi/hpsa.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 9a631e3..9934947 100644
--- a/drivers/scsi/hpsa.c
- simplify the driver
- there are a lot of quirky racy conditions not handled
- causes more aborts/resets when the number of commands to
be aborted is large, such as in multi-path fail-overs.
- has been turned off in our internal driver since 8/31/2015
Reviewed-by: Scott Benesh
Reviewed-by
- Block I/O requests with 0 length transfers which go down
the ioaccel path. This causes lockup issues down in the basecode.
- These issues have been fixed, but there are customers who are
experiencing the issues when running older firmware.
Reviewed-by: Scott Benesh
Reviewed-by: Scot
From: Scott Teel
create new worker thread to monitor controller events
- both the rescan and event monitor workers can cause a
rescan to occur however for multipath we have found
that we need to respond faster than the normal scheduled
rescan interval for path fail-overs.
- getting con
- queue depth assignment not in correct place, had no effect.
Reviewed-by: Scott Benesh
Reviewed-by: Scott Teel
Reviewed-by: Kevin Barnett
Signed-off-by: Don Brace
---
drivers/scsi/hpsa.c | 22 ++
drivers/scsi/hpsa.h |1 +
2 files changed, 11 insertions(+), 12 delet
- call scsi_done when the command completes.
Reviewed-by: Scott Benesh
Reviewed-by: Scott Teel
Reviewed-by: Kevin Barnett
Signed-off-by: Don Brace
---
drivers/scsi/hpsa.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 53
- mark device state sooner.
Reviewed-by: Scott Benesh
Reviewed-by: Scott Teel
Reviewed-by: Kevin Barnett
Signed-off-by: Don Brace
---
drivers/scsi/hpsa.c | 59 +++
drivers/scsi/hpsa.h |1 +
2 files changed, 46 insertions(+), 14 deletions(
Prevent enclosure resets.
Reviewed-by: Scott Benesh
Reviewed-by: Scott Teel
Reviewed-by: Kevin Barnett
Signed-off-by: Don Brace
---
drivers/scsi/hpsa.c |3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 9fb30c4..2990897 100644
--- a/drive
- schedule another scan.
- mark current scan as completed
Reviewed-by: Scott Benesh
Reviewed-by: Scott Teel
Reviewed-by: Kevin Barnett
Signed-off-by: Don Brace
---
drivers/scsi/hpsa.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 2990
Use the return from TUR as a check for the
device state.
Reviewed-by: Scott Benesh
Reviewed-by: Scott Teel
Reviewed-by: Kevin Barnett
Signed-off-by: Don Brace
---
drivers/scsi/hpsa.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa
external shelves do not support BMICs.
Reviewed-by: Scott Benesh
Reviewed-by: Scott Teel
Reviewed-by: Kevin Barnett
Signed-off-by: Don Brace
---
drivers/scsi/hpsa.c |5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 73daace..8e22aed 100
- align with latest spec.
- added __attribute((aligned(512)))
Reviewed-by: Scott Teel
Reviewed-by: Scott Benesh
Reviewed-by: Kevin Barnett
Signed-off-by: Don Brace
---
drivers/scsi/hpsa_cmd.h | 20 ++--
1 file changed, 14 insertions(+), 6 deletions(-)
diff --git a/drivers
Reviewed-by: Gerry Morong
Reviewed-by: Scott Teel
Signed-off-by: Don Brace
---
drivers/scsi/hpsa.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index eabb826..73daace 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@
These patches are based on Linus's tree
These patches are for:
- RedHat BZ: 1404073 - [HPE 7.3 Bug] multipath failover not reliable
- Multipath failover support in general.
The changes are:
- update identify physical device structure
- align with FW
- stop getting enclosure info for extern
Reviewed-by: Gerry Morong
Reviewed-by: Scott Teel
Signed-off-by: Don Brace
---
drivers/scsi/hpsa.c |4
1 file changed, 4 insertions(+)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 9d659aa..eabb826 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -108,10 +1
> -Original Message-
> From: Tomas Henzl [mailto:the...@redhat.com]
> Sent: Thursday, May 04, 2017 10:47 AM
> To: Don Brace ; joseph.szczy...@hpe.com;
> Gerry Morong ; John Hall
> ; j...@linux.vnet.ibm.com; Kevin Barnett
> ; Mahesh Rajashekhara
> ; Bader Ali - Saleh
> ; h...@infradead.org;
On 2017-04-10 19:12:49 [+0200], To Martin K . Petersen wrote:
> This is a repost to get the patches applied against v4.11-rc6. mkp's scsi
> for-next tree can be merged with no conflicts.
…
Martin, do you see any chance to get this merged? Chad replied to the
list that he is going to test it on 201
On 28.4.2017 20:20, Don Brace wrote:
> - mark device state sooner.
>
> Reviewed-by: Scott Benesh
> Reviewed-by: Scott Teel
> Reviewed-by: Kevin Barnett
> Signed-off-by: Don Brace
> ---
> drivers/scsi/hpsa.c | 59
> +++
> drivers/scsi/hpsa.h |
On Thu, May 04, 2017 at 03:32:44PM +, Bart Van Assche wrote:
> On Thu, 2017-05-04 at 09:15 -0600, Scott Bauer wrote:
> > On Thu, May 04, 2017 at 03:26:37PM +, Bart Van Assche wrote:
> > > On Thu, 2017-05-04 at 09:30 +0200, Christoph Hellwig wrote:
> > > > Please just add a flag to ->flags i
On Thu, 2017-05-04 at 09:15 -0600, Scott Bauer wrote:
> On Thu, May 04, 2017 at 03:26:37PM +, Bart Van Assche wrote:
> > On Thu, 2017-05-04 at 09:30 +0200, Christoph Hellwig wrote:
> > > Please just add a flag to ->flags instead of adding a whole new field.
> > >
> > > Otherwise this looks goo
On Thu, May 04, 2017 at 03:26:37PM +, Bart Van Assche wrote:
> On Thu, 2017-05-04 at 09:30 +0200, Christoph Hellwig wrote:
> > Please just add a flag to ->flags instead of adding a whole new field.
> >
> > Otherwise this looks good to me.
>
> Hello Christoph,
>
> Thanks for the feedback. I w
On Thu, 2017-05-04 at 09:30 +0200, Christoph Hellwig wrote:
> Please just add a flag to ->flags instead of adding a whole new field.
>
> Otherwise this looks good to me.
Hello Christoph,
Thanks for the feedback. I will make the proposed change and post a second
version.
Bart.
On Thu, 2017-05-04 at 11:43 +0200, Thierry Escande wrote:
> From: Derek Basehore
>
> Some external hard drives don't support the sync command even though the
> hard drive has write cache enabled. In this case, upon suspend request,
> sync cache failures are ignored if the error code in the sense
On Wed, 3 May 2017, 3:17pm, Gustavo A. R. Silva wrote:
> Properly update the position of the arguments in function call.
>
> Addresses-Coverity-ID: 1402010
> Signed-off-by: Gustavo A. R. Silva
> ---
> drivers/scsi/qedf/qedf_els.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> dif
On Wed, 3 May 2017, 5:23pm, Dan Carpenter wrote:
> We store sc_cmd->cmnd[0] which is an unsigned char in io_log->op so
> this should also be unsigned char. The other thing is that this is
> displayed in the debugfs:
>
> seq_printf(s, "0x%02x:", io_log->op);
>
> Smatch complains that the
https://bugzilla.kernel.org/show_bug.cgi?id=176951
Alberto Tiboni (a.tib...@gmail.com) changed:
What|Removed |Added
CC||a.tib...@gmail.com
Hello Matthew R. Ochs,
This is a semi-automatic email about new static checker warnings.
The patch 3065267a80c8: "scsi: cxlflash: Add hardware queues
attribute" from Apr 12, 2017, leads to the following Smatch complaint:
drivers/scsi/cxlflash/main.c:722 term_afu()
warn: variable derefe
From: Derek Basehore
Some external hard drives don't support the sync command even though the
hard drive has write cache enabled. In this case, upon suspend request,
sync cache failures are ignored if the error code in the sense header is
ILLEGAL_REQUEST. There's not much we can do for these driv
Please just add a flag to ->flags instead of adding a whole new field.
Otherwise this looks good to me.
47 matches
Mail list logo
