On Thu, Mar 30, 2017 at 05:19:01PM +0400, Dmitry Monakhov wrote:
> During LSFMM we have discussed how to test lower-backend of linux IO-stack.
> Common opinion was that xfstests is the most obvious solution which cover
> most of use cases filesystem care about.
>
> I'm working on integration T10-D
On Fri, Jan 20, 2017 at 07:27:02PM -0500, Martin K. Petersen wrote:
> > "Christoph" == Christoph Hellwig writes:
>
> Christoph> And get automatic MSI-X affinity for free.
>
> Chelsio folks: Please review and test!
ping!
On Thu, 03/30 11:30, Martin K. Petersen wrote:
> Fam Zheng writes:
>
> >>rw_max = min_not_zero(logical_to_sectors(sdp, dev_max),
> >> BLK_DEF_MAX_SECTORS);
> >
> > Yes, it is better. Is it okay to make the change when you apply?
>
> Sure. Applied to 4.11/scsi-fi
On 2017年03月30日 22:32, Michael S. Tsirkin wrote:
On Thu, Mar 30, 2017 at 02:00:08PM +0800, Jason Wang wrote:
On 2017年03月30日 04:48, Michael S. Tsirkin wrote:
We are going to add more parameters to find_vqs, let's wrap the call so
we don't need to tweak all drivers every time.
Signed-off-by: M
From: Xiubo Li
For the bidirectional case, the Data-Out buffer blocks will always at
the head of the tcmu_cmd's bitmap, and before gathering the Data-In
buffer, first of all it should skip the Data-Out ones, or the device
supporting BIDI commands won't work.
Fixed: 26418649eead ("target/user: In
Mike Snitzer writes:
Mike,
> But while discussing this effort with Jeff Moyer he asked: shouldn't the
> zeroed blocks be provisioned? This is a fairly embarassing question not
> to be able to answer in the moment. So I clearly need to learn what the
> overall intent of WRITE_ZEROES actually is
"h...@lst.de" writes:
> If you manually change the provisioning mode to WS10 on a device that
> must use WRITE SAME (16) to be able to address all blocks you're already
> screwed right now, and with this patch you can screw yourself through
> the WRITE_ZEROES path in addition to the DISCARD path.
Hi Satish,
My customer hit below error when issue LIP to fnic controller:
[94702.898408] sd 2:0:4:1: [sdx] tag#1 FAILED Result: hostbyte=DID_NO_CONNECT
driverbyte=DRIVER_OK
[94702.898416] sd 2:0:4:1: [sdx] tag#1 CDB: Write(10) 2a 00 04 56 c0 08 00 00
08 00
[94702.898420] blk_update_request: I/O
On Thu, Mar 30 2017 at 11:20am -0400,
Martin K. Petersen wrote:
> Mike Snitzer writes:
>
> > I can work on this now. Only question I have is: should DM thinp take
> > care to zero any misaligned head and tail? (I assume so but with all
> > the back and forth between Bart, Paolo and Martin I f
Now that we are using p2pmem SG buffers we occasionally have to copy
to and from this memory. For this, we add an iomem flag to
sg_copy_buffer for copying with iomemcpy. We also add the sg_iocopy_
variants to use this more easily.
Signed-off-by: Logan Gunthorpe
Signed-off-by: Stephen Bates
Signe
p2pmem will always be iomem so if we ever access it, we should be using
the correct methods to read and write to it.
Signed-off-by: Logan Gunthorpe
Signed-off-by: Stephen Bates
Signed-off-by: Steve Wise
---
drivers/nvme/target/core.c| 18 --
drivers/nvme/target/fabrics-
A p2pmem device is simply a PCI card with a BAR space that points to
regular memory. This may be an independent PCI card or part of another
completely unrelated device (like an IB card or a NVMe card). The
p2pmem device is designed such that other drivers may register p2pmem
memory for use by the s
This creates a userspace interface to use p2pmemory. A user can use
mmap on the p2pmem char device to get buffers from the corresponding
device. This allows a user to use p2p memory with existing
interfaces like RDMA and O_DIRECT.
This patch is a bit more controversial because people don't want to
Hello,
As discussed at LSF/MM we'd like to present our work to enable
copy offload support in NVMe fabrics RDMA targets. We'd appreciate
some review and feedback from the community on our direction.
This series is not intended to go upstream at this point.
The concept here is to use memory that's
From: Steve Wise
For each p2pmem instance, add a "stats" file to show
the gen_pool statistics.
Signed-off-by: Steve Wise
Signed-off-by: Logan Gunthorpe
Signed-off-by: Stephen Bates
---
drivers/memory/p2pmem.c | 49 +
include/linux/p2pmem.h |
From: Steve Wise
Some cxgb4 cards expose memory as part of BAR4. This patch registers
this memory as a p2pmem device.
Signed-off-by: Steve Wise
Signed-off-by: Logan Gunthorpe
Signed-off-by: Stephen Bates
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 3 +
drivers/net/ethernet/chelsio
We create a configfs attribute in each nvme-fabrics target port to
enable p2p memory use. When enabled, the port will only then use the
p2p memory if a p2p memory device can be found which is behind the
same switch as the RDMA port and all the block devices in use. If
the user enabled it an no devi
This patch creates a list of callbacks to notify users of this memory
that the p2pmem device is going away or gone.
In nvmet-rdma, we disconnect any queue using p2p memory.
The remote side will then automatically reconnect in a
couple seconds and regular system memory (or a different p2pmem device
On Thu, Mar 30, 2017 at 11:28:32AM -0400, Martin K. Petersen wrote:
> "h...@lst.de" writes:
>
> Christoph,
>
> > On Tue, Mar 28, 2017 at 04:48:55PM +, Bart Van Assche wrote:
> >> > if (sdp->no_write_same)
> >> > return BLKPREP_INVALID;
> >> > if (sdkp->ws16
On Thu, Mar 30, 2017 at 11:29:29AM -0400, Martin K. Petersen wrote:
> "h...@lst.de" writes:
>
> > Jens, any opinion? I'd like to remove it too, but I fear it might
> > break things. We could deprecate it first with a warning when read
> > and then remove it a few releases down the road.
>
> I
scsi_device_get() can fail. Hence check its return value.
Signed-off-by: Bart Van Assche
Cc: Boaz Harrosh
---
drivers/scsi/osd/osd_uld.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/osd/osd_uld.c b/drivers/scsi/osd/osd_uld.c
index e0ce5d2fd14d..1dea42
On Thu, 2017-03-30 at 08:29 +, Nicholas A. Bellinger wrote:
> diff --git a/drivers/target/iscsi/iscsi_target_util.c
> b/drivers/target/iscsi/iscsi_target_util.c
> index 5041a9c..b464033 100644
> --- a/drivers/target/iscsi/iscsi_target_util.c
> +++ b/drivers/target/iscsi/iscsi_target_util.c
> @
On Thu, Mar 30 2017 at 11:22am -0400,
Martin K. Petersen wrote:
> Mike Snitzer writes:
>
> > Would be very useful, particularly for testing, if
> > drivers/scsi/scsi_debug.c were updated to support WRITE ZEROES.
>
> There is no WRITE ZEROES in SCSI. You should be able to get the right
> behavi
Christoph Hellwig writes:
> Any progress on that? I'd like to get be2iscsi off the old MSI-X API
> for 4.12.
Applied to 4.12/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
Fam Zheng writes:
>> rw_max = min_not_zero(logical_to_sectors(sdp, dev_max),
>> BLK_DEF_MAX_SECTORS);
>
> Yes, it is better. Is it okay to make the change when you apply?
Sure. Applied to 4.11/scsi-fixes.
--
Martin K. Petersen Oracle Linux Engineering
"h...@lst.de" writes:
> Jens, any opinion? I'd like to remove it too, but I fear it might
> break things. We could deprecate it first with a warning when read
> and then remove it a few releases down the road.
I know of several apps that check this variable (as opposed to the
ioctl).
--
Mart
"h...@lst.de" writes:
Christoph,
> On Tue, Mar 28, 2017 at 04:48:55PM +, Bart Van Assche wrote:
>> >if (sdp->no_write_same)
>> >return BLKPREP_INVALID;
>> >if (sdkp->ws16 || sector > 0x || nr_sectors > 0x)
>>
>> Users can change the provisioning mode from use
Mike Snitzer writes:
> Would be very useful, particularly for testing, if
> drivers/scsi/scsi_debug.c were updated to support WRITE ZEROES.
There is no WRITE ZEROES in SCSI. You should be able to get the right
behavior with lbpws=1 lbprz=1.
--
Martin K. Petersen Oracle Linux Engineering
Mike Snitzer writes:
> I can work on this now. Only question I have is: should DM thinp take
> care to zero any misaligned head and tail? (I assume so but with all
> the back and forth between Bart, Paolo and Martin I figured I'd ask
> explicitly).
Yep, let's make sure our semantics match the
Would be very useful, particularly for testing, if
drivers/scsi/scsi_debug.c were updated to support WRITE ZEROES.
On Thu, 2017-03-30 at 01:48 -0700, Nicholas A. Bellinger wrote:
> Just for future reference, the flow of these tags should reflect the
> history of the patch. Eg:
>
> Reviewed-by: First reviewer
> Tested-by: First tester
> Reviewed-by: Second reviewer
> Signed-off-by: Patch Author
>
> and th
This adds PGR support for just TCMU, since tcmu doesn't
have the necessary IT_NEXUS info to process PGR in userspace,
so have those commands be processed in kernel.
Signed-off-by: Bryant G. Ly
---
drivers/target/target_core_configfs.c | 10 +-
drivers/target/target_core_device.c | 27 +
On Thu, Mar 30, 2017 at 02:00:08PM +0800, Jason Wang wrote:
>
>
> On 2017年03月30日 04:48, Michael S. Tsirkin wrote:
> > We are going to add more parameters to find_vqs, let's wrap the call so
> > we don't need to tweak all drivers every time.
> >
> > Signed-off-by: Michael S. Tsirkin
> > ---
>
>
On Thu, Mar 30 2017 at 7:44am -0400,
Christoph Hellwig wrote:
> On Thu, Mar 30, 2017 at 12:06:41PM +0200, Lars Ellenberg wrote:
>
> > Will it make an fstrim cause thinly provisioned
> > devices to suddenly be fully allocated?
>
> Not for SCSI devices. Yes for dm-thinp until it implements
> RE
Signed-off-by: Dmitry Monakhov
---
tests/generic/420 | 77 +++
tests/generic/420.out | 2 ++
tests/generic/group | 1 +
3 files changed, 80 insertions(+)
create mode 100755 tests/generic/420
create mode 100644 tests/generic/420.out
diff -
Linux-IO Target is very good framework for testing block backend.
It is more flexible than scsi_debug.
http://linux-iscsi.org/wiki/LIO
Signed-off-by: Dmitry Monakhov
---
common/config| 2 +
common/liotarget | 111 +++
2 files changed, 113
Test create virtual block device via lio-targed infastructure and
perform basic IO operations with data corruption detection.
Temprorally mark is as dangerous, because currently it trigger BUG_ON
inside blkdev_issue_flush
BTW: I use 'dd' to test read from corrupted image instead of xfs_io
because
During LSFMM we have discussed how to test lower-backend of linux IO-stack.
Common opinion was that xfstests is the most obvious solution which cover
most of use cases filesystem care about.
I'm working on integration T10-DIF/DIF data integrity features to ext4,
for that reason we need to be shure
On Thu, Mar 30, 2017 at 01:44:09PM +0200, Christoph Hellwig wrote:
> On Thu, Mar 30, 2017 at 12:06:41PM +0200, Lars Ellenberg wrote:
> > On Thu, Mar 23, 2017 at 10:33:40AM -0400, Christoph Hellwig wrote:
> > > It seems like DRBD assumes its on the wire TRIM request always zeroes
> > > data.
> > >
On Thu, Mar 30, 2017 at 12:06:41PM +0200, Lars Ellenberg wrote:
> On Thu, Mar 23, 2017 at 10:33:40AM -0400, Christoph Hellwig wrote:
> > It seems like DRBD assumes its on the wire TRIM request always zeroes data.
> > Use that fact to implement REQ_OP_WRITE_ZEROES.
> >
> > XXX: will need a careful
On Thu, Mar 23, 2017 at 10:33:40AM -0400, Christoph Hellwig wrote:
> It seems like DRBD assumes its on the wire TRIM request always zeroes data.
> Use that fact to implement REQ_OP_WRITE_ZEROES.
>
> XXX: will need a careful audit from the drbd team!
Thanks, this one looks ok to me.
The real ques
On 2017年03月30日 16:48, Nicholas A. Bellinger wrote:
Hi Xiubo & Co,
On Mon, 2017-03-27 at 17:07 +0800, lixi...@cmss.chinamobile.com wrote:
From: Xiubo Li
Changed for V5:
- This only includes #1 and #2. And for old #3, #4 are still reviewing.
- #1, since the issue reported by Ilias is a separate
Lars, can you please take a look a patch 22 and check if it's safe?
That's the big thing I want to know before posting the next version
of the series. If it's not safe I'd like to drop that patch.
> -Original Message-
> From: Christoph Hellwig [mailto:h...@lst.de]
> Sent: Friday, January 13, 2017 10:00 PM
> To: subbu.seethara...@broadcom.com; ketan.muka...@broadcom.com;
> jitendra.bhiv...@broadcom.com; linux-scsi@vger.kernel.org
> Subject: [PATCH] be2iscsi: switch to pci_alloc_irq_ve
On Tue, Mar 28, 2017 at 05:00:48PM +, Bart Van Assche wrote:
>
> It seems to me like the documentation in Documentation/ABI/testing/sysfs-block
> and the above code are not in sync. I think the above code will cause reading
> from the discard_zeroes_data attribute to return an empty string (""
On Tue, Mar 28, 2017 at 04:50:47PM +, Bart Van Assche wrote:
> On Thu, 2017-03-23 at 10:33 -0400, Christoph Hellwig wrote:
> > This gets us support for non-discard efficient write of zeroes (e.g. NVMe)
> > and preparse for removing the discard_zeroes_data flag.
>
> Hello Christoph,
>
> "prepa
On Tue, Mar 28, 2017 at 04:48:55PM +, Bart Van Assche wrote:
> > if (sdp->no_write_same)
> > return BLKPREP_INVALID;
> > if (sdkp->ws16 || sector > 0x || nr_sectors > 0x)
>
> Users can change the provisioning mode from user space from SD_LBP_WS16 into
> SD_LBP_W
On Tue, Mar 28, 2017 at 04:12:46PM +, Bart Van Assche wrote:
> Since REQ_OP_WRITE_ZEROES was introduced in kernel v4.10, do we need
> "Cc: stable" and "Fixes: a6f0788ec2881" tags for this patch?
No. This just works around the way scsi_setup_cmnd sets up the data
direction. Before this series
Hi Xiubo & Co,
On Mon, 2017-03-27 at 17:07 +0800, lixi...@cmss.chinamobile.com wrote:
> From: Xiubo Li
>
> Changed for V5:
> - This only includes #1 and #2. And for old #3, #4 are still reviewing.
> - #1, since the issue reported by Ilias is a separate new one, and will
> create a new patch la
On Tue, Mar 28, 2017 at 08:05:09AM -0600, ax...@kernel.dk wrote:
> > Although I know this is an issue in the existing code and not something
> > introduced by you: please consider using logical_to_sectors() instead of
> > open-coding this function. Otherwise this patch looks fine to me.
>
> The do
On Mon, Jan 23, 2017 at 09:41:45AM +0530, Jitendra Bhivare wrote:
> We will be taking this up along with some other changes in the same area.
Any progress on that? I'd like to get be2iscsi off the old MSI-X API
for 4.12.
From: Nicholas Bellinger
This patch closes a race between se_lun deletion during configfs
unlink in target_fabric_port_unlink() -> core_dev_del_lun()
-> core_tpg_remove_lun(), when transport_clear_lun_ref() blocks
waiting for percpu_ref RCU grace period to finish, but a new
NodeACL mappedlun is a
From: Nicholas Bellinger
This patch fixes a iscsi-target specific TMR reference leak
during session shutdown, that could occur when a TMR was
quiesced before the hand-off back to iscsi-target code
via transport_cmd_check_stop_to_fabric().
The reference leak happens because iscsit_free_cmd() was
From: Nicholas Bellinger
Hi all,
Here are two additional target bug-fixes that have been found
by the DATERA Q/A + automation team during extended longevity
and stress testing atop v4.1.y stable code.
The first is a iscsi-target specific TMR reference leak during
session shutdown when se_cmd qu
On Wed, Mar 29, 2017 at 01:55:09PM -0700, Kees Cook wrote:
> Prepare to mark sensitive kernel structures for randomization by making
> sure they're using designated initializers. These were identified during
> allyesconfig builds of x86, arm, and arm64, with most initializer fixes
> extracted from
On Tue, Mar 28, 2017 at 04:14:09PM +, Stephen Hemminger wrote:
> I decided not to send it to stable since problem was only observed on
> 4.11 but it is probably endemic to all GEN2 VM's
So, what does this mean? What should stable@ do? Nothing? Ok, now
dropped this from my patch queue :)
th
On Wed, 29 Mar 2017 23:48:44 +0300
"Michael S. Tsirkin" wrote:
> We are going to add more parameters to find_vqs, let's wrap the call so
> we don't need to tweak all drivers every time.
>
> Signed-off-by: Michael S. Tsirkin
> ---
> drivers/block/virtio_blk.c | 3 +--
> drivers/
57 matches
Mail list logo
