On 2017/3/16 8:07, Martin K. Petersen wrote:
> Kefeng Wang writes:
>
> Kefeng,
>
>> 'n = header_length + block_descriptor_length' could be greater than 512,
>> and will lead to oob access, so enlarge transfer buffer to fix it.
>
> Can you share the output of sg_modes -p 0x2a /dev/srN for the
CID needs to be freed even when invalidate or upload connection fails.
Attempt to close connection 3 times before freeing CID.
Set cleanup_type to INVALIDATE instead of force TCP_RST.
This unnecessarily is terminating connection with reset instead of
gracefully closing it.
Set save_cfg to 0 - ses
With previous patch adding ASYNC Rx buffers to free_list is not required.
Remove all free_list related operations.
Add in_use to track if buffer posted is being processed by driver and
purge all buffers received for connection if found so.
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/be2isc
FW runs out of buffer if buffers are not posted back soon.
ASYNC Rx CQE indicates that FW has consumed 8 RQEs.
Use it to post back buffers instead of waiting for buffers
to be processed and freed by driver.
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/be2iscsi/be_main.c | 124 +++
spin_unlock_bh back_lock is used in beiscsi_eh_device_reset instead of
spin_lock.
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/be2iscsi/be_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c
index 32b271
Currently, ASYNC PDU default queue size is set to max connections.
This leaves only one buffer per connection for any ASYNC PDUs from
targets.
Double the size of the default queue.
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/be2iscsi/be_main.c | 29 ++---
drivers/sc
scsi_flush_work flushes workqueue for the Scsi_Host.
In iSCSI offload enabled host, this would wait for all other
sessions under the host.
Use flush_work for the session being removed instead.
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/scsi_transport_iscsi.c | 3 +--
1 file changed, 1 ins
Version 11.4.0.0
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/be2iscsi/be_main.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/be2iscsi/be_main.h b/drivers/scsi/be2iscsi/be_main.h
index c6b95dc..ee18a95 100644
--- a/drivers/scsi/be2iscsi/be_main.h
+++ b/dri
Update Broadcom Copyright markings in all files.
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/be2iscsi/be.h | 11 ---
drivers/scsi/be2iscsi/be_cmds.c | 11 ---
drivers/scsi/be2iscsi/be_cmds.h | 11 ---
drivers/scsi/be2iscsi/be_iscsi.c | 13 -
drive
scsi host12: BS_1377 : mgmt_invalidate_connection Failed for cid=256
BUG: unable to handle kernel NULL pointer dereference at 0008
IP: [] __list_add+0xf/0xc0
PGD 0
Oops: [#1] SMP
Modules linked in:
...
CPU: 9 PID: 1542 Comm: iscsid Tainted: G T
3.10.0-51
Data in buffers are gathered into a single buffer before giving to
iSCSI layer. Though less likely to have payload more than 8K in
ASYNC PDU, the data length is provide by FW and check is missing
for overrun.
Signed-off-by: Jitendra Bhivare
---
drivers/scsi/be2iscsi/be_main.c | 7 ++-
1 file
This patch is generated against for-next branch.
v2 changes:
+be2iscsi: Update Copyright
Jitendra Bhivare (10):
be2iscsi: Check tag in beiscsi_mccq_compl_wait
be2iscsi: Fix closing of connection
be2iscsi: Replace spin_unlock_bh with spin_lock
scsi_transport_iscsi: Use flush_work in iscsi
Kefeng Wang writes:
Kefeng,
> 'n = header_length + block_descriptor_length' could be greater than 512,
> and will lead to oob access, so enlarge transfer buffer to fix it.
Can you share the output of sg_modes -p 0x2a /dev/srN for the offending
drive?
This mode page is usually much smaller than
Peter Chang writes:
> now that i think i've got gmail not marking everything as spam...
Doug?
>From 93409c62db49d15105390315a685e54083029bee Mon Sep 17 00:00:00 2001
From: peter chang
Date: Wed, 15 Feb 2017 14:11:54 -0800
Subject: [PATCH] [sg] check length passed to SG_NEXT_CMD_LEN
the user c
Maurizio Lombardi writes:
> With multipath, it may happen that the same device is passed to
> enclosure_add_device() multiple times and that the
> enclosure_add_links() function fails to create the symlinks because
> the device's sysfs directory entry is still NULL. In this case, the
> links wil
On Tue, 2017-03-14 at 16:23 +0200, Israel Rukshin wrote:
> Patch number 5 doesn't handle the case when device_for_each_child() is
> called. device_for_each_child() calls to target_unblock() that uses also
> starget_for_each_device(). After applying also the following change the
> hang disappeared
Hello, I'm looking for some help tracking down why I can no longer
hot-add disks to my virtual machines. They are guests on ESXi 6.0
using the LSI Logic SAS controller emulation, using the mptsas kernel
module. At some point between 3.18.27 and 4.4.50, we lost the ability
to hot-add disks to the
Raghava Aditya Renukunta writes:
> Reported-by: Tomas Henzl
...and another mangled email address.
Fixed it up.
--
Martin K. Petersen Oracle Linux Engineering
Elena Reshetova writes:
> refcount_t type and corresponding API should be used instead of
> atomic_t when the variable is used as a reference counter. This allows
> to avoid accidental refcounter overflows that might lead to
> use-after-free situations.
Applied to 4.12/scsi-queue.
--
Martin K.
Elena Reshetova writes:
> refcount_t type and corresponding API should be used instead of
> atomic_t when the variable is used as a reference counter. This allows
> to avoid accidental refcounter overflows that might lead to
> use-after-free situations.
Applied to 4.12/scsi-queue.
--
Martin K.
Tomas Winkler writes:
> IS_ERR and ERR_PTR already forcefully cast their argument, hence there
> is no need for additional (complex) casting.
Applied to 4.11/scsi-fixes.
--
Martin K. Petersen Oracle Linux Engineering
On 2017-03-14 05:19, Tomas Winkler wrote:
IS_ERR and ERR_PTR already forcefully cast their argument,
hence there is no need for additional (complex) casting.
Signed-off-by: Tomas Winkler
---
drivers/scsi/ufs/ufshcd-pltfrm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Manish Rangankar writes:
Applied to 4.11/scsi-fixes.
--
Martin K. Petersen Oracle Linux Engineering
On 2017-03-15 10:26, James Bottomley wrote:
On Mon, 2017-03-13 at 17:19 -0700, Subhash Jadavani wrote:
On 2017-03-12 03:22, Tomas Winkler wrote:
> Fix compilation warning
>
> drivers/scsi/ufs/ufshcd.c:7645:13: warning: comparison of unsigned
> expression < 0 is always false [-Wtype-limits]
> if
Raghava Aditya Renukunta writes:
> Currently command threads fails to return ioctls commands for older
> controller versions, since it returns when all the fibs have been
> allocated. Another issue is even all the fibs have not been allocated,
> the correct allocated fibs is not updated nor freed
Bill Kuzeja writes:
> After a Qlogic card breaks when initializing (test case), the system can
> crash in qla2xxx_eh_abort if processing anything but a scsi command type
> srb.
Applied to 4.11/scsi-fixes.
--
Martin K. Petersen Oracle Linux Engineering
> -Original Message-
> From: Raghava Aditya Renukunta
> [mailto:raghavaaditya.renuku...@microsemi.com]
> Sent: Tuesday, March 14, 2017 10:20 AM
> To: j...@linux.vnet.ibm.com; martin.peter...@oracle.com; linux-
> s...@vger.kernel.org
> Cc: Dave Carroll; Gana Sridaran; Scott Benesh; Tomas Hen
Following a command abort or device reset, ipr's EH handlers wait
for the commands getting aborted to get sent back from the adapter
prior to returning from the EH handler. This fixes up some cases
where the completion handler was not getting called, which would
have resulted in the EH thread wait
This fixes a race condition in the error handlomg paths of ipr. While a command
is
outstanding to the adapter, it is placed on a pending queue for the hrrq it is
associated with, while holding the HRRQ lock. When a command is completed,
it is removed from the pending queue, under HRRQ lock, and p
Removes some code in __ipr_eh_dev_reset which was modifying the
ipr_cmd done function. This should have already been setup at
command allocation time and if its since been changed, it means
we are in the ipr_erp* functions and need to wait for them to
complete and don't want to override that here.
On Wed, 2017-03-15 at 22:27 +0100, Sebastian Herbszt wrote:
> Use kref_read() instead of accessing the counter inside a kref.
Hello Sebastian,
It is a good habit for a patch that fixes a compilation warning to mention
the warning message that has been fixed in the patch description.
> @@ -3821,7
This patch closes up some potential race conditions observed in
the error handling paths in ipr while debugging an issue resulting
in a hang with SATA error handling. These patches ensure we are
holding the correct lock when adding and removing commands from
the free and pending queues in some err
Bump driver version
Signed-off-by: Brian King
---
drivers/scsi/ipr.h |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff -puN drivers/scsi/ipr.h~ipr_version_2_6_4 drivers/scsi/ipr.h
--- linux-2.6.git/drivers/scsi/ipr.h~ipr_version_2_6_4 2017-03-14
16:31:59.381210940 -0500
+++
This patch fixes a hang that can occur in ATA EH with ipr. With ipr's usage of
libata, commands should never end up on ap->eh_done_q. The timeout function we
use
for ipr, even for SATA devices, is scsi_times_out, so ATA_QCFLAG_EH_SCHEDULED
never gets set for ipr and EH is driven completely by ipr
Use kref_read() instead of accessing the counter inside a kref.
Signed-off-by: Sebastian Herbszt
---
efct/efct_ddump.c | 5 ++---
efct/efct_hw.c| 6 +++---
efct/efct_io.c| 3 +--
efct/efct_lio.c | 2 +-
efct/efct_scsi.c | 4 ++--
5 files changed, 9 insertions(+), 11 deletions(-)
diff
https://bugzilla.kernel.org/show_bug.cgi?id=188061
--- Comment #9 from himanshu.madh...@cavium.com (himanshu.madh...@qlogic.com)
---
(In reply to Anthony from comment #8)
> I added output in text attachment. By construction this card have 3 PCI-E
> switches onboard.
Checking with our hardware/fi
https://bugzilla.kernel.org/show_bug.cgi?id=108621
Martin Ziegler (zieg...@uni-freiburg.de) changed:
What|Removed |Added
Status|NEW |RESOLVED
After the split of linux/sched.h, linux/sched/signal.h is required.
Signed-off-by: Sebastian Herbszt
---
efct/efct_os.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/efct/efct_os.h b/efct/efct_os.h
index 16f7dc3..5ae269e 100644
--- a/efct/efct_os.h
+++ b/efct/efct_os.h
@@ -56,6 +56,7 @@
#
Don Brace writes:
> My bad. I'll send up a V4. Sorry about that.
I already fixed it up and James pulled the new tree. So we're all set.
--
Martin K. Petersen Oracle Linux Engineering
> -Original Message-
> From: James Bottomley [mailto:j...@linux.vnet.ibm.com]
> Sent: Wednesday, March 15, 2017 12:24 PM
> To: Don Brace ; joseph.szczy...@hpe.com;
> Gerry Morong ; John Hall
> ; Kevin Barnett
> ; Mahesh Rajashekhara
> ; Bader Ali - Saleh
> ; h...@infradead.org; Scott Teel
>
On Wed, Mar 15, 2017 at 02:54:09PM +0100, Hannes Reinecke wrote:
> On 03/14/2017 06:33 PM, Benjamin Block wrote:
> > Hello Hannes,
> >
> > On Wed, Mar 01, 2017 at 10:15:20AM +0100, Hannes Reinecke wrote:
> >> There hasn't been any reports for HBAs where asynchronous abort
> >> would not work, so we
On Mon, 2017-03-13 at 17:19 -0700, Subhash Jadavani wrote:
> On 2017-03-12 03:22, Tomas Winkler wrote:
> > Fix compilation warning
> >
> > drivers/scsi/ufs/ufshcd.c:7645:13: warning: comparison of unsigned
> > expression < 0 is always false [-Wtype-limits]
> > if ((value < UFS_PM_LVL_0) || (value
On Fri, 2017-03-10 at 14:35 -0600, Don Brace wrote:
> avoid rescan storms. No need to queue another
> if one is pending.
>
> Reviewed-by: Scott Benesh
> Reviewed-by: Scott Teel
> Reviewed-by: Tomas Henzl review
Guys, what is this additional "review" for? I just noticed because my
reply script
This is a rather large set of fixes. The bulk are for lpfc correcting
a lot of issues in the new NVME driver code which just went in in the
merge window. The others are: fix a hang in the vmware paravirt driver
caused by incorrect handling of the new MSI vector allocation. A long
standing bug in
Signed-off-by: Himanshu Madhani
Signed-off-by: Giridhar Malavali
---
drivers/scsi/qla2xxx/qla_def.h | 2 +
drivers/scsi/qla2xxx/qla_dfs.c | 92 --
2 files changed, 90 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_def.h b/drivers/scs
From: Quinn Tran
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_target.c | 6 +++---
drivers/scsi/qla2xxx/qla_target.h | 1 +
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_target.c
b/drivers/scsi/qla2xxx/qla_tar
From: Quinn Tran
Cc:
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_target.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/scsi/qla2xxx/qla_target.c
b/drivers/scsi/qla2xxx/qla_target.c
index 45f5077684f0..ecf97c5993e8 100644
--- a/drive
Hi Nic,
Please consider this series for inclusion in target-pending.
This series contains following changes.
o Fix for the deadlock because of inconsistent lock usage reported by Bart.
o Added patch to submit non-critical MBX command via IOCB path.
o Improved T10-DIF/PI handling with target stac
From: Joe Carnuccio
Cc:
Signed-off-by: Joe Carnuccio
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_attr.c | 4 +---
drivers/scsi/qla2xxx/qla_def.h | 6 +-
drivers/scsi/qla2xxx/qla_init.c | 1 +
drivers/scsi/qla2xxx/qla_mid.c | 14 --
drivers/scsi/qla2xxx/ql
From: Quinn Tran
When FW notify driver or driver detects low FW resource,
driver tries to send out Busy SCSI Status to tell Initiator
side to back off. During the send process, the lock was not held.
Cc:
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_t
From: Quinn Tran
If the remote port have started the login process, then the
PLOGI and PRLI should be back to back. Driver will allow
the remote port to complete the process. For the case where
the remote port decide to back off from sending PRLI, this
local port sets an expiration timer for the
From: Quinn Tran
Add routines to support T10 DIF tag.
Signed-off-by: Quinn Tran
Signed-off-by: Anil Gurumurthy
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_dbg.h | 1 +
drivers/scsi/qla2xxx/qla_def.h | 10 +
drivers/scsi/qla2xxx/qla_gbl.h | 6 +-
drivers/scsi
From: Quinn Tran
Normally, ABTS is sent to Target Core as Task MGMT command.
In the case of error, qla2xxx needs to send response, hardware_lock
is required to prevent request queue corruption.
Cc:
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_target.
From: Anil Gurumurthy
Signed-off-by: Anil Gurumurthy
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_def.h | 12
drivers/scsi/qla2xxx/qla_dfs.c | 15 +++
2 files changed, 27 insertions(+)
diff --git a/drivers/scsi/qla2xxx/qla_def.h b/drivers/scsi/qla2xxx/
From: Quinn Tran
The main lock that needs to be held for CMD or TMR submission
to upper layer is the sess_lock. The sess_lock is used to
serialize cmd submission and session deletion. The addition
of hardware_lock being held is not necessary. This patch removes
hardware_lock dependency from CMD/T
From: Quinn Tran
The Mailbox interface is currently over subscribed. We like
to reserve the Mailbox interface for the chip managment and
link initialization. Any non essential Mailbox command will
be routed through the IOCB interface. The IOCB interface is
able to absorb more commands.
Following
From: Quinn Tran
For target mode, when new scsi command arrive, driver first performs
a look up of the SCSI Host. The current look up method is based on
the ALPA portion of the NPort ID. For Cisco switch, the ALPA can
not be used as the index. Instead, the new search method is based
on the full v
Signed-off-by: Himanshu Madhani
signed-off-by: Giridhar Malavali
---
drivers/scsi/qla2xxx/qla_version.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_version.h
b/drivers/scsi/qla2xxx/qla_version.h
index 3cb1964b7786..45bc84e8e3bf 100644
--- a
From: Quinn Tran
Current driver wait for FW to be in the ready state before
processing in-coming commands. For Arbitrated Loop or
Point-to- Point (not switch), FW Ready state can take a while.
FW will transition to ready state after all Nports have been
logged in. In the mean time, certain initia
From: Colin Ian King
buffer is a pointer to the static char array event_buffer and
therefore can never be null, so the check is redundant. Remove it.
Detected by CoverityScan, CID#1077556 ("Logically Dead Code")
Signed-off-by: Colin Ian King
---
drivers/scsi/esas2r/esas2r_log.c | 5 -
1 f
On Mon, 2017-03-13 at 12:13 +0530, Sreekanth Reddy wrote:
> Hi,
>
> Our LSI(Broadcom) SAS3.5 HBA device's support virtual SES device.
>
> Whenever we load the mpt3sas driver then we are observing below error
> message,
>
> "Wrong diagnostic page; asked for 7 got 0"
>
> Our virtual SES device do
On 03/14/2017 06:56 PM, Benjamin Block wrote:
> Hello Hannes,
>
> On Wed, Mar 01, 2017 at 10:15:18AM +0100, Hannes Reinecke wrote:
>> When a command is sent as part of the error handling there
>> is not point whatsoever to start EH escalation when that
>> command fails; we are _already_ in the err
On 03/14/2017 06:33 PM, Benjamin Block wrote:
> Hello Hannes,
>
> On Wed, Mar 01, 2017 at 10:15:20AM +0100, Hannes Reinecke wrote:
>> There hasn't been any reports for HBAs where asynchronous abort
>> would not work, so we should make it mandatory and remove
>> the fallback.
>>
>> Signed-off-by: H
https://bugzilla.kernel.org/show_bug.cgi?id=108621
--- Comment #4 from Martin Ziegler (zieg...@uni-freiburg.de) ---
The bug did not appear in later kernels. I should have
report this earlier. Sorry
(Martin Ziegler)
--
You are receiving this mail because:
You are watching the assignee of the b
https://bugzilla.kernel.org/show_bug.cgi?id=108621
--- Comment #5 from Szőgyényi Gábor (szg0...@freemail.hu) ---
Can you close this bug, please?
--
You are receiving this mail because:
You are watching the assignee of the bug.
2017-03-13 7:43 GMT+01:00 Sreekanth Reddy :
> Hi,
>
> Our LSI(Broadcom) SAS3.5 HBA device's support virtual SES device.
>
> Whenever we load the mpt3sas driver then we are observing below error message,
>
> "Wrong diagnostic page; asked for 7 got 0"
>
> Our virtual SES device doesn't support Diagno
Hi,
Any Update?
Thanks,
Sreekanth
On Mon, Mar 13, 2017 at 12:13 PM, Sreekanth Reddy
wrote:
> Hi,
>
> Our LSI(Broadcom) SAS3.5 HBA device's support virtual SES device.
>
> Whenever we load the mpt3sas driver then we are observing below error message,
>
> "Wrong diagnostic page; asked for 7 got 0
Signed-off-by: Manish Rangankar
---
drivers/scsi/qedi/qedi_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c
index 8e3d928..92775a8 100644
--- a/drivers/scsi/qedi/qedi_main.c
+++ b/drivers/scsi/qedi/qedi_main.c
@@ -2007,6 +200
https://bugzilla.kernel.org/show_bug.cgi?id=194837
--- Comment #12 from Thorsten Leemhuis (li...@leemhuis.info) ---
(In reply to Omar Sandoval from comment #11)
> The fix was [...]
Thx for providing details!
> If you are still seeing crashes on -rc2,
Yes, but different ones every few boot atte
https://bugzilla.kernel.org/show_bug.cgi?id=194837
--- Comment #11 from Omar Sandoval (osan...@osandov.com) ---
The fix was
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=df23de55615fa7a190a85f49a950ccecdd9102f3,
which was part of this patch series:
c01228db4ba9 Rev
https://bugzilla.kernel.org/show_bug.cgi?id=194837
--- Comment #10 from Thorsten Leemhuis (li...@leemhuis.info) ---
(In reply to Thorsten Leemhuis from comment #9)
> (In reply to Omar Sandoval from comment #8)
>> This was fixed in v4.11-rc2.
> Care to provide a few more details and a commit that f
71 matches
Mail list logo
