Re: [PATCH 00/10] mpt3sas: full mq support

2017-01-31 Thread Hannes Reinecke
On 02/01/2017 08:07 AM, Kashyap Desai wrote: -Original Message- From: Hannes Reinecke [mailto:h...@suse.de] Sent: Wednesday, February 01, 2017 12:21 PM To: Kashyap Desai; Christoph Hellwig Cc: Martin K. Petersen; James Bottomley; linux-scsi@vger.kernel.org; Sathya Prakash Veerichetty; PDL

RE: [PATCH 00/10] mpt3sas: full mq support

2017-01-31 Thread Kashyap Desai
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] > Sent: Wednesday, February 01, 2017 12:21 PM > To: Kashyap Desai; Christoph Hellwig > Cc: Martin K. Petersen; James Bottomley; linux-scsi@vger.kernel.org; > Sathya > Prakash Veerichetty; PDL-MPT-FUSIONLINUX; Sreekanth Reddy

Re: remove the cmd_type field from struct request

2017-01-31 Thread Hannes Reinecke
On 01/31/2017 07:02 PM, Jens Axboe wrote: On 01/31/2017 07:57 AM, Christoph Hellwig wrote: [1] which were a pain in the ass to untangle and debug during development, it's really time for it to die.. Outside of the patch series in question, how to we expedite the euthanasia of IDE? What explici

Re: [PATCH 00/10] mpt3sas: full mq support

2017-01-31 Thread Hannes Reinecke
On 01/31/2017 06:54 PM, Kashyap Desai wrote: -Original Message- From: Hannes Reinecke [mailto:h...@suse.de] Sent: Tuesday, January 31, 2017 4:47 PM To: Christoph Hellwig Cc: Martin K. Petersen; James Bottomley; linux-scsi@vger.kernel.org; Sathya Prakash; Kashyap Desai; mpt-fusionlinux..

Re: [PATCH 4.10-rc3 12/13] net: ath5k: fix build errors when linux/phy*.h is removed from net/dsa.h

2017-01-31 Thread Kalle Valo
Russell King writes: > Fix these errors reported by the 0-day builder by replacing the > linux/export.h include with linux/module.h. > > In file included from include/linux/platform_device.h:14:0, > from drivers/net/wireless/ath/ath5k/ahb.c:20: > include/linux/device.h:1463:1: wa

pri hiadani partnera!

2017-01-31 Thread Barr Su
Ahoj, Som zastupca investicneho zaujmu o zaujem zahranicnych investícii zahrnajuce velky objem financnych prostriedkov, u ktorych sa snazime svoju ucast ako v zamori zastupcu. Moj klient, ktory je rodak z Thajska, ma nejake peniaze zo svojich obchodnych uspor chce investovať na základe kval

Re: [PATCH v3] mpt3sas: Force request partial completion alignment

2017-01-31 Thread Martin K. Petersen
> "Guilherme" == Guilherme G Piccoli writes: Guilherme> The firmware or device, possibly under a heavy I/O load, can Guilherme> return on a partial unaligned boundary. Scsi-ml expects these Guilherme> requests to be completed on an alignment boundary. Scsi-ml Guilherme> blindly requeues the I

Re: [PATCH] scsi_debug: Add OPTIMAL TRANSFER LENGTH GRANULARITY option.

2017-01-31 Thread Martin K. Petersen
> "Lukas" == Lukas Herbolt writes: Applied to 4.11/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v3 0/4] mpt3sas driver Enhancements and defect fixes:

2017-01-31 Thread Martin K. Petersen
> "Chaitra" == Chaitra P B writes: Chaitra> Here is the change list: Posting 4 patches for mpt3sas driver Chaitra> enhancement and defect fixes. * Handle cable event for Chaitra> notifying degraded speed. * Performance improvement for Chaitra> Crusader. * Fix Firmware fault state 0x2100 du

Re: remove the cmd_type field from struct request

2017-01-31 Thread Martin K. Petersen
> "Christoph" == Christoph Hellwig writes: Christoph> this series gets rid of the cmd_type field in struct Christoph> request and instead folds it into the REQ_OP* space. This Christoph> reduces the size of struct request, and leads to a single op Christoph> namespace that drivers can easily

Re: [PATCH V2] hpsa: remove coalescing settings for ioaccel2

2017-01-31 Thread Martin K. Petersen
> "Don" == Don Brace writes: Don> - Setting coalescing has a significant negative impact on low Don> queue-depth performance. - Does not help high queue-depth Don> performance. Applied to 4.11/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] storvsc: remove bogus code to transfer struct scatterlist

2017-01-31 Thread Martin K. Petersen
> "Christoph" == Christoph Hellwig writes: Christoph> Remove a piece of code in storvsc_queuecommand that tries to Christoph> pass the physical address of the kernel struct scatterlist Christoph> pointer to the host. Christoph> Fortunately the code can't ever be reached anyway. Applied to 4

Re: [PATCH 4.10-rc3 00/13] net: dsa: remove unnecessary phy.h include

2017-01-31 Thread Florian Fainelli
On 01/31/2017 11:17 AM, Russell King - ARM Linux wrote: > Including phy.h and phy_fixed.h into net/dsa.h causes phy*.h to be an > unnecessary dependency for quite a large amount of the kernel. There's > very little which actually requires definitions from phy.h in net/dsa.h > - the include itself

Re: [PATCH 0/6] ncr5380: Miscellaneous minor patches

2017-01-31 Thread Martin K. Petersen
> "Finn" == Finn Thain writes: Finn> This series removes some unused code and related comments, Finn> addresses the warnings generated by 'make W=1' and 'make C=1' and Finn> fixes a theoretical bug in the bus reset method in atari_scsi. Finn> There's also a patch to add a missing error check

Helpdesk

2017-01-31 Thread Andrea Haider
Dear E-mail User Please follow the link to update your webmail account http://ulvnw9j29.ukit.me Thank You

[Bug 193041] iSCSI initiator: mkfs.ext4 + mount triggers kernel oops

2017-01-31 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=193041 Bart Van Assche changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [dm-devel] split scsi passthrough fields out of struct request V2

2017-01-31 Thread Jens Axboe
On 01/31/2017 01:55 PM, Bart Van Assche wrote: > On Tue, 2017-01-31 at 13:34 -0800, Bart Van Assche wrote: >> On Mon, 2017-01-30 at 17:38 -0800, Jens Axboe wrote: >>> That's a known bug in mainline. Pull it into 4.10-rc6, >>> or use my for-next where everything is already merged. >> >> Hello Jens,

Re: [dm-devel] split scsi passthrough fields out of struct request V2

2017-01-31 Thread Bart Van Assche
On Tue, 2017-01-31 at 13:34 -0800, Bart Van Assche wrote: > On Mon, 2017-01-30 at 17:38 -0800, Jens Axboe wrote: > > That's a known bug in mainline. Pull it into 4.10-rc6, > > or use my for-next where everything is already merged. > > Hello Jens, > > With your for-next branch (commit c2e60b3a260

Re: [dm-devel] split scsi passthrough fields out of struct request V2

2017-01-31 Thread Bart Van Assche
On Mon, 2017-01-30 at 17:38 -0800, Jens Axboe wrote: > That's a known bug in mainline. Pull it into 4.10-rc6, > or use my for-next where everything is already merged. Hello Jens, With your for-next branch (commit c2e60b3a2602) I haven't hit any block layer crashes so far. The only issue I encoun

Re: remove the cmd_type field from struct request

2017-01-31 Thread Jens Axboe
On 01/31/2017 10:58 AM, Sergei Shtylyov wrote: > On 01/31/2017 09:51 PM, James Bottomley wrote: > [1] which were a pain in the ass to untangle and debug during development, it's really time for it to die.. >>> >>> Outside of the patch series in question, how to we expedite the >>> euthan

Re: remove the cmd_type field from struct request

2017-01-31 Thread Jens Axboe
On 01/31/2017 07:57 AM, Christoph Hellwig wrote: > Hi Jens, > > this series gets rid of the cmd_type field in struct request and > instead folds it into the REQ_OP* space. This reduces the size of > struct request, and leads to a single op namespace that drivers > can easily switch on. Except fo

Re: [PATCH 4.10-rc3 08/13] net: emac: fix build errors when linux/phy*.h is removed from net/dsa.h

2017-01-31 Thread Timur Tabi
On 01/31/2017 01:19 PM, Russell King wrote: drivers/net/ethernet/qualcomm/emac/emac-sgmii.c:58:12: error: dereferencing pointer to incomplete type 'struct phy_device' Add linux/phy.h to emac-sgmii.c Signed-off-by: Russell King --- drivers/net/ethernet/qualcomm/emac/emac-sgmii.c | 1 + The v

Re: [PATCH 4.10-rc3 01/13] net: sunrpc: fix build errors when linux/phy*.h is removed from net/dsa.h

2017-01-31 Thread Anna Schumaker
Hi Russell, On 01/31/2017 02:18 PM, Russell King wrote: > Removing linux/phy.h from net/dsa.h reveals a build error in the sunrpc > code: > > net/sunrpc/xprtrdma/svc_rdma_backchannel.c: In function 'xprt_rdma_bc_put': > net/sunrpc/xprtrdma/svc_rdma_backchannel.c:277:2: error: implicit declaration

Re: [PATCH 4.10-rc3 09/13] iscsi: fix build errors when linux/phy*.h is removed from net/dsa.h

2017-01-31 Thread Bart Van Assche
On Tue, 2017-01-31 at 19:19 +, Russell King wrote: > drivers/target/iscsi/iscsi_target_login.c:1135:7: error: implicit declaration > of function 'try_module_get' [-Werror=implicit-function-declaration] > > Add linux/module.h to iscsi_target_login.c. > > Signed-off-by: Russell King > --- >

[PATCH 4.10-rc3 03/13] net: macb: fix build errors when linux/phy*.h is removed from net/dsa.h

2017-01-31 Thread Russell King
drivers/net/ethernet/cadence/macb.h:862:33: sparse: expected ; at end of declaration drivers/net/ethernet/cadence/macb.h:862:33: sparse: Expected } at end of struct-union-enum-specifier drivers/net/ethernet/cadence/macb.h:862:33: sparse: got phy_interface drivers/net/ethernet/cadence/macb.h:877:1

[PATCH 4.10-rc3 02/13] net: cgroups: fix build errors when linux/phy*.h is removed from net/dsa.h

2017-01-31 Thread Russell King
net/core/netprio_cgroup.c:303:16: error: expected declaration specifiers or '...' before string constant MODULE_LICENSE("GPL v2"); ^~~~ Add linux/module.h to fix this. Signed-off-by: Russell King --- net/core/netprio_cgroup.c | 1 + 1 file changed, 1 insertion(+) di

[PATCH 4.10-rc3 06/13] net: fman: fix build errors when linux/phy*.h is removed from net/dsa.h

2017-01-31 Thread Russell King
drivers/net/ethernet/freescale/fman/fman_memac.c:519:21: error: dereferencing pointer to incomplete type 'struct fixed_phy_status' Add linux/phy_fixed.h to fman_memac.c Signed-off-by: Russell King --- drivers/net/ethernet/freescale/fman/fman_memac.c | 1 + 1 file changed, 1 insertion(+) diff

[PATCH 4.10-rc3 07/13] net: mvneta: fix build errors when linux/phy*.h is removed from net/dsa.h

2017-01-31 Thread Russell King
drivers/net/ethernet/marvell/mvneta.c:2694:26: error: storage size of 'status' isn't known drivers/net/ethernet/marvell/mvneta.c:2695:26: error: storage size of 'changed' isn't known drivers/net/ethernet/marvell/mvneta.c:2695:9: error: variable 'changed' has initializer but incomplete type drive

[PATCH 4.10-rc3 01/13] net: sunrpc: fix build errors when linux/phy*.h is removed from net/dsa.h

2017-01-31 Thread Russell King
Removing linux/phy.h from net/dsa.h reveals a build error in the sunrpc code: net/sunrpc/xprtrdma/svc_rdma_backchannel.c: In function 'xprt_rdma_bc_put': net/sunrpc/xprtrdma/svc_rdma_backchannel.c:277:2: error: implicit declaration of function 'module_put' [-Werror=implicit-function-declaration]

[PATCH 4.10-rc3 09/13] iscsi: fix build errors when linux/phy*.h is removed from net/dsa.h

2017-01-31 Thread Russell King
drivers/target/iscsi/iscsi_target_login.c:1135:7: error: implicit declaration of function 'try_module_get' [-Werror=implicit-function-declaration] Add linux/module.h to iscsi_target_login.c. Signed-off-by: Russell King --- drivers/target/iscsi/iscsi_target_login.c | 1 + 1 file changed, 1 inse

[PATCH 4.10-rc3 08/13] net: emac: fix build errors when linux/phy*.h is removed from net/dsa.h

2017-01-31 Thread Russell King
drivers/net/ethernet/qualcomm/emac/emac-sgmii.c:58:12: error: dereferencing pointer to incomplete type 'struct phy_device' Add linux/phy.h to emac-sgmii.c Signed-off-by: Russell King --- drivers/net/ethernet/qualcomm/emac/emac-sgmii.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers

[PATCH 4.10-rc3 11/13] net: liquidio: fix build errors when linux/phy*.h is removed from net/dsa.h

2017-01-31 Thread Russell King
drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:30: error: expected declaration specifiers or '...' before string constant drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:30: warning: data definition has no type or storage class drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:30: error:

[PATCH 4.10-rc3 10/13] MIPS: Octeon: Remove unnecessary MODULE_*()

2017-01-31 Thread Russell King
octeon-platform.c can not be built as a module for two reasons: (a) the Makefile doesn't allow it: obj-y := cpu.o setup.o octeon-platform.o octeon-irq.o csrc-octeon.o (b) the multiple *_initcall() statements, each of which are translated to a module_init() call when attempting a module bu

[PATCH 4.10-rc3 12/13] net: ath5k: fix build errors when linux/phy*.h is removed from net/dsa.h

2017-01-31 Thread Russell King
Fix these errors reported by the 0-day builder by replacing the linux/export.h include with linux/module.h. In file included from include/linux/platform_device.h:14:0, from drivers/net/wireless/ath/ath5k/ahb.c:20: include/linux/device.h:1463:1: warning: data definition has no type

[PATCH 4.10-rc3 05/13] net: bgmac: fix build errors when linux/phy*.h is removed from net/dsa.h

2017-01-31 Thread Russell King
drivers/net/ethernet/broadcom/bgmac.c:1015:17: error: dereferencing pointer to incomplete type 'struct mii_bus' drivers/net/ethernet/broadcom/bgmac.c:1185:2: error: implicit declaration of function 'phy_start' [-Werror=implicit-function-declaration] drivers/net/ethernet/broadcom/bgmac.c:1198:2: e

[PATCH 4.10-rc3 13/13] net: dsa: remove unnecessary phy*.h includes

2017-01-31 Thread Russell King
Including phy.h and phy_fixed.h into net/dsa.h causes phy*.h to be an unnecessary dependency for quite a large amount of the kernel. There's very little which actually requires definitions from phy.h in net/dsa.h - the include itself only wants the declaration of a couple of structures and IFNAMSI

[PATCH 4.10-rc3 04/13] net: lan78xx: fix build errors when linux/phy*.h is removed from net/dsa.h

2017-01-31 Thread Russell King
drivers/net/usb/lan78xx.c:394:33: sparse: expected ; at end of declaration drivers/net/usb/lan78xx.c:394:33: sparse: Expected } at end of struct-union-enum-specifier drivers/net/usb/lan78xx.c:394:33: sparse: got interface drivers/net/usb/lan78xx.c:403:1: sparse: Expected ; at the end of type decl

[PATCH 4.10-rc3 00/13] net: dsa: remove unnecessary phy.h include

2017-01-31 Thread Russell King - ARM Linux
Including phy.h and phy_fixed.h into net/dsa.h causes phy*.h to be an unnecessary dependency for quite a large amount of the kernel. There's very little which actually requires definitions from phy.h in net/dsa.h - the include itself only wants the declaration of a couple of structures and IFNAMSI

Re: remove the cmd_type field from struct request

2017-01-31 Thread Sergei Shtylyov
On 01/31/2017 09:51 PM, James Bottomley wrote: [1] which were a pain in the ass to untangle and debug during development, it's really time for it to die.. Outside of the patch series in question, how to we expedite the euthanasia of IDE? What explicit features/support are we missing through li

Re: remove the cmd_type field from struct request

2017-01-31 Thread James Bottomley
On Tue, 2017-01-31 at 10:02 -0800, Jens Axboe wrote: > On 01/31/2017 07:57 AM, Christoph Hellwig wrote: > > [1] which were a pain in the ass to untangle and debug during > > development, it's really time for it to die.. > > Outside of the patch series in question, how to we expedite the > euthana

Re: [PATCH V2 2/2] qedf: Add QLogic FastLinQ offload FCoE driver framework.

2017-01-31 Thread Chad Dupuis
On Mon, 30 Jan 2017, 10:34am -, Hannes Reinecke wrote: > On 01/25/2017 09:33 PM, Dupuis, Chad wrote: > > +static int qedf_request_msix_irq(struct qedf_ctx *qedf) > > +{ > > + int i, rc, cpu; > > + > > + cpu = cpumask_first(cpu_online_mask); > > + for (i = 0; i < qedf->num_queues; i++)

Re: remove the cmd_type field from struct request

2017-01-31 Thread Jens Axboe
On 01/31/2017 07:57 AM, Christoph Hellwig wrote: > [1] which were a pain in the ass to untangle and debug during development, > it's really time for it to die.. Outside of the patch series in question, how to we expedite the euthanasia of IDE? What explicit features/support are we missing through

RE: [PATCH 00/10] mpt3sas: full mq support

2017-01-31 Thread Kashyap Desai
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] > Sent: Tuesday, January 31, 2017 4:47 PM > To: Christoph Hellwig > Cc: Martin K. Petersen; James Bottomley; linux-scsi@vger.kernel.org; Sathya > Prakash; Kashyap Desai; mpt-fusionlinux@broadcom.com > Subject: Re: [PATCH

Re: [PATCH V2 2/2] qedf: Add QLogic FastLinQ offload FCoE driver framework.

2017-01-31 Thread Chad Dupuis
On Mon, 30 Jan 2017, 10:34am -, Hannes Reinecke wrote: > On 01/25/2017 09:33 PM, Dupuis, Chad wrote: > > From: "Dupuis, Chad" > > > > The QLogic FastLinQ Driver for FCoE (qedf) is the FCoE specific module for > > 41000 > > Series Converged Network Adapters by QLogic. This patch consists of

Re: [PATCH] Revert "sd: remove __data_len hack for WRITE SAME"

2017-01-31 Thread Lee Duncan
Acked-by: Lee Duncan -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 06/10] nbd: remove REQ_TYPE_DRV_PRIV leftovers

2017-01-31 Thread Christoph Hellwig
Disconnects don't use block layer requests these days, so all handling of private requests is dead code. Signed-off-by: Christoph Hellwig --- drivers/block/nbd.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index 9fd06ee.

remove the cmd_type field from struct request

2017-01-31 Thread Christoph Hellwig
Hi Jens, this series gets rid of the cmd_type field in struct request and instead folds it into the REQ_OP* space. This reduces the size of struct request, and leads to a single op namespace that drivers can easily switch on. Except for the legacy ide driver which has a mess of different request

[PATCH 01/10] scm_blk: remove unneeded REQ_TYPE_FS check

2017-01-31 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- drivers/s390/block/scm_blk.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/s390/block/scm_blk.c b/drivers/s390/block/scm_blk.c index 9f16ea6..152de68 100644 --- a/drivers/s390/block/scm_blk.c +++ b/drivers/s390/block/scm_blk.c @@ -300,13 +3

[PATCH 07/10] nbd: move request validity checking into nbd_send_cmd

2017-01-31 Thread Christoph Hellwig
This is where we do the rest of the request handling, which will become much simpler soon, too. Signed-off-by: Christoph Hellwig --- drivers/block/nbd.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index d4c

[PATCH 04/10] ms_block: remove pointless prep_fn

2017-01-31 Thread Christoph Hellwig
This driver will never see non-fs requests, and doesn't do anything else in the prep_fn. Signed-off-by: Christoph Hellwig --- drivers/memstick/core/ms_block.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/memstick/core/ms_block.c b/drivers/memstick/core/ms_block.c index

[PATCH 05/10] mspro_block: remove pointless prep_fn

2017-01-31 Thread Christoph Hellwig
This driver will never see non-fs requests, and doesn't do anything else in the prep_fn. Signed-off-by: Christoph Hellwig --- drivers/memstick/core/mspro_block.c | 13 - 1 file changed, 13 deletions(-) diff --git a/drivers/memstick/core/mspro_block.c b/drivers/memstick/core/mspro_b

[PATCH 02/10] ѕd: remove pointless REQ_TYPE_FS check

2017-01-31 Thread Christoph Hellwig
->done can only be called for fs requests, so no need to check again here. Signed-off-by: Christoph Hellwig --- drivers/scsi/sd.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index c779986..bd2fb4d 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/s

[PATCH 03/10] mmc: remove pointless request type check in mmc_prep_request

2017-01-31 Thread Christoph Hellwig
The block layer won't send requests the driver isn't asking for, so remove this check. Signed-off-by: Christoph Hellwig --- drivers/mmc/core/queue.c | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/mmc/core/queue.c b/drivers/mmc/core/queue.c index a6496d8..033f641 100644 --- a

Re: [PATCH 09/10] ide: don't abuse cmd_type

2017-01-31 Thread David Miller
From: Christoph Hellwig Date: Tue, 31 Jan 2017 16:57:30 +0100 > Currently the legacy ide driver defines several request types of it's own, > which is in the way of removing that field entirely. > > Instead add a type field to struct ide_request and use that to distinguish > the different types o

[PATCH 08/10] block: introduce blk_rq_is_passthrough

2017-01-31 Thread Christoph Hellwig
This can be used to check for fs vs non-fs requests and basically removes all knowledge of BLOCK_PC specific from the block layer, as well as preparing for removing the cmd_type field in struct request. Signed-off-by: Christoph Hellwig --- block/blk-core.c | 8 blo

[PATCH 09/10] ide: don't abuse cmd_type

2017-01-31 Thread Christoph Hellwig
Currently the legacy ide driver defines several request types of it's own, which is in the way of removing that field entirely. Instead add a type field to struct ide_request and use that to distinguish the different types of IDE-internal requests. It's a bit of a mess, but so is the surrounding

[PATCH 10/10] block: fold cmd_type into the REQ_OP_ space

2017-01-31 Thread Christoph Hellwig
Instead of keeping two levels of indirection for requests types, fold it all into the operations. The little caveat here is that previously cmd_type only applied to struct request, while the request and bio op fields were set to plain REQ_OP_READ/WRITE even for passthrough operations. Instead thi

Re: scsi: BUG in scsi_init_io

2017-01-31 Thread James Bottomley
On Tue, 2017-01-31 at 10:50 +0100, Dmitry Vyukov wrote: > On Tue, Jan 31, 2017 at 10:20 AM, Johannes Thumshirn < > jthumsh...@suse.de> wrote: > > On Tue, Jan 31, 2017 at 09:55:52AM +0100, Dmitry Vyukov wrote: > > > Hello, > > > > > > The following program triggers BUG in scsi_init_io: > > > > Wel

Re: [PATCH 08/10] mpt3sas: lockless command submission for scsi-mq

2017-01-31 Thread Christoph Hellwig
On Tue, Jan 31, 2017 at 02:46:19PM +0100, Hannes Reinecke wrote: > Yes, they are with your latest patchset. No, this has been the case since blk-mq support wa added to scsi. > Yes, but scsi_host_find_tag() still relies on req->special, which it > really shouldn't after your patches; scsi_cmd_priv

Re: [PATCH 08/10] mpt3sas: lockless command submission for scsi-mq

2017-01-31 Thread Hannes Reinecke
On 01/31/2017 02:22 PM, Christoph Hellwig wrote: > On Tue, Jan 31, 2017 at 10:25:58AM +0100, Hannes Reinecke wrote: >> Enable lockless command submission for scsi-mq by moving the >> command structure into the payload for struct request. > > We support cmd_size for both the mq and !mq code path, s

Re: [PATCH 08/10] mpt3sas: lockless command submission for scsi-mq

2017-01-31 Thread Christoph Hellwig
On Tue, Jan 31, 2017 at 10:25:58AM +0100, Hannes Reinecke wrote: > Enable lockless command submission for scsi-mq by moving the > command structure into the payload for struct request. We support cmd_size for both the mq and !mq code path, so this could be simplified by always taking your new bloc

Re: [PATCH] scsi_dh_emc: fix uninitialized return value ret

2017-01-31 Thread walter harms
Am 31.01.2017 13:22, schrieb Colin King: > From: Colin Ian King > > ret is uninitialized on a successful execution of clarrion_std_inquiry > and a garbage return value is being returted. Fix this by setting ret > to zero on the success exit path. > > Found by CoverityScan, CID#1398889 ("Unini

[PATCH] scsi_dh_emc: fix uninitialized return value ret

2017-01-31 Thread Colin King
From: Colin Ian King ret is uninitialized on a successful execution of clarrion_std_inquiry and a garbage return value is being returted. Fix this by setting ret to zero on the success exit path. Found by CoverityScan, CID#1398889 ("Uninitialized scaler variable") Fixes: b78205c93297b8219 ("sc

Re: [PATCH 00/10] mpt3sas: full mq support

2017-01-31 Thread Hannes Reinecke
On 01/31/2017 11:02 AM, Christoph Hellwig wrote: > On Tue, Jan 31, 2017 at 10:25:50AM +0100, Hannes Reinecke wrote: >> Hi all, >> >> this is a patchset to enable full multiqueue support for the mpt3sas driver. >> While the HBA only has a single mailbox register for submitting commands, >> it does h

Re: scsi: BUG in scsi_init_io

2017-01-31 Thread Dmitry Vyukov
On Tue, Jan 31, 2017 at 10:58 AM, Johannes Thumshirn wrote: > > [...] > >> Please-please-please, let's not use WARN for something that is not a >> kernel bug and is user-triggerable. This makes it impossible to >> automate kernel testing and requires hiring an army of people doing >> mechanical jo

Re: [PATCH 10/10] mpt3sas: scsi-mq interrupt steering

2017-01-31 Thread Christoph Hellwig
We should not need multiple submission queues for IRQ steering. We just need to build the cpu to vector reverse map that blk_mq_pci_map_queues builds. So maybe we need to refactor the API for ->map_queues a bit so that it's not tied to submission queues. In the meantime you can just opencode th

Re: [PATCH 00/10] mpt3sas: full mq support

2017-01-31 Thread Christoph Hellwig
On Tue, Jan 31, 2017 at 10:25:50AM +0100, Hannes Reinecke wrote: > Hi all, > > this is a patchset to enable full multiqueue support for the mpt3sas driver. > While the HBA only has a single mailbox register for submitting commands, > it does have individual receive queues per MSI-X interrupt and a

Re: scsi: BUG in scsi_init_io

2017-01-31 Thread Johannes Thumshirn
On Tue, Jan 31, 2017 at 10:50:49AM +0100, Dmitry Vyukov wrote: > On Tue, Jan 31, 2017 at 10:20 AM, Johannes Thumshirn > wrote: > > On Tue, Jan 31, 2017 at 09:55:52AM +0100, Dmitry Vyukov wrote: [...] > Please-please-please, let's not use WARN for something that is not a > kernel bug and is user

Re: scsi: BUG in scsi_init_io

2017-01-31 Thread Dmitry Vyukov
On Tue, Jan 31, 2017 at 10:20 AM, Johannes Thumshirn wrote: > On Tue, Jan 31, 2017 at 09:55:52AM +0100, Dmitry Vyukov wrote: >> Hello, >> >> The following program triggers BUG in scsi_init_io: > > Well crashing a machine just because of an empty dma transfer is a bit harsh, > isn't it? > > From 86

[PATCH 04/10] mpt3sas: separate out _base_recovery_check()

2017-01-31 Thread Hannes Reinecke
No functional change. Signed-off-by: Hannes Reinecke --- drivers/scsi/mpt3sas/mpt3sas_base.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c index 120b317..dd14596 100644 --- a

[PATCH 07/10] mpt3sas: use hi-priority queue for TMFs

2017-01-31 Thread Hannes Reinecke
When sending a TMF via the ioctl interface we should be using the hi-priority queue instead of the scsi queue to be consistent with overall TMF usage. Signed-off-by: Hannes Reinecke --- drivers/scsi/mpt3sas/mpt3sas_ctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH 06/10] mpt3sas: Introduce mpt3sas_get_st_from_smid()

2017-01-31 Thread Hannes Reinecke
Abstract accesses to the scsi_lookup array by introducing mpt3sas_get_st_from_smid(). Signed-off-by: Hannes Reinecke --- drivers/scsi/mpt3sas/mpt3sas_base.c | 20 drivers/scsi/mpt3sas/mpt3sas_base.h | 2 ++ drivers/scsi/mpt3sas/mpt3sas_scsih.c | 2 +- drivers

[PATCH 02/10] mpt3sas: set default value for cb_idx

2017-01-31 Thread Hannes Reinecke
No functional change. Signed-off-by: Hannes Reinecke --- drivers/scsi/mpt3sas/mpt3sas_base.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c index 0185a8d..09d0008 100644 --- a/drivers/scsi/mpt3sa

[PATCH 09/10] mpt3sas: Use 'msix_index' as argument for put_smid functions

2017-01-31 Thread Hannes Reinecke
Use msix_index as explicit argument for the various put_smid callbacks. No functional change. Signed-off-by: Hannes Reinecke --- drivers/scsi/mpt3sas/mpt3sas_base.c | 56 +--- drivers/scsi/mpt3sas/mpt3sas_base.h | 18 -- drivers/scsi/mpt3sas/mpt3sas_

[PATCH 05/10] mpt3sas: open-code _scsih_scsi_lookup_get()

2017-01-31 Thread Hannes Reinecke
Just a wrapper around the scsi lookup array and only used in one place, so open-code it. Signed-off-by: Hannes Reinecke --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b/drivers/scs

[PATCH 08/10] mpt3sas: lockless command submission for scsi-mq

2017-01-31 Thread Hannes Reinecke
Enable lockless command submission for scsi-mq by moving the command structure into the payload for struct request. Signed-off-by: Hannes Reinecke --- drivers/scsi/mpt3sas/mpt3sas_base.c | 125 ++ drivers/scsi/mpt3sas/mpt3sas_base.h | 2 + drivers/scsi/mpt3sas/mpt3sas_ctl.c

[PATCH 01/10] mpt3sas: switch to pci_alloc_irq_vectors

2017-01-31 Thread Hannes Reinecke
Cleanup the MSI-X handling allowing us to use the PCI-layer provided vector allocation. Signed-off-by: Hannes Reinecke --- drivers/scsi/mpt3sas/mpt3sas_base.c | 100 +--- drivers/scsi/mpt3sas/mpt3sas_base.h | 2 - 2 files changed, 46 insertions(+), 56 deletions(

[PATCH 03/10] mpt3sas: implement _dechain_st()

2017-01-31 Thread Hannes Reinecke
Split off _dechain_st() as separate function. No functional change. Signed-off-by: Hannes Reinecke --- drivers/scsi/mpt3sas/mpt3sas_base.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3

[PATCH 00/10] mpt3sas: full mq support

2017-01-31 Thread Hannes Reinecke
Hi all, this is a patchset to enable full multiqueue support for the mpt3sas driver. While the HBA only has a single mailbox register for submitting commands, it does have individual receive queues per MSI-X interrupt and as such does benefit from converting it to full multiqueue support. As usua

[PATCH 10/10] mpt3sas: scsi-mq interrupt steering

2017-01-31 Thread Hannes Reinecke
Enable all queues and implement correct I/O steering for scsi-mq. Signed-off-by: Hannes Reinecke --- drivers/scsi/mpt3sas/mpt3sas_base.c | 8 ++-- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 19 +++ 2 files changed, 25 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/mpt

Re: scsi: BUG in scsi_init_io

2017-01-31 Thread Johannes Thumshirn
On Tue, Jan 31, 2017 at 09:55:52AM +0100, Dmitry Vyukov wrote: > Hello, > > The following program triggers BUG in scsi_init_io: Well crashing a machine just because of an empty dma transfer is a bit harsh, isn't it? >From 86e6fa5f618fe588b98e923e032f33e075fcd4f4 Mon Sep 17 00:00:00 2001 From: Jo

scsi: BUG in scsi_init_io

2017-01-31 Thread Dmitry Vyukov
Hello, The following program triggers BUG in scsi_init_io: kernel BUG at drivers/scsi/scsi_lib.c:1043! invalid opcode: [#1] SMP KASAN Modules linked in: CPU: 0 PID: 2899 Comm: a.out Not tainted 4.10.0-rc5+ #201 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Bochs 01/01/2011 task

Re: [PATCH V3 08/24] aacraid: Added support for response path

2017-01-31 Thread Johannes Thumshirn
On Mon, Jan 30, 2017 at 08:16:48PM +, Raghava Aditya Renukunta wrote: > > > > -Original Message- > > From: Johannes Thumshirn [mailto:jthumsh...@suse.de] > > Sent: Monday, January 30, 2017 1:50 AM > > To: Raghava Aditya Renukunta > > > > Cc: j...@linux.vnet.ibm.com; martin.peter...@o