[PATCH 10/10] qla2xxx: Disable Out-of-order processing by default in Firmware

2016-12-19 Thread Himanshu Madhani
From: Quinn Tran Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_target.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c index 64e9abb..cac20af 100644 --- a/drivers/scsi/qla2

[PATCH 09/10] qla2xxx: Fix invalid handle erroneous message.

2016-12-19 Thread Himanshu Madhani
From: Quinn Tran Termination of Immediate Notify IOCB was using wrong IOCB handle. IOCB completion code was unable to find appropriate code path due to wrong handle. Following message is seen in the logs. "Error entry - invalid handle/queue ()." Signed-off-by: Quinn Tran Signed-off-by: Hi

[PATCH 06/10] qla2xxx: Fix crash due to null pointer access.

2016-12-19 Thread Himanshu Madhani
From: Quinn Tran This patch fixes crash due to NULL pointer access. Following stack trace will be seen. [1469877.797315] Call Trace: [1469877.799940] [] qla2x00_mem_alloc+0xb09/0x10c0 [qla2xxx] [1469877.806980] [] qla2x00_probe_one+0x86a/0x1b50 [qla2xxx] [1469877.814013] [] ? __pm_runtime_re

[PATCH 07/10] qla2xxx: Terminate exchange if corrputed.

2016-12-19 Thread Himanshu Madhani
From: Quinn Tran Corrupted ATIO is defined as length of fcp_header & fcp_cmd payload is less than 0x38. It's the minimum size for a frame to carry 8..16 bytes SCSI CDB. The exchange will be dropped or terminated if corrupted. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drive

[PATCH 04/10] qla2xxx: Reset reserved field in firmware options to 0.

2016-12-19 Thread Himanshu Madhani
During NVRAM initialization in target mode, reset reserved fields in firmware options to Zero (BIT 15) Signed-off-by: Himanshu Madhani Signed-off-by: Giridhar Malavali --- drivers/scsi/qla2xxx/qla_target.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/dri

[PATCH 05/10] qla2xxx: Collect additional information to debug fw dump.

2016-12-19 Thread Himanshu Madhani
From: Quinn Tran Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_mbx.c | 27 --- 1 file changed, 20 insertions(+), 7 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_mbx.c b/drivers/scsi/qla2xxx/qla_mbx.c index 2819ceb..b4386fc

[PATCH 03/10] qla2xxx: Set tcm_qla2xxx version to automatically track qla2xxx version.

2016-12-19 Thread Himanshu Madhani
Signed-off-by: Himanshu Madhani Signed-off-by: Giridhar Malavali --- drivers/scsi/qla2xxx/tcm_qla2xxx.c | 4 ++-- drivers/scsi/qla2xxx/tcm_qla2xxx.h | 1 - 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/qla2xxx/tcm_qla2xxx.c b/drivers/scsi/qla2xxx/tcm_qla2xxx.c inde

[PATCH 08/10] qla2xxx: Reduce exess wait during chip reset

2016-12-19 Thread Himanshu Madhani
From: Quinn Tran Soft reset and Risc reset should take 100uS to complete. This change pad the timeout up to 400uS, which should be plenty. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_init.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) d

[PATCH 00/10] qla2xxx: Bug fixes for driver.

2016-12-19 Thread Himanshu Madhani
Hi Christoph, Bart, This series contians bug fixes for target code in the driver. Please consider this series for target-pending. Thanks, Himanshu Himanshu Madhani (3): qla2xxx: Include ATIO queue in firmware dump when in target mode qla2xxx: Set tcm_qla2xxx version to automatically track ql

[PATCH 01/10] qla2xxx: Fix wrong IOCB type assumption.

2016-12-19 Thread Himanshu Madhani
From: Quinn Tran qlt_reset is called with Immedidate Notify IOCB only. Current code wrongly cast it as ATIO IOCB. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_target.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/

[PATCH 02/10] qla2xxx: Include ATIO queue in firmware dump when in target mode

2016-12-19 Thread Himanshu Madhani
Include ATIO queue for ISP27XX when firmware dump is collected for target mode. Signed-off-by: Himanshu Madhani Signed-off-by: Giridhar Malavali --- drivers/scsi/qla2xxx/qla_tmpl.c | 24 1 file changed, 24 insertions(+) diff --git a/drivers/scsi/qla2xxx/qla_tmpl.c b/dr

[PATCH] scsi: do not requeue requests unaligned with device sector size

2016-12-19 Thread Mauricio Faria de Oliveira
When a SCSI command (e.g., read operation) is partially completed with good status and residual bytes (i.e., not all the bytes from the specified transfer length were transferred) the SCSI midlayer will update the request/bios with the completed bytes and requeue the request in order to complete th

RE: [PATCH V4 08/11] megaraid_sas: Enable or Disable Fast path based on the PCI Threshold Bandwidth

2016-12-19 Thread Sasikumar PC
Hi Tomas, Please see my response inline Thanks sasi -Original Message- From: Tomas Henzl [mailto:the...@redhat.com] Sent: Thursday, December 15, 2016 10:10 AM To: Sasikumar PC; j...@kernel.org; h...@infradead.org Cc: linux-scsi@vger.kernel.org; Sathya Prakash Veerichetty; linux-ker...@vg

RE: [PATCH V4 06/11] megaraid_sas: Dynamic Raid Map Changes for SAS3.5 Generic Megaraid Controllers

2016-12-19 Thread Sasikumar PC
Hi Tomas, Please see my response inline Thanks sasi -Original Message- From: Sasikumar PC [mailto:sasikumar...@broadcom.com] Sent: Wednesday, December 14, 2016 4:49 PM To: 'Tomas Henzl'; 'j...@kernel.org'; 'h...@infradead.org' Cc: 'linux-scsi@vger.kernel.org'; Sathya Prakash Veerichetty;

RE: [PATCH V4 02/11] megaraid_sas: 128 MSIX Support

2016-12-19 Thread Sasikumar PC
Hi Tomas, Please see my response inline Thanks sasi -Original Message- From: Sasikumar PC [mailto:sasikumar...@broadcom.com] Sent: Wednesday, December 14, 2016 4:43 PM To: 'Tomas Henzl'; 'j...@kernel.org'; 'h...@infradead.org' Cc: 'linux-scsi@vger.kernel.org'; Sathya Prakash Veerichetty;

[PATCH v2 11/11] lpfc: lpfc version change to 11.2.0.4

2016-12-19 Thread James Smart
lpfc version change to 11.2.0.4 Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_version.h b/drivers/scsi/lpfc/lpfc_version.h index 50bfc43..0ee0623 100644 ---

[PATCH v2 10/11] lpfc: Add missing memory barrier

2016-12-19 Thread James Smart
On loosely ordered memory systems (PPC for example), the WQE elements were being updated in memory, but not necessarily flushed before the separate doorbell was written to hw which would cause hw to dma the WQE element. Thus, the hardware occasionally received partially updated WQE data. Add the

[PATCH v2 06/11] lpfc: FCoE VPort enable-disable does not bring up the VPort

2016-12-19 Thread James Smart
FCoE VPort enable-disable does not bring up the VPort. VPI structure needed to be initialized before being re-registered. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_vport.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/scsi/lpfc/lpfc

[PATCH v2 02/11] lpfc: Correct error in setting OS Driver Version with FW

2016-12-19 Thread James Smart
Correct error in setting OS Driver Version with FW. Prior length was too short. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_sli.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_s

[PATCH v2 09/11] lpfc: Correct oops on vport port resets

2016-12-19 Thread James Smart
Correct oops on vport port resets. Incorrect WQE type, thus the clearing code actually overstepped the WQE. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_sli.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_

[PATCH v2 03/11] lpfc: Deprecate lpfc_soft_wwn parameter

2016-12-19 Thread James Smart
Deprecate lpfc_soft_wwn parameter. No longer allow override of hw-assigned wwns Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc.h | 4 - drivers/scsi/lpfc/lpfc_attr.c | 216 -- drivers/scsi/lpfc/lpfc_init.c | 16

[PATCH v2 08/11] lpfc: Deprecate lpfc_prot_sg_seg_cnt parameter

2016-12-19 Thread James Smart
Deprecate lpfc_prot_sg_seg_cnt parameter. Eliminates driver from unnecessarily limiting DIF s/g list length. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc.h | 1 - drivers/scsi/lpfc/lpfc_attr.c | 10 -- 2 files changed, 11 deletions(-) diff --

[PATCH v2 05/11] lpfc: Correct host name in symbolic_name field

2016-12-19 Thread James Smart
Correct host name in symbolic_name field of nameserver registrations Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_attr.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c ind

[PATCH v2 04/11] lpfc: Correct issue leading to opps during link reset

2016-12-19 Thread James Smart
Correct issue leading to opps during link reset. Missing vport pointer. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_sli.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c index 230f924..47b5520

[PATCH v2 07/11] lpfc: Fix Xlane dynamic LUN set for LUN priority.

2016-12-19 Thread James Smart
Fix Xlane dynamic LUN set for LUN priority. Dynamic changing of the priority was not getting reflected on the LUN. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_attr.c | 23 +++ drivers/scsi/lpfc/lpfc_crtn.h | 7 --- drivers/scsi/lpf

[PATCH v2 00/11] lpfc: Update driver to version 11.2.0.4

2016-12-19 Thread James Smart
(I posted a little too quickly) This patch set updates the lpfc driver to revision 11.2.0.4 v2: - patch 10 revised for checkpatch warning - comment before wmb() - note: checkpatch also caught patch 5 for a sizeof warning. But it's actually correct. The resulting text is flagged due to th

[PATCH v2 01/11] lpfc: Clear the VendorVersion in the PLOGI/PLOGI ACC payload

2016-12-19 Thread James Smart
Clear the VendorVersion in the PLOGI/PLOGI ACC payload Vendor version info may have been set on fabric login. Before sending PLOGI payloads, ensure that it's cleared. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_els.c | 6 ++ drivers/scsi/lpfc/lpfc_hw.

[PATCH 09/11] lpfc: Correct oops on vport port resets

2016-12-19 Thread James Smart
Correct oops on vport port resets. Incorrect WQE type, thus the clearing code actually overstepped the WQE. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_sli.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_

[PATCH 07/11] lpfc: Fix Xlane dynamic LUN set for LUN priority.

2016-12-19 Thread James Smart
Fix Xlane dynamic LUN set for LUN priority. Dynamic changing of the priority was not getting reflected on the LUN. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_attr.c | 23 +++ drivers/scsi/lpfc/lpfc_crtn.h | 7 --- drivers/scsi/lpf

[PATCH 10/11] lpfc: Add missing memory barrier

2016-12-19 Thread James Smart
On loosely ordered memory systems (PPC for example), the WQE elements were being updated in memory, but not necessarily flushed before the separate doorbell was written to hw which would cause hw to dma the WQE element. Thus, the hardware occasionally received partially updated WQE data. Add the

[PATCH 05/11] lpfc: Correct host name in symbolic_name field

2016-12-19 Thread James Smart
Correct host name in symbolic_name field of nameserver registrations Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_attr.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c ind

[PATCH 03/11] lpfc: Deprecate lpfc_soft_wwn parameter

2016-12-19 Thread James Smart
Deprecate lpfc_soft_wwn parameter. No longer allow override of hw-assigned wwns Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc.h | 4 - drivers/scsi/lpfc/lpfc_attr.c | 216 -- drivers/scsi/lpfc/lpfc_init.c | 16

[PATCH 01/11] lpfc: Clear the VendorVersion in the PLOGI/PLOGI ACC payload

2016-12-19 Thread James Smart
Clear the VendorVersion in the PLOGI/PLOGI ACC payload Vendor version info may have been set on fabric login. Before sending PLOGI payloads, ensure that it's cleared. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_els.c | 6 ++ drivers/scsi/lpfc/lpfc_hw.

[PATCH 04/11] lpfc: Correct issue leading to opps during link reset

2016-12-19 Thread James Smart
Correct issue leading to opps during link reset. Missing vport pointer. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_sli.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c index 230f924..47b5520

[PATCH 08/11] lpfc: Deprecate lpfc_prot_sg_seg_cnt parameter

2016-12-19 Thread James Smart
Deprecate lpfc_prot_sg_seg_cnt parameter. Eliminates driver from unnecessarily limiting DIF s/g list length. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc.h | 1 - drivers/scsi/lpfc/lpfc_attr.c | 10 -- 2 files changed, 11 deletions(-) diff --

[PATCH 06/11] lpfc: FCoE VPort enable-disable does not bring up the VPort

2016-12-19 Thread James Smart
FCoE VPort enable-disable does not bring up the VPort. VPI structure needed to be initialized before being re-registered. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_vport.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/scsi/lpfc/lpfc

[PATCH 00/11] lpfc: Update driver to version 11.2.0.4

2016-12-19 Thread James Smart
This patch set updates the lpfc driver to revision 11.2.0.4 The patches were cut against 12/17 scsi.git tree, misc branch -- james James Smart (11): Clear the VendorVersion in the PLOGI/PLOGI ACC payload Correct error in setting OS Driver Version with FW Deprecate lpfc_soft_wwn parameter

[PATCH 02/11] lpfc: Correct error in setting OS Driver Version with FW

2016-12-19 Thread James Smart
Correct error in setting OS Driver Version with FW. Prior length was too short. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_sli.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_s

[PATCH 11/11] lpfc: lpfc version change to 11.2.0.4

2016-12-19 Thread James Smart
lpfc version change to 11.2.0.4 Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_version.h b/drivers/scsi/lpfc/lpfc_version.h index 50bfc43..0ee0623 100644 ---

Re: [PATCH v1 07/12] scsi: ufs: add option to change default UFS power management level

2016-12-19 Thread Rob Herring
On Tue, Dec 13, 2016 at 2:16 PM, Subhash Jadavani wrote: > On 2016-12-13 12:04, Rob Herring wrote: >> >> On Mon, Dec 12, 2016 at 04:54:20PM -0800, Subhash Jadavani wrote: >>> >>> UFS device and link can be put in multiple different low power modes >>> hence >>> UFS driver supports multiple differe

Re: [PATCH 1/9] qla2xxx: Move cmd search out of qla during ABTS

2016-12-19 Thread Bart Van Assche
On Mon, 2016-12-19 at 07:59 -0800, h...@infradead.org wrote: > On Mon, Dec 19, 2016 at 03:33:27PM +, Bart Van Assche wrote: > > Please consider removing the sess_cmd_list loop. Any lookups in > > sess_cmd_list should be performed by the target core and not by a > > target driver. Are you aware

Re: [PATCH 1/9] qla2xxx: Move cmd search out of qla during ABTS

2016-12-19 Thread h...@infradead.org
On Mon, Dec 19, 2016 at 03:33:27PM +, Bart Van Assche wrote: > Please consider removing the sess_cmd_list loop. Any lookups in > sess_cmd_list should be performed by the target core and not by a > target driver. Are you aware that core_tmr_abort_task() performs a very > similar lookup to the on

Re: [PATCH 1/9] qla2xxx: Move cmd search out of qla during ABTS

2016-12-19 Thread Bart Van Assche
On Sun, 2016-12-18 at 01:02 -0800, Himanshu Madhani wrote: > diff --git a/drivers/scsi/qla2xxx/tcm_qla2xxx.c > b/drivers/scsi/qla2xxx/tcm_qla2xxx.c > index 6643f6f..9275f36 100644 > --- a/drivers/scsi/qla2xxx/tcm_qla2xxx.c > +++ b/drivers/scsi/qla2xxx/tcm_qla2xxx.c > @@ -567,6 +567,30 @@ static in

Re: [PATCH RESEND] block: allow WRITE_SAME commands with the SG_IO ioctl

2016-12-19 Thread Jens Axboe
On 12/15/2016 10:48 AM, Mauricio Faria de Oliveira wrote: > The WRITE_SAME commands are not present in the blk_default_cmd_filter > write_ok list, and thus are failed with -EPERM when the SG_IO ioctl() > is executed without CAP_SYS_RAWIO capability (e.g., unprivileged users). > [ sg_io() -> blk_fil

Re: [PATCH RESEND] block: allow WRITE_SAME commands with the SG_IO ioctl

2016-12-19 Thread Christoph Hellwig
Looks fine, Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 5/8] linux: drop __bitwise__ everywhere

2016-12-19 Thread Luca Coelho
On Thu, 2016-12-15 at 07:15 +0200, Michael S. Tsirkin wrote: > __bitwise__ used to mean "yes, please enable sparse checks > unconditionally", but now that we dropped __CHECK_ENDIAN__ > __bitwise is exactly the same. > There aren't many users, replace it by __bitwise everywhere. > > Signed-off-by: