[PATCH] scsi/bfa: use designated initializers

2016-12-16 Thread Kees Cook
Prepare to mark sensitive kernel structures for randomization by making sure they're using designated initializers. These were identified during allyesconfig builds of x86, arm, and arm64, with most initializer fixes extracted from grsecurity. Signed-off-by: Kees Cook --- drivers/scsi/bfa/bfa_fc

[PATCH] cciss: use designated initializers

2016-12-16 Thread Kees Cook
Prepare to mark sensitive kernel structures for randomization by making sure they're using designated initializers. These were identified during allyesconfig builds of x86, arm, and arm64, with most initializer fixes extracted from grsecurity. Signed-off-by: Kees Cook --- drivers/block/cciss.h |

[PATCH] hpsa: use designated initializers

2016-12-16 Thread Kees Cook
Prepare to mark sensitive kernel structures for randomization by making sure they're using designated initializers. These were identified during allyesconfig builds of x86, arm, and arm64, with most initializer fixes extracted from grsecurity. Signed-off-by: Kees Cook --- drivers/scsi/hpsa.h | 4

[PATCH] scsi: esas2r: Fix format string type mistakes

2016-12-16 Thread Kees Cook
From: Emese Revfy This adds the missing __printf attribute which allows compile time format string checking (and will be used by the coming initify gcc plugin). Additionally, this fixes the warnings exposed by the attribute. Signed-off-by: Emese Revfy [kees: split scsi/acpi, merged attr and fix

[PATCH] scsi: qedi: return via va_end to match corresponding va_start

2016-12-16 Thread Colin King
From: Colin Ian King Although on most systems va_end is a no-op, it is good practice to use va_end on the function return path, especially since the va_start documenation states: "Each invocation of va_start() must be matched by a corresponding invocation of va_end() in the same function."

Re: [PATCH 2/2] SRP transport, scsi-mq: Wait for .queue_rq() if necessary

2016-12-16 Thread Bart Van Assche
On 11/23/2016 01:17 AM, Bart Van Assche wrote: > Ensure that if scsi-mq is enabled that scsi_internal_device_block() > waits until ongoing shost->hostt->queuecommand() calls have finished. > > Signed-off-by: Bart Van Assche > Reviewed-by: Sagi Grimberg > Reviewed-by: Martin K. Petersen > Cc: Ja

[patch] scsi: dpt_i2o: double free if adpt_i2o_online_hba() fails

2016-12-16 Thread Dan Carpenter
There are two places where adpt_i2o_online_hba() is called. Both callers call adpt_i2o_delete_hba(pHba) if adpt_i2o_online_hba() fails and since we also free it here that causes a double free bug. Signed-off-by: Dan Carpenter --- This bug pre-dates git. diff --git a/drivers/scsi/dpt_i2o.c b/dri

Re: [PATCH 08/22] qla2xxx: Refactore target code to remove symbol dependency

2016-12-16 Thread Bart Van Assche
On 12/15/2016 09:50 PM, Tran, Quinn wrote: > Qlogic was asked to support other Target Stack (SCST) using the same > qla2xxx.ko upstream driver. I had mentioned this during the last 2015 > LSF get together. Hopefully, that gives a better context. The > understanding that came away was “Qlogic do

Re: [PATCH 08/22] qla2xxx: Refactore target code to remove symbol dependency

2016-12-16 Thread Christoph Hellwig
On Thu, Dec 15, 2016 at 08:50:39PM +, Tran, Quinn wrote: > Christoph, > > Qlogic was asked to support other Target Stack (SC ST) using the same > qla2xxx.ko upstream driver. I had mentioned this during the last 2015 LSF > get together. Hopefully, that gives a better context. The understan