Hi Hannes,
Please find the response below,
On 11/11/16 10:13 PM, "Hannes Reinecke" wrote:
>On 11/08/2016 07:57 AM, Manish Rangankar wrote:
>> The QLogic FastLinQ Driver for iSCSI (qedi) is the iSCSI specific module
>> for 41000 Series Converged Network Adapters by QLogic.
>>
>> This patch consi
On 11/15/2016 07:14 AM, Rangankar, Manish wrote:
> Hi Hannes,
>
> Please find the response below,
>
> On 11/11/16 10:13 PM, "Hannes Reinecke" wrote:
>
[ .. ]
>> Please use the irq-affinity rework from Christoph here; that'll save you
>> the additional msix vectors allocation.
>
> The existing
On 11/14/2016 04:49 PM, Omar Sandoval wrote:
From: Omar Sandoval
Let's not depend on any of the BLK_MQ_RQ_QUEUE_* constants having
specific values. No functional change.
Signed-off-by: Omar Sandoval
---
Hi, Jens,
Some more trivial cleanup, feel free to apply or not if it's too intrusive.
I
From: Omar Sandoval
Let's not depend on any of the BLK_MQ_RQ_QUEUE_* constants having
specific values. No functional change.
Signed-off-by: Omar Sandoval
---
Hi, Jens,
Some more trivial cleanup, feel free to apply or not if it's too intrusive.
drivers/nvme/host/core.c | 4 ++--
drivers/nvm
> "Tomas" == Tomas Henzl writes:
Tomas> rport can't be null here, it would have failed already in
Tomas> fc_remote_port_chkready
Cisco folks: Please review!
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the b
> "John" == John Garry writes:
John> This patchset introduces some misc bug fixes, improvements, and
John> new features to the HiSilicon SAS driver.
This series needs review.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe li
> "Tomas" == Tomas Henzl writes:
Tomas> It is not good when an irq arrives before driver structures are
Tomas> allocated.
Sumit, Kashyap: Please review!
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body
> "Arun" == Arun Easi writes:
Arun,
Arun> Do you have any preference or thoughts on how the "qed" patches be
Arun> approached? Just as a reference, our rdma driver "qedr" went
Arun> through something similar[1], and eventually "qed" patches were
Arun> taken by David in the net tree and "qedr
> "Don" == Don Brace writes:
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 0b6eb5a..a296537 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -300,6 +300,10 @@ static bool hpsa_cmd_dev_match(struct ctlr_info *h, struct
CommandList *c,
> "Mauricio" == Mauricio Faria de Oliveira
> writes:
Mauricio> The previous commit ("qla2xxx: fix invalid DMA access after
Mauricio> command aborts in PCI device remove") introduced a regression
Mauricio> during an EEH recovery, since the change to the
Mauricio> qla2x00_abort_all_cmds()
> "Colin" == Colin King writes:
Colin> From: Colin Ian King Use correct index
Colin> on q, use h->intr_mode instead of i. Issue detected using static
Colin> analysis with cppcheck
Applied to 4.10/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this l
> "Colin" == Colin King writes:
Colin> From: Colin Ian King Trivial fix to
Colin> typo "repsonse" to "response" in dev_dbg message.
Applied to 4.10/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
t
> "Colin" == Colin King writes:
Colin> From: Colin Ian King Trivial fix to
Colin> spelling mistake "suspeneded" to "suspended" in dev_warn messages
Applied to 4.10/scsi-queue with s/iscsi/isci/.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the
> "Andrey" == Andrey Grodzovsky writes:
Andrey,
Andrey> Regarding older code where there is still a separate mpt2sas
Andrey> driver, should a separate patch to be done or this fix will be
Andrey> ported there ?
Feel free to submit a mpt2sas patch to the pre-4.4 stable trees.
--
Martin K.
> "Colin" == Colin King writes:
Colin> A couple of dev_printk messages spans two lines and the literal
Colin> string is missing a white space between words. Add the white
Colin> space.
Applied to 4.10/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from th
> "Bart" == Bart Van Assche writes:
Bart> It is required to hold the queue lock when calling
Bart> blk_run_queue_async() to avoid that a race between
Bart> blk_run_queue_async() and blk_cleanup_queue() is
Bart> triggered. Additionally, remove the get_device() and put_device()
Bart> calls from
On 11/12/2016 10:30 AM, Colin King wrote:
Trivial fix to typo "repsonse" to "response" in dev_dbg message.
Reviewed-by: Bart Van Assche
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://
On 11/12/2016 08:25 AM, Colin King wrote:
A couple of dev_printk messages spans two lines and the literal string
is missing a white space between words. Add the white space.
Reviewed-by: Bart Van Assche
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a m
On 11/12/2016 08:49 AM, Colin King wrote:
Trivial fix to spelling mistake "suspeneded" to "suspended" in
dev_warn messages
Reviewed-by: Bart Van Assche
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo
On 11/14/16, 1:26 PM, "Mauricio Faria de Oliveira"
wrote:
>The previous commit ("qla2xxx: fix invalid DMA access after command
>aborts in PCI device remove") introduced a regression during an EEH
>recovery, since the change to the qla2x00_abort_all_cmds() function
>calls qla2xxx_eh_abort(), wh
Hi Martin, David,
This is regarding the submission of the recent patch series we have posted
to linux-scsi and netdev:
[PATCH v2 0/6] Add QLogic FastLinQ iSCSI (qedi) driver.
[PATCH v2 1/6] qed: Add support for hardware offloaded iSCSI.
[PATCH v2 2/6] qed: Add iSCSI out of order packe
The previous commit ("qla2xxx: fix invalid DMA access after command
aborts in PCI device remove") introduced a regression during an EEH
recovery, since the change to the qla2x00_abort_all_cmds() function
calls qla2xxx_eh_abort(), which verifies the EEH recovery condition
but handles it heavy-handed
On 11/10/2016 10:53 PM, Damien Le Moal wrote:
Normally, sd_read_capacity sets sdp->use_16_for_rw to 1 based on the
disk capacity so that READ16/WRITE16 are used for large drives.
However, for a zoned disk with RC_BASIS set to 0, the capacity reported
through READ_CAPACITY may be very small, leadi
In blk_mq_map_swqueue, there is a memory optimization that frees the
tags of a queue that has gone unmapped. Later, if that hctx is remapped
after another topology change, the tags need to be reallocated.
If this allocation fails, a simple WARN_ON triggers, but the block layer
ends up with an act
While stressing memory and IO at the same time we changed SMT settings,
we were able to consistently trigger deadlocks in the mm system, which
froze the entire machine.
I think that under memory stress conditions, the large allocations
performed by blk_mq_init_rq_map may trigger a reclaim, which s
On 11/12/2016 09:47 PM, James Bottomley wrote:
On Fri, 2016-11-11 at 16:38 -0800, Bart Van Assche wrote:
Hello James and Martin,
This short patch series fixes a deadlock that I ran into for the
first time several months ago but for which I had not yet had the
time to post a fix. As usual, feedb
Looks fine,
Reviewed-by: Christoph Hellwig
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Reviewed-By: James Smart
(Bart: fyi - note my change in email address)
-- james
On 11/11/2016 4:55 PM, Bart Van Assche wrote:
It is required to hold the queue lock when calling blk_run_queue_async()
to avoid that a race between blk_run_queue_async() and
blk_cleanup_queue() is triggered. Addi
Looks fine, I was actually about to send the same fix..
Reviewed-by: Christoph Hellwig
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Colin Ian King
Use correct index on q, use h->intr_mode instead of i. Issue
detected using static analysis with cppcheck
Fixes: bc2bb1543e62a5d0 ("scsi: hpsa: use pci_alloc_irq_vectors and automatic
irq affinity")
Signed-off-by: Colin Ian King
---
drivers/scsi/hpsa.c | 2 +-
1 file chan
> if (instance->msix_vectors)
> for (i = 0; i < instance->msix_vectors; i++) {
> + free_irq(pci_irq_vector(instance->pdev, i),
>&instance->irq_context[i]);
> }
> else
> + free_irq(pci_irq_vector(
On Fri, Nov 11, 2016 at 03:59:05PM +0100, Hannes Reinecke wrote:
> You are right; irq affinity only makes sense for MSI-X.
> I'll be fixing it up.
It works for multi-MSI and MSI-X. And even for single-MSI or
INTx it's harmless as it will be ignored if only a single
vector is present.
--
To unsubs
> -Original Message-
> From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi-
> ow...@vger.kernel.org] On Behalf Of Hannes Reinecke
> Sent: Friday, November 11, 2016 3:15 PM
> To: Martin K. Petersen
> Cc: Christoph Hellwig; James Bottomley; Sumit Saxena; linux-
> s...@vger.kernel.org; H
> -Original Message-
> From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi-
> ow...@vger.kernel.org] On Behalf Of Christoph Hellwig
> Sent: Sunday, November 13, 2016 5:29 PM
> To: Hannes Reinecke
> Cc: Christoph Hellwig; Hannes Reinecke; Christoph Hellwig; Martin K.
Petersen;
> James
34 matches
Mail list logo
