RE: Device or HBA level QD throttling creates randomness in sequetial workload

2016-10-31 Thread Kashyap Desai
Jens- Replied inline. Omar - I tested your WIP repo and figure out System hangs only if I pass " scsi_mod.use_blk_mq=Y". Without this, your WIP branch works fine, but I am looking for scsi_mod.use_blk_mq=Y. Also below is snippet of blktrace. In case of higher per device QD, I see Requeue reques

Re: Kernel 4.8.4: INFO: task kworker/u16:8:289 blocked for more than 120 seconds.

2016-10-31 Thread TomK
On 10/30/2016 2:50 PM, TomK wrote: On 10/29/2016 5:44 PM, Nicholas A. Bellinger wrote: On Sat, 2016-10-29 at 14:10 -0400, TomK wrote: On 10/29/2016 3:50 AM, Nicholas A. Bellinger wrote: Hi TomK & Co, On Fri, 2016-10-28 at 02:01 -0400, TomK wrote: On 10/26/2016 8:08 AM, TomK wrote: On 10/26/

Re: esp_scsi QTAG in FAS216

2016-10-31 Thread Finn Thain
On Tue, 1 Nov 2016, Michael Schmitz wrote: > > I had tried to set that bit in zorro_esp_slave_configure but had not > > done a proper job of it - I'd only set esp->config3 and forgot to set > > tp->esp_config3. Time to retest this ... > > I don't think it's quite that easy - the ESP_CONFIG3_TE

Geschäftsvorschlag!!!

2016-10-31 Thread Louis ISAKI
-- Geschäftsvorschlag!!! Ich vermute das diese E-Mail eine Überraschung für Sie sein wird, aber es ist wahr.Ich bin bei einer routinen Überprüfung in meiner Bank (First National Bank von Süd Afrika) wo ich arbeite, auf einem Konto gestoßen, was nicht in anspruch genommen worden ist, wo derz

Re: [PATCH] vmw_pvscsi: return SUCCESS for successful command aborts

2016-10-31 Thread Jim Gill
On Fri, 2016-10-28 at 12:27 -0400, David Jeffery wrote: > The vmw_pvscsi driver reports most successful aborts as FAILED to the scsi > error handler. This is do to a misunderstanding of how completion_done() > works > and its interaction with a successful wait using > wait_for_completion_timeou

Re: [PATCH v3 12/12] scsi/ufs: qcom: Don't free resource-managed kmalloc element

2016-10-31 Thread Subhash Jadavani
On 2016-10-29 13:22, Vivek Gautam wrote: Host is allocated by managed kmalloc (devm_kmalloc). The memory allocated with this function is automatically freed on driver detach. So, no need to make an exclusive free call over it. Signed-off-by: Vivek Gautam --- New patch added in v3 of this clean

Re: [PATCH v3 04/12] phy: qcom-ufs-14nm: Add new compatible for msm8996 based phy

2016-10-31 Thread Subhash Jadavani
On 2016-10-29 13:22, Vivek Gautam wrote: Add a new compatible string for 14nm ufs phy present on msm8996 chipset. This phy is bit different from the legacy 14nm ufs phy in terms of the clocks that are needed to be handled in the driver. Signed-off-by: Vivek Gautam --- New patch in v3 of this c

[PATCH 2/6] g_NCR5380: Test the IRQ before accepting it

2016-10-31 Thread Ondrej Zary
Trigger an IRQ first with a test IRQ handler to find out if it really works. Disable the IRQ if not. This prevents hang when incorrect IRQ was specified by user. Signed-off-by: Ondrej Zary --- drivers/scsi/g_NCR5380.c | 44 +--- 1 file changed, 41 inser

[PATCH 0/6] (g_)NCR5380: Improve IRQ probing and some fixes

2016-10-31 Thread Ondrej Zary
Hello, this patch series improves IRQ probing and moves it from NCR5380 to g_NCR5380, adds IRQ auto-configuration for HP C2502 and enables all this by default. It also adds IRQ and base address checks to prevent hangs when wrong values are specified by user. There's also a small release region fix

[PATCH 3/6] g_NCR5380: Check for chip presence before calling NCR5380_init()

2016-10-31 Thread Ondrej Zary
Write and read back MODE_REG to check if the chip is really there before doing more initialization. This prevents hang when incorrect I/O address was specified by user (in the most common case where no device is present there so all reads result in 0xff). Signed-off-by: Ondrej Zary --- drivers/

[PATCH 4/6] g_NCR5380: Add IRQ auto-configuration for HP C2502

2016-10-31 Thread Ondrej Zary
Find free and working IRQ automatically on HP C2502 cards. Also allow IRQ 9 to work (aliases to IRQ 2 on the card). Signed-off-by: Ondrej Zary --- drivers/scsi/g_NCR5380.c | 29 +++-- 1 file changed, 27 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/g_NCR5380.

[PATCH 1/6] NCR5380: Use probe_irq_*() for IRQ probing

2016-10-31 Thread Ondrej Zary
Use standard probe_irq_on() and probe_irq_off() functions instead of own implementation. This prevents warning messages like this in the kernel log: genirq: Flags mismatch irq 1. (NCR-probe) vs. 0080 (i8042) Move the IRQ trigger code to a separate function so it can be used for other

[PATCH 5/6] g_NCR5380: Autoprobe IRQ by default

2016-10-31 Thread Ondrej Zary
IRQ probing seems to work fine now. Default to autoprobe for IRQ instead of disabling it. Signed-off-by: Ondrej Zary --- drivers/scsi/g_NCR5380.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/g_NCR5380.c b/drivers/scsi/g_NCR5380.c index 27fc499..6a08d3e

[PATCH 6/6] g_NCR5380: Fix release region in error handling

2016-10-31 Thread Ondrej Zary
When a SW-configurable card is specified but not found, the driver releases wrong region, causing the following message in kernel log: Trying to free nonexistent resource <-000f> Fix it by assigning base earlier. Signed-off-by: Ondrej Zary --- drivers/scsi/g_NCR5380.

RE: [PATCH 3/3] smartpqi: switch to pci_alloc_irq_vectors

2016-10-31 Thread Don Brace
> -Original Message- > From: Don Brace > Sent: Monday, October 17, 2016 8:45 AM > To: 'Johannes Thumshirn'; Christoph Hellwig > Cc: martin.peter...@oracle.com; ax...@kernel.dk; linux- > s...@vger.kernel.org; linux-bl...@vger.kernel.org > Subject: RE: [PATCH 3/3] smartpqi: switch to pci_allo

Re: "hpsa: Change SAS transport devices to bus 0." commit breaks hpacucli on old controller firmware

2016-10-31 Thread Don Brace
On 10/27/2016 01:15 PM, Jack Suter wrote: Hi there, Commit "hpsa: Change SAS transport devices to bus 0." (09371d623c9c3dc6ed7f53ec8ab01d25f0c6c697) breaks the hpacucli utility for some HP Smart Array controllers with old firmware. Specifically, I have a P410 connected to an HP DL180 G6 running

Re: esp_scsi QTAG in FAS216

2016-10-31 Thread Michael Schmitz
Hi Finn, > I had tried to set that bit in zorro_esp_slave_configure but had not > done a proper job of it - I'd only set esp->config3 and forgot to set > tp->esp_config3. Time to retest this ... I don't think it's quite that easy - the ESP_CONFIG3_TENB bit needs to be set for all targets if at le

[PATCH 0/3] scsi_dh: switch to scsi_execute_req_flags()

2016-10-31 Thread Hannes Reinecke
Hi all, here's a patchset to switch to scsi_execute_req_flags() for all SCSI device handlers. Originally we would be using blk_execute_rq_nowait to allow the 'activate' function to run asynchronously. However, as we're now calling the 'activate' function synchronously there's no point in using the

[PATCH 3/3] scsi_dh_hp_sw: switch to scsi_execute_req_flags()

2016-10-31 Thread Hannes Reinecke
Switch to using scsi_execute_req_flags() instead of using the block primitives. Signed-off-by: Hannes Reinecke --- drivers/scsi/device_handler/scsi_dh_hp_sw.c | 218 1 file changed, 61 insertions(+), 157 deletions(-) diff --git a/drivers/scsi/device_handler/scsi_dh_

[PATCH 1/3] scsi_dh_rdac: switch to scsi_execute_req_flags()

2016-10-31 Thread Hannes Reinecke
Switch to using scsi_execute_req_flags() instead of using the block primitives. Signed-off-by: Hannes Reinecke --- drivers/scsi/device_handler/scsi_dh_rdac.c | 160 - 1 file changed, 45 insertions(+), 115 deletions(-) diff --git a/drivers/scsi/device_handler/scsi_dh_

[PATCH 2/3] scsi_dh_emc: switch to scsi_execute_req_flags()

2016-10-31 Thread Hannes Reinecke
Switch to using scsi_execute_req_flags() instead of using the block primitives. Signed-off-by: Hannes Reinecke --- drivers/scsi/device_handler/scsi_dh_emc.c | 245 +++--- 1 file changed, 54 insertions(+), 191 deletions(-) diff --git a/drivers/scsi/device_handler/scsi_dh_

Re: Device or HBA level QD throttling creates randomness in sequetial workload

2016-10-31 Thread Jens Axboe
Hi, One guess would be that this isn't around a requeue condition, but rather the fact that we don't really guarantee any sort of hard FIFO behavior between the software queues. Can you try this test patch to see if it changes the behavior for you? Warning: untested... diff --git a/block/blk-mq.

Re: iscsi_trx going into D state

2016-10-31 Thread Robert LeBlanc
Nicholas, Thanks for following up on this. We have been chasing other bugs in our provisioning and as such has reduced our load on the boxes. We are hoping to get that all straightened out this week and do some more testing. So far we have not had any iSCSI in D state since the patch, be we haven'

Re: [PATCH] mvsas: fix error return code in mvs_task_prep()

2016-10-31 Thread Tejun Heo
On Mon, Oct 31, 2016 at 03:04:10PM +, Wei Yongjun wrote: > From: Wei Yongjun > > Fix to return error code -ENOMEM from the error handling > case instead of 0, as done elsewhere in this function. > > Signed-off-by: Wei Yongjun Applied to libata/for-4.9-fixes. Thanks. -- tejun -- To unsub

RE: [PATCH 2/4] hpsa: add generate controller NMI on lockup

2016-10-31 Thread Don Brace
> -Original Message- > From: Hannes Reinecke [mailto:h...@suse.de] > Sent: Thursday, October 27, 2016 4:03 AM > To: Don Brace; j...@linux.vnet.ibm.com; John Hall; Kevin Barnett; Mahesh > Rajashekhara; h...@infradead.org; Scott Teel; Viswas G; Justin Lindley; Scott > Benesh; elli...@hpe.com;

[PATCH] scsi: mpt3sas: fix some spelling mistakes in message and comments

2016-10-31 Thread Colin King
From: Colin Ian King Trival fixes, minor spelling mistakes in comments and in a KERN_INFO message. Signed-off-by: Colin Ian King --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b

Re: [PATCH 05/60] target: avoid to access .bi_vcnt directly

2016-10-31 Thread Christoph Hellwig
On Sat, Oct 29, 2016 at 04:08:04PM +0800, Ming Lei wrote: > When the bio is full, bio_add_pc_page() will return zero, > so use this way to handle full bio. > > Also replace access to .bi_vcnt for pr_debug() with bio_segments(). > > Signed-off-by: Ming Lei Looks fine, Reviewed-by: Christoph Hel

RE: [PATCH 1/4] hpsa: correct lockup detector pci_disable_device

2016-10-31 Thread Don Brace
> -Original Message- > From: Christoph Hellwig [mailto:h...@infradead.org] > Sent: Thursday, October 27, 2016 10:19 AM > To: Don Brace > Cc: j...@linux.vnet.ibm.com; John Hall; Kevin Barnett; Mahesh > Rajashekhara; h...@infradead.org; Scott Teel; Viswas G; Justin Lindley; Scott > Benesh; el

Re: [PATCH] mvsas: fix error return code in mvs_task_prep()

2016-10-31 Thread Luis de Bethencourt
On 31/10/16 15:04, Wei Yongjun wrote: > From: Wei Yongjun > > Fix to return error code -ENOMEM from the error handling > case instead of 0, as done elsewhere in this function. > > Signed-off-by: Wei Yongjun > --- > drivers/scsi/mvsas/mv_sas.c | 4 +++- > 1 file changed, 3 insertions(+), 1 dele

Re: [PATCH v5 14/14] nvme: Use BLK_MQ_S_STOPPED instead of QUEUE_FLAG_STOPPED in blk-mq code

2016-10-31 Thread Bart Van Assche
On Mon, 2016-10-31 at 09:53 -0400, Laurence Oberman wrote: > Applied all 14 patches, also corrected the part of the xen-blkfront.c > blkif_recover patch in patchv5-5/14. > > diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen- > blkfront.c > index 9908597..60fff99 100644 > --- a/drivers

[PATCH] mvsas: fix error return code in mvs_task_prep()

2016-10-31 Thread Wei Yongjun
From: Wei Yongjun Fix to return error code -ENOMEM from the error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun --- drivers/scsi/mvsas/mv_sas.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/mvsas/mv_sas.c b/driv

Re: [PATCH v5 14/14] nvme: Use BLK_MQ_S_STOPPED instead of QUEUE_FLAG_STOPPED in blk-mq code

2016-10-31 Thread Bart Van Assche
On 10/31/2016 06:53 AM, Laurence Oberman wrote: Ran multiple read/write buffered and directio tests via RDMA/SRP and mlx5 (100Gbit) with max_sectors_kb set to 1024, 2048, 4096 and 8196 Ran multiple read/write buffered and directio tests via RDMA/SRP and mlx4 (56Gbit) with max_sectors_kb set to

Re: [PATCH v5 14/14] nvme: Use BLK_MQ_S_STOPPED instead of QUEUE_FLAG_STOPPED in blk-mq code

2016-10-31 Thread Laurence Oberman
- Original Message - > From: "Bart Van Assche" > To: "Jens Axboe" > Cc: "Christoph Hellwig" , "James Bottomley" > , "Martin K. Petersen" > , "Mike Snitzer" , "Doug > Ledford" , "Keith > Busch" , "Ming Lei" , "Konrad > Rzeszutek Wilk" > , "Roger Pau Monné" , "Laurence > Oberman" , >

Re: [PATCH 2/3] g_NCR5380: Test the IRQ before accepting it

2016-10-31 Thread Finn Thain
On Mon, 31 Oct 2016, Ondrej Zary wrote: > On Monday 31 October 2016, Finn Thain wrote: > > On Sun, 30 Oct 2016, Ondrej Zary wrote: > > > Trigger an IRQ first with a test IRQ handler to find out if it really > > > works. Disable the IRQ if not. > > > > > > This prevents hang when incorrect IRQ was

Re: [PATCH 1/3] NCR5380: Use probe_irq_*() for IRQ probing

2016-10-31 Thread Finn Thain
On Mon, 31 Oct 2016, Ondrej Zary wrote: > On Monday 31 October 2016, Finn Thain wrote: > > On Sun, 30 Oct 2016, Ondrej Zary wrote: > > > Use standard probe_irq_on() and probe_irq_off() functions instead of own > > > implementation. > > > > Thanks for doing this. > > > > > This prevents warning me

Re: [PATCH 3/3] NCR5380: Check for chip presence in NCR5380_init()

2016-10-31 Thread Finn Thain
On Mon, 31 Oct 2016, Ondrej Zary wrote: > On Monday 31 October 2016, Finn Thain wrote: > > On Sun, 30 Oct 2016, Ondrej Zary wrote: > > > Read back MODE_REG after writing it in NCR5380_init() to check if the > > > chip is really there. > > > > > > This prevents hang when incorrect I/O address was

Re: Need some pointers to debug a target hang

2016-10-31 Thread Zhu Lingshan
Hi Nicholas, (sorry it would be a long mail) Sorry for the delay, I spent some test and debug work. I find the patch http://www.spinics.net/lists/target-devel/msg13530.html can solve two issues: (a). iscsit_stop_session() on the top of iscsi_np stack. (b).iscsi_check_for_session_reinstatement

Re: [PATCH 2/3] g_NCR5380: Test the IRQ before accepting it

2016-10-31 Thread Ondrej Zary
On Monday 31 October 2016, Finn Thain wrote: > On Sun, 30 Oct 2016, Ondrej Zary wrote: > > Trigger an IRQ first with a test IRQ handler to find out if it really > > works. Disable the IRQ if not. > > > > This prevents hang when incorrect IRQ was specified by user. > > > > Signed-off-by: Ondrej Zary

Re: [PATCH 1/3] NCR5380: Use probe_irq_*() for IRQ probing

2016-10-31 Thread Ondrej Zary
On Monday 31 October 2016, Finn Thain wrote: > On Sun, 30 Oct 2016, Ondrej Zary wrote: > > Use standard probe_irq_on() and probe_irq_off() functions instead of own > > implementation. > > Thanks for doing this. > > > This prevents warning messages like this in the kernel log: > > genirq: Flags mism

Re: esp_scsi QTAG in FAS216

2016-10-31 Thread Michael Schmitz
Hi Finn, Am 30.10.2016 um 15:33 schrieb Finn Thain: > > On Sat, 29 Oct 2016, I wrote: > >> >> On Sun, 13 Apr 2014, David Miller wrote: >> >>> >>> But oddly in the NCR53CX docs: >>> >>> >>> http://www.ibiblio.org/pub/historic-linux/early-ports/Sparc/NCR/NCR53C9X.txt >>> >>> it speaks as if E

Re: [PATCH 3/3] NCR5380: Check for chip presence in NCR5380_init()

2016-10-31 Thread Ondrej Zary
On Monday 31 October 2016, Finn Thain wrote: > On Sun, 30 Oct 2016, Ondrej Zary wrote: > > Read back MODE_REG after writing it in NCR5380_init() to check if the > > chip is really there. > > > > This prevents hang when incorrect I/O address was specified by user. > > > > Signed-off-by: Ondrej Zary