Hello,
I was wondering about the call to schedule in function qla4_82xx_crb_win_lock
for driver
drivers/scsi/qla4xxx/ql4_nx.c. It is called in 2 functions [qla4_82xx_rd_32 and
qla4_82xx_wr_32] while holding a write_lock_irqsave. Normally we avoid using
sleeping
functions while holding a lock.
I
On Mon, 12 Sep 2016, I wrote:
>
> BTW, DTC3x80 support (NCR 53C406 chip I believe) should be easy to do in
> g_NCR5380, which already supports the DTC3181E card.
>
Sorry, I should have written DTC406 chip, which is "supposedly compatible
with the NCR 53C400" but is nothing like a NCR 53C406.
On Sun, 11 Sep 2016, Christoph Hellwig wrote:
> Hi all,
>
> you seem to the currently active NCR580 cabal. Which frontends to
> NCR5380 do you test at the moment, or could you test?
I test the dmx3191d and mac_scsi drivers.
>
> NCR5380-based ISA drivers make up a significant part of those d
On Sun, 11 Sep 2016, Joe Perches wrote:
> On Sun, 2016-09-11 at 15:05 +0200, Julia Lawall wrote:
> > Constify local structures.
>
> Thanks Julia.
>
> A few suggestions & questions:
>
> Perhaps the script should go into scripts/coccinelle/
> so that future cases could be caught by the robot
> and
On Sun, 2016-09-11 at 15:05 +0200, Julia Lawall wrote:
> Constify local structures.
Thanks Julia.
A few suggestions & questions:
Perhaps the script should go into scripts/coccinelle/
so that future cases could be caught by the robot
and commit message referenced by the patch instances.
Can you
Instead of defining a local version of it.
Signed-off-by: Christoph Hellwig
---
drivers/scsi/qla2xxx/qla_def.h | 10 --
drivers/scsi/qla2xxx/qla_isr.c | 2 +-
2 files changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_def.h b/drivers/scsi/qla2xxx/qla_def.h
i
These should go together with the rest of the T10 protection
information defintions.
Signed-off-by: Christoph Hellwig
---
drivers/scsi/scsi_debug.c | 39 +++
drivers/scsi/sd.c | 11 ++-
drivers/scsi/sd.h | 21 -
driv
Hi Martin,
this series ensures scsi_debug and qla2xxx use the common t10_pi_tuple
defintion, and then also moves the remaining T10 PI related defintions
to .
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordo
And remove the declaration of the latter in sd.h as scsi_debug was the
only user.
Signed-off-by: Christoph Hellwig
---
drivers/scsi/scsi_debug.c | 15 ---
drivers/scsi/sd.h | 9 -
2 files changed, 8 insertions(+), 16 deletions(-)
diff --git a/drivers/scsi/scsi_debug
On Sunday 11 September 2016 19:01:55 Christoph Hellwig wrote:
> On Wed, Mar 25, 2015 at 09:52:53PM +0100, Ondrej Zary wrote:
> > > - wd7000
> > > - aha1542
> > > - in2000
> > > - NCR53c406
> > > - sym53c416
> > > - u14-34f
> > > - ultrastor
> >
> > NCR53c406a and sym53c416 look very similar.
On Sunday 11 September 2016 19:12:49 Christoph Hellwig wrote:
> Hi all,
>
> you seem to the currently active NCR580 cabal. Which frontends to NCR5380
> do you test at the moment, or could you test?
>
> NCR5380-based ISA drivers make up a significant part of those drivers still
> using scsi_module.
On Sun, Sep 11, 2016 at 03:05:42PM +0200, Julia Lawall wrote:
> Constify local structures.
>
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
Just my two cents but:
1. You *can* use a static analysis too to find bugs or other issues.
2. However, you shoul
Hi all,
you seem to the currently active NCR580 cabal. Which frontends to NCR5380
do you test at the moment, or could you test?
NCR5380-based ISA drivers make up a significant part of those drivers still
using scsi_module.c after it's 15 year deprecation period, and I'd like to
either move them
On Wed, Mar 25, 2015 at 09:52:53PM +0100, Ondrej Zary wrote:
> > - wd7000
> > - aha1542
> > - in2000
> > - NCR53c406
> > - sym53c416
> > - u14-34f
> > - ultrastor
>
> NCR53c406a and sym53c416 look very similar. The register numbers and commands
> are almost the same so NCR53c406 support co
Simply the interrupt setup by using the new PCI layer helpers.
Signed-off-by: Christoph Hellwig
---
drivers/vfio/pci/vfio_pci_intrs.c | 45 +
drivers/vfio/pci/vfio_pci_private.h | 1 -
2 files changed, 10 insertions(+), 36 deletions(-)
diff --git a/drivers
Switch the ipr driver to use pci_alloc_irq_vectors. We need to two calls to
pci_alloc_irq_vectors as ipr only supports multiple MSI-X vectors, but not
multiple MSI vectors.
Otherwise this cleans up a lot of cruft and allows to use a common
request_irq loop for irq types, which happens to only ite
Simply the interrupt setup by using the new PCI layer helpers.
Despite using pci_enable_msi_range, this driver was only requesting a
single MSI vector anyway.
Signed-off-by: Christoph Hellwig
---
drivers/media/pci/cobalt/cobalt-driver.c | 8 ++--
drivers/media/pci/cobalt/cobalt-driver.h | 2
Simply the interrupt setup by using the new PCI layer helpers.
One odd thing about this driver is that it looks like it could request
multiple MSI vectors, but it will then only ever use a single one.
Signed-off-by: Christoph Hellwig
---
drivers/misc/genwqe/card_base.h | 1 -
drivers/misc/gen
Switch the skd driver to use pci_alloc_irq_vectors. We need to two calls to
pci_alloc_irq_vectors as skd only supports multiple MSI-X vectors, but not
multiple MSI vectors.
Otherwise this cleans up a lot of cruft and allows to a lot more common code.
Signed-off-by: Christoph Hellwig
---
driver
Switch the arcmsr driver to use pci_alloc_irq_vectors. We need to two
calls to pci_alloc_irq_vectors as arcmsr only supports multiple MSI-X
vectors, but not multiple MSI vectors.
Otherwise this cleans up a lot of cruft and allows to use a common
request_irq loop for irq types, which happens to on
Hi all,
this series switch the remaining users of pci_enable_msi_{exact_range}
(accounting for ahci and nvme being done through other channels) to
use the pci_alloc_irq_vectors helper instead and thus simplify the
interrupt code in those drivers a lot. I decided to post it as a
series to everyone
For structure types defined in the same file or local header files, find
top-level static structure declarations that have the following
properties:
1. Never reassigned.
2. Address never taken
3. Not passed to a top-level macro call
4. No pointer or array-typed field passed to a function or stored
Constify local structures.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
//
// The first rule ignores some cases that posed problems
@r disable optional_qualifier@
identifier s != {peri_clk_data,threshold_attr,tracer_flags,tracer};
identifier i != {s5k5baf
For structure types defined in the same file or local header files, find
top-level static structure declarations that have the following
properties:
1. Never reassigned.
2. Address never taken
3. Not passed to a top-level macro call
4. No pointer or array-typed field passed to a function or stored
https://bugzilla.kernel.org/show_bug.cgi?id=156411
Thorsten Leemhuis changed:
What|Removed |Added
CC||regressi...@leemhuis.info
--- Commen
https://bugzilla.kernel.org/show_bug.cgi?id=153171
Thorsten Leemhuis changed:
What|Removed |Added
CC||regressi...@leemhuis.info
--- Commen
26 matches
Mail list logo