[Bug 151661] Adaptec 3805 prints "AAC: Host adapter dead -1" every 10 seconds but works fine anyway

2016-08-14 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=151661 --- Comment #6 from David Gravereaux --- I'm having this same 10 second issue with a 3805 on Ubuntu 16.04 LTS with kernel 4.4.0-34-generic Some dmesg samplings: $ dmesg |tail --lines=50 |grep AAC [46793.664043] AAC: Host adapter dead -1 [46803.6

[PATCH] be2iscsi: Use a more current logging style

2016-08-14 Thread Joe Perches
shost_printk macros are converted to beiscsi_ for a more current logging style. Consolidate the masked tests into a beiscsi_printk macro and use that to call shost_printk. Convert the __beiscsi_log macros to use shost_print directly. Miscellanea: o Remove the file prefix identifier and use kba

Re: Time to make dynamically allocated devt the default for scsi disks?

2016-08-14 Thread Dan Williams
[ adding Bart back to the cc ] On Sun, Aug 14, 2016 at 11:08 AM, Dan Williams wrote: > On Sun, Aug 14, 2016 at 10:20 AM, James Bottomley > wrote: [..] > I like it. I still think the bdi registration code should be in > charge of taking the extra reference on the disk device's parent to > isolat

Re: Time to make dynamically allocated devt the default for scsi disks?

2016-08-14 Thread Dan Williams
On Sun, Aug 14, 2016 at 10:20 AM, James Bottomley wrote: > On Sat, 2016-08-13 at 11:27 -0700, Dan Williams wrote: >> On Sat, Aug 13, 2016 at 10:43 AM, James Bottomley >> wrote: >> > On Sat, 2016-08-13 at 09:29 -0700, Dan Williams wrote: >> > > On Sat, Aug 13, 2016 at 8:23 AM, James Bottomley >> >

Re: [PATCH 0/2] be2iscsi: Logging neatening

2016-08-14 Thread Joe Perches
On Sun, 2016-08-14 at 17:09 +, Bart Van Assche wrote: > My primary concern is how to enable and disable log messages from user  > space. Many drivers define their own logging macros and export a bitmask  > that allows to enable and disable logging messages per category. These  > bitmask contro

Re: Time to make dynamically allocated devt the default for scsi disks?

2016-08-14 Thread James Bottomley
On Sat, 2016-08-13 at 11:27 -0700, Dan Williams wrote: > On Sat, Aug 13, 2016 at 10:43 AM, James Bottomley > wrote: > > On Sat, 2016-08-13 at 09:29 -0700, Dan Williams wrote: > > > On Sat, Aug 13, 2016 at 8:23 AM, James Bottomley > > > wrote: > > > > It does? The race is the fact that the parent

Re: [PATCH 0/2] be2iscsi: Logging neatening

2016-08-14 Thread Bart Van Assche
On 08/14/16 09:24, Joe Perches wrote: > On Sun, 2016-08-14 at 14:34 +, Bart Van Assche wrote: >> As one can see in be_main.h the "level" argument of macro beiscsi_log() >> is ignored for log levels KERN_EMERG, KERN_ALERT, KERN_CRIT and >> KERN_ERR. So for these log levels beiscsi_log() is a syn

Re: [PATCH 0/2] be2iscsi: Logging neatening

2016-08-14 Thread Joe Perches
On Sun, 2016-08-14 at 14:34 +, Bart Van Assche wrote: > On 08/13/16 13:42, Joe Perches wrote: > > Joe Perches (2): > >   be2iscsi: Coalesce split strings and formats > >   be2iscsi: Use a standard logging style > Hello Joe, Hello Bart. > As one can see in be_main.h the "level" argument of mac

Re: [PATCH] scsi: introduce a quirk for false cache reporting

2016-08-14 Thread Oliver Neukum
On Wed, 2016-08-10 at 22:40 -0400, Martin K. Petersen wrote: > > "Oliver" == Oliver Neukum writes: > > Oliver> Some SATA to USB bridges fail to cooperate with some drives > Oliver> resulting in no cache being present being reported to the > Oliver> host. That causes the host to skip sending a

Re: [PATCH 0/2] be2iscsi: Logging neatening

2016-08-14 Thread Bart Van Assche
On 08/13/16 13:42, Joe Perches wrote: > Joe Perches (2): > be2iscsi: Coalesce split strings and formats > be2iscsi: Use a standard logging style Hello Joe, As one can see in be_main.h the "level" argument of macro beiscsi_log() is ignored for log levels KERN_EMERG, KERN_ALERT, KERN_CRIT and

Re: Regression - SATA disks behind USB ones on v4.8-rc1, breaking boot. [Re: Who reordered my disks (probably v4.8-rc1 problem)]

2016-08-14 Thread Tom Yan
On 14 August 2016 at 11:10, Pavel Machek wrote: > > It is the case in v4.6. We had change hda->sda for SATA drives long > time ago, it was stable since that. Not for me. It has been like forever (even if it wasn't the fact) that the disk order is not consistent among boots. Only that would logica

Re: Regression - SATA disks behind USB ones on v4.8-rc1, breaking boot. [Re: Who reordered my disks (probably v4.8-rc1 problem)]

2016-08-14 Thread Pavel Machek
Hi! On Sun 2016-08-14 18:17:39, Tom Yan wrote: > On 14 August 2016 at 18:07, Tom Yan wrote: > > On 14 August 2016 at 18:01, Pavel Machek wrote: > >> > >> Since SATA support was merged, certainly since v2.4, and from way > >> before /dev/disk/by-id existed. > > > > I have no idea how "SATA before

[PATCH] multipath-tools: document how to add devices that need special flags in the SCSI subsystem

2016-08-14 Thread Xose Vazquez Perez
Full flags list at include/scsi/scsi_devinfo.h Arrays controllers included currently: {"3PARdata", "VV", NULL, BLIST_REPORTLUN2}, {"DEC", "HSG80", NULL, BLIST_REPORTLUN2 | BLIST_NOSTARTONADD}, {"HP", "A6189A", NULL, BLIST_SPARSELUN | BLIST_LARGELUN}, {"COMPAQ", "MSA1000", NULL, BLIST_SPARSE

[PATCH v4 24/26] fnic: Use time64_t to represent trace timestamps

2016-08-14 Thread Deepa Dinamani
trace timestamps use struct timespec and CURRENT_TIME which are not y2038 safe. These timestamps are only part of the trace log on the machine and are not shared with the fnic. Replace then with y2038 safe struct timespec64 and ktime_get_real_ts64(), respectively. Signed-off-by: Deepa Dinamani Re

Re: Time to make dynamically allocated devt the default for scsi disks?

2016-08-14 Thread Dan Williams
On Sat, Aug 13, 2016 at 10:43 AM, James Bottomley wrote: > On Sat, 2016-08-13 at 09:29 -0700, Dan Williams wrote: >> On Sat, Aug 13, 2016 at 8:23 AM, James Bottomley >> wrote: >> > It does? The race is the fact that the parent can be removed >> > before the child meaning if the parent name is re

Re: [PATCH v2 2/2] sd: check BLK_DEF_MAX_SECTORS against max_dev_sectors

2016-08-14 Thread Tom Yan
On 14 August 2016 at 17:00, Tom Yan wrote: > > That won't really work. min_t() would, though the line is gonna be a > bit long; not sure if I can/should simply cast the type (unsigned int) > to BLK_DEF_MAX_SECTORS. And which braces are you referring to? > Oh you mean the else-clause braces. Hmm I

Re: Time to make dynamically allocated devt the default for scsi disks?

2016-08-14 Thread Dan Williams
On Sat, Aug 13, 2016 at 11:27 AM, Dan Williams wrote: > On Sat, Aug 13, 2016 at 10:43 AM, James Bottomley [..] >> Um, so this patch doesn't fix the problem. It merely makes the lifetime >> rules correct so the problem can then be fixed at the scsi level. > > You're right that this patch does not f

Re: [RFC] libata-scsi: make sure Maximum Write Same Length is not too large

2016-08-14 Thread Tom Yan
On 13 August 2016 at 04:56, Martin K. Petersen wrote: >> "Tom" == Tom Yan writes: > > Tom, > >>> put_unaligned_be64(65535 * ATA_MAX_TRIM_RNUM / (sector_size / 512), >>> &rbuf[36]); > > How many 8-byte ranges fit in a 4096-byte sector? The thing is, as of ACS-4, blocks that carry DSM/TRIM LB

Re: [PATCH v2 2/2] sd: check BLK_DEF_MAX_SECTORS against max_dev_sectors

2016-08-14 Thread Tom Yan
On 13 August 2016 at 05:37, Martin K. Petersen wrote: > > It would be pretty unusual for a device that is smart enough to report a > transfer length limit to be constrained to 1 MB and change. > Well, it is done pretty much for libata's SATL. Also since opt_xfer_blocks is checked against dev_max,

Re: [PATCH v6 0/2] Block layer support ZAC/ZBC commands

2016-08-14 Thread Shaun Tancheff
On Tue, Aug 9, 2016 at 1:47 AM, Hannes Reinecke wrote: > On 08/05/2016 10:35 PM, Shaun Tancheff wrote: >> On Tue, Aug 2, 2016 at 8:29 PM, Damien Le Moal >> wrote: >>> Hannes, Shaun, >>> >>> Let me add some more comments. >>> On Aug 2, 2016, at 23:35, Hannes Reinecke wrote: On 08/

Re: [RFC] sd: dynamically adjust SD_MAX_WS16_BLOCKS as per the actual logical block size

2016-08-14 Thread Tom Yan
On 13 August 2016 at 04:26, Martin K. Petersen wrote: >> "Tom" == Tom Yan writes: > > Tom, > > Tom> I don't really follow. What would this BLK_MAX_BIO_SECTORS be? It > Tom> doesn't appear to me that a static value is going to address the > Tom> problem I am addressing in this patch. > > 0x7ff

[PATCH 2/2] be2iscsi: Use a standard logging style

2016-08-14 Thread Joe Perches
Neaten all the beiscsi_log uses. Remove the leading 'B_%d" prefixes and make the format and arguments match without an implied __LINE__. Signed-off-by: Joe Perches --- drivers/scsi/be2iscsi/be_cmds.c | 54 +++ drivers/scsi/be2iscsi/be_iscsi.c | 100 ++-- drivers/scsi/be2iscsi/be_m

[PATCH 1/2] be2iscsi: Coalesce split strings and formats

2016-08-14 Thread Joe Perches
Split strings are not preferred for ease of grep. Signed-off-by: Joe Perches --- drivers/scsi/be2iscsi/be_cmds.c | 15 ++-- drivers/scsi/be2iscsi/be_iscsi.c | 33 +++ drivers/scsi/be2iscsi/be_main.c | 180 ++- drivers/scsi/be2iscsi/be_mgmt.c | 3 +-

[PATCH 0/2] be2iscsi: Logging neatening

2016-08-14 Thread Joe Perches
Joe Perches (2): be2iscsi: Coalesce split strings and formats be2iscsi: Use a standard logging style drivers/scsi/be2iscsi/be_cmds.c | 61 +++--- drivers/scsi/be2iscsi/be_iscsi.c | 115 ++- drivers/scsi/be2iscsi/be_main.c | 398 +-- drivers/scsi/

[GIT PULL] [PATCH v4 00/26] Delete CURRENT_TIME and CURRENT_TIME_SEC macros

2016-08-14 Thread Deepa Dinamani
The series is aimed at getting rid of CURRENT_TIME and CURRENT_TIME_SEC macros. The macros are not y2038 safe. There is no plan to transition them into being y2038 safe. ktime_get_* api's can be used in their place. And, these are y2038 safe. Thanks to Arnd Bergmann for all the guidance and discus