https://bugzilla.kernel.org/show_bug.cgi?id=151661
--- Comment #5 from Arkadiusz Miskiewicz ---
Had the same error after upgrading from 3.14.X kernel to 4.4.15
[ 59.713349] AAC: Host adapter dead -1
[ 69.713352] AAC: Host adapter dead -1
[ 79.713347] AAC: Host adapter dead -1
[ 89.713344
On Tue, Jul 19, 2016 at 8:25 AM, Hannes Reinecke wrote:
> Implement ZBC support functions to read in the zone information
> and setup the zone tree.
>
> Signed-off-by: Hannes Reinecke
> ---
> drivers/scsi/Kconfig | 8 +
> drivers/scsi/Makefile | 1 +
> drivers/scsi/sd.c | 129 ++
https://bugzilla.kernel.org/show_bug.cgi?id=151661
Chris "SKip" Mac-Stoker changed:
What|Removed |Added
CC||chris...@niksun.com
--- Commen
On 12 August 2016 at 10:01, Martin K. Petersen
wrote:
>
> Again, the point of max_hw_sectors and max_dev_sectors is to enforce the
> hard limits of controller and device respectively. Nothing else.
>
Sounds like libata-scsi is doing something wrong then. It should not
set max_hw_sectors to dev->m
On 12 August 2016 at 09:34, Martin K. Petersen
wrote:
>> "Tom," == tom ty89 writes:
>
> Tom,
>
> + put_unaligned_be64(65535 * ATA_MAX_TRIM_RNUM /
> + (sector_size / 512), &rbuf[36]);
>
> MAXIMUM WRITE SAME LENGTH is in units of the device's logic
On 12 August 2016 at 11:10, Martin K. Petersen
wrote:
>
> However, the CDB transfer length limit is really not the main issue
> here, it's bi_size that we need to enforce.
>
> After contemplating a bit I think it would be cleanest to add
> BLK_MAX_BIO_SECTORS and clamp on that in blk_queue_max_foo
> "Tom" == tom ty89 writes:
Tom,
Tom> However, SD_MAX_WS16_BLOCKS is used to check values that are, for
Tom> example, orignated from Maximum Write Same Length field on the
Tom> Block Limit VPD. Such field expresses the number of blocks in terms
Tom> of the actual logical sector size of the s
> "Tyrel" == Tyrel Datwyler writes:
Tyrel> On 08/03/2016 02:36 PM, Tyrel Datwyler wrote:
>> This patchset introduces optional FC-TAPE/FC Class 3 Error Recovery
>> to the ibmvfc client driver.
>>
>> Tyrel Datwyler (2): ibmvfc: Set READ FCP_XFER_READY DISABLED bit in
>> PRLI ibmvfc: add FC Cla
> "Shaun" == Shaun Tancheff writes:
Shaun,
Shaun> In sd_setup_discard_cmnd() there are a some discard methods that
Shaun> fall back to using WRITE_SAME. It appears that those paths using
Shaun> WRITE_SAME should also use the SD_WRITE_SAME_TIMEOUT instead of
Shaun> the default SD_TIMEOUT.
Th
> "Tom" == Tom Yan writes:
Hey Tom,
Tom> Shouldn't we use Maximum Transfer Length to derive max_sectors (and
Tom> get rid of the almost useless max_dev_sectors)?
MAXIMUM TRANSFER LENGTH could be gigabytes. Some disks report it as the
full capacity of the device.
Again, the point of max_hw_
> "Tom," == tom ty89 writes:
Tom,
+ put_unaligned_be64(65535 * ATA_MAX_TRIM_RNUM /
+ (sector_size / 512), &rbuf[36]);
MAXIMUM WRITE SAME LENGTH is in units of the device's logical block
size.
--
Martin K. Petersen Oracle Linux Engineerin
> -Original Message-
> From: Martin K. Petersen [mailto:martin.peter...@oracle.com]
> Sent: Wednesday, August 10, 2016 9:26 PM
> To: Don Brace
> Cc: Martin K. Petersen; j...@linux.vnet.ibm.com; Viswas G; Mahesh
> Rajashekhara; h...@infradead.org; Scott Teel; Kevin Barnett; Justin Lindley;
>
From: Tom Yan
WRITE SAME (16) command can technically handle up to 32-bit
number of blocks. However, since 32-bit is also the limitation of
the maximum number of bytes that can be represented in the block
layer, the current SD_MAX_WS16_BLOCKS was hence derived from the
technical limit devided by
On Fri, Jul 22, 2016 at 05:24:00PM -0700, James Smart wrote:
>
> This patchset adds NVME support to the lpfc FC driver. It reworks
> the core driver for both NVME and SCSI protocol support, then adds the
> nvme-over-fabrics host and target interfaces which connect to the
> NVME FC transport lowe
On Fri, Jul 22, 2016 at 05:23:59PM -0700, James Smart wrote:
>
> Add FC LLDD loopback driver to test FC host and target transport within
> nvme-fabrics
>
> To aid in the development and testing of the lower-level api of the FC
> transport, this loopback driver has been created to act as if it wer
> +config NVME_TARGET_FC
> + tristate "NVMe over Fabrics FC target driver"
> + select NVME_TARGET
this should be a depends, NVME_TARGET is a user visible option.
> + /* TODO: better to use dma_map_page() ?*/
> + iod->rspdma = dma_map_single(tgtport->dev, iod->rspbu
On 08/09/2016 01:08 PM, Bart Van Assche wrote:
> On 08/04/2016 02:32 PM, Tyrel Datwyler wrote:
>> Commit 655ee63cf371 added a "Completed" sense string with key 0xF to
>> snstext[], but failed to updated the upper bounds check of the sense key in
>> scsi_sense_key_string().
>>
>> Fixes: 655ee63cf371
The patch isn't about how the request from the block layer will be
processed (to form the SCSI commands).
What it addresses is blk_queue_max_write_same_sectors() and
blk_queue_max_discard_sectors() that are called in the SCSI disk
driver. You can see that they are called with an input of the Maxim
This looks mostly fine, a few nitpicks below:
> +config NVME_FC
> + tristate "NVM Express over Fabrics FC host driver"
> + depends on BLK_DEV_NVME
This should be
select NVME_CORE
instead. The existing RDMA and loop drivers also get this wrong,
but I'll sned a patch to fix it up
Looks fine,
Reviewed-by: Christoph Hellwig
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Looks fine,
Reviewed-by: Christoph Hellwig
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sat, Jul 23, 2016 at 08:52:18AM -0700, James Smart wrote:
>
> On 7/22/2016 6:32 PM, Bart Van Assche wrote:
> > On 07/22/16 17:23, James Smart wrote:
> > > +buf = kmalloc(len + 1, GFP_KERNEL);
> > > +if (!buf)
> > > +return -ENOMEM;
> > > +memcpy(buf, s->from, len);
> > > +
Looks fine,
Reviewed-by: Christoph Hellwig
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
This needs to cover the loop and PCI driver a swell.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 08/03/2016 02:36 PM, Tyrel Datwyler wrote:
> This patchset introduces optional FC-TAPE/FC Class 3 Error Recovery to the
> ibmvfc client driver.
>
> Tyrel Datwyler (2):
> ibmvfc: Set READ FCP_XFER_READY DISABLED bit in PRLI
> ibmvfc: add FC Class 3 Error Recovery support
>
> drivers/scsi/i
In sd_setup_discard_cmnd() there are a some discard
methods that fall back to using WRITE_SAME. It
appears that those paths using WRITE_SAME should
also use the SD_WRITE_SAME_TIMEOUT instead of the
default SD_TIMEOUT.
Signed-off-by: Shaun Tancheff
---
I don't have a use case that breaks the curre
ping?
On Tue, Aug 02, 2016 at 02:36:32PM +0200, Christoph Hellwig wrote:
> From: Hannes Reinecke
>
> If dm-mpath encounters an reservation conflict it should not fail the
> path (as communication with the target is not affected) but should
> rather retry on another path. However, in doing so we
Code cleanup for lpfc_sriov_nr_virtfn parameter
Signed-off-by: Dick Kennedy
Signed-off-by: James Smart
---
drivers/scsi/lpfc/lpfc_attr.c | 35 +++
1 file changed, 3 insertions(+), 32 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lp
Revise strings with full lpfc parameter name
Signed-off-by: Dick Kennedy
Signed-off-by: James Smart
---
drivers/scsi/lpfc/lpfc_attr.c | 23 ---
1 file changed, 12 insertions(+), 11 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c
inde
Code cleanup for lpfc_max_scsicmpl_time parameter
Signed-off-by: Dick Kennedy
Signed-off-by: James Smart
---
drivers/scsi/lpfc/lpfc_attr.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c
index 81b1faf..3051
Fix crash on adapter reinit
Had unset fields passed to pci_pool_destroy() on teardown.
Signed-off-by: Dick Kennedy
Signed-off-by: James Smart
---
drivers/scsi/lpfc/lpfc_mem.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_mem.c b/drivers/scsi/
Fix lost target in pt-to-pt connect
Change reject code to something that allows a retry
Signed-off-by: Dick Kennedy
Signed-off-by: James Smart
---
drivers/scsi/lpfc/lpfc_els.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/
Code clean up for lpfc_iocb_cnt parameter
Signed-off-by: Dick Kennedy
Signed-off-by: James Smart
---
drivers/scsi/lpfc/lpfc_attr.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c
index be81e61..e5092dc 100
Make lpfc_prot_mask and lpfc_prot_guard per hba parameters
Signed-off-by: Dick Kennedy
Signed-off-by: James Smart
---
drivers/scsi/lpfc/lpfc.h | 2 ++
drivers/scsi/lpfc/lpfc_attr.c | 23 ++-
drivers/scsi/lpfc/lpfc_crtn.h | 2 --
drivers/scsi/lpfc/lpfc_init.c | 28 +++
Code cleanup for lpfc_aer_support parameter
Signed-off-by: Dick Kennedy
Signed-off-by: James Smart
---
drivers/scsi/lpfc/lpfc_attr.c | 43 +++
1 file changed, 3 insertions(+), 40 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpf
Code cleanup for lpfc_enable_rrq parameter
Signed-off-by: Dick Kennedy
Signed-off-by: James Smart
---
drivers/scsi/lpfc/lpfc_attr.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c
index e5092dc..22a66c7 1
lpfc version change to 11.2.0.2
Note: expects to be on top of prior lpfc 11.2.0.0. rev and not on
top of lpfc rev 11.2.0.1 which has fc-nvme mods as well. The patches in
this set should apply to 11.2.0.1, excepting this version change.
For now, this patch based on contents in scsi-misc branch of
Code cleanup for lpfc_topology parameter
Signed-off-by: Dick Kennedy
Signed-off-by: James Smart
---
drivers/scsi/lpfc/lpfc_attr.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c
index ae76aaa..81b1faf 1006
Double WQ element count to keep iops up
On embedded io queues, use the default element count, which is twice the
size of the default large WQE element count.
Signed-off-by: Dick Kennedy
Signed-off-by: James Smart
---
drivers/scsi/lpfc/lpfc_init.c | 2 +-
1 file changed, 1 insertion(+), 1 dele
This patch set updates the lpfc driver to revision 11.2.0.00
The patches were cut against scsi-misc
James Smart (14):
Double WQ element count to keep iops up
Fix sg_reset on SCSI device causing kernel crash
Set driver environment data on adapter
Make lpfc_prot_mask and lpfc_prot_guard pe
Set driver environment data on adapter
Signed-off-by: Dick Kennedy
Signed-off-by: James Smart
---
drivers/scsi/lpfc/lpfc_hw4.h | 12
drivers/scsi/lpfc/lpfc_sli.c | 29 +
2 files changed, 41 insertions(+)
diff --git a/drivers/scsi/lpfc/lpfc_hw4.h b/driv
Fix sg_reset on SCSI device causing kernel crash
Driver could reference stale node pointers in task mgmt call.
Changed to use resetting cmd and look up node pointer in task mgmt
function.
Signed-off-by: Dick Kennedy
Signed-off-by: James Smart
---
drivers/scsi/lpfc/lpfc_scsi.c | 18 +++
On Thu, 2016-08-11 at 18:43 +0200, Johannes Thumshirn wrote:
> On Thu, Aug 11, 2016 at 08:09:35AM -0700, James Bottomley wrote:
> > On Thu, 2016-08-11 at 09:59 +0200, Johannes Thumshirn wrote:
> > > Since commit 3f8d6f2a0 ('ses: fix discovery of SATA devices in
> > > SAS
> > > enclosures') ses_matc
On Thu, Aug 11, 2016 at 3:26 AM, wrote:
> From: Tom Yan
>
> Currently we advertise Maximum Write Same Length based on the
> maximum number of sectors that one-block TRIM payload can cover.
> The field are used to derived discard_max_bytes and
> write_same_max_bytes limits in the block layer, whi
- Original Message -
> From: "Laurence Oberman"
> To: "Bart Van Assche"
> Cc: dm-de...@redhat.com, linux-scsi@vger.kernel.org, "Mike Snitzer"
> , "Johannes Thumshirn"
>
> Sent: Wednesday, August 10, 2016 5:38:16 PM
> Subject: Re: [dm-devel] dm-mq and end_clone_request()
>
>
>
> ---
On Thu, Aug 11, 2016 at 08:09:35AM -0700, James Bottomley wrote:
> On Thu, 2016-08-11 at 09:59 +0200, Johannes Thumshirn wrote:
> > Since commit 3f8d6f2a0 ('ses: fix discovery of SATA devices in SAS
> > enclosures') ses_match_to_enclosure() is calling sas_get_address(),
> > which is coming from com
https://bugzilla.kernel.org/show_bug.cgi?id=151991
Bug ID: 151991
Summary: HP Help Desk Number 1 (888) 990-8801
Product: SCSI Drivers
Version: 2.5
Kernel Version: le
Hardware: All
OS: Linux
Tree: Mainline
https://bugzilla.kernel.org/show_bug.cgi?id=151661
--- Comment #3 from Piotr Szymaniak ---
Created attachment 228391
--> https://bugzilla.kernel.org/attachment.cgi?id=228391&action=edit
dmesg with mentioned Alex patch
--
You are receiving this mail because:
You are watching the assignee of th
https://bugzilla.kernel.org/show_bug.cgi?id=151661
--- Comment #2 from Piotr Szymaniak ---
Created attachment 228381
--> https://bugzilla.kernel.org/attachment.cgi?id=228381&action=edit
dmesg vanilla 4.7
--
You are receiving this mail because:
You are watching the assignee of the bug.
--
To u
https://bugzilla.kernel.org/show_bug.cgi?id=151661
--- Comment #1 from Piotr Szymaniak ---
(I'm a kernel bugzilla newbie and as newbie I'm not sure how much attention
gets kernel bugzilla and do this gets along with mailing lists and the other
way around. So I'm posting here my answers to David C
On Thu, 2016-08-11 at 09:59 +0200, Johannes Thumshirn wrote:
> Since commit 3f8d6f2a0 ('ses: fix discovery of SATA devices in SAS
> enclosures') ses_match_to_enclosure() is calling sas_get_address(),
> which is coming from commit bcf508c13385 ('scsi_transport_sas: add
> function to get SAS endpoint
On 08/10/2016 06:30 PM, Steffen Maier wrote:
> This was lost with commit 2c55b750a884b86dea8b4cc5f15e1484cc47a25c
> ("[SCSI] zfcp: Redesign of the debug tracing for SAN records.")
> but is necessary for problem determination, e.g. to see the
> currently active zone set during automatic port scan.
>
On 08/10/2016 06:30 PM, Steffen Maier wrote:
> commit 2c55b750a884b86dea8b4cc5f15e1484cc47a25c
> ("[SCSI] zfcp: Redesign of the debug tracing for SAN records.")
> started to add FC_CT_HDR_LEN which made zfcp dump random data
> out of bounds for RSPN GS responses because u.rspn.rsp
> is the largest
On 08/10/2016 06:30 PM, Steffen Maier wrote:
> With commit 2c55b750a884b86dea8b4cc5f15e1484cc47a25c
> ("[SCSI] zfcp: Redesign of the debug tracing for SAN records.")
> we lost the N_Port-ID where an ELS response comes from.
> With commit 7c7dc196814b9e1d5cc254dc579a5fa78ae524f7
> ("[SCSI] zfcp: Sim
On 08/10/2016 06:30 PM, Steffen Maier wrote:
> This information was lost with
> commit a54ca0f62f953898b05549391ac2a8a4dad6482b
> ("[SCSI] zfcp: Redesign of the debug tracing for HBA records.")
> but is required to debug e.g. invalid handle situations.
>
> Signed-off-by: Steffen Maier
> Fixes: a5
On 08/10/2016 06:30 PM, Steffen Maier wrote:
> Since commit a54ca0f62f953898b05549391ac2a8a4dad6482b
> ("[SCSI] zfcp: Redesign of the debug tracing for HBA records.")
> HBA records no longer contain WWPN, D_ID, or LUN
> to reduce duplicate information which is already in REC records.
> In contrast
On 08/10/2016 06:30 PM, Steffen Maier wrote:
> bring back
> commit d21e9daa63e009ce5b87bbcaa6d11ce48e07bbbe
> ("[SCSI] zfcp: Dont use 0 to indicate invalid LUN in rec trace")
> which was lost with
> commit ae0904f60fab7cb20c48d32eefdd735e478b91fb
> ("[SCSI] zfcp: Redesign of the debug tracing for r
On 08/10/2016 06:30 PM, Steffen Maier wrote:
> While retaining the actual filtering according to trace level,
> the following commits started to write such filtered records
> with a hardcoded record level of 1 instead of the actual record level:
> commit 250a1352b95e1db3216e5c5d4f4365bea5122f4a
> (
On 08/10/2016 06:30 PM, Steffen Maier wrote:
> On a successful end of reopen port forced,
> zfcp_erp_strategy_followup_success() re-uses the port erp_action
> and the subsequent zfcp_erp_action_cleanup() now
> sees ZFCP_ERP_SUCCEEDED with
> erp_action->action==ZFCP_ERP_ACTION_REOPEN_PORT
> instead
On 08/10/2016 06:30 PM, Steffen Maier wrote:
> In the hardware data router case, introduced with kernel 3.2
> commit 86a9668a8d29 ("[SCSI] zfcp: support for hardware data router")
> the ELS/GS request&response length needs to be initialized
> as in the chained SBAL case.
>
> Otherwise, the FCP cha
On 08/10/2016 06:30 PM, Steffen Maier wrote:
> For an NPIV-enabled FCP device, zfcp can erroneously show
> "NPort (fabric via point-to-point)" instead of "NPIV VPORT"
> for the port_type sysfs attribute of the corresponding
> fc_host.
> s390-tools that can be affected are dbginfo.sh and ziomon.
>
Hi,
Please consider this patch as Acked-by: Chaitra P B
Thanks,
Chaitra
-Original Message-
From: Greg Edwards [mailto:gedwa...@fireweed.org]
Sent: Saturday, July 30, 2016 9:36 PM
To: Sathya Prakash; Chaitra P B; Suganath Prabu Subramani; James E.J.
Bottomley; Martin K. Petersen
Cc: mpt
On 11 August 2016 at 11:37, Martin K. Petersen
wrote:
>> "Tom" == Tom Yan writes:
>
> I don't agree with conflating the optimal transfer size and the maximum
> supported ditto. Submitting the largest possible I/O to a device does
> not guarantee that you get the best overall performance.
>
>
From: Tom Yan
Currently we advertise Maximum Write Same Length based on the
maximum number of sectors that one-block TRIM payload can cover.
The field are used to derived discard_max_bytes and
write_same_max_bytes limits in the block layer, which currently can
at max be 0x (32-bit).
Howe
Since commit 3f8d6f2a0 ('ses: fix discovery of SATA devices in SAS
enclosures') ses_match_to_enclosure() is calling sas_get_address(),
which is coming from commit bcf508c13385 ('scsi_transport_sas: add
function to get SAS endpoint address'). sas_get_address() itself calls
sas_sdev_to_rdev() which B
65 matches
Mail list logo
