Re: [dm-devel] dm-mq and end_clone_request()

2016-07-28 Thread Hannes Reinecke
On 07/28/2016 05:40 PM, Mike Snitzer wrote: > On Thu, Jul 28 2016 at 11:23am -0400, > Bart Van Assche wrote: > >> On 07/28/2016 06:33 AM, Mike Snitzer wrote: [ .. ] > > Reality is I just need a testbed to reproduce. This back and forth > isn't really helping us converge on _why_ must_push_back(

[PATCH 1/3] mpt3sas: Eliminate conditional locking in mpt3sas_scsih_issue_tm()

2016-07-28 Thread Calvin Owens
This flag that conditionally acquires the mutex is confusing and prone to bugginess: refactor it into two separate function calls, and make the unlocked one complain if it's called outside the mutex. Signed-off-by: Calvin Owens --- drivers/scsi/mpt3sas/mpt3sas_base.h | 16 +++-- drivers/scs

[PATCH 3/3] mpt3sas: Fix warnings exposed by W=1

2016-07-28 Thread Calvin Owens
Trivial non-functional changes for a couple annoying things: 1) Functions local to files are not declared static, which is frustrating when reading the code because it's non-obvious at first glance what's actually called from other files. 2) Set-but-unused variables abound, presumably to

[PATCH 2/3] mpt3sas: Eliminate dead sleep_flag code

2016-07-28 Thread Calvin Owens
With the exception of a single call to wait_for_doorbell_int(), all this conditional sleeping code is dead. So delete it. Signed-off-by: Calvin Owens --- drivers/scsi/mpt3sas/mpt3sas_base.c | 241 +-- drivers/scsi/mpt3sas/mpt3sas_base.h | 6 +- drivers/scs

Re: [PATCH] ses: Fix racy cleanup of /sys in remove_dev()

2016-07-28 Thread Martin K. Petersen
> "Calvin" == Calvin Owens writes: >> Any thoughts? Squinting at this more it still seems racy, but a >> narrow race is surely better than just blatantly freeing everything >> while the file is still exposed in /sys? Is there a better way you'd >> prefer I accomplish this? >> >> (I have boxe

Re: [PATCH] lpfc: Fix possible NULL pointer dereference

2016-07-28 Thread Martin K. Petersen
> "James" == James Smart writes: James> This patch is good. Johannes: You were going to tweak a few things and resubmit. Please do. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to major

[PATCH 3/3] nvme-fabrics: Add host_traddr options field to host infrastructure

2016-07-28 Thread James Smart
Add the host_traddr field to allow specification of the host-port connection info for the transport. Will be used by FC transport. Signed-off-by: James Smart --- drivers/nvme/host/fabrics.c | 13 + drivers/nvme/host/fabrics.h | 4 2 files changed, 17 insertions(+) diff --git

[PATCH 2/3] nvme-fabrics: revise host transport option descriptions

2016-07-28 Thread James Smart
Revise some of the comments so not so ethernet-network centric Signed-off-by: James Smart --- drivers/nvme/host/fabrics.h | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/nvme/host/fabrics.h b/drivers/nvme/host/fabrics.h index 89df52c..2755efd 100644 --- a/driv

[PATCH 0/3] nvme-fabrics: Patch host code in prep for FC transport support

2016-07-28 Thread James Smart
Patch nvme-fabrics host code in prep for FC transport support: - Add the host_traddr field to allow specification of the host-port connection info for the transport. Will be used by FC transport. - Revise nvmf_get_address() string to account for not all options being present. - Revise some of

[PATCH 1/3] nvme-fabrics: rework nvmf_get_address() for variable options

2016-07-28 Thread James Smart
Revise nvmf_get_address() string to account for not all options being present. Signed-off-by: James Smart --- drivers/nvme/host/fabrics.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/nvme/host/fabrics.c b/drivers/nvme/host/fabrics.c index dc99676..28

Diagnosing interrupt problem seen with PERC H710P Mini firmware 21.3.1-0004 or 21.3.2-0005

2016-07-28 Thread Stig
Hello, I hope it is OK to post this. I have been investigating a problem seen on Dell R720(xd) hosts with PERC H710P Mini firmware 21.3.1-0004 or 21.3.2-0005, running RHEL 6.6 and 6.7. Interrupts are only seen on the first interrupt. The details are in https://bugzilla.redhat.com/show_bug.cgi?

Re: dm-mq and end_clone_request()

2016-07-28 Thread Mike Snitzer
On Thu, Jul 28 2016 at 11:23am -0400, Bart Van Assche wrote: > On 07/28/2016 06:33 AM, Mike Snitzer wrote: > >On Wed, Jul 27 2016 at 7:05pm -0400, > >Bart Van Assche wrote: > >>Thanks again for having made this patch available. I will test it as > >>soon as I have the time. BTW, in the meantime

Re: dm-mq and end_clone_request()

2016-07-28 Thread Bart Van Assche
On 07/28/2016 06:33 AM, Mike Snitzer wrote: On Wed, Jul 27 2016 at 7:05pm -0400, Bart Van Assche wrote: Thanks again for having made this patch available. I will test it as soon as I have the time. BTW, in the meantime I ran a few tests with DM_MQ_DEFAULT=n since until now I ran all tests with

Re: [PATCH] lpfc: Fix possible NULL pointer dereference

2016-07-28 Thread James Smart
This patch is good. Thanks -- james Signed-off-by: James Smart On 6/15/2016 6:00 AM, Johannes Thumshirn wrote: Check for the existance of pciob->vport before accessing it. Signed-off-by: Johannes Thumshirn --- drivers/scsi/lpfc/lpfc_sli.c | 13 - 1 file changed, 4 insertion

Re: dm-mq and end_clone_request()

2016-07-28 Thread Mike Snitzer
On Wed, Jul 27 2016 at 7:05pm -0400, Bart Van Assche wrote: > On 07/27/2016 01:09 PM, Mike Snitzer wrote: > > In addition to the above patch, please apply this patch and retest your > >4.7 kernel: > > > >diff --git a/drivers/md/dm-mpath.c b/drivers/md/dm-mpath.c > >index 287caa7..16583c1 100644