Re: [PATCH] add u64 number parser

2016-07-22 Thread Bart Van Assche
On 07/22/16 17:23, James Smart wrote: + buf = kmalloc(len + 1, GFP_KERNEL); + if (!buf) + return -ENOMEM; + memcpy(buf, s->from, len); + buf[len] = '\0'; Hello James, Have you considered to combine the above kmalloc() and memcpy() calls into a single kasp

[PATCH 0/5] nvme-fabrics: add FC Transport support

2016-07-22 Thread James Smart
This patchset adds FC transport support to nvme fabrics. Adds both initiator and target. The transport utilizes a lower-level api with FC hbas to actually perform FC link traffic. The drivers are mostly ignorant of the actual NVME transport implementation, and provide hooks to send/receive FC-4

[PATCH 2/3] nvme-fabrics: Add nvme host FC transport support to lpfc driver

2016-07-22 Thread James Smart
This patch updates the lpfc driver such that it ties into the NVME FC transport to add host (initiator) support. It currently is an unoptimized NVME implementation. The patch: -Replaces stubs so that the local FC port is registered with the NVME FC transport as a "nvme local port" -Replaces stub

[PATCH 1/5] nvme-fabrics: Add FC transport FC-NVME definitions

2016-07-22 Thread James Smart
nvme-fabrics: Add FC transport FC-NVME definitions: - Formats for Cmd, Data, Rsp IUs - Formats FC-4 LS definitions Signed-off-by: James Smart --- include/linux/nvme-fc.h | 296 1 file changed, 296 insertions(+) create mode 100644 include/linux

[PATCH 4/5] nvme-fabrics: Add target FC transport support

2016-07-22 Thread James Smart
Add nvme-fabrics target FC transport support Implements the FC-NVME T11 definition of how nvme fabric capsules are performed on an FC fabric. Utilizes a lower-layer API to FC host adapters to send/receive FC-4 LS operations and perform the FCP transactions necessary to perform and FCP IO request

[PATCH 3/3] nvme-fabrics: Add nvme target FC transport support to lpfc driver

2016-07-22 Thread James Smart
This patch updates the lpfc driver such that it ties into the NVME FC transport to add target (nvme subsystem) support. It currently is an unoptimized NVME implementation. The patch: -Updates the async RX path of the adapter to support reception of NVME commands -Registers the local FC port with

[PATCH 0/3] nvme-fabrics: Add NVME FC Transport support to lpfc

2016-07-22 Thread James Smart
This patchset adds NVME support to the lpfc FC driver. It reworks the core driver for both NVME and SCSI protocol support, then adds the nvme-over-fabrics host and target interfaces which connect to the NVME FC transport lower-level api. Patches are cut against the linux-nvme for-4.8/drivers br

[PATCH 2/5] nvme-fabrics: Add FC transport LLDD api definitions

2016-07-22 Thread James Smart
nvme-fabrics: Add FC transport LLDD api definitions: Host: -LLDD registration with the host transport -registering host ports (local ports) and target ports seen on fabric (remote ports) -Data structures and call points for FC-4 LS's and FCP IO requests Target: -LLDD registration with the tar

[PATCH 3/5] nvme-fabrics: Add host FC transport support

2016-07-22 Thread James Smart
Add nvme-fabrics host FC transport support Implements the FC-NVME T11 definition of how nvme fabric capsules are performed on an FC fabric. Utilizes a lower-layer API to FC host adapters to send/receive FC-4 LS operations and FCP operations that comprise NVME over FC operation. The T11 definitio

[PATCH 5/5] nvme-fabrics: Add FC LLDD loopback driver to test FC host and target transport

2016-07-22 Thread James Smart
Add FC LLDD loopback driver to test FC host and target transport within nvme-fabrics To aid in the development and testing of the lower-level api of the FC transport, this loopback driver has been created to act as if it were a FC hba driver supporting both the host interfaces as well as the targ

[PATCH] nvme-fabrics: patch target code in prep for FC transport support

2016-07-22 Thread James Smart
Patch nvme-fabrics target code in prep for FC transport support: - Add FC transport type decoding - Add FC address family decoding Patch is cut against the linux-nvme for-4.8/drivers branch Note: this patch had been posted to the prior nvme fabrics repository but not merged before being brought

[PATCH] nvme-fabrics: Patch host code in prep for FC transport support

2016-07-22 Thread James Smart
Patch nvme-fabrics host code in prep for FC transport support: - Add the host_traddr field to allow specification of the host-port connection info for the transport. Will be used by FC transport. - Revise nvmf_get_address() string to account for not all options being present. - Revise some of

[PATCH] add u64 number parser

2016-07-22 Thread James Smart
add u64 number parser Will be used by the nvme-fabrics FC transport in parsing options Signed-off-by: James Smart --- include/linux/parser.h | 1 + lib/parser.c | 47 +++ 2 files changed, 48 insertions(+) diff --git a/include/linux/parser

[PATCH] nvme-fabrics: set sqe.command_id in core, not transports

2016-07-22 Thread James Smart
set sqe.command_id in core, not transports Patch is cut against the linux-nvme for-4.8/drivers branch Signed-off-by: James Smart --- drivers/nvme/host/core.c | 3 ++- drivers/nvme/host/rdma.c | 1 - 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/nvme/host/core.c b/drive

[PATCH v4 5/7] iscsi-target: replace iscsi_initiatorname_tolower() with strtolower()

2016-07-22 Thread Markus Mayer
After introducing generic strtolower(), iscsi_initiatorname_tolower() is no longer needed. Signed-off-by: Markus Mayer Acked-by: Nicholas Bellinger --- drivers/target/iscsi/iscsi_target_nego.c | 17 + 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/drivers/target/i

[PATCH v4 1/7] lib: string: add functions to case-convert strings

2016-07-22 Thread Markus Mayer
Add a collection of generic functions to convert strings to lowercase or uppercase. Changing the case of a string (with or without copying it first) seems to be a recurring requirement in the kernel that is currently being solved by several duplicated implementations doing the same thing. This cha

[PATCH v4 0/7] lib: string: add functions to case-convert strings

2016-07-22 Thread Markus Mayer
This series introduces a family of generic string case conversion functions. This kind of functionality is needed in several places in the kernel. Right now, everybody seems to be implementing their own copy of this functionality. Based on the discussion of the previous version of this series[1] a

Re: [PATCH 1/5] sd: configure ZBC devices

2016-07-22 Thread Ewan D. Milne
On Tue, 2016-07-19 at 15:25 +0200, Hannes Reinecke wrote: > For ZBC devices I/O must not cross zone boundaries, so setup > the 'chunk_sectors' block queue setting to the zone size. > This is only valid for REPORT ZONES SAME type 2 or 3; > for other types the zone sizes might be different > for indi

Re: [PATCH 2/6] block: update chunk_sectors in blk_stack_limits()

2016-07-22 Thread Martin K. Petersen
> "Hannes" == Hannes Reinecke writes: Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kerne

Re: [PATCH 4/6] block: Add 'zoned' sysfs queue attribute

2016-07-22 Thread Martin K. Petersen
> "Hannes" == Hannes Reinecke writes: Hannes> Add a sysfs queue attribute 'zoned' to display the zone layout Hannes> for zoned devices. Not quite one value per file :( -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scs

Re: [PATCH 1/6] blk-sysfs: Add 'chunk_sectors' to sysfs attributes

2016-07-22 Thread Martin K. Petersen
> "Hannes" == Hannes Reinecke writes: Hannes> The queue limits already have a 'chunk_sectors' setting, so we Hannes> should be presenting it via sysfs. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsu

Re: [PATCH 0/2] cxlflash: Regression patch and updating Maintainers list

2016-07-22 Thread Martin K. Petersen
> "Uma" == Uma Krishnan writes: Uma> First patch in this set fixes a regression that was casued by the Uma> Commit 704c4b0ddc03 ("cxlflash: Shutdown notify support for CXL Uma> Flash cards"), which is currently staged for 4.8 in next/master. Uma> Second patch updates the Maintainers list for

Re: [PATCH] lpfc: fix oops in lpfc_sli4_scmd_to_wqidx_distr() from lpfc_send_taskmgmt()

2016-07-22 Thread Martin K. Petersen
> "Mauricio" == Mauricio Faria de Oliveira > writes: Mauricio> The lpfc_sli4_scmd_to_wqidx_distr() function expects the Mauricio> scsi_cmnd 'lpfc_cmd->pCmd' not to be null, and point to the Mauricio> midlayer command. Applied to 4.8/scsi-queue. -- Martin K. Petersen Oracle Linux

[PATCH resend v3 3/5] libata-scsi: use u8 array to store mode page copy

2016-07-22 Thread tom . ty89
From: Tom Yan ata_mselect_*() would initialize a char array for storing a copy of the current mode page. However, char could be signed char. In that case, bytes larger than 127 would be converted to negative number. For example, 0xff from def_control_mpage[] would become -1. This prevented ata_m

Re: [PATCH resend v2 3/5] libata-scsi: use u8 array to store mode page copy

2016-07-22 Thread Tom Yan
Strange. I merely changed the two "char" to "u8". I wonder how the tab became spaces. Anyway, sorry about that, resending soon. On 22 July 2016 at 17:59, Sergei Shtylyov wrote: > Hello. > > > On 7/22/2016 2:29 AM, tom.t...@gmail.com wrote: > >> From: Tom Yan >> >> ata_mselect_*() would initializ

Re: [PATCH 2/2] MAINTAINERS: Update cxlflash maintainers

2016-07-22 Thread Matthew R. Ochs
> On Jul 21, 2016, at 3:44 PM, Uma Krishnan wrote: > > Adding myself as a cxlflash maintainer. > > Signed-off-by: Uma Krishnan Acked-by: Matthew R. Ochs -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordo

Re: [PATCH 1/2] cxlflash: Verify problem state area is mapped before notifying shutdown

2016-07-22 Thread Matthew R. Ochs
> On Jul 21, 2016, at 3:44 PM, Uma Krishnan wrote: > > If an EEH or some other hard error occurs while the > adapter instance was being initialized, on the subsequent > shutdown of the device, the system could crash with: > > [c00f1da03b60] c05eccfc pci_device_shutdown+0x6c/0x100 > [

Re: HDD Unrecovered readerror issue

2016-07-22 Thread James Bottomley
On Fri, 2016-07-22 at 09:51 -0400, Jeff Moyer wrote: > Dmitry Monakhov writes: > > > But once I rewrite this block, problem goes away. > > #xfs_io -c "pwrite -S 0x0 $((80069000/2))k 4k" -d /dev/sda > > > > Now I can read it w/o any errors and smartctl is happy > > #smartctl -t short /dev/sda >

[PATCH -next] ibmvscsis: Use list_move_tail instead of list_del/list_add_tail

2016-07-22 Thread Wei Yongjun
Using list_move_tail() instead of list_del() + list_add_tail(). Signed-off-by: Wei Yongjun --- drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c b/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c index

Re: HDD Unrecovered readerror issue

2016-07-22 Thread Jeff Moyer
Dmitry Monakhov writes: > But once I rewrite this block, problem goes away. > #xfs_io -c "pwrite -S 0x0 $((80069000/2))k 4k" -d /dev/sda > > Now I can read it w/o any errors and smartctl is happy > #smartctl -t short /dev/sda > #smartctl -l selftest /dev/sda > Num Test_DescriptionStatus

[Bug 139951] New: GORILLLLA@ZOH00 1.8 88.633. 55.26+++ ZOHO tech support TOLLFREE number. ZOHO TECH SUPPORT PHONRE NUMBER, ZOHO TELEPHONE NUMBER

2016-07-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=139951 Bug ID: 139951 Summary: GORIA@ZOH00 1.8 88.633. 55.26+++ ZOHO tech support TOLLFREE number. ZOHO TECH SUPPORT PHONRE NUMBER, ZOHO TELEPHONE NUMBER Product: SCSI Drivers

Re: [PATCH resend v2 3/5] libata-scsi: use u8 array to store mode page copy

2016-07-22 Thread Sergei Shtylyov
Hello. On 7/22/2016 2:29 AM, tom.t...@gmail.com wrote: From: Tom Yan ata_mselect_*() would initialize a char array for storing a copy of the current mode page. However, char could be signed char. In that case, bytes larger than 127 would be converted to negative number. For example, 0xff fro

Re: [PATCH] lpfc: fix oops in lpfc_sli4_scmd_to_wqidx_distr() from lpfc_send_taskmgmt()

2016-07-22 Thread Johannes Thumshirn
On Tue, Jun 07, 2016 at 08:13:08PM -0300, Mauricio Faria de Oliveira wrote: > The lpfc_sli4_scmd_to_wqidx_distr() function expects the scsi_cmnd > 'lpfc_cmd->pCmd' not to be null, and point to the midlayer command. > > That's not true in the .eh_(device|target|bus)_reset_handler path, > because lp