Re: [RFC] libata-scsi: introducing SANITIZE translation

2016-07-08 Thread James Bottomley
On Fri, 2016-07-08 at 19:38 +, Tom Yan wrote: > On 8 July 2016 at 17:29, James Bottomley > wrote: > > Or we could simply patch sg_sanitze to issue the ATA_16 pass > > through when it sees a sata device ... > > > > Ugh that sounds ugly to me. Anyway that's off-topic. Not really. The point

[PATCH v3 5/7] iscsi-target: replace iscsi_initiatorname_tolower() with strtolower()

2016-07-08 Thread Markus Mayer
After introducing generic strtolower(), iscsi_initiatorname_tolower() is no longer needed. Signed-off-by: Markus Mayer --- drivers/target/iscsi/iscsi_target_nego.c | 17 + 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/drivers/target/iscsi/iscsi_target_nego.c b/dr

[PATCH v3 1/7] lib: string: add functions to case-convert strings

2016-07-08 Thread Markus Mayer
Add a collection of generic functions to convert strings to lowercase or uppercase. Changing the case of a string (with or without copying it first) seems to be a recurring requirement in the kernel that is currently being solved by several duplicated implementations doing the same thing. This cha

[PATCH v3 0/7] lib: string: add functions to case-convert strings

2016-07-08 Thread Markus Mayer
This series introduces a family of generic string case conversion functions. This kind of functionality is needed in several places in the kernel. Right now, everybody seems to be implementing their own copy of this functionality. Based on the discussion of the previous version of this series[1] a

[GIT PULL] SCSI fixes for 4.7-rc6

2016-07-08 Thread James Bottomley
Three fixes. One is the qla24xx MSI regression, one is a theoretical problem over blacklist matching, which would bite USB badly if it ever triggered and one is a system hang with a particular type of IPR device. The patch is available here: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scs

Re: [RFC] libata-scsi: introducing SANITIZE translation

2016-07-08 Thread Tom Yan
On 8 July 2016 at 17:29, James Bottomley wrote: > > OK, since you ignore the argument about maintenance: safety for us > means that it doesn't bitrot as an almost never used addition. The > reason our SATL should only support the commands Linux uses is > precisely because if it's used often we ge

Re: [PATCH] qla2xxx: Fix NULL pointer deref in QLA interrupt

2016-07-08 Thread Himanshu Madhani
On 7/8/16, 12:27 AM, "Thorsten Leemhuis" wrote: >Bruno Prémont wrote on 30.06.2016 17:00: >> In qla24xx_process_response_queue() rsp->msix->cpuid may trigger NULL >> pointer dereference when rsp->msix is NULL: >> […] >> The affected code was introduced by commit >> cdb898c52d1dfad4b4800b83a58b3

RE: [PATCH v3 13/13] cxgbit: add files for cxgbit.ko

2016-07-08 Thread Steve Wise
> > > In first series libcxgb.ko will have common > > > iSCSI DDP Page Pod Manager that will be shared > > > by three Chelsio iSCSI drivers > > > cxgb3i, cxgb4i, cxgbit. > > > > cool > > > > > In subsequent series I will add common connection > > > management and other hardware specific common code

Re: [PATCH v2 1/7] lib: string: add functions to case-convert strings

2016-07-08 Thread Markus Mayer
On 7 July 2016 at 17:19, Rasmus Villemoes wrote: > On Tue, Jul 05 2016, Markus Mayer wrote: > >> +/** >> + * strncpytoupper - Copy a length-limited string and convert to uppercase. >> + * @dst: The buffer to store the result. >> + * @src: The string to convert to uppercase. >> + * @len: Maximum s

Re: [PATCH v3 13/13] cxgbit: add files for cxgbit.ko

2016-07-08 Thread Varun Prakash
On Thu, Jul 07, 2016 at 10:54:20AM +0300, Or Gerlitz wrote: > On Wed, Jul 6, 2016 at 8:17 PM, Varun Prakash wrote: > > On Wed, Jul 06, 2016 at 12:24:43AM +0300, Or Gerlitz wrote: > >> On Thu, May 26, 2016 at 9:58 PM, Varun Prakash wrote: > >> > >> > Hi Or, Nicholas and Steve > >> > Thank you for

[net-next 6/6] cxgb3i,cxgb4i: fix symbol not declared sparse warning

2016-07-08 Thread Varun Prakash
Fix following sparse warnings warning: symbol 'cxgb3i_ofld_init' was not declared. Should it be static? warning: symbol 'cxgb4i_cplhandlers' was not declared. Should it be static? warning: symbol 'cxgb4i_ofld_init' was not declared. Should it be static? Signed-off-by: Varun Prakash --- drivers/s

[net-next 2/6] cxgb3i,cxgb4i,libcxgbi: remove iSCSI DDP support

2016-07-08 Thread Varun Prakash
Remove old ddp code from cxgb3i,cxgb4i,libcxgbi. Next two commits adds DDP support using common iSCSI DDP Page Pod Manager. Signed-off-by: Varun Prakash --- drivers/scsi/cxgbi/cxgb3i/cxgb3i.c | 128 drivers/scsi/cxgbi/cxgb4i/cxgb4i.c | 142 - drivers/scsi/cxgbi/libcxgbi.c

[net-next 5/6] libcxgb: export ppm release and tagmask set api

2016-07-08 Thread Varun Prakash
Export cxgbi_ppm_release() to release ppod manager and cxgbi_tagmask_set() to set tag mask, they are used by cxgb3i, cxgb4i and cxgbit. Signed-off-by: Varun Prakash --- drivers/net/ethernet/chelsio/libcxgb/libcxgb_ppm.c | 2 ++ drivers/scsi/cxgbi/cxgb3i/cxgb3i.c | 1 + drivers/sc

[net-next 4/6] cxgb3i: add iSCSI DDP support

2016-07-08 Thread Varun Prakash
Add iSCSI DDP support in cxgb3i driver using common iSCSI DDP Page Pod Manager. Signed-off-by: Varun Prakash --- drivers/scsi/cxgbi/cxgb3i/cxgb3i.c | 119 - 1 file changed, 118 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/cxgbi/cxgb3i/cxgb3i.c b/dr

[net-next 3/6] cxgb4i,libcxgbi: add iSCSI DDP support

2016-07-08 Thread Varun Prakash
Add iSCSI DDP support in cxgb4i driver using common iSCSI DDP Page Pod Manager. Signed-off-by: Varun Prakash --- drivers/scsi/cxgbi/Makefile| 2 + drivers/scsi/cxgbi/cxgb3i/Kbuild | 1 + drivers/scsi/cxgbi/cxgb3i/Kconfig | 1 + drivers/scsi/cxgbi/cxgb4i/Kbuild | 1 + drivers

[net-next 1/6] libcxgb: add library module for Chelsio drivers

2016-07-08 Thread Varun Prakash
Add common library module(libcxgb.ko) for Chelsio drivers to remove duplicate code. Code for iSCSI DDP Page Pod Manager is moved from cxgb4.ko to libcxgb.ko. Earlier only cxgbit.ko was using this code, now cxgb3i and cxgb4i will also use common Page Pod manager code. In future this module will ha

[net-next 0/6] common library for Chelsio drivers

2016-07-08 Thread Varun Prakash
Hi, This patch series adds common library module(libcxgb.ko) for Chelsio drivers to remove duplicate code. This series moves common iSCSI DDP Page Pod manager code from cxgb4.ko to libcxgb.ko, earlier this code was used by only cxgbit.ko now it is used by three Chelsio iSCSI drivers cxgb3i, cxgb

Re: [RFC] libata-scsi: introducing SANITIZE translation

2016-07-08 Thread James Bottomley
On Sat, 2016-07-09 at 00:20 +0800, Tom Yan wrote: > To be honest, that sounds like FUD to me. If argument is to be in acronyms, it's KISS. > The exact reason why this can "safely" be introduced to the SATL is > that, it is a "one-shot" command that would only be triggered by the > user through a

Re: [RFC] libata-scsi: introducing SANITIZE translation

2016-07-08 Thread Tom Yan
To be honest, that sounds like FUD to me. The exact reason why this can "safely" be introduced to the SATL is that, it is a "one-shot" command that would only be triggered by the user through a user space utility. It's nothing like TRIM that would be triggered by the filesystem layer or so "from t

Re: [PATCH 2/2] dm: call PR reserve/unreserve on each underlying device

2016-07-08 Thread Mike Christie
On 07/08/2016 07:23 AM, Christoph Hellwig wrote: > So far we tried to rely on the SCSI 'all target ports' bit to register > all path, but for many setups this didn't work properly as the different > path aren seen as separate initiators to the target instead of multiple > ports of the same initiato

Re: [PATCH 1/2] sd: don't use the ALL_TG_PT bit for reservations

2016-07-08 Thread Mike Christie
On 07/08/2016 07:23 AM, Christoph Hellwig wrote: > These only work if the we use the same initiator ID for all path, > which might not be true if we use different protocols, or even just > different HBAs. > > Instead dm-mpath will grow support to register all path manually > later in this series.

Re: [PATCH] megaraid_sas: Do not fire MR_DCMD_PD_LIST_QUERY to controllers which do not support it

2016-07-08 Thread Tomas Henzl
On 8.7.2016 12:30, Sumit Saxena wrote: > There was an issue reported by Lucz Geza on Dell Perc 6i. As per issue > reported, > megaraid_sas driver goes into an infinite error reporting loop as soon as > there is a change > in the status of one of the arrays (degrade, resync online etc …). > Below

[PATCH 1/2] sd: don't use the ALL_TG_PT bit for reservations

2016-07-08 Thread Christoph Hellwig
These only work if the we use the same initiator ID for all path, which might not be true if we use different protocols, or even just different HBAs. Instead dm-mpath will grow support to register all path manually later in this series. Signed-off-by: Christoph Hellwig --- drivers/scsi/sd.c | 3

PR API fixes for multipathing

2016-07-08 Thread Christoph Hellwig
I was a bit overeager to thing ALL_TG_PT would solve all our multipathing woes in respect to persistent reservation. Turns out that there are lots of possible setups where it doesn't work, and we'll have to ask device mapper to register all underlying devices instead. -- To unsubscribe from this

[PATCH 2/2] dm: call PR reserve/unreserve on each underlying device

2016-07-08 Thread Christoph Hellwig
So far we tried to rely on the SCSI 'all target ports' bit to register all path, but for many setups this didn't work properly as the different path aren seen as separate initiators to the target instead of multiple ports of the same initiator. Because of that we'll stop setting the 'all target po

[PATCH] megaraid_sas: Do not fire MR_DCMD_PD_LIST_QUERY to controllers which do not support it

2016-07-08 Thread Sumit Saxena
There was an issue reported by Lucz Geza on Dell Perc 6i. As per issue reported, megaraid_sas driver goes into an infinite error reporting loop as soon as there is a change in the status of one of the arrays (degrade, resync online etc …). Below are the error logs reported continuously- Jun 25 0

RE: [PATCH] Do not fire MR_DCMD_PD_LIST_QUERY to controllers which do not support it

2016-07-08 Thread Sumit Saxena
Please ignore this patch. I missed to add megaraid_sas in subject line. I realized after sending. Will be resending with proper subject. Sorry for spamming. > -Original Message- > From: Sumit Saxena [mailto:sumit.sax...@broadcom.com] > Sent: Friday, July 08, 2016 3:51 PM > To: james.bottom

[PATCH] Do not fire MR_DCMD_PD_LIST_QUERY to controllers which do not support it

2016-07-08 Thread Sumit Saxena
There was an issue reported by Lucz Geza on Dell Perc 6i. As per issue reported, driver goes into an infinite error reporting loop as soon as there is a change in the status of one of the arrays (degrade, resync online etc …). Below are the error logs reported continuously- Jun 25 08:49:30 ns8 ke

Re: Double-Fetch bug in Linux-4.5/drivers/scsi/aacraid/commctrl.c

2016-07-08 Thread Pengfei Wang
Dear David, Thank you for the quick response, and I think the safest way is check for equal, not only check for not larger than the first checked value, although I’m not sure whether anything wrong would happen if it is smaller. Please let me know if a patch is applied. Thanks! Bests Pengfei >

[Bug 121531] Adaptec 7805H SAS HBA (pm80xx): hangs when writing >80MB at once

2016-07-08 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=121531 --- Comment #15 from Jack Wang --- Hi Viswas, Thanks for update. Good to know MicroSemi is still working on it! Could you update the Maintainer file about your guys working email address? Regards, Jack 2016-07-08 6:47 GMT+02:00 Viswas G : > P

Re: [Bug 121531] Adaptec 7805H SAS HBA (pm80xx): hangs when writing >80MB at once

2016-07-08 Thread Jack Wang
Hi Viswas, Thanks for update. Good to know MicroSemi is still working on it! Could you update the Maintainer file about your guys working email address? Regards, Jack 2016-07-08 6:47 GMT+02:00 Viswas G : > Patch set for pm80xx is pending for the last 3 quarters. > We will submit those soon with

Re: [PATCH] qla2xxx: Fix NULL pointer deref in QLA interrupt

2016-07-08 Thread Thorsten Leemhuis
Bruno Prémont wrote on 30.06.2016 17:00: > In qla24xx_process_response_queue() rsp->msix->cpuid may trigger NULL > pointer dereference when rsp->msix is NULL: > […] > The affected code was introduced by commit > cdb898c52d1dfad4b4800b83a58b3fe5d352edde > (qla2xxx: Add irq affinity notification). >

Re: [PATCH] cxl: remove dead Kconfig options

2016-07-08 Thread Andrew Donnellan
On 04/07/16 17:12, Andrew Donnellan wrote: Remove the CXL_KERNEL_API and CXL_EEH Kconfig options, as they were only needed to coordinate the merging of the cxlflash driver. Also remove the stub implementation of cxl_perst_reloads_same_image() in cxlflash which is only used if CXL_EEH isn't define