Permit changing of a LU name from a (fake) IEEE registered NAA (5)
to a locally assigned UUID. Using a UUID (RFC 4122) for a SCSI
designation descriptor (e.g. a LU name) was added in spc5r08.pdf
(a draft INCITS standard) on 25 January 2016. Add parameter
uuid_ctl to use a separate UUID for each LU
For reported SAS addresses replace fake IEEE registered NAAs (5)
with locally assigned NAAs (3).
Reviewed-by: Hannes Reinecke
Reviewed-by: Bart Van Assche
Signed-off-by: Douglas Gilbert
---
drivers/scsi/scsi_debug.c | 35 ++-
1 file changed, 18 insertions(+), 17
Cleanup some mode and vpd pages. Stop reporting SBC (disk) pages
when peripheral type is something else (e.g. tape). Update
version descriptors. Expand LBPRZ flag handling.
Reviewed-by: Hannes Reinecke
Reviewed-by: Bart Van Assche
Signed-off-by: Douglas Gilbert
---
drivers/scsi/scsi_debug.c |
Based on "[PATH V2] scsi_debug: rework resp_report_luns" patch
sent by Tomas Winkler on Thursday, 26 Feb 2015. His notes:
1. Remove duplicated boundary checks which simplify the fill-in
loop
2. Use more of scsi generic API
Replace fixed length response array a with heap allocation
allowing
Changes since v2.5
- rework the 'add multiple queue support' patch based on
reviewers' comments to more closely follow the scsi/block mq
template
Changes since original version:
- reduce resp_report_luns to reporting 256 LUNs (0 to 255)
using address_method=0 which is single level
Use TYPE_* constants for SCSI peripheral device types instead
of numbers. Further cleanups requested by checkpatch.pl .
Reviewed-by: Hannes Reinecke
Reviewed-by: Bart Van Assche
Signed-off-by: Douglas Gilbert
---
drivers/scsi/scsi_debug.c | 86 +--
1
Add submit_queue parameter (minimum and default: 1; maximum:
nr_cpu_ids) that controls how many queues are built, each with
their own lock and in_use bit vector. Add statistics parameter
which is default off.
Signed-off-by: Douglas Gilbert
---
drivers/scsi/scsi_debug.c | 702
On 05/05/16 20:47, Douglas Gilbert wrote:
On 2016-05-04 06:32 PM, Bart Van Assche wrote:
On 04/30/2016 07:44 PM, Douglas Gilbert wrote:
+static struct sdebug_queue *get_queue(void)
+{
+struct sdebug_queue *sqp = sdebug_q_arr;
+
+return sqp + (raw_smp_processor_id() % submit_queues);
+}
On 2016-05-04 06:32 PM, Bart Van Assche wrote:
On 04/30/2016 07:44 PM, Douglas Gilbert wrote:
+static struct sdebug_queue *get_queue(void)
+{
+struct sdebug_queue *sqp = sdebug_q_arr;
+
+return sqp + (raw_smp_processor_id() % submit_queues);
+}
Does this function have the same purpose
> "Dan" == Dan Carpenter writes:
Dan> The caller assumes that "itnim" is NULL on error and non-NULL on
Dan> success but really "itnim" is uninitialized on error. This
Dan> function should just use normal error handling where it returns
Dan> zero on success and negative on failure.
Anil, ple
> "Andy" == Andy Lutomirski writes:
Andy> I actually read the error messages in my logs, and successful
Andy> initialization is not an error.
Andy> Arguably these log lines could be deleted entirely.
Applied to 4.7/scsi-queue.
Thanks!
--
Martin K. Petersen Oracle Linux Engineering
-
> "Uma" == Uma Krishnan writes:
Uma> When a cxlflash adapter goes into EEH recovery and multiple
Uma> processes (each having established its own context) are active, the
Uma> EEH recovery can hang if the processes attempt to recover in
Uma> parallel. The symptom logged after a couple of minut
From: Colin Ian King
The removal the #ifdef'd code on CONFIG_ARCH_HAS_SG_CHAIN in
commit 02c4de53add1b79 ("target/rd: always chain S/G list")
removed the setting of need_to_release to true, so we are now left
with need_to_release always being false and hence the conditional
kfree is never reached
On 05/05/2016 03:58 PM, Bart Van Assche wrote:
> On 03/28/2016 02:29 PM, Bart Van Assche wrote:
>> Avoid that the sd driver registers a BDI device with a name that
>> is still in use. This patch avoids that the following warning gets
>> triggered:
>>
>> [ ... ]
>
> (replying to my own e-mail)
>
>
On 03/28/2016 02:29 PM, Bart Van Assche wrote:
Avoid that the sd driver registers a BDI device with a name that
is still in use. This patch avoids that the following warning gets
triggered:
[ ... ]
(replying to my own e-mail)
If anyone could review this patch that would be very welcome.
Than
On Thu, May 05, 2016 at 10:01:13AM +0200, Hannes Reinecke wrote:
> On 05/05/2016 05:50 AM, Paul Mackerras wrote:
> > On Wed, May 04, 2016 at 12:04:16PM +0200, Hannes Reinecke wrote:
...
> >> Nearly.
> >> The thing is, a T-10 vendor specific ID is _supposed_ to be an ASCII
> >> string. So I'd rather
On 05/05/2016 05:50 AM, Paul Mackerras wrote:
> On Wed, May 04, 2016 at 12:04:16PM +0200, Hannes Reinecke wrote:
>> On 05/04/2016 08:58 AM, Paul Mackerras wrote:
>>> This adds code to scsi_vpd_lun_id() to enable it to use T10 vendor ID
>>> based designators. This is needed to allow alua to work on
17 matches
Mail list logo
