On Wed, Mar 23, 2016 at 09:49:26PM -0400, David Bond wrote:
>
> Some ethernet adapter vendors are supplying products which support optional
> (payed license) features. On some adapters this includes a hardware iscsi
> initiator. The same adapters in a normal (no extra licenses) mode of
> operatio
We will look into this early next week and provide a detailed response. On
the first look this is ACK from Broadcom, will reconfirm.
-Original Message-
From: Ewan D. Milne [mailto:emi...@redhat.com]
Sent: Friday, April 01, 2016 2:04 PM
To: Joe Lawrence
Cc: linux-scsi@vger.kernel.org; Sath
On Fri, 2016-04-01 at 15:13 -0400, Joe Lawrence wrote:
> On 04/01/2016 02:51 PM, Ewan D. Milne wrote:
> > On Fri, 2016-04-01 at 13:56 -0400, Joe Lawrence wrote:
> >> @@ -2804,12 +2803,12 @@ _scsih_fw_event_cleanup_queue(struct
> >> MPT3SAS_ADAPTER *ioc)
> >>/*
> >> * Wait o
On 04/01/2016 02:51 PM, Ewan D. Milne wrote:
> On Fri, 2016-04-01 at 13:56 -0400, Joe Lawrence wrote:
>> @@ -2804,12 +2803,12 @@ _scsih_fw_event_cleanup_queue(struct MPT3SAS_ADAPTER
>> *ioc)
>> /*
>> * Wait on the fw_event to complete. If this returns 1, then
>>
Hello Satish Kharat,
This is a semi-automatic email about new static checker warnings.
The patch ce4b9e8980fa: "fnic: Using rport->dd_data to check rport
online instead of rport_lookup." from Mar 18, 2016, leads to the
following Smatch complaint:
drivers/scsi/fnic/fnic_scsi.c:457 fnic_queuecom
On Fri, 2016-04-01 at 10:06 -0400, Chad Dupuis wrote:
> On Fri, 1 Apr 2016, Johannes Thumshirn wrote:
>
> > On 2016-04-01 15:10, Chad Dupuis wrote:
> > > From: Joe Carnuccio
> > >
> > > Per customer request, add the following driver tunables:
> > >
> > > o devloss_tmo
> > > o max_luns
> > > o q
https://bugzilla.kernel.org/show_bug.cgi?id=111381
Gabriel A. Devenyi changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
On Fri, 2016-04-01 at 13:56 -0400, Joe Lawrence wrote:
> The driver's fw events are queued up using the the fw_event_work's
> struct work, not its delayed_work member. The latter appears to be
> unused and may provoke CONFIG_DEBUG_OBJECTS_TIMERS "assert_init not
> available" false warnings in _scs
On 03/31/2016 01:05 AM, Nicholas A. Bellinger wrote:
On Wed, 2016-03-16 at 10:48 -0600, Chris Friesen wrote:
On 03/11/2016 01:45 AM, Nicholas A. Bellinger wrote:
On Thu, 2016-03-10 at 23:30 -0800, Christoph Hellwig wrote:
On Thu, Mar 10, 2016 at 04:24:25PM -0600, Chris Friesen wrote:
Hi,
I'm
On 04/01/2016 11:01 AM, Lee Duncan wrote:
On 04/01/2016 12:58 AM, Johannes Thumshirn wrote:
On 2016-03-31 20:05, Lee Duncan wrote:
This commit updates the target core ALUA and PR
modules to use the new "dbroot" attribute instead
of assuming the target database is in "/var/target".
Same goes f
Himanshu
I looked at using the attribute for this but because of where I have to discard
the command I dont want to have to go fetch the attribute each time in the same
code path.
Its significant overhead to have to go fetch the attribute value each time as I
allow for a dynamic on off via the
On 04/01/2016 12:58 AM, Johannes Thumshirn wrote:
> On 2016-03-31 20:05, Lee Duncan wrote:
>> This commit updates the target core ALUA and PR
>> modules to use the new "dbroot" attribute instead
>> of assuming the target database is in "/var/target".
>
> Same goes for this one,
>
> Reviewed-by: J
Looks fine to me.
Reviewed-by: Laurence Oberman
Laurence Oberman
Principal Software Maintenance Engineer
Red Hat Global Support Services
- Original Message -
From: "Joe Lawrence"
To: linux-scsi@vger.kernel.org
Cc: "Sathya Prakash" , "Chaitra P B"
, "Suganath Prabu Subramani"
, "Calvi
The driver's fw events are queued up using the the fw_event_work's
struct work, not its delayed_work member. The latter appears to be
unused and may provoke CONFIG_DEBUG_OBJECTS_TIMERS "assert_init not
available" false warnings in _scsih_fw_event_cleanup_queue. Remove it
and update _scsih_fw_even
On Fri, Apr 01 2016 at 9:37am -0400,
Johannes Thumshirn wrote:
> [ +Cc Hannes ]
>
> On 2016-04-01 15:22, Mike Snitzer wrote:
> >On Fri, Apr 01 2016 at 4:12am -0400,
> >Johannes Thumshirn wrote:
> >
> >>On 2016-03-31 22:04, Mike Snitzer wrote:
> >>>I developed these changes some weeks ago but
On Fri, 1 Apr 2016, Johannes Thumshirn wrote:
On 2016-04-01 15:10, Chad Dupuis wrote:
Signed-off-by: Chad Dupuis
---
drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
index d95eee6..60
On Fri, 1 Apr 2016, Johannes Thumshirn wrote:
On 2016-04-01 15:10, Chad Dupuis wrote:
From: Joe Carnuccio
Per customer request, add the following driver tunables:
o devloss_tmo
o max_luns
o queue_depth
o tm_timeout
Signed-off-by: Joe Carnuccio
Signed-off-by: Chad Dupuis
---
drivers/scsi
On 2016-04-01 15:10, Chad Dupuis wrote:
Signed-off-by: Chad Dupuis
---
Reviewed-by: Johannes Thumshirn
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.h
On 2016-04-01 15:10, Chad Dupuis wrote:
When we are in connection recovery and the internal command timer on a
request
pops, either the scsi_cmnd->device or scsi_cmnd->device->host back
pointers may
be NULL as the device that the command that the request was submitted
on may
have been subsequen
On 2016-04-01 15:10, Chad Dupuis wrote:
Signed-off-by: Chad Dupuis
---
drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
index d95eee6..60423cf 100644
--- a/drivers/scsi/bnx2fc/bnx2fc_fco
On 2016-04-01 15:10, Chad Dupuis wrote:
Signed-off-by: Chad Dupuis
---
Looks like a nice debug feature,
Reviewed-by: Johannes Thumshirn
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http:/
On 2016-04-01 15:10, Chad Dupuis wrote:
From: Joe Carnuccio
Per customer request, add the following driver tunables:
o devloss_tmo
o max_luns
o queue_depth
o tm_timeout
Signed-off-by: Joe Carnuccio
Signed-off-by: Chad Dupuis
---
drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 38
+
From: Joe Carnuccio
Per customer request, add the following driver tunables:
o devloss_tmo
o max_luns
o queue_depth
o tm_timeout
Signed-off-by: Joe Carnuccio
Signed-off-by: Chad Dupuis
---
drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 38 +-
drivers/scsi/bnx2fc/bnx2
Signed-off-by: Chad Dupuis
---
drivers/scsi/bnx2fc/bnx2fc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/bnx2fc/bnx2fc.h b/drivers/scsi/bnx2fc/bnx2fc.h
index 499e369..9ce361a 100644
--- a/drivers/scsi/bnx2fc/bnx2fc.h
+++ b/drivers/scsi/bnx2fc/bnx2fc.h
@@ -65,7
When we are in connection recovery and the internal command timer on a request
pops, either the scsi_cmnd->device or scsi_cmnd->device->host back pointers may
be NULL as the device that the command that the request was submitted on may
have been subsequently reaped due to the connection recovery. T
Signed-off-by: Chad Dupuis
---
drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
index d95eee6..60423cf 100644
--- a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
+++ b/drivers/scsi/bnx2fc/bnx2fc_fcoe
Signed-off-by: Chad Dupuis
---
drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 19 +++
1 file changed, 19 insertions(+)
diff --git a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
index 600c29d..d95eee6 100644
--- a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
+++ b/drivers/scsi
Hi James, Martin,
Please add the following patches to the scsi tree at your earliest
convenience.
Chad Dupuis (4):
bnx2fc: Print when we send a fip keep alive.
bnx2fc: Print netdev device name when FCoE is successfully
initialized.
bnx2fc: Check sc_cmd device and host pointer before ret
[ +Cc Hannes ]
On 2016-04-01 15:22, Mike Snitzer wrote:
On Fri, Apr 01 2016 at 4:12am -0400,
Johannes Thumshirn wrote:
On 2016-03-31 22:04, Mike Snitzer wrote:
>I developed these changes some weeks ago but have since focused on
>regression and performance testing on larger NUMA systems.
>
>F
On Fri, Apr 01 2016 at 4:12am -0400,
Johannes Thumshirn wrote:
> On 2016-03-31 22:04, Mike Snitzer wrote:
> >I developed these changes some weeks ago but have since focused on
> >regression and performance testing on larger NUMA systems.
> >
> >For regression testing I've been using mptest:
> >h
On 3/31/2016 9:27 PM, Winkler, Tomas wrote:
> On Thu, 2016-03-31 at 19:57 +0100, Joao Pinto wrote:
>> Adding UFS 2.0 support to the UFS core driver.
>>
>> Signed-off-by: Joao Pinto
>
> Looks good to me, though not tested yet
> Tomas
I have tested the build in a x86 and ARC. Also tested the funct
On 2016-03-31 22:04, Mike Snitzer wrote:
The primary motivation of this commit is to improve the scalability of
DM multipath on large NUMA systems where m->lock spinlock contention
has
been proven to be a serious bottleneck on really fast storage.
The ability to atomically read a pointer, usin
On 2016-03-31 22:04, Mike Snitzer wrote:
Allows the 'work_mutex' member to no longer cross a cacheline.
Signed-off-by: Mike Snitzer
---
Looks good,
Reviewed-by: Johannes Thumshirn
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@v
On 2016-03-31 22:04, Mike Snitzer wrote:
The use of atomic_t for nr_valid_paths, pg_init_in_progress and
pg_init_count will allow relaxing the use of the m->lock spinlock.
Suggested-by: Hannes Reinecke
Signed-off-by: Mike Snitzer
Looks good,
Reviewed-by: Johannes Thumshirn
--
To unsubscribe
On 2016-03-31 22:04, Mike Snitzer wrote:
Mechanical change that doesn't make any real effort to reduce the use
of
m->lock; that will come later (once atomics are used for counters,
etc).
Suggested-by: Hannes Reinecke
Signed-off-by: Mike Snitzer
Looks good,
Reviewed-by: Johannes Thumshirn
On 2016-03-31 22:04, Mike Snitzer wrote:
I developed these changes some weeks ago but have since focused on
regression and performance testing on larger NUMA systems.
For regression testing I've been using mptest:
https://github.com/snitm/mptest
For performance testing I've been using a null_bl
On 2016-03-31 20:05, Lee Duncan wrote:
This commit updates the target core ALUA and PR
modules to use the new "dbroot" attribute instead
of assuming the target database is in "/var/target".
Same goes for this one,
Reviewed-by: Johannes Thumshirn
as soon as it has a Signed-off-by line
--
To un
On 2016-03-31 20:05, Lee Duncan wrote:
This commit adds the read-write attribute "dbroot", in
the top-level CONFIGFS (core) target directory,
normally /sys/kernel/config/target. This attribute
defaults to "/var/target" but can be changed by
writing a new pathname string to it.
Target modules tha
On 2016-04-01 08:57, Hannes Reinecke wrote:
VPD pages 0x0 and 0x83 are mandatory even for SPC-2, so we should
be lowering the restriction to avoid having to whitelist every
SPC-2 compliant device.
Signed-off-by: Hannes Reinecke
Looks good,
Reviewed-by: Johannes Thumshirn
--
To unsubscribe fr
On 2016-04-01 08:57, Hannes Reinecke wrote:
The patch "scsi: rescan VPD attributes" introduced a regression in
which
devices that don't support VPD were being scanned for VPD attributes
anyway. This could cause issues for this parts and should be avoided
so
the check for scsi_level has been m
On 03/30/2016 09:41 PM, Benjamin Block wrote:
> Hello Hannes,
>
> I am a bit late here, but as this got pulled and Steffen didn't have
> time to give it a review, I did today.
>
> On 08:39 Thu 17 Mar , Hannes Reinecke wrote:
>> On larger installations it is useful to disable automatic LUN
>>
41 matches
Mail list logo
