On 02/18/2016 11:08 PM, Bart Van Assche wrote:
> On 02/15/2016 12:24 AM, Hannes Reinecke wrote:
>> @@ -180,7 +172,7 @@ static int submit_stpg(struct scsi_device
>> *sdev, int group_id,
>>
>> /* Prepare the data buffer */
>> memset(stpg_data, 0, stpg_len);
>> -stpg_data[4] = TPGS_STA
On 02/18/2016 11:06 PM, Bart Van Assche wrote:
> On 02/15/2016 12:24 AM, Hannes Reinecke wrote:
>> --- a/include/scsi/scsi_proto.h
>> +++ b/include/scsi/scsi_proto.h
>> @@ -277,5 +277,17 @@ struct scsi_lun {
>> __u8 scsi_lun[8];
>> };
>>
>> +/* SPC asymmetric access states */
>> +#define SC
On 02/18/2016 10:55 PM, Bart Van Assche wrote:
> On 02/15/2016 12:24 AM, Hannes Reinecke wrote:
>> Add an 'access_state' attribute to struct scsi_device to
>> display the asymmetric LUN access state.
>
> Do we really need to add this attribute to SCSI devices that do not
> support ALUA, e.g. ATA d
On 02/18/2016 08:41 PM, Bart Van Assche wrote:
> On 02/15/2016 12:24 AM, Hannes Reinecke wrote:
>> if (optimize)
>> -h->flags |= ALUA_OPTIMIZE_STPG;
>> +pg->flags |= ALUA_OPTIMIZE_STPG;
>> else
>> -h->flags &= ~ALUA_OPTIMIZE_STPG;
>> +pg->flags |= ~ALUA_O
Hi Mike,
On 02/19/16 02:17, Mike Snitzer wrote:
> But unfortunately I cannot get either the scsidebug or tcmloop mode to
> run against v4.5-rc4
>
> For tcmloop, targetcli fails with:
> "Could not create ISCSIFabricModule in configFS."
Hmm, it sounds like there's unnecessary dependency in targetc
Hi Mika,
On Thu, Feb 18, 2016 at 7:54 PM, Mika Westerberg
wrote:
> Runtime PM of the SCSI host is already handled by calls to
> scsi_autopm_get_host() and scsi_autopm_put_host() from appropriate places
> whenever the host needs to be powered on. This works fine when there is
> device connected to
On 02/15/2016 12:24 AM, Hannes Reinecke wrote:
Track attached SCSI devices and update the 'access_state' field
whenever an ALUA state change has been detected.
Reviewed-by: Bart Van Assche
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majo
On 02/15/2016 12:24 AM, Hannes Reinecke wrote:
@@ -180,7 +172,7 @@ static int submit_stpg(struct scsi_device *sdev, int
group_id,
/* Prepare the data buffer */
memset(stpg_data, 0, stpg_len);
- stpg_data[4] = TPGS_STATE_OPTIMIZED & 0x0f;
+ stpg_data[4] = SCSI_ACCESS_
On 02/15/2016 12:24 AM, Hannes Reinecke wrote:
--- a/include/scsi/scsi_proto.h
+++ b/include/scsi/scsi_proto.h
@@ -277,5 +277,17 @@ struct scsi_lun {
__u8 scsi_lun[8];
};
+/* SPC asymmetric access states */
+#define SCSI_ACCESS_STATE_OPTIMAL 0x00
+#define SCSI_ACCESS_STATE_ACTIVE
On 02/15/2016 12:24 AM, Hannes Reinecke wrote:
Add an 'access_state' attribute to struct scsi_device to
display the asymmetric LUN access state.
Do we really need to add this attribute to SCSI devices that do not
support ALUA, e.g. ATA devices ? From a system on which this patch
series has be
On 02/15/2016 12:24 AM, Hannes Reinecke wrote:
If a device needs to be rescanned the device_handler might need
to be rechecked, too.
So add a 'rescan' callback to the device handler and call it
upon scsi_rescan_device(). The rescan callback will be invoked
from the Unit Attention handling of ASC/
On 02/15/2016 12:24 AM, Hannes Reinecke wrote:
Sending a 'REPORT TARGET PORT GROUP' command is a costly operation,
as the array has to gather information about all ports.
So instead of using RTPG to poll for a status update when a port
is in transitioning we should be sending a TEST UNIT READY, a
On 02/15/2016 12:24 AM, Hannes Reinecke wrote:
When we read in the target port group state we should be
updating all affected port groups, otherwise we risk
running out of sync.
Reviewed-by: Bart Van Assche
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of
On 02/15/2016 12:24 AM, Hannes Reinecke wrote:
When we receive a unit attention code of 'ALUA state changed'
we should recheck the state, as it might be due to an implicit
ALUA state transition. This allows us to return NEEDS_RETRY
instead of ADD_TO_MLQUEUE, allowing to terminate the retries
afte
On 02/15/2016 12:24 AM, Hannes Reinecke wrote:
Add a new blacklist flag BLIST_SYNC_ALUA to instruct the
alua device handler to use synchronous command submission
for ALUA commands.
Reviewed-by: Bart Van Assche
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body
On 02/15/2016 12:24 AM, Hannes Reinecke wrote:
Some arrays may only capable of handling one STPG at a time,
so this patch adds a singlethreaded workqueue for STPGs to be
submitted synchronously.
Reviewed-by: Bart Van Assche
--
To unsubscribe from this list: send the line "unsubscribe linux-scs
On 02/15/2016 12:24 AM, Hannes Reinecke wrote:
The current ALUA device_handler has two drawbacks:
- We're sending a 'SET TARGET PORT GROUP' command to every LUN,
disregarding the fact that several LUNs might be in a port group
and will be automatically switched whenever _any_ LUN within
On 16-02-17 11:59 PM, Douglas Gilbert wrote:
sg3_utils is a package of command line utilities for sending
SCSI and some ATA commands to devices. This package targets
the Linux 4, 3, 2.6 and 2.4 kernel series. It has ports to
FreeBSD, Tru64, Solaris, and Windows (cygwin and MinGW).
There are two
On 02/15/2016 12:24 AM, Hannes Reinecke wrote:
The 'relative port' field is not used, and might get stale when
the port group changes. So remove the field altogether.
Reviewed-by: Bart Van Assche
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message
On 02/15/2016 12:24 AM, Hannes Reinecke wrote:
When the optimize_stpg module option is set we should just set it
once during port_group allocation. Doing so allows us to override
it later with device specific settings.
Reviewed-by: Bart Van Assche
--
To unsubscribe from this list: send the lin
On 02/15/2016 12:24 AM, Hannes Reinecke wrote:
This reverts commit a8e5a2d593cbfccf530c3382c2c328d2edaa7b66
Reviewed-by: Bart Van Assche
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http:/
On 02/15/2016 12:24 AM, Hannes Reinecke wrote:
Rework alua_check_vpd() to use scsi_vpd_get_tpg()
and move the port group selection into the function, too.
With that we can simplify alua_initialize() to just
call alua_check_tpgs() and alua_check_vpd();
Reviewed-by: Bart Van Assche
--
To unsubsc
On 02/15/2016 12:24 AM, Hannes Reinecke wrote:
Use scsi_vpd_lun_id() to assign a unique device identification
to the alua port group structure.
Reviewed-by: Bart Van Assche
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kerne
On 02/15/2016 12:24 AM, Hannes Reinecke wrote:
if (optimize)
- h->flags |= ALUA_OPTIMIZE_STPG;
+ pg->flags |= ALUA_OPTIMIZE_STPG;
else
- h->flags &= ~ALUA_OPTIMIZE_STPG;
+ pg->flags |= ~ALUA_OPTIMIZE_STPG;
The above looks w
On 02/15/2016 12:24 AM, Hannes Reinecke wrote:
All commands are issued synchronously, so no need to open-code
scsi_execute_req_flags() anymore. And we can get rid of the
static sense code structure element. scsi_execute_req_flags()
will be setting REQ_QUIET and REQ_PREEMPT, but that is
perfectly
On 02/15/2016 12:24 AM, Hannes Reinecke wrote:
default:
+ sdev_printk(KERN_INFO, sdev,
+ "%s: stpg failed, unhandled TPGS state %d",
+ ALUA_DH_NAME, h->state);
+ return SCSI_DH_NOSYS;
break;
On 02/15/2016 12:24 AM, Hannes Reinecke wrote:
If the call to SET TARGET PORT GROUPS fails we have no idea what
state the array is left in, so we need to issue a call to
REPORT TARGET PORT GROUPS in these cases.
Reviewed-by: Bart Van Assche
--
To unsubscribe from this list: send the line "unsu
On 02/15/2016 12:24 AM, Hannes Reinecke wrote:
Separate out SET TARGET PORT GROUP functionality into a separate
function alua_stpg().
Reviewed-by: Bart Van Assche
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More
Two simple fixes. One prevents a soft lockup on some target removal
scenarios and the other prevents us trying to probe the marvell console
device, which causes it to time out and need the bus resetting.
The patch is available here:
git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scs
On Wed, Oct 07 2015 at 1:39am -0400,
Junichi Nomura wrote:
> This is a set of scripts for kernel-side dm-multipath testing. Current
> set of scripts are stress testing of extreme situation and its coverage
> is limited. But recently found dm-mpath regressions should be detectable
> with this. I
On Thu, 2016-02-18 at 11:40 -0500, Ewan Milne wrote:
> It also appears to me upon further inspection that the existing code has
> other problems. In particular, once mpt_mapresources() has returned
> with a nonzero error code, it looks like iounmap() should be called, but
> it is not in the case o
Sorry about this. I am working on an older 3.10 codebase (RHEL7.x) where the
equivalent function int se_dev_set_unmap_zeroes_data(struct se_device *dev, int
flag) does and SHOULD return 0. There are apparently more changes between
configfs in 3.10 and latest than I found. That one slipped by whe
On Thu, 2016-02-18 at 10:00 +0100, Johannes Thumshirn wrote:
> On Wed, Feb 17, 2016 at 11:40:59PM -0500, Insu Yun wrote:
> > the failure of ioc->reset_work_q is checked,
> > but not ioc->fw_event_q.
> >
> > Signed-off-by: Insu Yun
> > ---
> > drivers/message/fusion/mptbase.c | 44
> > ++
Hello,
Patchset looks good to me. Once Jens acks the first patch, I'll apply
the whole series to libata/for-4.6 w/ the field initialization
updated.
Thanks.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
M
On Tue, 9 Feb 2016, Alexandre Rossi wrote:
> Hi,
>
> netconsole does not seem to work so early in the boot process this time.
>
> > As this is Linux 4.3 and not 4.4, I guess this is a different problem
> > though. Alexandre, where you able to capture the stack trace? I’d submit
> > a new bug rep
On Thu, Feb 18, 2016 at 08:12:46AM -0500, Tejun Heo wrote:
> On Thu, Feb 18, 2016 at 12:45:05PM +0200, Andy Shevchenko wrote:
> > > + .driver.pm = &ahci_pci_pm_ops,
> >
> > Please, do this in several assignments, since to support older compilers.
>
> Can you please elaborate?
On Mon, Feb 15, 2016 at 03:25:13PM +, Joao Pinto wrote:
> This patch has the goal to add support for DesignWare UFS Controller
> specific operations and to add specific platform and pci drivers.
>
> Signed-off-by: Joao Pinto
> ---
> Changes v7->v8 (Akinobu Mita):
> - DME sets were simplified
On Mon, Feb 15, 2016 at 03:25:12PM +, Joao Pinto wrote:
> Adding UFS 2.0 support to the UFS core driver.
>
> Signed-off-by: Joao Pinto
> ---
> Changes v7->v8:
> - Added "jedec, ufs-2.0" to the ufschd-platform compatibility strings
> Changes v0->v7:
> - Nothing changed (just to keep up with pa
On Thu, Feb 18, 2016 at 12:45:05PM +0200, Andy Shevchenko wrote:
> > + .driver.pm = &ahci_pci_pm_ops,
>
> Please, do this in several assignments, since to support older compilers.
Can you please elaborate? That's a single assignment. Are there
compilers which can't do that?
On Thu, Feb 18, 2016 at 01:54:02PM +0100, Tomas Henzl wrote:
> On 18.2.2016 09:39, Suganath Prabu Subramani wrote:
> > From: Suganath prabu Subramani
> >
> > Deallocate resources before reallocating of the same in retry_allocation
> > path of _base_allocate_memory_pools()
> >
> > Signed-off-by: Su
On 18.2.2016 09:39, Suganath Prabu Subramani wrote:
> From: Suganath prabu Subramani
>
> Deallocate resources before reallocating of the same in retry_allocation
> path of _base_allocate_memory_pools()
>
> Signed-off-by: Suganath prabu Subramani
>
> Signed-off-by: Chaitra P B
> ---
> drivers/s
On Mon, Feb 15, 2016 at 10:39:55PM +0530, Sagi Grimberg wrote:
>
> > 1. void (*iscsit_rx_pdu)(struct iscsi_conn *);
> > Rx thread uses this for receiving and processing
> > iSCSI PDU in full feature phase.
>
> Is iscsit_rx_pdu the best name for this? it sounds like
> a function that would
On 18/02/2016 10:30, Hannes Reinecke wrote:
On 02/18/2016 11:12 AM, John Garry wrote:
On 18/02/2016 07:40, Hannes Reinecke wrote:
[ .. ]
Well, the classical thing would be to associate each request tag
with a SAS task; or, in your case, associate each slot index with a
request tag.
You probabl
On Thu, Feb 18, 2016 at 10:54 AM, Mika Westerberg
wrote:
> In order to add support for runtime PM to the ahci driver we first need to
> convert the driver to use modern non-legacy system suspend hooks. There
> should be no functional changes.
>
One comment below, otherwise:
Reviewed-by: Andy Shev
On 02/18/2016 11:12 AM, John Garry wrote:
> On 18/02/2016 07:40, Hannes Reinecke wrote:
[ .. ]
>> Well, the classical thing would be to associate each request tag
>> with a SAS task; or, in your case, associate each slot index with a
>> request tag.
>> You probably would need to reserve some slots
On 18/02/2016 07:40, Hannes Reinecke wrote:
On 02/16/2016 05:56 PM, John Garry wrote:
On 16/02/2016 15:33, Hannes Reinecke wrote:
On 02/16/2016 01:22 PM, John Garry wrote:
In high-datarate aging tests, it is found that
the SCSI framework can periodically
issue lu resets to the device. This is
/* by default, task resp is complete */
-static void slot_err_v1_hw(struct hisi_hba *hisi_hba,
- struct sas_task *task,
- struct hisi_sas_slot *slot)
+static void slot_err_v1_hw(struct hisi_hba *hisi_hba, struct
sas_task *task,
+ struct hisi_sas_slot *s
On 16/02/2016 15:41, John Garry wrote:
On 16/02/2016 15:22, Hannes Reinecke wrote:
On 02/16/2016 01:22 PM, John Garry wrote:
Add a function to abort a slot (task) in the device
(if it is in the task set) and then cleanup and
complete the task.
The function is called from work queue context as
i
On Wed, Feb 17, 2016 at 11:40:59PM -0500, Insu Yun wrote:
> the failure of ioc->reset_work_q is checked,
> but not ioc->fw_event_q.
>
> Signed-off-by: Insu Yun
> ---
> drivers/message/fusion/mptbase.c | 44
>
> 1 file changed, 27 insertions(+), 17 deleti
Hi,
Linux already supports runtime PM of disks (drivers/scsi/sd.c) so that
after certain amount of idle time the disk is suspended automatically. This
series extends the support to AHCI host controllers. Whenever SATA ports
are determined to be idle (all children are runtime suspended) the host
co
Runtime PM of the SCSI host is already handled by calls to
scsi_autopm_get_host() and scsi_autopm_put_host() from appropriate places
whenever the host needs to be powered on. This works fine when there is
device connected to the host as once it runtime suspends the host will too.
However, if there
If block device is left runtime suspended during system suspend, resume
hook of the driver typically corrects runtime PM status of the device back
to "active" after it is resumed. However, this is not enough as queue's
runtime PM status is still "suspended". As long as it is in this state
blk_pm_pe
This patch adds runtime PM support for the AHCI host controller driver so
that the host controller is powered down when all SATA ports are runtime
suspended. Powering down the AHCI host controller can reduce power
consumption and possibly allow the CPU to enter lower power idle states
(S0ix) during
In order to add support for runtime PM to the ahci driver we first need to
convert the driver to use modern non-legacy system suspend hooks. There
should be no functional changes.
Signed-off-by: Mika Westerberg
---
drivers/ata/ahci.c | 49 ++---
1 file
Add new functions ahci_rpm_get_port()/ahci_rpm_put_port() that change
runtime PM status of AHCI ports. Depending if the AHCI host has runtime PM
enabled or disabled calling these may trigger runtime suspend/resume of the
host controller.
We also call these functions in appropriate places to make s
This allows sysfs nodes to read the cached value directly instead of
powering up possibly runtime suspended controller.
Signed-off-by: Mika Westerberg
---
drivers/ata/ahci.h| 1 +
drivers/ata/libahci.c | 7 +++
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/ata/ah
We treat system suspend of SCSI devices pretty much the same as runtime
suspend. If the device is already runtime suspended we leave it to that
state during system suspend. On resume from system sleep we then resume the
device and correct the runtime PM status back to "active".
There is a problem
From: Suganath prabu Subramani
Deallocate resources before reallocating of the same in retry_allocation
path of _base_allocate_memory_pools()
Signed-off-by: Suganath prabu Subramani
Signed-off-by: Chaitra P B
---
drivers/scsi/mpt3sas/mpt3sas_base.c | 1 +
1 file changed, 1 insertion(+)
diff
From: Suganath prabu Subramani
Updating maintainers list for MPT FUSION DRIVERS,
broadcom support link and email id.
Signed-off-by: Suganath prabu Subramani
Signed-off-by: Chaitra P B
---
MAINTAINERS | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/MAINTAINERS b
We were getting build warning about:
drivers/scsi/dpt_i2o.c:183:29: warning: 'dptids' defined but not used
dptids[] is only used in the MODULE_DEVICE_TABLE so when MODULE is not
defined then dptids[] becomes unused.
Reviewed-by: Johannes Thumshirn
Signed-off-by: Sudip Mukherjee
---
Resending v
On Wed, Feb 17, 2016 at 09:20:03PM +0530, Sudip Mukherjee wrote:
> On Wednesday 17 February 2016 07:57 PM, One Thousand Gnomes wrote:
> >On Wed, 17 Feb 2016 17:50:14 +0530
> >Sudip Mukherjee wrote:
> >
> >>This is a pci device but was not done in the usual way a pci driver is
> >>done. Convert the
61 matches
Mail list logo
