On Wed, Jan 06, 2016 at 08:40:09PM -0500, Martin K. Petersen wrote:
> > "Mike" == mchristi writes:
>
> Mike> The following patches begin to cleanup the request->cmd_flags and
> bio-> bi_rw mess. We currently use cmd_flags to specify the operation,
> Mike> attributes and state of the request.
On Tue, Jan 05, 2016 at 02:53:16PM -0600, mchri...@redhat.com wrote:
> From: Mike Christie
>
> This patch has xfs set the bio bi_op to a REQ_OP, and
> rq_flag_bits to bi_rw.
>
> Note:
> I have run xfs tests on these btrfs patches. There were some failures
> with and without the patches. I have n
> "Finn" == Finn Thain writes:
Finn> Like my previous work on the NCR5380 drivers, this patch series
Finn> has bug fixes, code cleanup and modernization. These drivers
Finn> suffer from mistakes, poor style and neglect and this long series
Finn> addresses the worst of it, covering all ten wra
> "Uma" == Uma Krishnan writes:
Uma> This patch set contains miscellaneous fixes and adds support for a
Uma> future IBM CXL adapter. This series is intended for 4.5 and is
Uma> bisectable. Please reference the changelog below for details on
Uma> what has been altered from previous versions of
> "Mike" == mchristi writes:
Mike> The following patches begin to cleanup the request->cmd_flags and
bio-> bi_rw mess. We currently use cmd_flags to specify the operation,
Mike> attributes and state of the request. For bi_rw we use it for
Mike> similar info and also the priority but then als
> "Mike" == mchristi writes:
+enum req_op {
+ REQ_OP_READ,
+ REQ_OP_WRITE= REQ_WRITE,
+ REQ_OP_DISCARD = REQ_DISCARD,
+ REQ_OP_WRITE_SAME = REQ_WRITE_SAME,
+};
+
I have been irked by the REQ_ prefix in bios since the flags were
consolidated
From: Raghava Aditya Renukunta
Updated diver version to 41052
Changes in V2:
None
Signed-off-by: Raghava Aditya Renukunta
Reviewed-by: Johannes Thumshirn
---
drivers/scsi/aacraid/aacraid.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/aacraid/aacraid.h b/dr
From: Raghava Aditya Renukunta
while driver removal is in progress or PCI shutdown is invoked, driver
kills AIF aacraid thread, but IOCTL requests from the management tools
re-start AIF thread leading to IOP_RESET.
Fixed by setting adapter_shutdown flag when PCI shutdown is invoked.
Changes in
From: Raghava Aditya Renukunta
aac_fib_map_free() calls pci_free_consistent() without checking that
dev->hw_fib_va is not NULL and dev->max_fib_size is not zero.If they
are indeed NULL/0, this will result in a hang as pci_free_consistent()
will attempt to invalidate cache for the entire 64-bit ad
From: Raghava Aditya Renukunta
Added support for PCI EEH(extended error handling).
Changes in V2:
Made local functions static
Removed call to aac_fib_free_tag
Set adapter_shutdown flag when PCI error detected
Signed-off-by: Raghava Aditya Renukunta
Reviewed-by: Tomas Henzl
---
drivers/scsi/
From: Raghava Aditya Renukunta
During EEH PCI hotplug activity kernel unloads and loads the driver,
causing character device to be unregistered(aac_remove_one).When the
driver is loaded back using aac_probe_one the character device needs
to be registered again for the AIF management tools to work
From: Raghava Aditya Renukunta
During EEH recovery number of online CPU's might change thereby changing
the number of MSIx vectors. Since each fib is allocated to a vector,
changes in the number of vectors causes fib to be sent thru invalid
vectors.In addition the correct number of MSIx vectors i
This patchset includes the following changes (bug fixes and
new feature support) specific to aacraid driver.
V2:
Removed aac_fib_free_tag function
Setup relevant fib variables only once
Created aac_fib_vector_assign function
Made EEH functions static
Added character device status macros
changed lo
From: Raghava Aditya Renukunta
The driver utilizes an array of atomic variables to keep track of
IO submissions to each vector. To submit an IO multiple threads
iterate through the array to find a vector which has empty slots
to send an IO. The reading and updating of the variable is not atomic,
From: Raghava Aditya Renukunta
Series 7 does not support PCI hot reset used by EEH.
Enabled fundamental reset only for Series 7
Changes in V2:
None
Signed-off-by: Raghava Aditya Renukunta
Reviewed-by: Johannes Thumshirn
---
drivers/scsi/aacraid/linit.c | 6 ++
1 file changed, 6 insertio
From: Raghava Aditya Renukunta
The method to allocate and free FIB's in the present code utilizes
spinlocks.Multiple IO's have to wait on the spinlock to acquire or
free fibs creating a performance bottleneck.
An alternative solution would be to use block layer tags to keep track
of the fibs all
Hello Martin,
> -Original Message-
> From: Martin K. Petersen [mailto:martin.peter...@oracle.com]
> Sent: Monday, January 4, 2016 6:08 PM
> To: Raghava Aditya Renukunta
> Cc: jbottom...@parallels.com; linux-scsi@vger.kernel.org; Mahesh
> Rajashekhara; Murthy Bhat; zzzSantosh Akula; Gana Sr
James Bottomley wrote:
> On Wed, 2016-01-06 at 09:24 +0100, Bart Van Assche wrote:
> > Instead of representing the states "visible in sysfs" and
> > "has been removed from the target list" by a single state
> > variable, use two variables to represent this information.
> >
> > This patch avoids th
> "KYS" == K Y Srinivasan writes:
The template discussion appears to have lost momentum and since the
concerns were minor I have applied your latest series to 4.5/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe lin
> "Paolo" == Paolo Bonzini writes:
>> This is v3 of the series to provide an "official" sg.h header (and
>> scsi_ioctl.h too, though it's basically obsolete) together with the
>> other userspace API definitions. The change from v2 to v3 is that
>> defaults for sg.c are not exported in includ
> "Wilfried" == Wilfried Weissmann writes:
Wilfried> add SGPIO support to Marvell 94xx
Applied to 4.5/scsi-queue.
Thanks!
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger
> "Colin" == Colin King writes:
Colin,
Colin> The return code and error return is incorrectly indented which
Colin> may cause some confusion as it appears at first sight to be
Colin> associated with a device not ready error (with missing { }
Colin> braces) rather than a DEV_IS_GONE() failure
Hi Mike,
On Tue, 2016-01-05 at 14:53 -0600, mchri...@redhat.com wrote:
> From: Mike Christie
>
> This patch has the target modules set the bio bi_op to a REQ_OP, and
> rq_flag_bits to bi_rw.
>
> This patch is compile tested only.
>
> Signed-off-by: Mike Christie
> ---
> drivers/target/target
On Wed, 2016-01-06 at 17:00 +, Himanshu Madhani wrote:
> Hi Nic,
>
>
> On 12/20/15, 10:57 PM, "Nicholas A. Bellinger" wrote:
>
> >Hi Himanshu & Co,
> >
> >On Thu, 2015-12-17 at 14:56 -0500, Himanshu Madhani wrote:
> >> Hi Nic,
> >>
> >> Please apply this series to target-pending at your ea
Return value of snprintf is not bound by size value, 2nd argument.
(https://www.kernel.org/doc/htmldocs/kernel-api/API-snprintf.html).
Return value is number of printed chars, can be larger than 2nd argument.
Therefore, it can write null byte out of bounds ofbuffer.
Since snprintf puts null, it doe
On Jan 6, 2016, at 7:53 AM, Insu Yun wrote:
>
> Return value of snprintf is not bound by size value, 2nd argument.
> (https://www.kernel.org/doc/htmldocs/kernel-api/API-snprintf.html).
> Return value is number of printed chars, can be larger than 2nd argument.
> Therefore, it can write null byte
Hi Nic,
On 12/20/15, 10:57 PM, "Nicholas A. Bellinger" wrote:
>Hi Himanshu & Co,
>
>On Thu, 2015-12-17 at 14:56 -0500, Himanshu Madhani wrote:
>> Hi Nic,
>>
>> Please apply this series to target-pending at your earliest convenience.
>>
>> changes from v1 -> v2
>>
>> o Added Reviewed-by tag f
Le Mon, 4 Jan 2016 12:22:34 +0200 (EET)
Kai Makisara écrivait:
> The patch has been tested with my DDS-4 drive.
Oh BTW, may be you could correct this one while you're at it :) I don't
think my kernel is so old... :)
~# mt -f /dev/st0 stshowopt
Your kernel (3.18.25) may be too old for this comma
Le Wed, 6 Jan 2016 17:10:15 +0100
Emmanuel Florac écrivait:
> Works OK with LTO-5 (HP). Sizing the partitions is quite difficult, as
> you can see. To get one "wrap" in the first partition, "140" and
> "1424000" work, but "145" doesn't. Same for LTO-6 (I'm still
> looking for the proper s
Le Mon, 4 Jan 2016 12:46:26 +0100
Emmanuel Florac écrivait:
> That works fine for me. I'm going to do some testing with other drives
> I have (LTO-3 -- should fail -- and LTO-5).
>
Works OK with LTO-5 (HP). Sizing the partitions is quite difficult, as
you can see. To get one "wrap" in the first
Le Wed, 6 Jan 2016 10:23:34 -0500 (EST)
Laurence Oberman écrivait:
> MaxPartitions: 0
>
> Drive is working fine,
>
> # mt -f /dev/st0 status
> SCSI 2 tape drive:
> File number=0, block number=0, partition=0.
> Tape block size 512 bytes. Density code 0x58 (no translation).
> Soft error count sin
On 01/05/2016 09:53 PM, mchri...@redhat.com wrote:
From: Mike Christie
This has callers of submit_bio/submit_bio_wait set the bio->bi_rw
instead of passing it in. This makes that use the same as
generic_make_request and how we set the other bio fields.
Reviewed-by: Bart Van Assche
--
To unsu
On Wed, 2016-01-06 at 09:24 +0100, Bart Van Assche wrote:
> Instead of representing the states "visible in sysfs" and
> "has been removed from the target list" by a single state
> variable, use two variables to represent this information.
>
> This patch avoids that SCSI device removal can trigger
Thanks Doug
Trying that now
Laurence Oberman
Principal Software Maintenance Engineer
Red Hat Global Support Services
- Original Message -
From: "Douglas Gilbert"
To: "Laurence Oberman" , "Emmanuel Florac"
Cc: "Laurence Oberman" , "Kai Makisara"
, linux-scsi@vger.kernel.org
Sent: Wedn
On 16-01-06 10:32 AM, Laurence Oberman wrote:
Firmware update fails as follows:
Still researching. This is the only LTO5 I have access to so unless Shane has
one I may not be able to make progress.
(Its way long out of warranty and support)
We mostly use this for generic st driver and changer
Firmware update fails as follows:
Still researching. This is the only LTO5 I have access to so unless Shane has
one I may not be able to make progress.
(Its way long out of warranty and support)
We mostly use this for generic st driver and changer testing for RHEL and it
has not been updated fo
I left the log of the failure to partition out
Here it is
# mt -f /dev/nst0 mkpartition 1
/dev/nst0: Input/output error
[ 5499.341648] st 0:0:0:0: [st0] Block limits 1 - 16777215 bytes.
[ 5499.342903] st 0:0:0:0: [st0] Mode sense. Length 11, medium 0, WBS 10, BLL 8
[ 5499.343523] st 0:0:0:0: [s
Hello Emanuel
I am using this device, its an Ultrium 5 (LTO5)
Its an older changer and I am unable to update the firmware, still working on
that.
What version of mt are you using, as I am testing using a RHEL7.2 base and the
upstream patched kernel.
Linux example.redhat.com 4.3.3 #1 SMP Tue Ja
Le Tue, 5 Jan 2016 16:55:04 -0500 (EST)
Laurence Oberman écrivait:
> mt -f /dev/nst0 mkpartition 1
>
What is the type of drive exactly? I still couldn't test with the LTO-5
drive as the machine it's connected to is being reinstalled.
--
---
Return value of snprintf is not bound by size value, 2nd argument.
(https://www.kernel.org/doc/htmldocs/kernel-api/API-snprintf.html).
Return value is number of printed chars, can be larger than 2nd argument.
Therefore, it can write null byte out of bounds ofbuffer.
Since snprintf puts null, it doe
Hi Hariprasad,
[auto build test ERROR on net-next/master]
url:
https://github.com/0day-ci/linux/commits/Hariprasad-Shenai/cxgb4-Add-LRO-infrastructure-for-cxgb4i-driver/20160106-203040
config: i386-allmodconfig (attached as .config)
reproduce:
# save the attached .config to linux
Hi Hariprasad,
[auto build test ERROR on net-next/master]
url:
https://github.com/0day-ci/linux/commits/Hariprasad-Shenai/cxgb4-Add-LRO-infrastructure-for-cxgb4i-driver/20160106-203040
config: i386-allmodconfig (attached as .config)
reproduce:
# save the attached .config to linux
Hi
This patch series adds LRO iscsi support for chelsio T4/T5 adapters.
This patch series has been created against net-next tree and includes
patches on cxgb4 and cxgb4i driver.
We have included all the maintainers of respective drivers. Kindly review
the change and let us know in case of any re
Signed-off-by: Karen Xie
Signed-off-by: Manoj Malviya
Signed-off-by: Hariprasad Shenai
---
drivers/scsi/cxgbi/cxgb4i/cxgb4i.c | 396 +++--
1 file changed, 382 insertions(+), 14 deletions(-)
diff --git a/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c
b/drivers/scsi/cxgbi/cx
Signed-off-by: Hariprasad Shenai
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 15 +-
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 40 ++---
drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.h | 5
drivers/net/ethernet/chelsio/cxgb4/sge.c| 10 +++
The skbs could contain both paritial pdus and multiple completed pdus.
Signed-off-by: Karen Xie
Signed-off-by: Manoj Malviya
Signed-off-by: Hariprasad Shenai
---
drivers/scsi/cxgbi/libcxgbi.c | 415 +-
drivers/scsi/cxgbi/libcxgbi.h | 4 +
2 files chang
Looks good,
Reviewed-by: Christoph Hellwig
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Instead of representing the states "visible in sysfs" and
"has been removed from the target list" by a single state
variable, use two variables to represent this information.
This patch avoids that SCSI device removal can trigger a
soft lockup.
See also:
* "scsi: restart list search after unlock
48 matches
Mail list logo
