> -Original Message-
> From: James Bottomley [mailto:james.bottom...@hansenpartnership.com]
> Sent: Friday, December 18, 2015 8:48 AM
> To: KY Srinivasan ; Hannes Reinecke ;
> gre...@linuxfoundation.org; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; oher...@suse.com;
> jbo
Three fixes this time, two in SES picked up by KASAN for various types
of buffer overrun. The first is a USB array which returns page 8
whatever is asked for and causes us to overrun with incorrect data
format assumptions and the second is an invalid iteration of page 10
(the additional informatio
Hi Don,
Did you see these comments I had from my review of this patch?
-matt
> On Dec 9, 2015, at 5:41 PM, Matthew R. Ochs wrote:
>
>> On Dec 9, 2015, at 3:18 PM, Don Brace wrote:
>
> No commit message?
You can disregard this one as I saw you added a message in v1.
>
>>
>> Reviewed-by:
> On Dec 15, 2015, at 9:25 AM, Don Brace wrote:
>
> On 12/09/2015 05:21 PM, Matthew R. Ochs wrote:
>>> On Dec 9, 2015, at 3:18 PM, Don Brace wrote:
>>>
>>> sas transport places devices on bus 0 but driver was setting
>>> the bus to 3.
>>>
>>> Reviewed-by: Justin Lindley
>>> Reviewed-by: Kevin
On Fri, 2015-12-18 at 09:49 +0100, Hannes Reinecke wrote:
> What I would like to see is a clear separation here:
> - Disable FC disk handling if FC attributes are not configured
> - Add a module parameter allowing to disable FC attributes even if
> they are compiled in. Remember: this is a virtual
> -Original Message-
> From: Hannes Reinecke [mailto:h...@suse.de]
> Sent: Friday, December 18, 2015 12:49 AM
> To: KY Srinivasan ; gre...@linuxfoundation.org; linux-
> ker...@vger.kernel.org; de...@linuxdriverproject.org; oher...@suse.com;
> jbottom...@parallels.com; h...@infradead.org;
We have to lock due to how we reserve a slot in the delivery queue.
We are looking to optimise this, but it's not straightforward.
Perf is a good strategy, but, to be honest, I have not spent a lot
of time looking at this so I'm looking for low hanging fruit initially.
FYI, our hardware does h
On Fri, 2015-12-18 at 16:20 +, KY Srinivasan wrote:
>
> > -Original Message-
> > From: Hannes Reinecke [mailto:h...@suse.de]
> > Sent: Friday, December 18, 2015 12:52 AM
> > To: KY Srinivasan ; gre...@linuxfoundation.org;
> > linux-
> > ker...@vger.kernel.org; de...@linuxdriverproject.
> -Original Message-
> From: Hannes Reinecke [mailto:h...@suse.de]
> Sent: Friday, December 18, 2015 12:52 AM
> To: KY Srinivasan ; gre...@linuxfoundation.org; linux-
> ker...@vger.kernel.org; de...@linuxdriverproject.org; oher...@suse.com;
> jbottom...@parallels.com; h...@infradead.org;
On 12/18/2015 04:36 PM, John Garry wrote:
On 18/12/2015 15:19, Bart Van Assche wrote:
On 12/18/2015 04:08 PM, Hannes Reinecke wrote:
On 12/18/2015 03:58 PM, John Garry wrote:
Hi,
I have started to enable scsi-mq on the HiSilicon SAS driver.
Are there hints/checks I should use to make sure it
On 18/12/2015 15:19, Bart Van Assche wrote:
On 12/18/2015 04:08 PM, Hannes Reinecke wrote:
On 12/18/2015 03:58 PM, John Garry wrote:
Hi,
I have started to enable scsi-mq on the HiSilicon SAS driver.
Are there hints/checks I should use to make sure it is configured
correctly/optimally? In my i
On 12/18/2015 04:08 PM, Hannes Reinecke wrote:
On 12/18/2015 03:58 PM, John Garry wrote:
Hi,
I have started to enable scsi-mq on the HiSilicon SAS driver.
Are there hints/checks I should use to make sure it is configured
correctly/optimally? In my initial testing I have seen some
performance i
Hi,
I have started to enable scsi-mq on the HiSilicon SAS driver.
Are there hints/checks I should use to make sure it is configured
correctly/optimally? In my initial testing I have seen some performance
improvements, but none like what I have seen in presentations.
Cheers,
John
--
To unsu
On 12/18/2015 03:58 PM, John Garry wrote:
Hi,
I have started to enable scsi-mq on the HiSilicon SAS driver.
Are there hints/checks I should use to make sure it is configured
correctly/optimally? In my initial testing I have seen some
performance improvements, but none like what I have seen in
p
Hi Sumit,
[auto build test WARNING on scsi/for-next]
[also build test WARNING on v4.4-rc5 next-20151218]
url:
https://github.com/0day-ci/linux/commits/Sumit-Saxena/megaraid_sas-Do-not-allow-PCI-access-during-OCR/20151218-213231
base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb
drivers/scsi/megaraid/megaraid_sas_fusion.c:331:20-27: WARNING: kzalloc should
be used for fusion -> cmd_list, instead of kmalloc/memset
drivers/scsi/megaraid/megaraid_sas_fusion.c:342:24-31: WARNING: kzalloc should
be used for fusion -> cmd_list [ i ], instead of kmalloc/memset
Use kzalloc ra
On Fri, Dec 18, 2015 at 06:57:08PM +0530, Sumit Saxena wrote:
> This patch will add support for drive ordering for a particular set of device
> ID (0x005D, 0x005F) & subsystem vendor ID(0x1028).
This really has no business in Linux. Everyone should be using uuid
based disk addressing if they ca
Sumit Saxena (15):
megaraid_sas: Do not allow PCI access during OCR
megaraid_sas: MFI IO timeout handling
megaraid_sas: Syncing request flags macro names with firmware
megaraid_sas: Task management support
megaraid_sas: Update device Queue depth based on interface type
megaraid_sas: Fas
This patch will add support for drive ordering for a particular set of device
ID (0x005D, 0x005F) & subsystem vendor ID(0x1028).
The driver sends down MR_DCMD_CTRL_BIOS_DATA_GET to obtain information about
the boot drive and calculates the target ID & Channel ID.
Instead of invoking scsi_scan_h
This patch will do some fixes in OCR path of SRIOV enabled series of Avago
controllers.
1)Removing late detection HB.
2)Change in the behavior if the FW found in READY/OPERAETIONAL state.
Signed-off-by: Uday Lingala
Signed-off-by: Sumit Saxena
---
drivers/scsi/megaraid/megaraid_sas_fusion.c
This patch will add support for Dual Queue depth reported by firmware.
Below are key points-
1. For iMR controllers, firmware will report two queue depths- 1. Controller
wide Queue depth 2. LDIO Queue depth(240).
Ofcourse, Controller wide Queue depth will be greater among two. Using this new
me
This patch will introduce module-parameter for SCSI command timeout value and
fix setting of resetwaitime beyond a value.
Signed-off-by: Kashyap Desai
Signed-off-by: Sumit Saxena
---
drivers/scsi/megaraid/megaraid_sas_base.c | 15 ---
drivers/scsi/megaraid/megaraid_sas_fusion.c
This patch will add capability in driver to tell firmware that it can throttle
IOs in case Controller's Queue depth is downgraded post OFU
(Online firmware upgrade). This feature will ensure firmware can be downgraded
from higher queue depth to lower queue depth without needing system reboot.
Add
Firmware will fill per LD data to tell driver that particular LD supports
Region lock bypass or not. If yes, then
Driver will send non FP LDIO to region lock bypass FIFO. With this change in
driver, firmware will optimize certain
code to improve performance.
Signed-off-by: Kashyap Desai
Signed
This patch will create reply queue pool for each MSI-x index and will provide
array of all reply queue base address
instead of single base address of legacy mode. Using this new interface Driver
can support higher Queue depth allocating
more reply queue as scattered DMA pool.
If array mode is n
Make instance->adprecovery variable atomic and removes hba_lock spinlock while
accessing instance->adprecovery.
Signed-off-by: Sumit Saxena
Signed-off-by: Kashyap Desai
---
drivers/scsi/megaraid/megaraid_sas.h|2 +-
drivers/scsi/megaraid/megaraid_sas_base.c | 95 ++-
Optimized MFI adapters' OCR path, particularly megasas_wait_for_outstanding()
function.
Signed-off-by: Kashyap Desai
Signed-off-by: Sumit Saxena
---
drivers/scsi/megaraid/megaraid_sas_base.c | 104 +++--
1 files changed, 54 insertions(+), 50 deletions(-)
diff --git a/
build_and_issue_cmd should return SCSI_MLQUEUE_HOST_BUSY for few error case
instead of returning 1.
Signed-off-by: Sumit Saxena
---
drivers/scsi/megaraid/megaraid_sas_base.c |9 ++---
drivers/scsi/megaraid/megaraid_sas_fusion.c |4 ++--
2 files changed, 4 insertions(+), 9 deletion
This patch will add task management(TM) support for SCSI commands in
megaraid_sas driver.
Added TM functions are below-
1)Task abort
2)Target reset
Below are few key points-
1. Currently, megaraid_sas driver performs Controller reset when any IO times
out.
With these TM support added in driver,
Signed-off-by: Sumit Saxena
---
drivers/scsi/megaraid/megaraid_sas_fusion.c |6 +++---
drivers/scsi/megaraid/megaraid_sas_fusion.h |3 ++-
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c
b/drivers/scsi/megaraid/megaraid_sas_fusio
This patch will update device Queue depth based on interface type(SAS, SATA..)
for sysPDs.
For Virtual disks(VDs), there will be no change in queue depth(will remain 256).
To fetch interface type(SAS or SATA or FC..) of syspD, driver will send DCMD
MR_DCMD_PD_GET_INFO per sysPD.
Signed-off-by: S
This patch will do proper error handling for DCMD timeout and failed cases for
fusion adapters.
Below are few key design points-
1. For MFI adapters, in case of DCMD timeout(DCMD which must return SUCCESS)
driver will call kill adapter.
2. What action needs to be taken in case of DCMD timeout is
This patch will do synhronization between OCR function and AEN function using
"reset_mutex" lock.
reset_mutex will be acquire only in first half of the AEN function which issue
DCMD. Second half
of the function calls SCSI API (scsi_add_device/scsi_remove_device) should be
out of reset_mutex
to a
Hello Nick,
should these patches be included in 4.1.x LTS series too?:
Nicholas Bellinger (2):
iscsi-target: Fix rx_login_comp hang after login failure
target: Fix race for SCF_COMPARE_AND_WRITE_POST checking
They are marked as #v3.10+ and #v3.12+ but I still don't see them in 4.1.15.
Thank
On 12/08/2015 03:08 PM, Ewan D. Milne wrote:
From: "Ewan D. Milne"
The klist traversal used by the reading of /proc/scsi/scsi is not interlocked
against device removal. It takes a reference on the containing object, but
this does not prevent the device from being removed from the list. Thus,
On 12/08/2015 03:08 PM, Ewan D. Milne wrote:
From: "Ewan D. Milne"
This prevents crashing due to accessing a removed element on the list,
the iterator will now hold the correct reference. It was not sufficient
to rely on the klist's reference on the containing device object.
From a patch ori
On 12/15/2015 04:54 PM, Jitendra Bhivare wrote:
From: Jitendra
Null pointer dereference in shutdown path after taking dump.
Shutdown path is not needed as FW comes up clean every time during probe
after issuing FUNCTION reset MBOX command.
Signed-off-by: Jitendra
---
drivers/scsi/be2iscsi/
On 12/08/2015 03:08 PM, Ewan D. Milne wrote:
From: "Ewan D. Milne"
These functions are needed to expose an iterator for SCSI usage.
From a patch originally developed by David Jeffery
Signed-off-by: Ewan D. Milne
---
drivers/base/bus.c | 59
On 12/15/2015 04:55 PM, Jitendra Bhivare wrote:
From: Jitendra
System crash in I+T card personality
Fix to add validation for ULP in initiator mode, physical port number,
and supported queue, icd, cid counts.
Signed-off-by: Jitendra
---
drivers/scsi/be2iscsi/be_main.c |2 +-
drivers/s
On 12/15/2015 04:55 PM, Jitendra Bhivare wrote:
From: Jitendra
Log messages for misconfigured transceivers reported by FW.
Register async events that driver handles using MCC_CREATE_EXT ioctl.
Errors messages for faulted/uncertified/unqualified optics are logged.
Added IOCTL to get port_name t
On 11/13/2015 11:43 AM, Wilfried Weissmann wrote:
add SGPIO support to Marvell 94xx
Signed-off-by: Wilfried Weissmann
---
drivers/scsi/mvsas/mv_94xx.c | 134 +
drivers/scsi/mvsas/mv_94xx.h | 71 +
drivers/scsi/mvsas/mv_init.c |2
driv
On 12/15/2015 04:57 PM, Don Brace wrote:
These patches are based on Linus's tree
The changes are:
- correct missing changes from snprintf to scnprintf
in path_info_show by Rasmus Villemoes
- fix reported bus for SAS transport devices
- add in enclosure information
Changes from initial
Hi Jitendra,
On 12/15/2015 04:54 PM, Jitendra Bhivare wrote:
From: Jitendra
This patch is generated against for-next branch.
Jitendra (15):
be2iscsi: Fix soft lockup in mgmt_get_all_if_id path using bmbx
be2iscsi: Fix mbox synchronization replacing spinlock with mutex
be2iscsi: Fix t
On 12/15/2015 04:55 PM, Jitendra Bhivare wrote:
From: Jitendra
Async link event provides port_speed info. Use the same to report in
ISCSI_HOST_PARAM_PORT_SPEED query. Removed link status query IOCTL used
to do the same.
25G and 40G are defined in kernel enum iscsi_port_speed.
Fixed get_nic_co
On 12/15/2015 04:55 PM, Jitendra Bhivare wrote:
From: Jitendra
Login/Logout loop was hanging after few hours. /var/log/message showed
that alloc_wrb_handle() function was not able to allocate any new WRB.
Sep 11 11:25:22 Jhelum10 kernel: connection32513:0: Could not send nopout
Sep 11 11:25:22
On 12/15/2015 04:55 PM, Jitendra Bhivare wrote:
From: Jitendra
Driver version: 11.0.0.0
Signed-off-by: Jitendra
---
drivers/scsi/be2iscsi/be_main.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/be2iscsi/be_main.h b/drivers/scsi/be2iscsi/be_main.h
in
On 12/15/2015 04:55 PM, Jitendra Bhivare wrote:
From: Jitendra
OS not responding when running 2 port traffic on 72 CPUs system.
be2iscsi IRQs gets affined to CPU0 when irqbalancer is disabled.
be_iopoll processing completions in BLOCK_IOPOLL_SOFTIRQ hogged CPU0.
1. Use budget to exit the poll
On 12/15/2015 04:55 PM, Jitendra Bhivare wrote:
From: Jitendra
Change return value of completed MCC EBUSY to EINVAL.
Signed-off-by: Jitendra
---
drivers/scsi/be2iscsi/be_cmds.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/be2iscsi/be_cmds.c b/drive
On 12/15/2015 04:54 PM, Jitendra Bhivare wrote:
From: Jitendra
Configuring VLAN parameters through IPv6 interface was not supported in driver.
Signed-off-by: Jitendra
---
drivers/scsi/be2iscsi/be_iscsi.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/sc
On 12/15/2015 04:54 PM, Jitendra Bhivare wrote:
From: Jitendra
Use of mutex_lock_interruptible can return -EINTR, handle and log
the error.
Signed-off-by: Jitendra
---
drivers/scsi/be2iscsi/be_iscsi.c |7 ---
drivers/scsi/be2iscsi/be_mgmt.c | 10 ++
2 files changed, 10
On 12/15/2015 04:54 PM, Jitendra Bhivare wrote:
From: Jitendra
FW recommended timeout for all mbox command is 30s.
Use msleep instead mdelay to relinquish CPU when polling for
mbox completion.
Signed-off-by: Jitendra
---
drivers/scsi/be2iscsi/be_cmds.c |5 +++--
1 files changed, 3 inse
On 12/15/2015 04:54 PM, Jitendra Bhivare wrote:
From: Jitendra
alloc_mcc_tag/free_mcc_tag is now done under mcc_lock spin_lock
Signed-off-by: Jitendra
---
drivers/scsi/be2iscsi/be_cmds.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
Reviewed-by: Hannes Reinecke
Cheers
On 12/15/2015 04:54 PM, Jitendra Bhivare wrote:
From: Jitendra
Replace lock based tag_state manipulations with atomic operations.
Signed-off-by: Jitendra
---
drivers/scsi/be2iscsi/be.h |2 +-
drivers/scsi/be2iscsi/be_cmds.c | 26 --
2 files changed, 13 i
On 12/15/2015 04:54 PM, Jitendra Bhivare wrote:
From: Jitendra
We are taking mbox_lock spinlock which disables pre-emption before we poll
for mbox completion. Waiting there with spinlock held in excess of 20s will
cause soft lockup.
Actual fix is to change mbox_lock to mutex.
The changes are d
On 12/15/2015 04:54 PM, Jitendra Bhivare wrote:
From: Jitendra
This is second part of actual fix for soft lockup.
All mbox cmds issued using BMBX and MCC are synchronized using mutex
mbox_lock instead of spin_lock. Used mutex_lock_interruptible where
ever possible.
Signed-off-by: Jitendra
--
On 12/13/2015 09:28 PM, K. Y. Srinivasan wrote:
For FC devices managed by this driver, atttach the appropriate transport
template. This will allow us to create the appropriate sysfs files for
these devices. With this we can publish the wwn for both the port and the node.
Signed-off-by: K. Y. Sri
On 12/13/2015 09:28 PM, K. Y. Srinivasan wrote:
The function storvsc_channel_init() repeatedly interacts with the host to
extract various channel properties. Refactor this code to eliminate code
repetition.
Signed-off-by: K. Y. Srinivasan
Reviewed-by: Long Li
Reviewed-by: Johannes Thumshirn
T
On 12/13/2015 09:28 PM, K. Y. Srinivasan wrote:
On the interrupt path, we repeatedly establish the pointer to the
storvsc_device. Fix this.
Signed-off-by: K. Y. Srinivasan
Reviewed-by: Long Li
Reviewed-by: Johannes Thumshirn
Tested-by: Alex Ng
---
drivers/scsi/storvsc_drv.c | 23
On 12/13/2015 09:28 PM, K. Y. Srinivasan wrote:
The hv_fc_wwn_packet is exchanged over vmbus. Make the definition in Linux match
the Window's definition.
Signed-off-by: K. Y. Srinivasan
Reviewed-by: Johannes Thumshirn
Reviewed-by: Long Li
Tested-by: Alex Ng
---
drivers/scsi/storvsc_drv.c |
59 matches
Mail list logo
