Re: [RFC PATCH] lpfc: Add lockdep assertions

On 11/20/2015 01:37 PM, Johannes Thumshirn wrote: Several functions in lpfc have comments stating that the function must be called with the hbalock (or hostlock, or ringlock) held. Add lockdep_assert_held() annotations to these functions, so one can actually verify the locks are held. [ ... ] @

RE: [PATCH 3/3] block: Export max_dev_sectors_kb in sysfs

> -Original Message- > From: linux-block-ow...@vger.kernel.org [mailto:linux-block- > ow...@vger.kernel.org] On Behalf Of Martin K. Petersen > Sent: Wednesday, December 16, 2015 4:54 PM > To: linux-scsi@vger.kernel.org; linux-bl...@vger.kernel.org > Cc: Martin K. Petersen > Subject: [PAT

Re: [PATCH v2] hisi_sas: use platform_get_irq()

> "John" == John Garry writes: John> It is preferred that drivers use platform_get_irq() instead of John> irq_of_parse_and_map(), so replace. Applied to 4.5/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-sc

Re: [patch] qla2xxx: fix a timeout loop

Hi Dan, On 12/16/15, 3:07 AM, "linux-scsi-ow...@vger.kernel.org on behalf of Dan Carpenter" wrote: >After the loop we test for "if (!retries) " as a failure, but actually >the post-op here will end with retries set to -1. I have fixed this by >using a pre-op instead. > >Fixes: 7ec0effd30bb ('

Re: [PATCH 2/3] sd: Reject optimal transfer length smaller than page size

On 15-12-16 05:53 PM, Martin K. Petersen wrote: Eryu Guan reported that loading scsi_debug would fail. This turned out to be caused by scsi_debug reporting an optimal I/O size of 32KB which is smaller than the 64KB page size on the PowerPC system in question. Add a check to ensure that we only u

Note to driver maintainers

When somebody posts a patch to a piece of code you maintain it is your responsibility to respond to it. That's what being a maintainer means. There are a ton of trivial/Coccinelle fixes posted that nobody has done anything about. I'm not talking about spelling fixes or whitespace churn. Many of t

Re: [PATCH 16/17] lpfc: Use kzalloc instead of kmalloc

Reviewed-by: Matthew R. Ochs -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC PATCH] lpfc: Add lockdep assertions

Johannes, Thank you for the time and effort on the patch. At this time, as it doesn't functionally change anything, I did not include the patch. I will consider it if we see additional issues it can help resolve. -- james s On 11/20/2015 4:37 AM, Johannes Thumshirn wrote: Several functions

Re: [PATCH v2 1/2] scsi: lpfc: Use kzalloc instead of kmalloc

fyi - this patch was just pushed in our 11.0.0.10 patch set - patch 16/17 -- james s On 10/24/2015 8:25 PM, Matthew R. Ochs wrote: On Oct 24, 2015, at 2:06 AM, Punit Vara wrote: This patch is to the lpfc_els.c which resolves following warning reported by coccicheck: WARNING: kzalloc should

Re: [PATCH v2] lpfc: replaced kmalloc + memset with kzalloc

fyi - this patch was just pushed in our 11.0.0.10 patch set - patch 16/17 Note: Patch 16 contains the exact same patch submitted by Punit Vara. I posted Punit's change only as it arrived earlier. -- james s On 11/18/2015 11:34 PM, Saurabh Sengar wrote: replacing kmalloc and memset by a sin

Re: [PATCH] SCSI-lpfc: Delete unnecessary checks before the function call "mempool_destroy"

fyi - this patch was just pushed in our 11.0.0.10 patch set - patch 15/17 -- james s On 11/17/2015 12:44 AM, SF Markus Elfring wrote: From: Markus Elfring Date: Tue, 17 Nov 2015 09:34:27 +0100 The mempool_destroy() function tests whether its argument is NULL and then returns immediately. Thu

Re: [PATCH 1/3] scsi_debug: Increase the reported optimal transfer length

On 15-12-16 05:53 PM, Martin K. Petersen wrote: The OPTIMAL TRANSFER LENGTH reported by scsi_debug is 64 blocks which translates to 32KB with the default logical block size. That's much lower than what real storage devices typically report (256KB to 1MB). Bump the optimal transfer length to 1024

[PATCH 05/17] lpfc: Fix driver crash when module parameter lpfc_fcp_io_channel set to 16

Fix driver crash when module parameter lpfc_fcp_io_channel set to 16 Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_init.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init

[PATCH 16/17] lpfc: Use kzalloc instead of kmalloc

From: Punit Vara This patch is to the lpfc_els.c which resolves following warning reported by coccicheck: WARNING: kzalloc should be used for rdp_context, instead of kmalloc/memset Signed-off-by: Punit Vara Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_els.c | 3 +-- 1 file change

[PATCH 08/17] lpfc: Fix RDP Speed reporting.

Fix RDP Speed reporting. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_els.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c index 3394648..f7a2967 100644 ---

[PATCH 00/17] lpfc: Update to revision 11.0.0.10

This patch set updates the lpfc driver to revision 11.0.0.10 The patches were cut against scsi-misc James Smart (17): Fix FCF Infinite loop in lpfc_sli4_fcf_rr_next_index_get. Fix the FLOGI discovery logic to comply with T11 standards Added throttle logging support. Fix RegLogin failed e

[PATCH 06/17] lpfc: Fix crash in fcp command completion path.

Fix crash in fcp command completion path. Missed null check. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_scsi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c index d51

[PATCH 01/17] lpfc: Fix FCF Infinite loop in lpfc_sli4_fcf_rr_next_index_get.

Fix FCF Infinite loop in lpfc_sli4_fcf_rr_next_index_get. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_sli.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c index f9585c

[PATCH 10/17] lpfc: Make write check error processing more resilient

Make write check error processing more resilient. Checks to catch writes that fw reports weren't fully complete yet SCSI status indicated fine needed correction. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_scsi.c | 27 +-- 1 file c

[PATCH 17/17] lpfc: Update version to 11.0.0.10 for upstream patch set

Update version to 11.0.0.10 for upstream patch set Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_version.h b/drivers/scsi/lpfc/lpfc_version.h index ea53aa6..

[PATCH 03/17] lpfc: Added throttle logging support.

Implemented a throttle on error logging. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc.h | 5 +++ drivers/scsi/lpfc/lpfc_attr.c| 18 +++ drivers/scsi/lpfc/lpfc_crtn.h| 1 + drivers/scsi/lpfc/lpfc_disc.h| 11 +++ drivers/scsi

[PATCH 13/17] lpfc: Fix external loopback failure.

Fix external loopback failure. Rx sequence reassembly was incorrect. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_sli.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lp

[PATCH 11/17] lpfc: Use new FDMI speed definitions for 10G, 25G and 40G FCoE.

Use new FDMI speed definitions for 10G, 25G and 40G FCoE. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_attr.c| 2 +- drivers/scsi/lpfc/lpfc_ct.c | 146 ++- drivers/scsi/lpfc/lpfc_els.c | 3 + drivers/scsi

[PATCH 09/17] lpfc: Fix RDP ACC being too long.

Fix RDP ACC being too long. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_els.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c index f7a2967..817cdfc 100644 --- a/drivers/scsi/lpfc/

[PATCH 15/17] lpfc: Delete unnecessary checks before the function call "mempool_destroy"

From: Markus Elfring The mempool_destroy() function tests whether its argument is NULL and then returns immediately. Thus the test around the calls is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: James Smart --- drivers/s

[PATCH 07/17] lpfc: Modularize and cleanup FDMI code in driver

Modularize, cleanup, add comments - for FDMI code in driver Note: I don't like the comments with leading # - but as we have a lot if present, I'm deferring to handle it in one big fix later. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc.h | 16 +-

[PATCH 04/17] lpfc: Fix RegLogin failed error seen on Lancer FC during port bounce

Fix RegLogin failed error seen on Lancer FC during port bounce Fix the statemachine and ref counting. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_els.c | 14 +- drivers/scsi/lpfc/lpfc_hbadisc.c | 8 drivers/scsi/lpfc/lpfc_npo

[PATCH 12/17] lpfc: Fix mbox reuse in PLOGI completion

Fix mbox reuse in PLOGI completion. Moved allocations so that buffer properly init'd. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_nportdisc.c | 31 +-- 1 file changed, 21 insertions(+), 10 deletions(-) diff --git a/drivers/scsi

[PATCH 14/17] lpfc: Add logging for misconfigured optics.

Add logging for misconfigured optics acqe reported by fw. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_hw4.h | 51 drivers/scsi/lpfc/lpfc_init.c | 67 ++- drivers/scsi/lpfc/lpfc_sli4.

[PATCH 02/17] lpfc: Fix the FLOGI discovery logic to comply with T11 standards

Fix the FLOGI discovery logic to comply with T11 standards We weren't properly setting fabric parameters, such as R_A_TOV and E_D_TOV, when we registered the vfi object in default configs and pt2pt configs. Revise to now pass service params with the values to the firmware and ensure they are rese

[PATCH 2/3] sd: Reject optimal transfer length smaller than page size

Eryu Guan reported that loading scsi_debug would fail. This turned out to be caused by scsi_debug reporting an optimal I/O size of 32KB which is smaller than the 64KB page size on the PowerPC system in question. Add a check to ensure that we only use the device-reported OPTIMAL TRANSFER LENGTH if

[PATCH 1/3] scsi_debug: Increase the reported optimal transfer length

The OPTIMAL TRANSFER LENGTH reported by scsi_debug is 64 blocks which translates to 32KB with the default logical block size. That's much lower than what real storage devices typically report (256KB to 1MB). Bump the optimal transfer length to 1024 blocks. Signed-off-by: Martin K. Petersen ---

[PATCH 3/3] block: Export max_dev_sectors_kb in sysfs

Some storage devices report a maximum transfer length which indicates the maximum size of an I/O request that the device can process. This limit is enforced in combination with the controller's max_hw_sectors and DMA constraints to ensure that we do not issue a command too big for the device. Expo

Re: [patch] qla2xxx: fix a timeout loop

> "Dan" == Dan Carpenter writes: Dan> After the loop we test for "if (!retries) " as a failure, but Dan> actually the post-op here will end with retries set to -1. I have Dan> fixed this by using a pre-op instead. Applied to 4.4/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineer

Re: [patch] qla2xxx: fix a timeout loop

On Wed, Dec 16, 2015 at 02:07:46PM +0300, Dan Carpenter wrote: > After the loop we test for "if (!retries) " as a failure, but actually > the post-op here will end with retries set to -1. I have fixed this by > using a pre-op instead. > > Fixes: 7ec0effd30bb ('[SCSI] qla2xxx: Add support for ISP8

[patch] qla2xxx: fix a timeout loop

After the loop we test for "if (!retries) " as a failure, but actually the post-op here will end with retries set to -1. I have fixed this by using a pre-op instead. Fixes: 7ec0effd30bb ('[SCSI] qla2xxx: Add support for ISP8044.') Signed-off-by: Dan Carpenter diff --git a/drivers/scsi/qla2xxx/q