Hi Srinivasan,
[auto build test ERROR on scsi/for-next]
[also build test ERROR on v4.4-rc4 next-20151211]
url:
https://github.com/0day-ci/linux/commits/K-Y-Srinivasan/scsi-storvsc-Properly-support-FC-hosts/20151213-042209
base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git f
Hi Raghava,
[auto build test ERROR on scsi/for-next]
[also build test ERROR on v4.4-rc4 next-20151211]
url:
https://github.com/0day-ci/linux/commits/Raghava-Aditya-Renukunta/aacraid-Patchset-for-aacraid-driver-version-41052/20151211-094405
base: https://git.kernel.org/pub/scm/linux/kernel/g
Hi Srinivasan,
[auto build test ERROR on scsi/for-next]
[also build test ERROR on v4.4-rc4 next-20151211]
url:
https://github.com/0day-ci/linux/commits/K-Y-Srinivasan/scsi-storvsc-Properly-support-FC-hosts/20151213-042209
base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git f
>> @@ -127,9 +127,8 @@ static struct iscsi_param
>> *iscsi_set_default_param(struct iscsi_param_list *para
>> char *name, char *value, u8 phase, u8 scope, u8 sender,
>> u16 type_range, u8 use)
>> {
>> -struct iscsi_param *param = NULL;
>> +struct iscsi_param *par
On the interrupt path, we repeatedly establish the pointer to the
storvsc_device. Fix this.
Signed-off-by: K. Y. Srinivasan
Reviewed-by: Long Li
Reviewed-by: Johannes Thumshirn
Tested-by: Alex Ng
---
drivers/scsi/storvsc_drv.c | 23 ---
1 files changed, 8 insertions(+),
The function storvsc_channel_init() repeatedly interacts with the host to
extract various channel properties. Refactor this code to eliminate code
repetition.
Signed-off-by: K. Y. Srinivasan
Reviewed-by: Long Li
Reviewed-by: Johannes Thumshirn
Tested-by: Alex Ng
---
V2: Fixed error pat
For FC devices managed by this driver, atttach the appropriate transport
template. This will allow us to create the appropriate sysfs files for
these devices. With this we can publish the wwn for both the port and the node.
Signed-off-by: K. Y. Srinivasan
Reviewed-by: Long Li
Tested-by: Alex Ng
The hv_fc_wwn_packet is exchanged over vmbus. Make the definition in Linux match
the Window's definition.
Signed-off-by: K. Y. Srinivasan
Reviewed-by: Johannes Thumshirn
Reviewed-by: Long Li
Tested-by: Alex Ng
---
drivers/scsi/storvsc_drv.c |5 ++---
1 files changed, 2 insertions(+), 3 de
Properly support FC hosts. Additional cleanup patches are also
included.
In this version I have adddressed comments from
Dan Carpenter and
from Johannes Thumshirn .
K. Y. Srinivasan (4):
scsi: storvsc: Fix a bug in the layout of the hv_fc_wwn_packet
scsi: storvsc: Properly support Fibre Chan
On Sat, Dec 12, 2015 at 03:34:50PM +0100, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Sat, 12 Dec 2015 11:36:02 +0100
>
> Omit the unnecessary setting to a null pointer for the variable "param"
> at the beginning of the function "iscsi_set_default_param"
> because it can be directly i
Am 12.12.2015 15:45, schrieb SF Markus Elfring:
> From: Markus Elfring
> Date: Sat, 12 Dec 2015 15:04:57 +0100
>
> The variable "acceptor_values" and "proposer_values" were initialized
> by null pointers and immediately assigned values from input parameters
> by separate statements.
> Let us ex
>> @@ -200,9 +200,8 @@ free_param:
>> int iscsi_create_default_params(struct iscsi_param_list **param_list_ptr)
>> {
>> struct iscsi_param *param;
>> -struct iscsi_param_list *pl;
>> +struct iscsi_param_list *pl = kzalloc(sizeof(*pl), GFP_KERNEL);
>>
>> -pl = kzalloc(sizeof(struc
On Sat, 12 Dec 2015, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Sat, 12 Dec 2015 13:44:06 +0100
>
> The variable "pl" was declared and immediately assigned a return value
> from a function call in a separate statement.
>
> * Let us express the desired variable initialisation direct
From: Markus Elfring
Date: Sat, 12 Dec 2015 15:04:57 +0100
The variable "acceptor_values" and "proposer_values" were initialized
by null pointers and immediately assigned values from input parameters
by separate statements.
Let us express the desired variable initialisations directly.
Signed-off
From: Markus Elfring
Date: Sat, 12 Dec 2015 14:34:26 +0100
The variables "tmp1" and "tmp2" will eventually be set to appropriate
pointers from a call of the strchr() function.
Thus let us omit the explicit initialisation at the beginning.
Signed-off-by: Markus Elfring
---
drivers/target/iscsi/
From: Markus Elfring
Date: Sat, 12 Dec 2015 14:12:50 +0100
This issue was detected by using the Coccinelle software.
Choose a jump label according to the current Linux coding style convention.
Signed-off-by: Markus Elfring
---
drivers/target/iscsi/iscsi_target_parameters.c | 64 +-
From: Markus Elfring
Date: Sat, 12 Dec 2015 13:44:06 +0100
The variable "pl" was declared and immediately assigned a return value
from a function call in a separate statement.
* Let us express the desired variable initialisation directly.
* Avoid the repetition of the data type specification fo
From: Markus Elfring
Date: Sat, 12 Dec 2015 13:20:08 +0100
The variable "param" will eventually be set to an appropriate pointer
from a call of the iscsi_set_default_param() function.
Thus let us omit the explicit initialisation at the beginning.
Signed-off-by: Markus Elfring
---
drivers/targe
From: Markus Elfring
Date: Sat, 12 Dec 2015 12:50:10 +0100
This issue was detected by using the Coccinelle software.
A sanity check would be performed by the iscsi_set_default_param() function
even if it is known already that the passed variable contained
a null pointer.
* This implementation d
From: Markus Elfring
Date: Sat, 12 Dec 2015 11:36:02 +0100
Omit the unnecessary setting to a null pointer for the variable "param"
at the beginning of the function "iscsi_set_default_param"
because it can be directly initialized with the return value
from the function "kzalloc".
Signed-off-by: M
From: Markus Elfring
Date: Sat, 12 Dec 2015 15:25:20 +0100
Some update suggestions were taken into account from static
source code analysis.
Markus Elfring (7):
Use a variable initialisation in iscsi_set_default_param() directly
Less checks in iscsi_set_default_param() after error detection
On Fri, Dec 11, 2015 at 12:59:01PM -0500, Doug Ledford wrote:
> On 12/11/2015 09:22 AM, Christoph Hellwig wrote:
> > Hi Bart,
> >
> > thanks for all the reviews. I've updated the git branch with your
> > suggestions and reviewed-by tags. I'm going to wait a little bit
> > longer for other review
22 matches
Mail list logo
