Re: [PATCH 1/2]Revert "SCSI: Fix NULL pointer dereference in runtime PM"

2015-11-26 Thread Xue, Ken
On 四, 2015-09-10 at 10:23 +0800, Ken Xue wrote: Can someone help to apply this patch series? Thanks. http://marc.info/?l=linux-scsi&m=144185206825609&w=2 http://marc.info/?l=linux-scsi&m=144185208525611&w=2 > Revert "SCSI: Fix NULL pointer dereference in runtime PM" > > This reverts commit 4971

Re: [PATCH 2/3] arcmsr: Split dma resource allocation to a new function

2015-11-26 Thread Ching Huang
On Thu, 2015-11-26 at 11:46 -0800, Joe Perches wrote: > On Thu, 2015-11-26 at 19:41 +0800, Ching Huang wrote: > > split dma resource allocation and io register assignment from get_config to > > a new function arcmsr_alloc_io_queue. > > trivia: > > > diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c

Re: [PATCH 22/71] ncr5380: Eliminate selecting state

2015-11-26 Thread Finn Thain
On Thu, 26 Nov 2015, Ondrej Zary wrote: > > [ 156.014234] scsi host2: Generic NCR5380/NCR53C400 SCSI, io_port 0x0, > n_io_port 0, base 0xd8000, irq 0, can_queue 16, cmd_per_lun 2, sg_tablesize > 128, this_id 7, flags { NO_DMA_FIXUP }, options { AUTOPROBE_IRQ PSEUDO_DMA } > [ 156.020369] scsi

Re: [PATCH 2/3] arcmsr: Split dma resource allocation to a new function

2015-11-26 Thread Joe Perches
On Thu, 2015-11-26 at 19:41 +0800, Ching Huang wrote: > split dma resource allocation and io register assignment from get_config to a > new function arcmsr_alloc_io_queue. trivia: > diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c > b/drivers/scsi/arcmsr/arcmsr_hba.c [] > +static bool arcmsr_alloc

Re: [PATCH 22/71] ncr5380: Eliminate selecting state

2015-11-26 Thread Ondrej Zary
On Thursday 26 November 2015 11:23:01 Finn Thain wrote: > > On Wed, 25 Nov 2015, Ondrej Zary wrote: > > > On Wednesday 25 November 2015 04:17:09 Finn Thain wrote: > > > > > > On Tue, 24 Nov 2015, Ondrej Zary wrote: > > > > > > > > > > > Bisecting slow module initialization pointed to this comm

[PATCH v1 1/1] scsi_debug: check for bigger value first

2015-11-26 Thread Andy Shevchenko
From: Andy Shevchenko Even for signed types we have to check for bigger positive value first. Otherwise it will be never happened. Acked-by: Douglas Gilbert Signed-off-by: Andy Shevchenko --- drivers/scsi/scsi_debug.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/d

Re: block: Always check queue limits for cloned requests

2015-11-26 Thread Mike Snitzer
On Thu, Nov 26 2015 at 2:46am -0500, Hannes Reinecke wrote: > When a cloned request is retried on other queues it always needs > to be checked against the queue limits of that queue. > Otherwise the calculations for nr_phys_segments might be wrong, > leading to a crash in scsi_init_sgtable(). >

Re: [PATCH v3 2/5] arcmsr: fixes not release allocated resource

2015-11-26 Thread Tomas Henzl
On 26.11.2015 08:32, Ching Huang wrote: > On Wed, 2015-11-25 at 14:55 +0100, Tomas Henzl wrote: >> On 25.11.2015 12:41, Ching Huang wrote: >>> From: Ching Huang >>> >>> Releasing allocated resource if get configuration data failed. >>> >>> Signed-of-by: Ching Huang >>> >>> --- >>> >>> diff -uprN

[PATCH 3/3] arcmsr: change driver version to v1.30.00.22-20151126

2015-11-26 Thread Ching Huang
From: Ching Huang change driver version to v1.30.00.22-20151126 Signed-of-by: Ching Huang --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h 2015-11-25 18:04:26.0 +0800 +++ b/drivers/scsi/arcmsr/arcmsr.h 2015-11

[PATCH 2/3] arcmsr: Split dma resource allocation to a new function

2015-11-26 Thread Ching Huang
From: Ching Huang split dma resource allocation and io register assignment from get_config to a new function arcmsr_alloc_io_queue. Signed-of-by: Ching Huang --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr/arcmsr_hba.c 2015-11-2

[PATCH 1/3] arcmsr: modify codes for more readable

2015-11-26 Thread Ching Huang
From: Ching Huang modify codes for more readable Signed-of-by: Ching Huang --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr/arcmsr_hba.c 2015-11-25 18:08:52.0 +0800 +++ b/drivers/scsi/arcmsr/arcmsr_hba.c 2015-11-26 15:52:

[PATCH 0/3] arcmsr: fix bug of reallocate dma resource

2015-11-26 Thread Ching Huang
io register assignment from get_config to new function arcmsr_alloc_io_queue. Patch 3 change driver version to v1.30.00.22-20151126. -- -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo inf

Re: [PATCH 22/71] ncr5380: Eliminate selecting state

2015-11-26 Thread Finn Thain
On Wed, 25 Nov 2015, Ondrej Zary wrote: > On Wednesday 25 November 2015 04:17:09 Finn Thain wrote: > > > > On Tue, 24 Nov 2015, Ondrej Zary wrote: > > > > > > > > Bisecting slow module initialization pointed to this commit. > > > > > > Before this commit (2 seconds): > > > [ 60.317374] scsi

RE: [PATCH] scsi: rescan VPD attributes

2015-11-26 Thread Seymour, Shane M
> The VPD page information might change, so we need to be able to > update it. This patch implements a VPD page rescan whenever > the 'rescan' sysfs attribute is triggered. > > Signed-off-by: Hannes Reinecke > --- Reviewed-by: Shane Seymour -- To unsubscribe from this list: send the line "unsub

[PATCH v2 1/4] bfa:Updating copyright messages

2015-11-26 Thread anil.gurumurthy
From: Anil Gurumurthy Signed-off-by: Sudarsana Kalluru Signed-off-by: Anil Gurumurthy --- drivers/scsi/bfa/bfa.h |5 +++-- drivers/scsi/bfa/bfa_core.c |5 +++-- drivers/scsi/bfa/bfa_cs.h|5 +++-- drivers/scsi/bfa/bfa_defs.h |5 +++-- drivers/scsi/bfa

[PATCH v2 4/4] bfa:Update driver version to 3.2.25.0

2015-11-26 Thread anil.gurumurthy
From: Anil Gurumurthy Signed-off-by: Sudarsana Kalluru Signed-off-by: Anil Gurumurthy --- drivers/scsi/bfa/bfad_drv.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/bfa/bfad_drv.h b/drivers/scsi/bfa/bfad_drv.h index 8001459..f9e8620 100644 --- a/drivers/

[PATCH v2 3/4] bfa:File header and user visible string changes

2015-11-26 Thread anil.gurumurthy
From: Anil Gurumurthy Signed-off-by: Sudarsana Kalluru Signed-off-by: Anil Gurumurthy --- drivers/scsi/bfa/bfa.h |2 +- drivers/scsi/bfa/bfa_core.c |2 +- drivers/scsi/bfa/bfa_cs.h|2 +- drivers/scsi/bfa/bfa_defs.h |2 +- drivers/scsi/bfa/bfa_defs_fc

[PATCH v2 0/4] bfa: Patches for scsi "misc" branch

2015-11-26 Thread anil.gurumurthy
From: Anil Gurumurthy Hi Martin, James Re-sending the patches that were submitted earlier, but appear to have fallen through the cracks. Addressed a comment regarding the commit message as well. Please apply the following patches to the scsi tree, misc branch at your earliest convenience. Th

[PATCH v2 2/4] bfa:Fix for crash when bfa_itnim is NULL

2015-11-26 Thread anil.gurumurthy
From: Anil Gurumurthy Fix a very corner case when the port gets disconnected and the BFA and FCS layers clean up references to the IT nexus. During this window if a task management command is issued by the SCSI-ML and ends up referencing a NULL itnim, it could lead to a crash. Signed-off-by: S

RE: [PATCH 2/4] bfa:Fix for crash when bfa_itnim is NULL

2015-11-26 Thread Anil Gurumurthy
Thanks Johannes, will repost the patch set. -Original Message- From: Johannes Thumshirn [mailto:jthumsh...@suse.de] Sent: 26 November 2015 14:06 To: Anil Gurumurthy ; martin.peter...@oracle.com; james.bottom...@hansenpartnership.com Cc: linux-scsi ; Sudarsana Kalluru Subject: Re: [PATC

Re: QUEUE_FLAG_NO_SG_MERGE and non-block-mq

2015-11-26 Thread Ming Lei
On Thu, Nov 26, 2015 at 4:13 PM, Hannes Reinecke wrote: > Hi all, > > while investigating the crash in scsi_lib.c I found a rather curious > behaviour for QUEUE_FLAG_NO_SG_MERGE. > > While the flag is evaluated in blk_recalc_rq_segments and > blk_recount_segments (resulting in nr_phys_segments bei

Re: [PATCH 4/4] bfa:Update driver version to 3.2.25.0

2015-11-26 Thread Johannes Thumshirn
On Thu, 2015-11-26 at 02:43 -0500, anil.gurumur...@qlogic.com wrote: > From: Anil Gurumurthy > > Signed-off-by: Sudarsana Kalluru > Signed-off-by: Anil Gurumurthy > --- >  drivers/scsi/bfa/bfad_drv.h |2 +- >  1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/scsi/bf

Re: [PATCH 3/4] bfa:File header and user visible string changes

2015-11-26 Thread Johannes Thumshirn
On Thu, 2015-11-26 at 02:43 -0500, anil.gurumur...@qlogic.com wrote: > From: Anil Gurumurthy > > Signed-off-by: Sudarsana Kalluru > Signed-off-by: Anil Gurumurthy > --- >  drivers/scsi/bfa/bfa.h   |2 +- >  drivers/scsi/bfa/bfa_core.c  |2 +- >  drivers/scsi/bfa/bfa_cs.h  

Re: [PATCH 1/4] bfa:Updating copyright messages

2015-11-26 Thread Johannes Thumshirn
On Thu, 2015-11-26 at 02:43 -0500, anil.gurumur...@qlogic.com wrote: > From: Anil Gurumurthy > > Signed-off-by: Sudarsana Kalluru > Signed-off-by: Anil Gurumurthy > --- >  drivers/scsi/bfa/bfa.h   |5 +++-- >  drivers/scsi/bfa/bfa_core.c  |5 +++-- >  drivers/scsi/bfa/bfa_cs.h

Re: [PATCH 2/4] bfa:Fix for crash when bfa_itnim is NULL

2015-11-26 Thread Johannes Thumshirn
On Thu, 2015-11-26 at 02:43 -0500, anil.gurumur...@qlogic.com wrote: > From: Anil Gurumurthy Can you please explain a bit more why it is crashing in the commit message, i.e. copy the comment you added to the source here as well. And as I spot the words fix and crash in the subject, you might co

[PATCH 3/4] bfa:File header and user visible string changes

2015-11-26 Thread anil.gurumurthy
From: Anil Gurumurthy Signed-off-by: Sudarsana Kalluru Signed-off-by: Anil Gurumurthy --- drivers/scsi/bfa/bfa.h |2 +- drivers/scsi/bfa/bfa_core.c |2 +- drivers/scsi/bfa/bfa_cs.h|2 +- drivers/scsi/bfa/bfa_defs.h |2 +- drivers/scsi/bfa/bfa_defs_fc

[PATCH 2/4] bfa:Fix for crash when bfa_itnim is NULL

2015-11-26 Thread anil.gurumurthy
From: Anil Gurumurthy Signed-off-by: Sudarsana Kalluru Signed-off-by: Anil Gurumurthy --- drivers/scsi/bfa/bfad_im.c | 26 ++ 1 files changed, 26 insertions(+), 0 deletions(-) diff --git a/drivers/scsi/bfa/bfad_im.c b/drivers/scsi/bfa/bfad_im.c index efcb247..2c0cf8a

[PATCH 4/4] bfa:Update driver version to 3.2.25.0

2015-11-26 Thread anil.gurumurthy
From: Anil Gurumurthy Signed-off-by: Sudarsana Kalluru Signed-off-by: Anil Gurumurthy --- drivers/scsi/bfa/bfad_drv.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/bfa/bfad_drv.h b/drivers/scsi/bfa/bfad_drv.h index 8001459..f9e8620 100644 --- a/drivers/

[PATCH 1/4] bfa:Updating copyright messages

2015-11-26 Thread anil.gurumurthy
From: Anil Gurumurthy Signed-off-by: Sudarsana Kalluru Signed-off-by: Anil Gurumurthy --- drivers/scsi/bfa/bfa.h |5 +++-- drivers/scsi/bfa/bfa_core.c |5 +++-- drivers/scsi/bfa/bfa_cs.h|5 +++-- drivers/scsi/bfa/bfa_defs.h |5 +++-- drivers/scsi/bfa

[PATCH 0/4] bfa: Patches for scsi "misc" branch

2015-11-26 Thread anil.gurumurthy
From: Anil Gurumurthy Hi Martin, James Re-sending the patches that were submitted earlier, but appear to have fell through the cracks. Please apply the following patches to the scsi tree, misc branch at your earliest convenience. Thanks, Anil Anil Gurumurthy (4): bfa:Updating copyright mess

QUEUE_FLAG_NO_SG_MERGE and non-block-mq

2015-11-26 Thread Hannes Reinecke
Hi all, while investigating the crash in scsi_lib.c I found a rather curious behaviour for QUEUE_FLAG_NO_SG_MERGE. While the flag is evaluated in blk_recalc_rq_segments and blk_recount_segments (resulting in nr_phys_segments being computed based on that flag) it is completely ignored during blk_r