From: Markus Elfring
Date: Tue, 17 Nov 2015 08:14:52 +0100
The kmem_cache_destroy() function tests whether its argument is NULL
and then returns immediately. Thus the test around the calls is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
--
On 11/16/2015 05:49 PM, Arnd Bergmann wrote:
> Building the advansys driver in a big-endian configuration such as
> ARM allmodconfig shows a warning:
>
> drivers/scsi/advansys.c: In function 'adv_build_req':
> include/uapi/linux/byteorder/big_endian.h:32:26: warning: large integer
> implicitly
On Mon, 2015-11-16 at 16:18 -0800, Bart Van Assche wrote:
> Instead of representing the states "visible in sysfs" and
> "has been removed from the target list" by a single state
> variable, use two variables to represent this information.
>
> This patch avoids that SCSI device removal can trigger
Hi,
On Monday 09 November 2015 10:56 AM, Alim Akhtar wrote:
> From: Seungwon Jeon
>
> This patch introduces Exynos UFS PHY driver. This driver
> supports to deal with phy calibration and power control
> according to UFS host driver's behavior.
>
> Signed-off-by: Seungwon Jeon
> Signed-off-by:
Hi Alim,
On Monday 16 November 2015 06:31 AM, Alim Akhtar wrote:
> Hi Kishon,
>
> Any more concern on the PHY part of this series?
Sorry for the late reply. Yes, I still have concerns. I'll comment on your
patch.
Thanks
Kishon
>
> Thanks!
>
> On Mon, Nov 9, 2015 at 10:56 AM, Alim Akhtar wro
Instead of representing the states "visible in sysfs" and
"has been removed from the target list" by a single state
variable, use two variables to represent this information.
This patch avoids that SCSI device removal can trigger a
soft lockup.
See also:
* "scsi: restart list search after unlock
This patch fixes the following kernel bug:
kernel:BUG: rwlock recursion on CPU#2, insmod/39333, 8803e998cb28
kernel: Call Trace:
kernel: [] dump_stack+0x48/0x64
kernel: [] rwlock_bug+0x67/0x70
kernel: [] do_raw_write_lock+0x8a/0xa0
kernel: [] _raw_write_lock_irqsave+0x63/0x80
kernel: [] qla82x
Bart Van Assche wrote:
> [PATCH] qla2xxx: Fix rwlock recursion
>
> Fixes: 8dfa4b5a9b44 ("qla2xxx: Fix sparse annotation")
> Signed-off-by: Bart Van Assche
> Reported-by: Himanshu Madhani
> Cc: Giridhar Malavali
> ---
> drivers/scsi/qla2xxx/qla_nx.c | 3 ++-
> 1 file changed, 2 insertions(+)
On 11/16/2015 04:10 AM, Hannes Reinecke wrote:
> On 11/13/2015 10:54 PM, Martin K. Petersen wrote:
>>> "Lee" == Lee Duncan writes:
>>
Well, I'm a bit worried about the loss of a monotonically increasing
host number from the debugging perspective. Right now, if you look
at any l
Hi John,
[auto build test ERROR on scsi/for-next]
[also build test ERROR on v4.4-rc1 next-20151116]
url:
https://github.com/0day-ci/linux/commits/John-Garry/HiSilicon-SAS-driver/20151116-215304
base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next
config: i386
> -Original Message-
> From: linux-rdma-ow...@vger.kernel.org
> [mailto:linux-rdma-ow...@vger.kernel.org] On Behalf Of Sagi Grimberg
> Sent: Monday, November 16, 2015 12:38 PM
> To: Steve Wise; 'Christoph Hellwig'; linux-r...@vger.kernel.org
> Cc: bart.vanass...@sandisk.com; ax...@fb.com
On Mon, Nov 16, 2015 at 7:20 PM, Russell King - ARM Linux
wrote:
> On Mon, Nov 16, 2015 at 05:49:23PM +0100, Arnd Bergmann wrote:
>> It turns out that the commit that introduced this used the cpu_to_le32()
>> incorrectly on an 8-bit field, which results in the sense_len to always
>> be set to zero
After looking at the nes driver, I don't see any common way to support drain
w/o some serious driver mods. Since SRP is the only
user, perhaps we can ignore iWARP for this function...
But iser/isert essentially does it too (and I think xprtrdma will have
it soon)...
the modify_qp is invoked
On Mon, Nov 16, 2015 at 06:20:31PM +, Russell King - ARM Linux wrote:
> On Mon, Nov 16, 2015 at 05:49:23PM +0100, Arnd Bergmann wrote:
> > It turns out that the commit that introduced this used the cpu_to_le32()
> > incorrectly on an 8-bit field, which results in the sense_len to always
> > be
> -Original Message-
> From: Steve Wise [mailto:sw...@opengridcomputing.com]
> Sent: Monday, November 16, 2015 10:38 AM
> To: Sagi Grimberg; Christoph Hellwig; linux-r...@vger.kernel.org
> Cc: bart.vanass...@sandisk.com; ax...@fb.com; linux-scsi@vger.kernel.org;
> linux-ker...@vger.kerne
On Mon, Nov 16, 2015 at 05:49:23PM +0100, Arnd Bergmann wrote:
> It turns out that the commit that introduced this used the cpu_to_le32()
> incorrectly on an 8-bit field, which results in the sense_len to always
> be set to zero, as the SCSI_SENSE_BUFFERSIZE value gets moved to upper
> byte of the
Bart, can you resend your patch on top of 4.4-rc1? I think we really
need it so we should get it into 4.4 and backport it to -stable.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.k
On 11/16/2015 09:22 AM, Christoph Hellwig wrote:
the code in this area changed enough since 4.3 that it won't easily
apply. But a backport would still be very useful!
In that case:
Reviewed-by: Bart Van Assche
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the bo
Hi John,
[auto build test ERROR on scsi/for-next]
[also build test ERROR on v4.4-rc1 next-20151116]
url:
https://github.com/0day-ci/linux/commits/John-Garry/HiSilicon-SAS-driver/20151116-215304
base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next
config: i386
Hi Bart,
the code in this area changed enough since 4.3 that it won't easily
apply. But a backport would still be very useful!
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.
> On Nov 15, 2015, at 4:10 AM, Or Gerlitz wrote:
>
> On Fri, Nov 13, 2015 at 6:51 PM, Mike Christie wrote:
>> On 11/13/2015 09:06 AM, Or Gerlitz wrote:
The patch has caused multiple regressions, did not even compile when
> sent to me, and was poorly reviewed and I have not heard from y
On 11/15/2015 09:59 AM, Christoph Hellwig wrote:
Without this sg_dma_len will return 0 on architectures tha have
the dma_length field.
Signed-off-by: Christoph Hellwig
---
drivers/infiniband/ulp/srp/ib_srp.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/infiniband/ulp/srp/ib
Building the advansys driver in a big-endian configuration such as
ARM allmodconfig shows a warning:
drivers/scsi/advansys.c: In function 'adv_build_req':
include/uapi/linux/byteorder/big_endian.h:32:26: warning: large integer
implicitly truncated to unsigned type [-Woverflow]
#define __cpu_t
On 11/15/2015 3:34 AM, Sagi Grimberg wrote:
+
+struct ib_stop_cqe {
+struct ib_cqecqe;
+struct completion done;
+};
+
+static void ib_stop_done(struct ib_cq *cq, struct ib_wc *wc)
+{
+struct ib_stop_cqe *stop =
+container_of(wc->wr_cqe, struct ib_stop_cqe, cqe);
+
+c
The iser RDMA_CM negotiation protocol is shared by
the initiator and the target, so have a shared header
for the defines and structure. Move relevant items from
the initiator and target headers.
Signed-off-by: Sagi Grimberg
Signed-off-by: Jenny Derzhavetz
Cc: linux-scsi
---
drivers/infiniband/
On Mon, Nov 16, 2015 at 09:05:48PM +0800, John Garry wrote:
> Add devicetree bindings for HiSilicon SAS driver.
>
> Signed-off-by: John Garry
> Signed-off-by: Zhangfei Gao
Acked-by: Rob Herring
> ---
> .../devicetree/bindings/scsi/hisilicon-sas.txt | 69
> ++
> 1 fil
Signed-off-by: John Garry
---
drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 389 +
1 file changed, 389 insertions(+)
diff --git a/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c
b/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c
index e9aebce..9fe89bb 100644
--- a/drivers/scsi/hisi_sas/
Add functions for scsi host template scan_finished
and scan_start methods
Signed-off-by: John Garry
---
drivers/scsi/hisi_sas/hisi_sas.h | 1 +
drivers/scsi/hisi_sas/hisi_sas_main.c | 25 +
2 files changed, 26 insertions(+)
diff --git a/drivers/scsi/hisi_sas/hisi_s
Add function methods for tmf's.
Signed-off-by: John Garry
---
drivers/scsi/hisi_sas/hisi_sas_main.c | 309 ++
1 file changed, 309 insertions(+)
diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c
b/drivers/scsi/hisi_sas/hisi_sas_main.c
index 63ebaf3..4ee90eb 1006
Add handlers for fatal interrupts
Signed-off-by: John Garry
---
drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 119 +
1 file changed, 119 insertions(+)
diff --git a/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c
b/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c
index a95259c..e29b7c7
This is for expander broadcast event.
Signed-off-by: John Garry
---
drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 31 +++
1 file changed, 31 insertions(+)
diff --git a/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c
b/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c
index 1723dd4..ad50aed
Add functions to deal with lldd_dev_found and lldd_dev_gone.
Signed-off-by: John Garry
---
drivers/scsi/hisi_sas/hisi_sas.h | 13 +
drivers/scsi/hisi_sas/hisi_sas_main.c | 88 ++
drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 41
3 files chan
This patch adds the initial bare main driver for the
HiSilicon SAS HBA. This only introduces the changes to
build and load the main driver module.
The complete driver consists of the core main module and
also a module platform driver for driving the hw.
The HBA is a platform device.
Signed-off-b
Add cq interrupt handler and also slot error handler
function.
Signed-off-by: John Garry
---
drivers/scsi/hisi_sas/hisi_sas.h | 9 +
drivers/scsi/hisi_sas/hisi_sas_main.c | 35
drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 345 +
3 files changed, 389 ins
Add method for lldd_control_phy. Currently link rate
control and spinup hold is unsupported.
Signed-off-by: John Garry
---
drivers/scsi/hisi_sas/hisi_sas.h | 3 +++
drivers/scsi/hisi_sas/hisi_sas_main.c | 29 +
drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 23 +
Signed-off-by: John Garry
---
drivers/scsi/hisi_sas/hisi_sas_main.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c
b/drivers/scsi/hisi_sas/hisi_sas_main.c
index 8cd1b55..d7d9516 100644
--- a/drivers/scsi/hisi_sas/hisi_sas_main.c
+++ b/drivers/sc
Add functionality to init slot indexing.
Slot indexing is for the host to track which slots
(or tags) are free and which are used.
Signed-off-by: John Garry
---
drivers/scsi/hisi_sas/hisi_sas.h | 4
drivers/scsi/hisi_sas/hisi_sas_main.c | 23 +++
2 files changed,
Add abnormal irq handler. This handler is concerned with
phy down event.
Also add port formed and port deformed handlers.
Signed-off-by: John Garry
---
drivers/scsi/hisi_sas/hisi_sas.h | 2 +
drivers/scsi/hisi_sas/hisi_sas_main.c | 118 +
drivers/scsi/his
Add maintainer for HiSilicon SAS driver.
Signed-off-by: John Garry
---
MAINTAINERS | 7 +++
1 file changed, 7 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index e9caa4b..c7081bd 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -5035,6 +5035,13 @@ F: include/uapi/linux/if_hippi.h
Add code to interrupts, so now we can get a phy up
interrupt when a disk is connected.
Signed-off-by: John Garry
---
drivers/scsi/hisi_sas/hisi_sas.h | 5 +
drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 161 +
2 files changed, 166 insertions(+)
diff --git a/dr
Signed-off-by: John Garry
---
drivers/scsi/hisi_sas/hisi_sas.h | 1 +
drivers/scsi/hisi_sas/hisi_sas_main.c | 8
2 files changed, 9 insertions(+)
diff --git a/drivers/scsi/hisi_sas/hisi_sas.h b/drivers/scsi/hisi_sas/hisi_sas.h
index c50384f..62bc6f3 100644
--- a/drivers/scsi/hisi_s
Signed-off-by: John Garry
---
drivers/scsi/hisi_sas/hisi_sas.h | 1 +
drivers/scsi/hisi_sas/hisi_sas_main.c | 4 +
drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 337 +
3 files changed, 342 insertions(+)
diff --git a/drivers/scsi/hisi_sas/hisi_sas.h b/drivers
Signed-off-by: John Garry
---
drivers/scsi/hisi_sas/hisi_sas.h | 2 ++
drivers/scsi/hisi_sas/hisi_sas_main.c | 49 ++
drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 15 +++
3 files changed, 66 insertions(+)
diff --git a/drivers/scsi/hisi_sas/hisi_sas.h b
Add support for smp function, which allows devices
attached by expander to be controlled
Signed-off-by: John Garry
---
drivers/scsi/hisi_sas/hisi_sas.h | 3 ++
drivers/scsi/hisi_sas/hisi_sas_main.c | 9
drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 88 ++
The SAS address for the HBA comes from the device tree.
Signed-off-by: John Garry
---
drivers/scsi/hisi_sas/hisi_sas.h | 1 +
drivers/scsi/hisi_sas/hisi_sas_main.c | 12
2 files changed, 13 insertions(+)
diff --git a/drivers/scsi/hisi_sas/hisi_sas.h b/drivers/scsi/hisi_sas/hi
Add devicetree bindings for HiSilicon SAS driver.
Signed-off-by: John Garry
Signed-off-by: Zhangfei Gao
---
.../devicetree/bindings/scsi/hisilicon-sas.txt | 69 ++
1 file changed, 69 insertions(+)
create mode 100644 Documentation/devicetree/bindings/scsi/hisilicon-sas.t
Each completion queue has a structure. This is mainly for
passing to irq handler so we know which queue the irq occured
on.
Signed-off-by: John Garry
---
drivers/scsi/hisi_sas/hisi_sas.h | 7 +++
drivers/scsi/hisi_sas/hisi_sas_main.c | 6 ++
2 files changed, 13 insertions(+)
diff -
Signed-off-by: John Garry
---
drivers/scsi/hisi_sas/hisi_sas.h | 2 ++
drivers/scsi/hisi_sas/hisi_sas_main.c | 3 +++
2 files changed, 5 insertions(+)
diff --git a/drivers/scsi/hisi_sas/hisi_sas.h b/drivers/scsi/hisi_sas/hisi_sas.h
index 3a2400e..3749c46 100644
--- a/drivers/scsi/hisi_sas/h
Add functionality to register device as a scsi host.
The SAS domain transport ops are empty at this point.
Signed-off-by: John Garry
---
drivers/scsi/hisi_sas/hisi_sas.h | 34 ++
drivers/scsi/hisi_sas/hisi_sas_main.c | 116 ++
2 files changed, 150 i
This patch also includes relevant memory/pool
free'ing and sas/scsi host removal
Signed-off-by: John Garry
---
drivers/scsi/hisi_sas/hisi_sas_main.c | 71 ++-
1 file changed, 70 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c
b/dr
Allocate DMA and non-DMA memories for the controller. Also
create DMA pools.
These include:
- Delivery queues
- Completion queues
- Command status buffer
- Command table
- ITCT (For device context)
- Host slot info
- IO status
- Breakpoint
- host slot indexing
- SG data
- FIS
- interrupts names
S
Signed-off-by: John Garry
---
drivers/scsi/hisi_sas/hisi_sas.h | 15 +++
drivers/scsi/hisi_sas/hisi_sas_main.c | 31 +++
2 files changed, 46 insertions(+)
diff --git a/drivers/scsi/hisi_sas/hisi_sas.h b/drivers/scsi/hisi_sas/hisi_sas.h
index 5ac5a82..
Signed-off-by: John Garry
---
drivers/scsi/hisi_sas/hisi_sas.h | 131 +++
1 file changed, 131 insertions(+)
diff --git a/drivers/scsi/hisi_sas/hisi_sas.h b/drivers/scsi/hisi_sas/hisi_sas.h
index 87f4b61..19d40b7 100644
--- a/drivers/scsi/hisi_sas/hisi_sas.h
++
Add module init code for v1 hw.
Signed-off-by: John Garry
---
drivers/scsi/hisi_sas/Makefile | 1 +
drivers/scsi/hisi_sas/hisi_sas.h | 3 ++
drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 53 ++
3 files changed, 57 insertions(+)
create mode 100644 drive
Scan the device tree for all properties. Also
do this:
- do ioremap for SAS registers
- allocate memory for interrupt names
Signed-off-by: John Garry
---
drivers/scsi/hisi_sas/hisi_sas.h | 10
drivers/scsi/hisi_sas/hisi_sas_main.c | 45 ++-
2 files c
Include initialisation.
Signed-off-by: John Garry
Conflicts:
drivers/scsi/hisi_sas/hisi_sas_main.c
---
drivers/scsi/hisi_sas/hisi_sas.h | 12
drivers/scsi/hisi_sas/hisi_sas_main.c | 6 ++
2 files changed, 18 insertions(+)
diff --git a/drivers/scsi/hisi_sas/hisi_s
Add path to send ssp command to HW
Signed-off-by: John Garry
---
drivers/scsi/hisi_sas/hisi_sas.h | 30 +
drivers/scsi/hisi_sas/hisi_sas_main.c | 234 +
drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 194 +++
3 files changed, 458 inse
The xfer_rdy, command, and task frame's iu structures
are not available in , but only aic94xx
driver folder.
Add them to include/scsi/sas.h
Signed-off-by: John Garry
---
drivers/scsi/aic94xx/aic94xx_sas.h | 49 -
include/scsi/sas.h | 74 +++
This is the driver patchset for the HiSilicon SAS driver. The driver
is a platform driver.
The driver will support multiple revisions of HW. Currently only "v1"
HW is supported.
The driver uses libsas framework within the SCSI framework.
The v1 HW supports SSP and SMP, but not STP/SATA.
Differe
On 11/13/2015 10:54 PM, Martin K. Petersen wrote:
>> "Lee" == Lee Duncan writes:
>
>>> Well, I'm a bit worried about the loss of a monotonically increasing
>>> host number from the debugging perspective. Right now, if you look
>>> at any log, hostX always refers to one and only one incarnati
On 15/11/2015 02:21, Nicholas A. Bellinger wrote:
From: Nicholas Bellinger
This patch addresses a case where iscsi_target_do_tx_login_io()
fails sending the last login response PDU, after the RX/TX
threads have already been started.
The case centers around iscsi_target_rx_thread() not invoki
On 15/11/2015 23:10, Or Gerlitz wrote:
On Sun, Nov 15, 2015, Sagi Grimberg wrote:
On 15/11/2015 19:59, Christoph Hellwig wrote:
Without this sg_dma_len will return 0 on architectures tha have
the dma_length field.
and what wrong with that?
Because it's not length 0. It's because I did
From: Markus Elfring
Date: Mon, 16 Nov 2015 09:39:12 +0100
The kmem_cache_destroy() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
63 matches
Mail list logo
