Re: [PATCH 02/12] megaraid_sas : Code optimization- remove PCI Ids based checks

2015-10-28 Thread Martin K. Petersen
> "Kashyap" == Kashyap Desai writes: Kashyap> Here is last outstanding patch series. Kashyap> http://marc.info/?l=linux-scsi&m=144102204225400&w=2 Kashyap> Last patch series was missed because of small rebase Kashyap> issue. James suggested not to ACK anything which is not Kashyap> critical

[Bug 106841] do not output error for simple subenclosure (handle Short Enclosure Status diagnostic page)

2015-10-28 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=106841 --- Comment #1 from Tom Yan --- Oops I missed the lsscsi output: [tom@localhost ~]$ sudo lsscsi -g | grep WD [7:0:0:0]diskWD My Passport 083A 1065 /dev/sdc /dev/sg3 [7:0:0:1]enclosu WD SES Device 1065 -

[Bug 106841] New: do not output error for simple subenclosure (handle Short Enclosure Status diagnostic page)

2015-10-28 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=106841 Bug ID: 106841 Summary: do not output error for simple subenclosure (handle Short Enclosure Status diagnostic page) Product: IO/Storage Version: 2.5 Kernel Version: 4.2.4

Re: [PATCH] scsi: Set sg_tablesize to 1, for LLDDs that set SG_NONE

2015-10-28 Thread Matthew R. Ochs
> On Oct 28, 2015, at 2:36 PM, Manoj Kumar wrote: > > Oops while testing blk_mq over the new cxlflash driver. > > [ 2960.817172] Oops: Kernel access of bad area, sig: 11 [#5] > [ 2960.817309] NIP __blk_mq_run_hw_queue+0x278/0x4c0 > [ 2960.817313] LR __blk_mq_run_hw_queue+0x2bc/0x4c0 > [ 2960.81

Re: [RESEND PATCH] scsi_sysfs: Fix queue_ramp_up_period return code

2015-10-28 Thread Matthew R. Ochs
> On Oct 27, 2015, at 4:49 AM, Peter Oberparleiter > wrote: > > Writing a number to /sys/bus/scsi/devices//queue_ramp_up_period > returns the value of that number instead of the number of bytes written. > This behavior can confuse programs expecting POSIX write() semantics. > Fix this by returni

[PATCH 1 23/25] hpsa: fix multiple issues in path_info_show

2015-10-28 Thread Don Brace
From: Rasmus Villemoes path_info_show() seems to be broken in multiple ways. First, there's 817 return snprintf(buf, output_len+1, "%s%s%s%s%s%s%s%s", 818 path[0], path[1], path[2], path[3], 819 path[4], path[5], path[6], path[7]); so hopefully output_len contains the combine

[PATCH 1 25/25] hpsa: bump the driver version

2015-10-28 Thread Don Brace
Reviewed-by: Justin Lindley Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Reviewed-by: Gerry Morong Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index ca38a00..1b43157 100

[PATCH 1 24/25] hpsa: add in sas transport class

2015-10-28 Thread Don Brace
From: Kevin Barnett Reviewed-by: Scott Teel Reviewed-by: Justin Lindley Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 535 +-- drivers/scsi/hpsa.h | 27 ++ drivers/scsi/hpsa_cmd.h | 14 + 3 files changed

[PATCH 1 18/25] External array LUNs must use target and lun numbers assigned by the

2015-10-28 Thread Don Brace
From: Scott Teel external array. So the driver must treat these differently from local LUNs when assigning lun/target. LUN's 'model' field has been used to detect Lun types that need special treatment, but the desire is to eliminate the need to reference specific array models, and support any ex

[PATCH 1 19/25] hpsa: eliminate fake lun0 enclosures

2015-10-28 Thread Don Brace
From: Scott Teel We don't need to create fake enclosure devices at Lun0 in external target array configurations anymore. This was done to support Pre-SCSI rev 5 controllers that didn't suppoprt report luns commands, so the SCSI layer had to scan targets. If there was no LUN at LUN 0, then the tar

[PATCH 1 21/25] hpsa: disable report lun data caching

2015-10-28 Thread Don Brace
From: Scott Teel When external target arrays are present, disable the firmware's normal behavior of returning a cached copy of the report lun data, and force it to collect new data each time we request a report luns. This is necessary for external arrays, since there may be no reliable signal fr

[PATCH 1 20/25] hpsa: add discovery polling for PT RAID devices.

2015-10-28 Thread Don Brace
From: Scott Teel There are problems with getting configuration change notification in pass-through RAID environments. So, activate flag h->discovery_polling when one of these devices is detected in update_scsi_devices. After discovery_polling is set, execute a report luns from rescan_controller

[PATCH 1 22/25] hpsa: enhance device messages

2015-10-28 Thread Don Brace
Reviewed-by: Justin Lindley Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 45 - 1 file changed, 40 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 3

[PATCH 1 17/25] hpsa: move scsi_add_device and scsi_remove_device calls to new function

2015-10-28 Thread Don Brace
From: Kevin Barnett preparation for adding the sas transport class Reviewed-by: Scott Teel Reviewed-by: Justin Lindley Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 65 +++ 1 file changed, 39 insertions(+), 26

[PATCH 1 16/25] hpsa: refactor hpsa_figure_bus_target_lun

2015-10-28 Thread Don Brace
From: Kevin Barnett setup for sas transport. Need to set the bus and target accordingly. Reviewed-by: Scott Teel Reviewed-by: Justin Lindley Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 25 - drivers/scsi/hpsa.h |5 + 2 file

[PATCH 1 07/25] hpsa: correct transfer length for 6 byte read/write commands

2015-10-28 Thread Don Brace
handle block counts of 0. Cleanup block and block count calculations. Reviewed-by: Scott Teel Reviewed-by: Justin Lindley Reviewed-by: Kevin Barnett Reviewed-by: Tomas Henzl Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 19 ++- 1 file changed, 6 insertions(+), 13 delet

[PATCH 1 15/25] hpsa: enhance hpsa_get_device_id

2015-10-28 Thread Don Brace
use an index into vpd data for SAS/SATA drives Reviewed-by: Scott Teel Reviewed-by: Justin Lindley Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 23 --- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/hpsa.c b/d

[PATCH 1 13/25] hpsa: simplify update scsi devices

2015-10-28 Thread Don Brace
From: Kevin Barnett remove repeated calculation that checks for physical or logical devices. Reviewed-by: Scott Teel Reviewed-by: Justin Lindley Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 23 ++- drivers/scsi/hpsa.h |1 + 2 files

[PATCH 1 11/25] hpsa: correct ioaccel2 sg chain len

2015-10-28 Thread Don Brace
Reviewed-by: Scott Teel Reviewed-by: Justin Lindley Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 3973fb3..ffc0551 100644 --- a/drivers/scsi

[PATCH 1 08/25] hpsa: fix hpsa_adjust_hpsa_scsi_table

2015-10-28 Thread Don Brace
Fix a NULL pointer issue in the driver when devices are removed during a reset. Signed-off-by: Don Brace --- drivers/block/cciss.h |1 + drivers/scsi/hpsa.c | 16 drivers/scsi/hpsa.h |1 + 3 files changed, 18 insertions(+) diff --git a/drivers/block/cciss.h b/driv

[PATCH 1 14/25] hpsa: add function is_logical_device

2015-10-28 Thread Don Brace
From: Kevin Barnett simplify checking for logical/physical devices Reviewed-by: Scott Teel Reviewed-by: Justin Lindley Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/drive

[PATCH 1 10/25] hpsa: correct check for non-disk devices

2015-10-28 Thread Don Brace
The driver is using two MACROs which seemingly are looking in the wrong location for the device_flags returned from CISS_REPORT_PHYS. Both MACROs, NON_DISK_PHYS_DEV and PHYS_IOACCEL, are using the pointer returned from figure_lunaddrbytes which is the address of the LUN.lunid element in the extende

[PATCH 1 12/25] hpsa: simplify check for device exposure

2015-10-28 Thread Don Brace
From: Kevin Barnett remove macros and cleanup device exposure checking Reviewed-by: Scott Teel Reviewed-by: Justin Lindley Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 25 +++-- drivers/scsi/hpsa.h |6 +- 2 files changed, 12 ins

[PATCH 1 09/25] hpsa: fix physical target reset

2015-10-28 Thread Don Brace
From: Scott Teel Set reset type in device_reset_handler to do either logical unit reset for logical devices, or physical target reset, for physical devices. Reviewed-by: Scott Teel Reviewed-by: Justin Lindley Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 34

[PATCH 1 03/25] hpsa: check for null arguments to dev_printk

2015-10-28 Thread Don Brace
Check for NULLs. Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |6 ++ drivers/scsi/hpsa.h |2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 864fb03..6b6e9bb 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi/hpsa.

[PATCH 1 06/25] hpsa: abandon rescans on memory alloaction failures.

2015-10-28 Thread Don Brace
Abandon and reschedule rescan process only if device inquiries fail due to mem alloc failures, which are likely to occur for all devices. Otherwise, skip device if inquiry fails for other reasons, and continue rescanning process for other devices. Reviewed-by: Scott Teel Reviewed-by: Justin Lind

[PATCH 1 00/25] hpsa updates

2015-10-28 Thread Don Brace
These patches are based on Linus's tree The changes are: - corrected issue with dev_printk - add driver requested rescans - stop rescans on memory allocation failures and skip over unresponsive devices - correct 0 byte READ(6)/WRITE(6) transfers - correct issues when looking at CISS_REPORT

[PATCH 1 02/25] hpsa: remove unused hpsa_tag_discard_error_bits

2015-10-28 Thread Don Brace
This function is no longer used. Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index e60c652..864fb03 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi/hpsa.c @@ -23

[PATCH 1 05/25] hpsa: allow driver requested rescans

2015-10-28 Thread Don Brace
Reviewed-by: Scott Teel Reviewed-by: Justin Lindley Reviewed-by: Kevin Barnett Reviewed-by: Tomas Henzl Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 17 +++-- drivers/scsi/hpsa.h |1 + 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/hpsa.c

[PATCH 1 01/25] hpsa: stop zeroing reset_cmds_out and ioaccel_cmds_out during rescan

2015-10-28 Thread Don Brace
pulling the rug out from under the reset handler likewise for ioaccel_cmds_out Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 40669f8..e60c652 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/

[PATCH 1 04/25] hpsa: fix null device issues

2015-10-28 Thread Don Brace
Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 25 - 1 file changed, 20 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 6b6e9bb..3fe8a18 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi/hpsa.c @@ -1136,7 +1136,7 @@ stati

Re: [PATCH] scsi: hpsa: fix multiple issues in path_info_show

2015-10-28 Thread Don Brace
On 10/27/2015 05:16 PM, Rasmus Villemoes wrote: I'm not familiar with this code, but path_info_show() (added in 8270b86243658 "hpsa: add sysfs entry path_info to show box and bay information") seems to be broken in multiple ways. First, there's 817 return snprintf(buf, output_len+1, "%s%s%s%

Blk-mq/scsi-mq Tuning

2015-10-28 Thread Chad Dupuis
Hi Folks, We¹ve begun to explore blk-mq and scsi-mq and wanted to know if there were any best practices in terms of block layer settings. We¹re looking specifically at the FCoE and iSCSI protocols. A little background on the queues in our hardware first: we have a per connection transmit queue a

[PATCH] scsi: Set sg_tablesize to 1, for LLDDs that set SG_NONE

2015-10-28 Thread Manoj Kumar
Oops while testing blk_mq over the new cxlflash driver. [ 2960.817172] Oops: Kernel access of bad area, sig: 11 [#5] [ 2960.817309] NIP __blk_mq_run_hw_queue+0x278/0x4c0 [ 2960.817313] LR __blk_mq_run_hw_queue+0x2bc/0x4c0 [ 2960.817314] Call Trace: [ 2960.817320] __blk_mq_run_hw_queue+0x2bc/0x4c0

Re: Persistent Reservation API V4

2015-10-28 Thread Mike Snitzer
On Wed, Oct 28 2015 at 2:43pm -0400, Mike Snitzer wrote: > On Thu, Oct 15 2015 at 8:10am -0400, > Christoph Hellwig wrote: > > > This series adds support for a simplified Persistent Reservation API > > to the block layer. The intent is that both in-kernel and userspace > > consumers can use

Re: Persistent Reservation API V4

2015-10-28 Thread Mike Snitzer
On Thu, Oct 15 2015 at 8:10am -0400, Christoph Hellwig wrote: > This series adds support for a simplified Persistent Reservation API > to the block layer. The intent is that both in-kernel and userspace > consumers can use the API instead of having to hand craft SCSI or NVMe > command through t

RE: [PATCH 02/12] megaraid_sas : Code optimization- remove PCI Ids based checks

2015-10-28 Thread Kashyap Desai
> > > -Original Message- > > From: Martin K. Petersen [mailto:martin.peter...@oracle.com] > > Sent: Wednesday, October 28, 2015 8:03 AM > > To: sumit.sax...@avagotech.com > > Cc: linux-scsi@vger.kernel.org; the...@redhat.com; > > martin.peter...@oracle.com; h...@infradead.org; > > jbottom..

[PATCH v6 01/15] scsi: ufs: clear UTRD, UPIU req and rsp before new transfers

2015-10-28 Thread Yaniv Gardi
Clear the UFS data structures before sending new request. The SCSI command is sent to the device within the UFS UPIU request. As part of the transfer UPIU preparation, the SCSI command is copied to the UPIU structure according to the SCSI command size. As different SCSI commands differ in size fro

[PATCH v6 00/15] Big fixes, retries, handle a race condition

2015-10-28 Thread Yaniv Gardi
Important: This serie of 15 small patches should be pushed after the series of 8 patches "Fix error message and present UFS variant probe" V6: update Reviewed-by from various reviewers V5: removed un-necessary wmb() V4: fixing a few comments from reviewers V3: removed specific calls to wmb() si

[PATCH v6 02/15] scsi: ufs: clear fields UTRD, UPIU req and rsp before new transfers

2015-10-28 Thread Yaniv Gardi
Some of the data structures (like response UPIU) and/or its elements (unused fields) should be cleared before sending out the respective command to UFS device. This change clears the UPIU response data structure for query commands and NOP command before sending out the command. We also initialize

[PATCH v6 03/15] scsi: ufs: verify command tag validity

2015-10-28 Thread Yaniv Gardi
A race condition appear to exist between request completion when scsi_done() is called to end the request and set the tag back to -1 (at blk_queue_end_tag() scsi_end_request), and scsi layer error handling which aborts the command and reuses it to request sense data. Sending the request sense is do

[PATCH v6 05/15] scsi: ufs: increase fDeviceInit query response timeout

2015-10-28 Thread Yaniv Gardi
fDeviceInit query response time for some devices is too long that default query request timeout of 100ms may not be enough. Experiments show that fDeviceInit response sometimes takes 500ms so to be on safer side this change sets the timeout to 600ms. Without this change, we might unnecessarily have

[PATCH v6 06/15] scsi: ufs: avoid exception event handler racing with PM callbacks

2015-10-28 Thread Yaniv Gardi
If device raises the exception event in the response to the commands sent during the runtime/system PM callbacks, exception event handler might run in parallel with PM callbacks and may see unclocked register accesses. This change fixes this issue by not scheduling the exception event handler while

[PATCH v6 08/15] scsi: ufs: add retries to dme_peer get and set attribute

2015-10-28 Thread Yaniv Gardi
The dme_peer get/set attribute commands are prone to errors, therefore we add three retries for the UIC command sending. Error code returned from ufshcd_send_uic_cmd() is checked, and unless it was successful or the retries have finished, another command will be sent. Reviewed-by: Gilad Broner Re

[PATCH v6 07/15] scsi: ufs: set REQUEST_SENSE command size to 18 bytes

2015-10-28 Thread Yaniv Gardi
According to UFS device specification REQUEST_SENSE command can only report back up to 18 bytes of data. Reviewed-by: Dolev Raviv Signed-off-by: Gilad Broner Signed-off-by: Yaniv Gardi --- drivers/scsi/ufs/ufshcd.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git

[PATCH v6 11/15] scsi: ufs: retry failed query flag requests

2015-10-28 Thread Yaniv Gardi
UFS flag query requests may fail sometimes due to timeouts etc. Add a wrapper function to retry up to 10 times in case of such failure, similar to retries being made for attribute queries. Reviewed-by: Dolev Raviv Signed-off-by: Gilad Broner Signed-off-by: Yaniv Gardi --- drivers/scsi/ufs/ufs

[PATCH v6 10/15] scsi: ufs: fix error recovery after the hibern8 exit failure

2015-10-28 Thread Yaniv Gardi
Hibern8 exit can be called from 3 different context: - ufshcd_hibern8_exit_work - ufshcd_ungate_work - runtime/system resume If hibern8 exit fails for some reason then we try to bring the link to active state by link startup but this recovery mechanism results into deadlock or errors f

[PATCH v6 15/15] scsi: ufs: add wrapper for retrying sending query attribute

2015-10-28 Thread Yaniv Gardi
Sometimes queries from the device might return a failure so it is recommended to retry sending the query, before giving up. This change adds a wrapper to retry sending a query attribute, in cases where we need to wait longer, before we continue, or before reporting a failure. Reviewed-by: Gilad Br

[PATCH v6 12/15] scsi: ufs: reduce the interrupts for power mode change requests

2015-10-28 Thread Yaniv Gardi
DME commands such as Hibern8 enter/exit and gear switch generate 2 completion interrupts, one for confirmation that command is received by local UniPro and 2nd one is the final confirmation after communication with remote UniPro. Currently both of these completions are registered as interrupt event

[PATCH v6 13/15] scsi: ufs: add missing memory barriers

2015-10-28 Thread Yaniv Gardi
Performing several writes to UFS host controller registers has no guarantee of ordering, so we must make sure register writes to setup request list base address etc. are performed before the run/stop register is enabled. In addition, when setting up a task request, we must make sure the updating of

[PATCH v6 09/15] scsi: ufs: add retries for hibern8 enter

2015-10-28 Thread Yaniv Gardi
If hibern8 enter command fails then UFS link state may be unknown which may result into timeout of all the commands issued after failure. This change does 2 things (for pre-defined number of retry counts) after hibern8 enter failure: 1. Recovers the UFS link to active state 2. If link is recovered

[PATCH v6 14/15] scsi: ufs: commit descriptors before setting the doorbell

2015-10-28 Thread Yaniv Gardi
Add a write memory barrier to make sure descriptors prepared are actually written to memory before ringing the doorbell. We have also added the write memory barrier after ringing the doorbell register so that controller sees the new request immediately. Reviewed-by: Dolev Raviv Signed-off-by: Gil

[PATCH v6 04/15] scsi: ufs: clear outstanding_request bit in case query timeout

2015-10-28 Thread Yaniv Gardi
When sending a query to the device returns with a timeout error, we clear the corresponding bit in the DOORBELL register but we don't clear the outstanding_request field as we should. This patch fixes this bug. Reviewed-by: Subhash Jadavani Reviewed-by: Gilad Broner Reviewed-by: Dolev Raviv Sig

Re: [PATCH v4 11/11] scsi: ufs-exynos: add UFS host support for Exynos SoCs

2015-10-28 Thread Kishon Vijay Abraham I
Hi, On Sunday 25 October 2015 05:34 PM, Alim Akhtar wrote: > Hi Kishon > Thanks again for you review. > > On Fri, Oct 23, 2015 at 8:48 PM, Kishon Vijay Abraham I wrote: >> Hi, >> >> On Thursday 15 October 2015 08:38 AM, Alim Akhtar wrote: >>> +CCing kishon Vijay, >>> >>> On 10/14/2015 06:25 PM,

RE: [PATCH v5 00/15] Big fixes, retries, handle a race condition

2015-10-28 Thread Dolev Raviv
Reviewed-by: Dolev Raviv Thanks, Dolev -- Qualcomm Israel, on behalf of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -Original Message- From: Yaniv Gardi [mailto:yga...@codeaurora.org] Sent:

Re: [PATCH v2 00/17] add fixes, device quirks, error recovery,

2015-10-28 Thread Gilad Broner
Looks good to me. Reviewed-by: Gilad Broner > V2: > This series should be pushed on top of 15 patches series: > "Big fixes, retries, handle a race condition" > fixed and few comments. > > V1: > This series should be pushed on top of 15 patches series: > "Big fixes, retries, handle a race conditio

[PATCH v9 5/8] scsi: ufs: creates wrapper functions for vops

2015-10-28 Thread Yaniv Gardi
In order to simplify the code a set of wrapper functions is created to test and call each of the variant operations. Reviewed-by: Akinobu Mita Reviewed-by: Subhash Jadavani Reviewed-by: Gilad Broner Signed-off-by: Yaniv Gardi --- drivers/scsi/ufs/ufs-qcom.c | 1 - drivers/scsi/ufs/ufshcd.c

[PATCH v9 4/8] scsi: ufs: add ufshcd_get_variant ufshcd_set_variant

2015-10-28 Thread Yaniv Gardi
This patch adds ufshcd_get_variant() and ufshcd_set_variant() routines in order to get/set the variant specific data. Reviewed-by: Akinobu Mita Reviewed-by: Subhash Jadavani Reviewed-by: Gilad Broner Signed-off-by: Yaniv Gardi --- drivers/scsi/ufs/ufs-qcom.c | 34 +---

[PATCH v9 1/8] phy: qcom-ufs: fix build error when the component is built as a module

2015-10-28 Thread Yaniv Gardi
Export the following functions in order to avoid build errors when the component PHY_QCOM_UFS is compiled as a module: ERROR: "ufs_qcom_phy_disable_ref_clk" [drivers/scsi/ufs/ufs-qcom.ko] undefined! ERROR: "ufs_qcom_phy_enable_ref_clk" [drivers/scsi/ufs/ufs-qcom.ko] undefined! ERRO

[PATCH v9 3/8] scsi: ufs-qcom: update configuration option of SCSI_UFS_QCOM component

2015-10-28 Thread Yaniv Gardi
This change is required in order to be able to build the component as a module. Reviewed-by: Akinobu Mita Reviewed-by: Subhash Jadavani Reviewed-by: Gilad Broner Signed-off-by: Yaniv Gardi --- drivers/scsi/ufs/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/driver

[PATCH v9 2/8] scsi: ufs-qcom: fix compilation warning if compiled as a module

2015-10-28 Thread Yaniv Gardi
This change fixes a compilation warning that happens if SCSI_UFS_QCOM is compiled as a module. Also this patch fixes an error happens when insmod the module: "ufs_qcom: module license 'unspecified' taints kernel." Reviewed-by: Akinobu Mita Reviewed-by: Subhash Jadavani Reviewed-by: Gilad Broner

[PATCH v9 6/8] scsi: ufs: make the UFS variant a platform device

2015-10-28 Thread Yaniv Gardi
This change turns the UFS variant (SCSI_UFS_QCOM) into a UFS a platform device. In order to do so a few additional changes are required: 1. The ufshcd-pltfrm is no longer serves as a platform device. Now it only serves as a group of platform APIs such as PM APIs (runtime suspend/resume, syste

[PATCH v9 8/8] scsi: ufs-qcom: add QUniPro hardware support and power optimizations

2015-10-28 Thread Yaniv Gardi
New revisions of UFS host controller supports the new UniPro hardware controller (referred as QUniPro). This patch adds the support to enable this new UniPro controller hardware. This change also adds power optimization for bus scaling feature, as well as support for HS-G3 power mode. Reviewed-by

[PATCH v9 7/8] scsi: ufs-qcom: add debug prints for test bus

2015-10-28 Thread Yaniv Gardi
Adds support for configuring and reading the test bus and debug registers. This change also adds another vops in order to print the debug registers. Reviewed-by: Subhash Jadavani Reviewed-by: Gilad Broner Signed-off-by: Yaniv Gardi --- drivers/scsi/ufs/ufs-qcom.c | 165 +++

[PATCH v9 0/8] Fix error message and present UFS variant

2015-10-28 Thread Yaniv Gardi
V9: update commit message with Reviewed-by and update commit message of patch 4/8 V8: add phy attributes to UFS devicetree documentation file V7: removed additional dead code V6: removed dead code from ufs-qcom.c and added calling to ufshcd_dealloc_host() in ufshcd-pltfrm.c in case of an error a

RE: [PATCH 01/12] megaraid_sas : Expose TAPE drives unconditionally

2015-10-28 Thread Sumit Saxena
> -Original Message- > From: Martin K. Petersen [mailto:martin.peter...@oracle.com] > Sent: Wednesday, October 28, 2015 7:44 AM > To: sumit.sax...@avagotech.com > Cc: linux-scsi@vger.kernel.org; sta...@vger.kernel.org; the...@redhat.com; > martin.peter...@oracle.com; h...@infradead.org; jbo

RE: [PATCH 02/12] megaraid_sas : Code optimization- remove PCI Ids based checks

2015-10-28 Thread Sumit Saxena
> -Original Message- > From: Martin K. Petersen [mailto:martin.peter...@oracle.com] > Sent: Wednesday, October 28, 2015 8:03 AM > To: sumit.sax...@avagotech.com > Cc: linux-scsi@vger.kernel.org; the...@redhat.com; > martin.peter...@oracle.com; h...@infradead.org; jbottom...@parallels.com; >