Re: [Bugfix 0/3] Convert eata driver to a normal PCI device driver

On 2015/9/15 0:01, Arthur Marsh wrote: > > > Jiang Liu wrote on 14/09/15 12:38: >> Hi Authur, >> As suggested by Bjorn, patch 1-2 set implement a PCI device >> driver to manage eata PCI devices. And patch 3 tries to support PCI >> device hot-removal for eata, but I have no change to test due

Re: [PATCH 00/29] cxlflash: Miscellaneous bug fixes and corrections

> On Sep 13, 2015, at 8:12 PM, Ian Munsie wrote: > > Hi Matt & Manoj, > > Just a general comment about this series - I'd like to see more detailed > commit messages for almost all these patches. Of course James is the > scsi maintainer and it's up to him whether to take these as is or not, > but

Re: [Bugfix 0/3] Convert eata driver to a normal PCI device driver

Jiang Liu wrote on 14/09/15 12:38: Hi Authur, As suggested by Bjorn, patch 1-2 set implement a PCI device driver to manage eata PCI devices. And patch 3 tries to support PCI device hot-removal for eata, but I have no change to test due to limited knowledge about scsi subsystem and lacki

Re: [PATCH 0/6] Create ida helpers and use them

Lee Duncan writes: > As pointed out by Christoph Hellwig, many of the users > of the ida index routines call them with the same calling > pattern, so why not make some helper functions to help > clean up and simplify the code a bit. > > After looking at all the uses of the ida routines, I > notic

Re: [Bugfix 3/3] eata: Enhance eata driver to support PCI device hot-removal

On 2015/9/14 16:31, Ballabio, Dario wrote: > Agreed, It does not make sense to have this driver converted to a hot plug > api. Thanks, got the point:) Originally i thought user may trigger PCI device hot-removal by sysfs interfaces and there's comment mentioning that eata driver breaks PCI hotplu

Re: [Bugfix 2/3] eata: Implement PCI driver to manage eata PCI devices

On 2015/9/14 16:17, Hannes Reinecke wrote: > On 09/14/2015 05:08 AM, Jiang Liu wrote: >> Previously the eata driver just grabs and accesses eata PCI devices >> without implementing a PCI device driver, that causes troubles with >> latest IRQ related >> >> Commit 991de2e59090 ("PCI, x86: Implement p

RE: [Bugfix 3/3] eata: Enhance eata driver to support PCI device hot-removal

Agreed, It does not make sense to have this driver converted to a hot plug api. Cheers, *** Ph.D. Dario Ballabio Principal Field Support Specialist, EMC EMEA Mobile phone: +393487978851 -Original Message- From: Hannes Reinecke [mailto:h...@suse.d

Re: [Bugfix 3/3] eata: Enhance eata driver to support PCI device hot-removal

On 09/14/2015 05:08 AM, Jiang Liu wrote: > Due to having no hardware for testing, this is just a sample code > to support PCI device hot-removal. It just passing compilation, > no any tests. > > Signed-off-by: Jiang Liu > --- > drivers/scsi/eata.c | 26 ++ > 1 file chan

Re: [Bugfix 2/3] eata: Implement PCI driver to manage eata PCI devices

On 09/14/2015 05:08 AM, Jiang Liu wrote: > Previously the eata driver just grabs and accesses eata PCI devices > without implementing a PCI device driver, that causes troubles with > latest IRQ related > > Commit 991de2e59090 ("PCI, x86: Implement pcibios_alloc_irq() and > pcibios_free_irq()") cha

Re: [Bugfix 1/3] eata: Use IDA to manage eata board IDs

On 09/14/2015 05:08 AM, Jiang Liu wrote: > Use IDA to manage eata board IDs, so we could dynamically allocate > and free board IDs later. > > Signed-off-by: Jiang Liu > --- Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de

Re: [PATCH 14/14] lpfc: Update version to 11.0.0.0 for upstream patch set

On 08/31/2015 10:48 PM, James Smart wrote: > > Update version to 11.0.0.0 for upstream patch set > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- > drivers/scsi/lpfc/lpfc_version.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/lpfc/lpf

Re: [PATCH 13/14] lpfc: Fix default RA_TOV and ED_TOV in the FC/FCoE driver for all topologies

On 08/31/2015 10:48 PM, James Smart wrote: > > Fix default RA_TOV and ED_TOV in the FC/FCoE driver for all topologies > > Initial link up defaults were not properly being tracked relative to > initial FLOGI or pt2pt PLOGI. Add code to initialize them. > > Signed-off-by: Dick Kennedy > Signed-of

Re: [PATCH 12/14] lpfc: The linux driver does not reinitiate discovery after a failed FLOGI

On 08/31/2015 10:48 PM, James Smart wrote: > > The linux driver does not reinitiate discovery after a failed FLOGI > > Forgot to clear FCF Discovery in-progress flag upon FLOGI failures. > Thus we didn't restart FLOGI. > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- > drive

Re: [PATCH 11/14] lpfc: Fix for discovery failure in PT2PT when FLOGI's ELS ACC response gets aborted

On 08/31/2015 10:48 PM, James Smart wrote: > > Fix for discovery failure in PT2PT when FLOGI's ELS ACC response gets aborted > > Change login state machine to: > - Restart FLOGI if prior is ABTS'd > - Reject incoming FLOGIs if we have one pending > > The above ensures that we always finish FLOGI

Re: [PATCH 10/14] lpfc: Add support for Lancer G6 and 32G FC links

On 08/31/2015 10:48 PM, James Smart wrote: > > Add support for Lancer G6 and 32G FC links > > Signed-off-by: Dick Kennedy > Signed-off-by: James Smart > --- Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de

Re: [PATCH 08/14] lpfc: Fix possible use-after-free and double free in lpfc_mbx_cmpl_rdp_page_a2()

On 08/31/2015 10:48 PM, James Smart wrote: > > From: Johannes Thumshirn > > If the bf_get() call in lpfc_mbx_cmpl_rdp_page_a2() does succeeds, execution > continues normally and mp gets kfree()d. > > If the subsequent call to lpfc_sli_issue_mbox() fails execution jumps to the > error label wher

Re: [PATCH 06/14] lpfc:Make the function lpfc_sli4_mbox_completions_pending static in order to comply with function prototype

On 08/31/2015 10:48 PM, James Smart wrote: > > From: Nicholas Krause > > This makes the function lpfc_sli4_mbox_completion's definition > static now in order to comply with its prototype being also > declared as static too. > > Signed-off-by: Nicholas Krause > Signed-off-by: James Smart > ---

Re: [PATCH 07/14] lpfc: remove set but not used variables

On 08/31/2015 10:48 PM, James Smart wrote: > > From: Sebastian Herbszt > > Remove set but not used variables. > > Signed-off-by: Sebastian Herbszt > Signed-off-by: James Smart > --- Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h..

Re: [PATCH 05/14] Fix kmalloc overflow in LPFC driver at large core count

On 08/31/2015 10:48 PM, James Smart wrote: > > Note: original patch modified by me to resolve unused variable warning > > From: ian mitchell > > This patch allows the LPFC to start up without a fatal kernel bug based > on an exceeded KMALLOC_MAX_SIZE and a too large NR_CPU-based maskbits > fiel

Re: [PATCH 03/14] lpfc: in sli3 use configured sg_seg_cnt for sg_tablesize

On 08/31/2015 10:48 PM, James Smart wrote: > > From: Bodo Stroesser > > Hi James, > > We had some performance problems with RAID systems connected to LPe12k. > AFAICS, the reason is a small bug in lpfc.ko, causing the IO-size to > be smaller than expected. > > The patch below fixes it for us.

Re: [PATCH 02/14] lpfc: Remove unnessary cast

On 08/31/2015 10:48 PM, James Smart wrote: > > From: Firo Yang > > kzalloc() returns a void pointer - no need to cast it in > drivers/scsi/lpfc/lpfc_init.c::lpfc_sli_driver_resource_setup() > > Signed-off-by: Firo Yang > Signed-off-by: James Smart > --- > drivers/scsi/lpfc/lpfc_init.c | 3 +-

Re: [PATCH 01/14] lpfc: fix model description

On 08/31/2015 10:48 PM, James Smart wrote: > > From: Sebastian Herbszt > > Remove trailing space from model description. > > Signed-off-by: Sebastian Herbszt > Signed-off-by: James Smart > --- > drivers/scsi/lpfc/lpfc_init.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff -