Re: [PATCH] lpfc: Fix possible use-after-free and double free in lpfc_mbx_cmpl_rdp_page_a2()

On 8/18/2015 6:27 PM, Sebastian Herbszt wrote: Johannes Thumshirn wrote: Sebastian Herbszt writes: Johannes Thumshirn wrote: If the bf_get() call in lpfc_mbx_cmpl_rdp_page_a2() does succeeds, execution continues normally and mp gets kfree()d. If the subsequent call to lpfc_sli_issue_mbox()

[PATCH 09/14] fix: lpfc_send_rscn_event sends bigger buffer size

From: Ales Novak lpfc_send_rscn_event() allocates data for sizeof(struct lpfc_rscn_event_header) + payload_len, but claims that the data has size of sizeof(struct lpfc_els_event_header) + payload_len. That leads to buffer overruns. Signed-off-by: Ales Novak Signed-off-by: James Smart Reviewed

[PATCH 13/14] lpfc: Fix default RA_TOV and ED_TOV in the FC/FCoE driver for all topologies

Fix default RA_TOV and ED_TOV in the FC/FCoE driver for all topologies Initial link up defaults were not properly being tracked relative to initial FLOGI or pt2pt PLOGI. Add code to initialize them. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_hbadisc.c |

[PATCH 08/14] lpfc: Fix possible use-after-free and double free in lpfc_mbx_cmpl_rdp_page_a2()

From: Johannes Thumshirn If the bf_get() call in lpfc_mbx_cmpl_rdp_page_a2() does succeeds, execution continues normally and mp gets kfree()d. If the subsequent call to lpfc_sli_issue_mbox() fails execution jumps to the error label where lpfc_mbuf_free() is called with mp->virt and mp->phys as

[PATCH 04/14] lpfc: Destroy lpfc_hba_index IDR on module exit

From: Johannes Thumshirn Destroy lpfc_hba_index IDR on module exit, reclaiming the allocated memory. This was detected by the following semantic patch (written by Luis Rodriguez ) @ defines_module_init @ declarer name module_init, module_exit; declarer name DEFINE_IDR; identifier init; @@ mod

[PATCH 12/14] lpfc: The linux driver does not reinitiate discovery after a failed FLOGI

The linux driver does not reinitiate discovery after a failed FLOGI Forgot to clear FCF Discovery in-progress flag upon FLOGI failures. Thus we didn't restart FLOGI. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_els.c | 9 +++-- 1 file changed, 7 insert

[PATCH 06/14] lpfc:Make the function lpfc_sli4_mbox_completions_pending static in order to comply with function prototype

From: Nicholas Krause This makes the function lpfc_sli4_mbox_completion's definition static now in order to comply with its prototype being also declared as static too. Signed-off-by: Nicholas Krause Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_sli.c | 2 +- 1 file changed, 1 insert

[PATCH 14/14] lpfc: Update version to 11.0.0.0 for upstream patch set

Update version to 11.0.0.0 for upstream patch set Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_version.h b/drivers/scsi/lpfc/lpfc_version.h index 6258d3d..e

[PATCH 05/14] Fix kmalloc overflow in LPFC driver at large core count

Note: original patch modified by me to resolve unused variable warning From: ian mitchell This patch allows the LPFC to start up without a fatal kernel bug based on an exceeded KMALLOC_MAX_SIZE and a too large NR_CPU-based maskbits field. The bug was based on the number of CPU cores in a system

[PATCH 07/14] lpfc: remove set but not used variables

From: Sebastian Herbszt Remove set but not used variables. Signed-off-by: Sebastian Herbszt Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_attr.c | 6 drivers/scsi/lpfc/lpfc_bsg.c | 20 -- drivers/scsi/lpfc/lpfc_ct.c| 5 drivers/scsi/lpfc/lpf

[PATCH 10/14] lpfc: Add support for Lancer G6 and 32G FC links

Add support for Lancer G6 and 32G FC links Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc.h | 8 +--- drivers/scsi/lpfc/lpfc_attr.c| 17 + drivers/scsi/lpfc/lpfc_ct.c | 6 ++ drivers/scsi/lpfc/lpfc_els.c | 2 ++

[PATCH 11/14] lpfc: Fix for discovery failure in PT2PT when FLOGI's ELS ACC response gets aborted

Fix for discovery failure in PT2PT when FLOGI's ELS ACC response gets aborted Change login state machine to: - Restart FLOGI if prior is ABTS'd - Reject incoming FLOGIs if we have one pending The above ensures that we always finish FLOGI processing, regardless of who initated FLOGI, before proce

[PATCH 01/14] lpfc: fix model description

From: Sebastian Herbszt Remove trailing space from model description. Signed-off-by: Sebastian Herbszt Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.

[PATCH 02/14] lpfc: Remove unnessary cast

From: Firo Yang kzalloc() returns a void pointer - no need to cast it in drivers/scsi/lpfc/lpfc_init.c::lpfc_sli_driver_resource_setup() Signed-off-by: Firo Yang Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_init.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a

[PATCH 03/14] lpfc: in sli3 use configured sg_seg_cnt for sg_tablesize

From: Bodo Stroesser Hi James, We had some performance problems with RAID systems connected to LPe12k. AFAICS, the reason is a small bug in lpfc.ko, causing the IO-size to be smaller than expected. The patch below fixes it for us. Please CC me, I'm not on the list. Best regards Bodo ---

[PATCH 00/14] lpfc: Update to revision 11.0.0.0

This patch set updates the lpfc driver to revision 11.0.0.0 The patches were cut against scsi-misc -- james s James Smart (14): Pull in patches posted to linux-scsi prior: lpfc: fix model description lpfc: Remove unnessary cast lpfc: in sli3 use configured sg_seg_cnt for sg_table

[PATCH] Update scsi host to use ida for host number

From: Lee Duncan Each Scsi_host instance gets a host number starting at 0, but this is implemented with an atomic integer, and rollover doesn't seem to have been considered. Another side-effect of this design is that scsi host numbers used by iscsi are never reused, thereby making rollover more

Re: [PATCH] Remove check for SAS expander when querying bay/enclosure IDs.

On Tue, Jul 14, 2015 at 6:23 AM, Hannes Reinecke wrote: > On 07/13/2015 04:27 PM, Jordan Hargrave wrote: >> Dell Server backplanes can report bay/enclosure IDs without an >> expander present. This patch allows the bay/enclosure IDs to be >> propagaged to sysfs.we >> >> Signed-off-by: Jordan Hargr

Re: [PATCH] hfcldd: Add Hitachi FC driver.

"豊原吉宏 / TOYOHARA，YOSHIHIRO" writes: > I am an engineer in Hitachi. , > We committed the following files newly > and mailed the patch by one mail. Maybe you could split it up into a logical patch series. All in all 131907 LOC in one patch are quite some work to review as well. > > But the mail h

[PATCH] scsi_scan: don't dump trace when scsi_prep_async_scan() is called twice

The only user of scsi_prep_async_scan() is scsi_scan_host() and it handles the situation correctly. Move 'called twice' reporting to debug level as well. The issue is observed on Hyper-V: on any device add/remove event storvsc driver calls scsi_scan_host() and in case previous scan is still runnin

[PATCH] hfcldd: Add Hitachi FC driver.

I am an engineer in Hitachi. , We committed the following files newly and mailed the patch by one mail. But the mail has about 4,600,000 characters, and is blocked beyond 100,000 character of the mail permission. There are also source file beyond 20,000 lines. Could you advise how to do and send

RE: [PATCH 1/1] storvsc: Don't set the SRB_FLAGS_QUEUE_ACTION_ENABLE flag

> -Original Message- > From: James Bottomley [mailto:james.bottom...@hansenpartnership.com] > Sent: Monday, August 31, 2015 7:02 AM > To: KY Srinivasan > Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org; oher...@suse.com; > jbottom...@parallels

Re: [PATCH 1/1] storvsc: Don't set the SRB_FLAGS_QUEUE_ACTION_ENABLE flag

On Mon, 2015-08-31 at 08:21 -0700, K. Y. Srinivasan wrote: > Don't set the SRB_FLAGS_QUEUE_ACTION_ENABLE flag since we are not specifying > tags. What's the actual problem description this causes? James > Signed-off-by: K. Y. Srinivasan > Cc: sta...@vger.kernel.org > --- > drivers/scsi/storvs

[PATCH 1/1] storvsc: Don't set the SRB_FLAGS_QUEUE_ACTION_ENABLE flag

Don't set the SRB_FLAGS_QUEUE_ACTION_ENABLE flag since we are not specifying tags. Signed-off-by: K. Y. Srinivasan Cc: sta...@vger.kernel.org --- drivers/scsi/storvsc_drv.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvs

RE: [PATCH] scsi_scan: move 'INQUIRY result too short' message to debug level

> -Original Message- > From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > Sent: Monday, August 31, 2015 5:50 AM > To: James E.J. Bottomley > Cc: linux-scsi@vger.kernel.org; linux-ker...@vger.kernel.org; KY Srinivasan > ; Long Li ; Dexuan Cui > > Subject: [PATCH] scsi_scan: move 'INQU

[PATCH] scsi_scan: move 'INQUIRY result too short' message to debug level

Some Hyper-V hosts are known for ignoring SPC-2/3/4 requirement for 'INQUIRY data (see table ...) shall contain at least 36 bytes'. As a result we get tons on 'scsi 0:7:1:1: scsi scan: INQUIRY result too short (5), using 36' messages on console. As Hyper-V is also known for its serial port being ex

[PATCH v3 0/10] megaraid_sas : Updates for scsi for-next

MegaRaid driver changes. This patch set is rebased on top of below commit- commit da0dc9fb4e6b0ad5a947c27a3c48985f6a2377eb Author: Bjorn Helgaas Date: Tue Jul 7 15:52:45 2015 -0500 megaraid_sas: fix whitespace errors Please consider this patch set for next kernel release. Signed-off-by:

[PATCH v3 9/10] megaraid_sas : Code refactor for use of requestorId

Some of the code changes was proposed by David Binderman Removed redudant check of requestorId. Redundant condition: instance.requestorId. Check for plasma firmware 1.11 or new restructured to support only for specific device id Signed-off-by: Sumit Saxena Signed-off-by: Kashyap Desai --- d

[PATCH v3 10/10] megaraid_sas : Version upgrade

Signed-off-by: Sumit Saxena Signed-off-by: Kashyap Desai --- drivers/scsi/megaraid/megaraid_sas.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_sas.h b/drivers/scsi/megaraid/megaraid_sas.h index ccda60d..fc58ba3 100644 --- a/drivers/s

[PATCH v3 7/10] megaraid_sas : Print critical fw event message

Print firmware event in readable format. This will help user to track any critical firmware event without any application support. sample syslogd output - megaraid_sas :02:00.0: 8619 (491648347s/0x0020/WARN) - Controller temperature threshold exceeded. This may indicate inadequate system coo

[PATCH v3 6/10] megaraid_sas : Chip reset if driver fail to bring ioc ready

Patch which fix the issue reported as below. http://marc.info/?l=linux-scsi&m=143694494104544&w=2 This patch will try to do chip reset from driver load time. Driver load time, if firmware is not comming to ready state, driver try chip reset calling adp_reset() callback. For fusion adapter, that

[PATCH v3 04/10] megaraid_sas : Code cleanup-use local variable drv_ops inside megasas_ioc_init_fusion

Signed-off-by: Sumit Saxena Signed-off-by: Kashyap Desai Reviewed-by: Martin Petersen --- drivers/scsi/megaraid/megaraid_sas_fusion.c | 20 ++-- 1 files changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megarai

[PATCH v3 01/10] megaraid_sas : Synchronize driver headers with firmware APIs

Signed-off-by: Sumit Saxena Signed-off-by: Kashyap Desai Reviewed-by: Martin Petersen --- drivers/scsi/megaraid/megaraid_sas.h| 18 ++ drivers/scsi/megaraid/megaraid_sas_fusion.h |3 ++- 2 files changed, 16 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/m

[PATCH v3 5/10] megaraid_sas : Support for max_io_size 1MB

Driver will expose max sge = 256 (earlier it was 64), if firmware support extended IO size upto 1M. Signed-off-by: Sumit Saxena Signed-off-by: Kashyap Desai Reviewed-by: Martin Petersen --- drivers/scsi/megaraid/megaraid_sas.h|7 ++- drivers/scsi/megaraid/megaraid_sas_fusion.c |

[PATCH v3 3/10] megaraid_sas : Jbod sequence number support

Implemented JBOD map which will provide quick access for JBOD path and also provide sequence number. This will help hardware to fail command to the FW in case of any sequence mismatch. Fast Path IO for JBOD will refer JBOD map (which has sequence number per JBOD devices) instead of Raid map.

[PATCH v3 8/10] megaraid_sas : Fix validHandles check in io path

Syncro firmware supports round robin IO switch on dual path. For this driver use validHandles as a check for dual path. This check suppose to be > 1 (not > 2) Without this patch, earlier driver code does not use dual path functionality. Signed-off-by: Sumit Saxena Signed-off-by: Kashyap Desai

[PATCH v3 02/10] megaraid_sas : Increase timeout to 60 secs for abort frames during shutdown

Signed-off-by: Sumit Saxena Signed-off-by: Kashyap Desai Reviewed-by: Martin Petersen --- drivers/scsi/megaraid/megaraid_sas_base.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c

RE: [PATCH v2 0/10] megaraid_sas : Updates for scsi for-next

> -Original Message- > From: James Bottomley [mailto:james.bottom...@hansenpartnership.com] > Sent: Saturday, August 29, 2015 1:03 AM > To: sumit.sax...@avagotech.com > Cc: linux-scsi@vger.kernel.org; the...@redhat.com; > martin.peter...@oracle.com; h...@infradead.org; jbottom...@parallels.

RE: [scsi 5/7 RESEND] scsi_debug: schedule_resp fix input variable check

> > On Sun, 2015-08-30 at 10:36 +, Winkler, Tomas wrote: > > > > > > > > > > > > > > > I'm just not sure why the patches are not merged or even rejected. > > > > > > > > Because ideally I want a Maintainer ack. That's Doug Gilbert. > > > > James > > The patches were discussed and the ACked by