Sebastian Herbszt writes:
> Johannes Thumshirn wrote:
>> If the bf_get() call in lpfc_mbx_cmpl_rdp_page_a2() does succeeds, execution
>> continues normally and mp gets kfree()d.
>>
>> If the subsequent call to lpfc_sli_issue_mbox() fails execution jumps to the
>> error label where lpfc_mbuf_free
On 08/17/2015 07:36 AM, Dan Carpenter wrote:
These casts are wrong and unnecessary. They annoy static checkers
because they imply we are planning to write sizeof(long) bytes to a
sizeof(u32) buffer which would corrupt memory.
Hello Dan,
Can you verify whether that patch is still needed after
Hi Brian,
Thanks for reviewing.
All good suggestions that I am fine with implementing. As these are fairly
minor,
would you be okay with these being made in a separate ‘fix' patch series?
-matt
> On Aug 17, 2015, at 9:38 AM, Brian King wrote:
>
> On 08/13/2015 09:47 PM, Matthew R. Ochs wrote
Johannes Thumshirn wrote:
> If the bf_get() call in lpfc_mbx_cmpl_rdp_page_a2() does succeeds, execution
> continues normally and mp gets kfree()d.
>
> If the subsequent call to lpfc_sli_issue_mbox() fails execution jumps to the
> error label where lpfc_mbuf_free() is called with mp->virt and mp->
Does this look fine to you Jens?
I'd love to get this API into 4.3 so I can submit the NFS SCSI layout
patches that depend on it for 4.4.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vg
Broadcasting…
Regards,
Hiral
On 7/20/15, 5:48 PM, "Hiral Shah (hishah)" wrote:
>Hi Martin,
>
>Thanks for the suggestion. Actually boot make more sense as the value will be
>either 0 or 1 only. We have already release following patch to other non-linux
>customers. We will make sure next
The routines in scsi_rpm.c assume that if a runtime-PM callback is
invoked for a SCSI device, it can only mean that the device's driver
has asked the block layer to handle the runtime power management (by
calling blk_pm_runtime_init(), which among other things sets q->dev).
However, this assumpti
These casts are wrong and unnecessary. They annoy static checkers
because they imply we are planning to write sizeof(long) bytes to a
sizeof(u32) buffer which would corrupt memory.
Signed-off-by: Dan Carpenter
diff --git a/drivers/scsi/qla4xxx/ql4_init.c b/drivers/scsi/qla4xxx/ql4_init.c
index
On 08/13/2015 09:47 PM, Matthew R. Ochs wrote:
> --- a/drivers/scsi/cxlflash/common.h
> +++ b/drivers/scsi/cxlflash/common.h
> @@ -76,6 +76,12 @@ enum cxlflash_init_state {
> INIT_STATE_SCSI
> };
>
> +enum cxlflash_state {
> + STATE_NORMAL, /* Normal running state, everything good */
On Mon, 2015-08-17 at 14:12 +, Mahesh Rajashekhara wrote:
> Hi James,
>
> Please let me know the status of V6 patchset.
Well, you altered it fairly significantly with the combination, so I
need the original reviewers at least to glance over it and say their
reviews stand.
If you kept the rev
Hi James,
Please let me know the status of V6 patchset.
Thanks,
Mahesh
-Original Message-
From: Mahesh Rajashekhara [mailto:mahesh.rajashekh...@pmcs.com]
Sent: Thursday, August 13, 2015 5:52 AM
To: James Bottomley; Tomas Henzl
Cc: jbottom...@parallels.com; linux-scsi@vger.kernel.org;
aa
In case psataPayload->status has a status of IO_OPEN_CNX_ERROR_HW_RESOURCE_BUSY
ts->stat gets set to SAS_OPEN_REJECT but a missing 'break' statement causes a
fallthrough to the default handler of the switch statement overriding ts->stat
to SAS_DEV_NO_RESPONSE.
Signed-off-by: Johannes Thumshirn
Ac
Jack Wang writes:
> 2015-08-17 15:04 GMT+02:00 Johannes Thumshirn :
>> In case XXX returns with a status of IO_OPEN_CNX_ERROR_HW_RESOURCE_BUSY
Apparently I've hit enter to fast. This shouldn't be XXX but
psataPayload->status. I'll be sending a v2 :-(.
>> ts->stat gets set to SAS_OPEN_REJECT but
2015-08-17 15:04 GMT+02:00 Johannes Thumshirn :
> In case XXX returns with a status of IO_OPEN_CNX_ERROR_HW_RESOURCE_BUSY
> ts->stat gets set to SAS_OPEN_REJECT but a missing 'break' statement causes a
> fallthrough to the default handler of the switch statement overriding ts->stat
> to SAS_DEV_NO_
In case XXX returns with a status of IO_OPEN_CNX_ERROR_HW_RESOURCE_BUSY
ts->stat gets set to SAS_OPEN_REJECT but a missing 'break' statement causes a
fallthrough to the default handler of the switch statement overriding ts->stat
to SAS_DEV_NO_RESPONSE.
Signed-off-by: Johannes Thumshirn
---
drive
In bfa_fcs_lport_get_rport_max_speed() check if port is non NULL before
dereferencing it's child port->fcs->bfa to trl_enabled.
NB: I'm not entirely sure if port can even be NULL, so the check for NULL might
be useless as well.
Signed-off-by: Johannes Thumshirn
---
drivers/scsi/bfa/bfa_fcs_lpor
If the bf_get() call in lpfc_mbx_cmpl_rdp_page_a2() does succeeds, execution
continues normally and mp gets kfree()d.
If the subsequent call to lpfc_sli_issue_mbox() fails execution jumps to the
error label where lpfc_mbuf_free() is called with mp->virt and mp->phys as
function arguments. This is
On Fri, Aug 14, 2015 at 9:15 AM, Viswas G wrote:
> On Thu, Aug 13, 2015 at 6:13 PM, Jinpu Wang
> wrote:
>> Hi
>>
>> On Tue, Aug 11, 2015 at 11:36 AM, wrote:
>>> From: Viswas G
>>>
>>> In Nexus reset the device state request are not needed.
>>>
>>> Changes from V1:
>>> Device state change requ
18 matches
Mail list logo
