Re: [PATCH 0/9] qla2xxx: Patches for scsi "misc" branch.

2015-07-23 Thread Nicholas A. Bellinger
On Thu, 2015-07-23 at 23:38 -0700, Nicholas A. Bellinger wrote: > Hi Himanshu & Co, > > (Adding target-devel CC') > > On Wed, 2015-06-10 at 11:05 -0400, Himanshu Madhani wrote: > > Hi James, > This series contains a number of qla2xxx target mode related bug-fixes > that have not made it into s

Re: [PATCH 0/9] qla2xxx: Patches for scsi "misc" branch.

2015-07-23 Thread Nicholas A. Bellinger
Hi Himanshu & Co, (Adding target-devel CC') On Wed, 2015-06-10 at 11:05 -0400, Himanshu Madhani wrote: > Hi James, > > Please apply the following patches to the scsi tree at your earliest > convenience for inclusion in the next mainline merge window. > > Thanks, > Himanshu > > Himanshu Madhani

Re: [PATCH v1 0/4] Descriptor format sense data

2015-07-23 Thread Nicholas A. Bellinger
On Wed, 2015-07-15 at 10:55 +0300, Sagi Grimberg wrote: > This small patchset addresses some issues with descriptor format > sense data. > > Patch 1 fixes wrong additional sense length for descriptor format > information field. > > Patch 2 protects against buffer overflow in scsi_set_information_

Re: [PATCH v4 0/5] Target sense data handling modifications

2015-07-23 Thread Nicholas A. Bellinger
Hi Sagi & Co, Apologies for the extended delayed follow-up on this series.. Applied to target-pending/for-next, including the scsi_error.c -> scsi_common.c conversion in patch #4. Thanks folks! On Wed, 2015-07-08 at 17:58 +0300, Sagi Grimberg wrote: > This patch set modifies the target sense da

Re: [PATCH] iscsi-target: Fix iscsit_start_kthreads failure OOPs

2015-07-23 Thread Nicholas A. Bellinger
Hey Sagi, Apologies for the extended delay to follow-up on this.. On Tue, 2015-07-07 at 15:04 +0300, Sagi Grimberg wrote: > On 7/7/2015 12:01 PM, Nicholas A. Bellinger wrote: > > Hey Sagi, > > > > This addresses a regression with traditional iscsi-target that I noticed > > recently, but has not b

RE: [PATCH] target: add support for START_STOP_UNIT SCSI opcode

2015-07-23 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- > ow...@vger.kernel.org] On Behalf Of Spencer Baugh > Sent: Thursday, July 23, 2015 5:28 PM > To: Christoph Hellwig ; Spencer Baugh > ... > Subject: Re: [PATCH] target: add support for START_STOP_UNIT S

[PATCH 0/4] iscsi/iser-target fixes for v4.2-rc

2015-07-23 Thread Nicholas A. Bellinger
From: Nicholas Bellinger Hi Sagi & Co, The following series is a handful of iscsi/iser-target related bugfixes for issues uncovered during recent testing with v4.2-rc code. Patch #1 fixes a long-standing use-after-free issue during explicit TPG shutdown for demo-mode sessions. Patch #2 address

[PATCH 1/4] iscsi-target: Fix use-after-free during TPG session shutdown

2015-07-23 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch fixes a use-after-free bug in iscsit_release_sessions_for_tpg() where se_portal_group->session_lock was incorrectly released/re-acquired while walking the active se_portal_group->tpg_sess_list. The can result in a NULL pointer dereference when iscsit_close_ses

[PATCH 4/4] iser-target: Fix REJECT CM event use-after-free OOPs

2015-07-23 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch fixes a bug in iser-target code where the REJECT CM event handler code currently performs a isert_put_conn() for the final isert_conn->kref put, while iscsi_np process context is still blocked in isert_get_login_rx(). Once isert_get_login_rx() is awoking due t

[PATCH 3/4] iscsi-target: Fix iser explicit logout TX kthread leak

2015-07-23 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch fixes a regression introduced with the following commit in v4.0-rc1 code, where an explicit iser-target logout would result in ->tx_thread_active being incorrectly cleared by the logout post handler, and subsequent TX kthread leak: commit 88dcd2dab5c23b1c9

[PATCH 2/4] iscsi-target: Fix iscsit_start_kthreads failure OOPs

2015-07-23 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch fixes a regression introduced with the following commit in v4.0-rc1 code, where a iscsit_start_kthreads() failure triggers a NULL pointer dereference OOPs: commit 88dcd2dab5c23b1c9cfc396246d8f476c872f0ca Author: Nicholas Bellinger Date: Thu Feb

Re: [PATCH] target: add support for START_STOP_UNIT SCSI opcode

2015-07-23 Thread Spencer Baugh
From: Brian Bunker AIX servers using VIOS servers that virtualize FC cards will have a problem booting without support for START_STOP_UNIT. v2: Cite sb3r36 exactly, clean up if conditions Signed-off-by: Brian Bunker Signed-off-by: Spencer Baugh --- drivers/target/target_core_sbc.c | 36 +

[PATCH] target: fix crash in cmd tracing when cmd didn't match a LUN

2015-07-23 Thread Spencer Baugh
From: Alexei Potashnik If command didn't match a LUN and we're sending check condition, the target_cmd_complete ftrace point will crash because it assumes that cmd->t_task_cdb has been set. The fix will temporarily set t_task_cdb to the se_cmd buffer and copy first 6 bytes of cdb in there as soo

[Bug 101891] mvsas prep failed, NULL pointer dereference in mvs_slot_task_free+0x5/0x1f0 [mvsas]

2015-07-23 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=101891 --- Comment #1 from Dāvis --- Some more call traces [ cut here ] kernel: WARNING: CPU: 4 PID: 6442 at fs/sysfs/group.c:224 sysfs_remove_group+0xa1/0xb0() kernel: sysfs group 8189de80 not found for kobject 'end_de

Re: [PATCH v3] target: Drop iSCSI use of mutex around max_cmd_sn increment

2015-07-23 Thread Spencer Baugh
From: Roland Dreier In a performance profile, taking a mutex in iscsit_increment_maxcmdsn() shows up very high. However taking a mutex around "sess->max_cmd_sn += 1" seems pretty silly: we're not serializing against other contexts in any useful way. I did a quick audit and there don't appear t

[Bug 101891] New: mvsas prep failed, NULL pointer dereference in mvs_slot_task_free+0x5/0x1f0 [mvsas]

2015-07-23 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=101891 Bug ID: 101891 Summary: mvsas prep failed, NULL pointer dereference in mvs_slot_task_free+0x5/0x1f0 [mvsas] Product: SCSI Drivers Version: 2.5 Kernel Version: 4.1.2 Har

RE: [PATCH V5 05/11] [SCSI] aacraid: Tune response path if IsFastPath bit set

2015-07-23 Thread Rajinikanth Pandurangan
Hi Tomas, We will make the changes and submit. Thanks, -Original Message- From: Tomas Henzl [mailto:the...@redhat.com] Sent: Thursday, July 23, 2015 7:40 AM To: Rajinikanth Pandurangan; jbottom...@parallels.com; linux-scsi@vger.kernel.org Cc: aacr...@pmc-sierra.com; Harry Yang; Rich Bo

[PATCH v2] target: Drop iSCSI use of mutex around max_cmd_sn increment

2015-07-23 Thread Spencer Baugh
From: Roland Dreier In a performance profile, taking a mutex in iscsit_increment_maxcmdsn() shows up very high. However taking a mutex around "sess->max_cmd_sn += 1" seems pretty silly: we're not serializing against other contexts in any useful way. I did a quick audit and there don't appear t

RE: [PATCH V5 10/11] [SCSI] aacraid: Replace pci_enable_msix() with pci_enable_msix_range()

2015-07-23 Thread Rajinikanth Pandurangan
Hi Tomas, Thanks for the details. Will merge the patches and resubmit. -Original Message- From: Tomas Henzl [mailto:the...@redhat.com] Sent: Thursday, July 23, 2015 7:34 AM To: Rajinikanth Pandurangan; jbottom...@parallels.com; linux-scsi@vger.kernel.org Cc: aacr...@pmc-sierra.com; Ha

Re: [PATCH V5 05/11] [SCSI] aacraid: Tune response path if IsFastPath bit set

2015-07-23 Thread Tomas Henzl
On 22.7.2015 18:49, rajinikanth.panduran...@pmcs.com wrote: > From: Rajinikanth Pandurangan > > Description: > If 'IsFastPath' bit is set, then response path assumes no error > and skips error check. > > Changes from V2: > None > > Reviewed By: > Tomas Henzl , The same here - I

Re: [PATCH V5 03/11] [SCSI] aacraid: Change interrupt mode to MSI for series-6 controller

2015-07-23 Thread Tomas Henzl
On 22.7.2015 18:49, rajinikanth.panduran...@pmcs.com wrote: > From: Rajinikanth Pandurangan > > Description: > This change always sets MSI interrupt mode for series-6 controller. > Note: For series 6 family, MSIx is not supported. > > Changes from V2: > Only Subject & description change.

Re: [PATCH V5 10/11] [SCSI] aacraid: Replace pci_enable_msix() with pci_enable_msix_range()

2015-07-23 Thread Tomas Henzl
On 23.7.2015 15:42, Rajinikanth Pandurangan wrote: > Hello Tomas, > > Our real intention was to replace pci_enable_msix() with > pci_enable_msix_range(). > In V4, I had min as 8 and max as msi_count (which could be max of 32). So > range was 2 - 32. But then as you suggested to make separate p

RE: [PATCH V5 10/11] [SCSI] aacraid: Replace pci_enable_msix() with pci_enable_msix_range()

2015-07-23 Thread Rajinikanth Pandurangan
Hello Tomas, Our real intention was to replace pci_enable_msix() with pci_enable_msix_range(). In V4, I had min as 8 and max as msi_count (which could be max of 32). So range was 8 - 32. But then as you suggested to make separate patch if I wanted to set the min range different, I have create

RE: [PATCH V5 10/11] [SCSI] aacraid: Replace pci_enable_msix() with pci_enable_msix_range()

2015-07-23 Thread Rajinikanth Pandurangan
Hello Tomas, Our real intention was to replace pci_enable_msix() with pci_enable_msix_range(). In V4, I had min as 8 and max as msi_count (which could be max of 32). So range was 2 - 32. But then as you suggested to make separate patch if I wanted to set the min range different, I have create

Re: [PATCH V5 11/11] [SCSI] aacraid: Requests at least 2 MSIx in pci_enable_msix_range()

2015-07-23 Thread Tomas Henzl
On 22.7.2015 18:49, rajinikanth.panduran...@pmcs.com wrote: > From: Rajinikanth Pandurangan > > Description: > In MSIx mode, we need at least 2 vectors. > > Changes from V4: > Newly created for V5 based on review comment. > > Signed-off-by: Rajinikanth Pandurangan Tomas > --- >

Re: [PATCH V5 10/11] [SCSI] aacraid: Replace pci_enable_msix() with pci_enable_msix_range()

2015-07-23 Thread Tomas Henzl
On 22.7.2015 18:49, rajinikanth.panduran...@pmcs.com wrote: > From: Rajinikanth Pandurangan > > Description: > As pci_enable_msix() deprecated, replaced with pci_enable_msix_range() > > V4 Reviewed/commented by: > Tomas Henzl > > Changes from V4: > Changed to 1 as minimum m

dobre rano

2015-07-23 Thread buss msg
Nize kontaktujte me pro zakladni dohodu. E-mail: jjg.ch...@gmail.com -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] target: improve unsupported opcode message

2015-07-23 Thread Sagi Grimberg
On 7/23/2015 1:01 AM, Spencer Baugh wrote: From: Joern Engel Make the warning about unsupported SCSI opcode more useful: - Add in the initiator name so we know who's sending it. - Print the warning even for opcodes that spc_parse_cdb() knows about but that we don't handle. Signed-off-

Re: [PATCH] qla2xxx: Return the fabric command state for non-task management requests

2015-07-23 Thread Christoph Hellwig
On Tue, Jul 21, 2015 at 03:07:55PM -0700, Spencer Baugh wrote: > From: Dilip Kumar Uppugandla > > Invoking get_cmd_state for qla2xxx always returns 0. Instead change it > to return the actual fabric state from qla_tgt_cmd. This will help with > debugging. I think the ->get_cmd_state callback sho

Re: [PATCH] target: allow underflow/overflow for PR OUT etc. commands

2015-07-23 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig (altough normal Linux style would be to add parenthesis around the logial and) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/

Re: [PATCH] target: respond to unknown initiators with sensible REPORT LUNS list length

2015-07-23 Thread Christoph Hellwig
On Wed, Jul 22, 2015 at 03:08:17PM -0700, Spencer Baugh wrote: > done: > + /* > + * If no real LUNs are accessible, report an allocation length > + * of 1 LUN to account for virtual LUN 0. > + */ > + if (lun_count == 0) > + lun_count = 1; > + Shouldn't the code

Re: [PATCH] target: improve unsupported opcode message

2015-07-23 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] target: add support for START_STOP_UNIT SCSI opcode

2015-07-23 Thread Christoph Hellwig
On Tue, Jul 21, 2015 at 03:07:53PM -0700, Spencer Baugh wrote: > +static sense_reason_t > +sbc_emulate_startstop(struct se_cmd *cmd) > +{ > + unsigned char *cdb = cmd->t_task_cdb; > + > + /* From SBC-3: > + * Immediate bit should be set since there is nothing to complete > + * POW

[Bug 101841] iommu memory handling cause mmblock devices stop working

2015-07-23 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=101841 --- Comment #1 from Ivan --- intel_iommu=off does not help, but switched to 3.14.48 lts and successfully tranfered all the data without any error -- You are receiving this mail because: You are the assignee for the bug. -- To unsubscribe from t

[Bug 101841] New: iommu memory handling cause mmblock devices stop working

2015-07-23 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=101841 Bug ID: 101841 Summary: iommu memory handling cause mmblock devices stop working Product: IO/Storage Version: 2.5 Kernel Version: 4.0.x, 4.1.x Hardware: All