Re: [PATCH] target/iscsi: fix digest computation for chained SGs

2015-07-21 Thread Roland Dreier
On Tue, Jul 21, 2015 at 1:57 AM, Sagi Grimberg wrote: > How were you able to get a chained SG list in the target code? Local hack. So this bug can't be hit in current mainline code, but patch improves the code and removes a hidden booby-trap, so I think it makes sense to apply. -- To unsubscribe

Re: [PATCH] qla2xxx: Return the fabric command state for non-task management requests

2015-07-21 Thread Himanshu Madhani
On 7/21/15, 3:07 PM, "Spencer Baugh" wrote: >From: Dilip Kumar Uppugandla > >Invoking get_cmd_state for qla2xxx always returns 0. Instead change it >to return the actual fabric state from qla_tgt_cmd. This will help with >debugging. > >Signed-off-by: Dilip Kumar Uppugandla >Signed-off-by: Spe

Re: [PATCH] target: fix crash in cmd tracing when cmd didn't match a LUN

2015-07-21 Thread Spencer Baugh
Please disregard, depends on another patch. Will send again later. Sorry for the noise. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] target: fix crash in cmd tracing when cmd didn't match a LUN

2015-07-21 Thread Spencer Baugh
From: Alexei Potashnik If command didn't match a LUN and we're sending check condition, the target_cmd_complete ftrace point will crash because it assumes that cmd->t_task_cdb has been set. The fix will temporarily set t_task_cdb to the se_cmd buffer and copy first 6 bytes of cdb in there as soo

[PATCH] qla2xxx: Return the fabric command state for non-task management requests

2015-07-21 Thread Spencer Baugh
From: Dilip Kumar Uppugandla Invoking get_cmd_state for qla2xxx always returns 0. Instead change it to return the actual fabric state from qla_tgt_cmd. This will help with debugging. Signed-off-by: Dilip Kumar Uppugandla Signed-off-by: Spencer Baugh --- drivers/scsi/qla2xxx/tcm_qla2xxx.c | 6

[PATCH] target/iscsi: Fix double free of a TUR followed by a solicited NOPOUT

2015-07-21 Thread Spencer Baugh
From: Alexei Potashnik Make sure all non-READ SCSI commands get targ_xfer_tag initialized to 0x, not just WRITEs. Double-free of a TUR cmd object occurs under the following scenario: 1. TUR received (targ_xfer_tag is uninitialized and left at 0) 2. TUR status sent 3. First unsolicited N

[PATCH] target: add support for START_STOP_UNIT SCSI opcode

2015-07-21 Thread Spencer Baugh
From: Brian Bunker AIX servers using VIOS servers that virtualize FC cards will have a problem booting without support for START_STOP_UNIT. Signed-off-by: Brian Bunker Signed-off-by: Spencer Baugh --- drivers/target/target_core_sbc.c | 33 + 1 file changed, 33

[PATCH V4 10/10] [SCSI] aacraid: Replace pci_enable_msix() with pci_enable_msix_range()

2015-07-21 Thread rajinikanth.pandurangan
From: Rajinikanth Pandurangan Description: As pci_enable_msix() deprecated, replaced with pci_enable_msix_range() V3 Reviewed/commented by: Tomas Henzl Changes from V3: Uses pci_enable_msix_range() instead of pci_enable_msix_exact() based on review comment. Signed-off-

[PATCH V4 09/10] [SCSI] aacraid: Update driver version

2015-07-21 Thread rajinikanth.pandurangan
From: Rajinikanth Pandurangan Signed-off-by: Rajinikanth Pandurangan --- drivers/scsi/aacraid/aacraid.h | 2 +- drivers/scsi/aacraid/linit.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/aacraid/aacraid.h b/drivers/scsi/aacraid/aacraid.h index 7b95227..73

[PATCH V4 08/10] [SCSI] aacraid: Send commit-config to controller firmware

2015-07-21 Thread rajinikanth.pandurangan
From: Rajinikanth Pandurangan Description: Controller BIOS/UEFI driver used to send this request. But for IBM-Power system there is no BIOS/UEFI driver. So this change is required for IBM, otherwise controller will be read-only mode. Changes from V2: None Reviewed by:

[PATCH V4 07/10] [SCSI] aacraid: Unblock IOCTLs to controller once system resumed from suspend

2015-07-21 Thread rajinikanth.pandurangan
From: Rajinikanth Pandurangan Description: Driver blocks ioctls once it received shutdown/suspend request during suspend/hybernation. This patch unblocks ioctls on resume path. Changes from V2: None Reviewed by: Mahesh Rajashekhara , Johannes Thumshirn Signed-off-by: Rajinik

[PATCH V4 03/10] [SCSI] aacraid: Change interrupt mode to MSI for series-6 controller

2015-07-21 Thread rajinikanth.pandurangan
From: Rajinikanth Pandurangan Description: This change always sets MSI interrupt mode for series-6 controller. Note: For series 6 family, MSIx is not supported. Changes from V2: Only Subject & description change. Reviewed by: Tomas Henzl , Mahesh Rajashekhara , Johannes Thumshirn S

[PATCH V4 04/10] [SCSI] aacraid: Enable 64-bit write to controller register

2015-07-21 Thread rajinikanth.pandurangan
From: Rajinikanth Pandurangan Description: If writeq() not supported, then do atomic two 32bit write Changes from V2: None Reviewed by: Tomas Henzl , Mahesh Rajashekhara , Johannes Thumshirn Signed-off-by: Rajinikanth Pandurangan --- drivers/scsi/aacraid/aacraid.h | 9 +

[PATCH V4 06/10] [SCSI] aacraid: Reset irq affinity hints before releasing irq

2015-07-21 Thread rajinikanth.pandurangan
From: Rajinikanth Pandurangan Description: Reset irq affinity hints before releasing IRQ Removed duplicate code of IRQ acquire/release Changes from V2: None Reviewed by: Mahesh Rajashekhara , Johannes Thumshirn Signed-off-by: Rajinikanth Pandurangan --- drivers/scsi/aacrai

[PATCH V4 05/10] [SCSI] aacraid: Tune response path if IsFastPath bit set

2015-07-21 Thread rajinikanth.pandurangan
From: Rajinikanth Pandurangan Description: If 'IsFastPath' bit is set, then response path assumes no error and skips error check. Changes from V2: None Reviewed By: Tomas Henzl , Mahesh Rajashekhara , Johannes Thumshirn Signed-off-by: Rajinikanth Pandurangan --- drivers/s

[PATCH V4 01/10] [SCSI] aacraid: Fix for logical device name and UID not exposed to the OS

2015-07-21 Thread rajinikanth.pandurangan
From: Rajinikanth Pandurangan Description: Driver sends the right size of the response buffer. Changes from V2: None V2: Reviewed-by: Johannes Thumshirn Reviewed-by: Tomas Henzl Reviewed-by: Mahesh Rajashekhara Signed-off-by: Rajinikanth Pandurangan --- drivers/scsi/aacraid/aachba

[PATCH V4 02/10] [SCSI] aacraid: Add Power Management support

2015-07-21 Thread rajinikanth.pandurangan
From: Rajinikanth Pandurangan Description: * .suspend() and .resume() routines implemented in the driver * aac_release_resources() initiates firmware shutdown * aac_acquire_resources re-initializes the host interface Changes from V2: Increased msleep(1) to msleep(20) Reve

[PATCH V4 00/10] [SCSI] aacraid: Patchset for aacraid driver version 41010

2015-07-21 Thread rajinikanth.pandurangan
From: Rajinikanth Pandurangan This patchset includes the following changes (bug fixes and new feature support) specific to aacraid driver. V4: Updated code with pci_enable_msix_range instead of exact. V3: Increased msleep() time from 1 to 20. Created new patch for pci_enable_msix() replacement.

Re: [PATCH 1/2] target: remove unused lun_flags field from se_lun

2015-07-21 Thread Spencer Baugh
Christoph Hellwig writes: > Looks good, > > but what's up with your From lines: > > On Mon, Jul 20, 2015 at 04:29:49PM -0700, Spencer Baugh wrote: >> From: Spencer Baugh >> >> From: Chris Zankel > > plus another address for you in the actual email From line. Who > did actually write this patc

Re: [PATCH] scsi: fix memory leak with scsi-mq

2015-07-21 Thread Christoph Hellwig
Thanks Tony, this looks good to me. In the long run I'll see how we can hide these implementation details in the lib/scatterlist.c code instead of burdening it on the users. Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a

Re: [PATCH 2/2] target: remove initiatorname field in se_acl_lun

2015-07-21 Thread Christoph Hellwig
Looks good too, but same From: issue as the last patch. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] target: remove unused lun_flags field from se_lun

2015-07-21 Thread Christoph Hellwig
Looks good, but what's up with your From lines: On Mon, Jul 20, 2015 at 04:29:49PM -0700, Spencer Baugh wrote: > From: Spencer Baugh > > From: Chris Zankel plus another address for you in the actual email From line. Who did actually write this patch? -- To unsubscribe from this list: send th

Re: [PATCH] target/iscsi: fix digest computation for chained SGs

2015-07-21 Thread Sagi Grimberg
On 7/21/2015 3:12 AM, Spencer Baugh wrote: From: Alexei Potashnik Current implementation assumes that all the buffers of an IO are linked with a single SG list. Which makes it fail if SG chaining is used. Signed-off-by: Alexei Potashnik --- drivers/target/iscsi/iscsi_target.c | 9 -

Re: [PATCH 1/2] mpt2sas: Refcount sas_device objects and fix unsafe list usage

2015-07-21 Thread Calvin Owens
On Sunday 07/12 at 23:52 -0700, Christoph Hellwig wrote: > On Sat, Jul 11, 2015 at 09:24:55PM -0700, Calvin Owens wrote: > > These objects can be referenced concurrently throughout the driver, we > > need a way to make sure threads can't delete them out from under each > > other. This patch adds th

Re: [PATCH 1/2] mpt2sas: Refcount sas_device objects and fix unsafe list usage

2015-07-21 Thread Calvin Owens
On Monday 07/13 at 11:05 -0400, Joe Lawrence wrote: > On 07/12/2015 12:24 AM, Calvin Owens wrote: > > These objects can be referenced concurrently throughout the driver, we > > need a way to make sure threads can't delete them out from under each > > other. This patch adds the refcount, and refacto

Re: [PATCH 1/2] mpt2sas: Refcount sas_device objects and fix unsafe list usage

2015-07-21 Thread Calvin Owens
On Thursday 07/16 at 20:27 +0530, Sreekanth Reddy wrote: > On Sun, Jul 12, 2015 at 9:54 AM, Calvin Owens wrote: > > These objects can be referenced concurrently throughout the driver, we > > need a way to make sure threads can't delete them out from under each > > other. This patch adds the refcou