Re: [PATCH v3] [SCSI] mpt2sas, mpt3sas: Abort initialization if no memory I/O resources detected

2015-07-14 Thread Sreekanth Reddy
On Tue, Jul 14, 2015 at 10:36:58PM -0700, Yinghai Lu wrote: > On Tue, Jul 14, 2015 at 9:49 PM, Sreekanth Reddy > wrote: > > Driver crashes if the BIOS do not set up at least one > > memory I/O resource. This failure can happen if the device is too > > slow to respond during POST and is missed by t

Re: [PATCH v3] [SCSI] mpt2sas, mpt3sas: Abort initialization if no memory I/O resources detected

2015-07-14 Thread Yinghai Lu
On Tue, Jul 14, 2015 at 9:49 PM, Sreekanth Reddy wrote: > Driver crashes if the BIOS do not set up at least one > memory I/O resource. This failure can happen if the device is too > slow to respond during POST and is missed by the BIOS, but Linux > then detects the device later in the boot process

[PATCH] MAINTAINERS: Update LSILOGIC MPT FUSION DRIVERS (FC/SAS/SPI) maintainers list

2015-07-14 Thread Sreekanth Reddy
Updating maintainers list for the entry LSILOGIC MPT FUSION DRIVERS in MAINTAINERS file Signed-off-by: Sreekanth Reddy --- MAINTAINERS | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 2d3d55c..c3cd5c9 100644 --- a/MAINTAINERS +++ b/MAINTAIN

[PATCH v3] [SCSI] mpt2sas, mpt3sas: Abort initialization if no memory I/O resources detected

2015-07-14 Thread Sreekanth Reddy
Driver crashes if the BIOS do not set up at least one memory I/O resource. This failure can happen if the device is too slow to respond during POST and is missed by the BIOS, but Linux then detects the device later in the boot process. Changes in v3: Rearranged the code to remove the code redun

[PATCH v2 7/8] qla2xxx: drop cmds/tmrs arrived while session is being deleted

2015-07-14 Thread Himanshu Madhani
From: Alexei Potashnik If a new initiator (different WWN) shows up on the same fcport, old initiator's session is scheduled for deletion. But there is a small window between it being marked with QLA_SESS_DELETION_IN_PROGRESS and qlt_unret_sess getting called when new session's commands will keep

[PATCH v2 2/8] qla2xxx: cleanup cmd in qla workqueue before processing TMR

2015-07-14 Thread Himanshu Madhani
From: Swapnil Nagle Since cmds go into qla_tgt_wq and TMRs don't, it's possible that TMR like TASK_ABORT can be queued over the cmd for which it was meant. To avoid this race, use a per-port list to keep track of cmds that are enqueued to qla_tgt_wq but not yet processed. When a TMR arrives, iter

[PATCH v2 6/8] qla2xxx: disable scsi_transport_fc registration in target mode

2015-07-14 Thread Himanshu Madhani
From: Alexei Potashnik There are multiple reasons for disabling this: 1. It provides no functional benefit. We pretty much only get a few more sysfs entries for each port, but all that information is already available from /sys/kernel/debug/target/qla-session-X 2. It already only works in priva

[PATCH v2 5/8] qla2xxx: added sess generations to detect RSCN update races

2015-07-14 Thread Himanshu Madhani
From: Alexei Potashnik RSCN processing in qla2xxx driver can run in parallel with ELS/IO processing. As such the decision to remove disappeared fc port's session could be stale, because a new login sequence has occurred since and created a brand new session. Previous mechanism of dealing with th

[PATCH v2 3/8] qla2xxx: delay plogi/prli ack until existing sessions are deleted

2015-07-14 Thread Himanshu Madhani
From: Alexei Potashnik - keep qla_tgt_sess object on the session list until it's freed - modify use of sess->deleted flag to differentiate delayed session deletion that can be cancelled from irreversible one: QLA_SESS_DELETION_PENDING vs QLA_SESS_DELETION_IN_PROGRESS - during IN_PROGRESS de

[PATCH v2 4/8] qla2xxx: Abort stale cmds on qla_tgt_wq when plogi arrives

2015-07-14 Thread Himanshu Madhani
From: Alexei Potashnik cancel any commands from initiator's s_id that are still waiting on qla_tgt_wq when PLOGI arrives. Cc: Signed-off-by: Alexei Potashnik Acked-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_target.c | 35 +++

[PATCH v2 0/8] qla2xxx: Updates for Target Mode driver

2015-07-14 Thread Himanshu Madhani
Hi James, This series is applied on top of patch series sent on June 10 [PATCH 0/9] qla2xxx: Patches for scsi "misc" branch (http://marc.info/?l=linux-scsi&m=143395156920505&w=2) These set of patches addresses issue with reuse of stale command found in a customer enviorment. Here's sequence of

[PATCH v2 8/8] qla2xxx: terminate exchange when command is aborted by LIO

2015-07-14 Thread Himanshu Madhani
From: Alexei Potashnik The newly introduced aborted_task TFO callback has to terminate exchange with QLogic driver, since command is being deleted and no status will be queued to the driver at a later point. This patch also moves the burden of releasing one cmd refcount to the aborted_task handl

[PATCH v2 1/8] qla2xxx: kill sessions/log out initiator on RSCN and port down events

2015-07-14 Thread Himanshu Madhani
From: Roland Dreier To fix some issues talking to ESX, this patch modifies the qla2xxx driver so that it never logs into remote ports. This has the side effect of getting rid of the "rports" entirely, which means we never log out of initiators and never tear down sessions when an initiator goes

[PATCH 3/3] [RESEND] ipr: Fix invalid array indexing for HRRQ

2015-07-14 Thread Brian King
Fixes another signed / unsigned array indexing bug in the ipr driver. Currently, when hrrq_index wraps, it becomes a negative number. We do the modulo, but still have a negative number, so we end up indexing backwards in the array. Given where the hrrq array is located in memory, we probably won't

[PATCH 0/3] ipr: Fixes for 4.2-rc

2015-07-14 Thread Brian King
James, Given the previous ipr driver update missed the 4.2 merge window, I'm resending the three patches also critical enough for -stable. The first is a fix for an oops and the other two are fixes for memory corruption bugs. If you've already queued these up, you can ignore this resend, but I

[PATCH 1/3] [RESEND] ipr: Fix locking for unit attention handling

2015-07-14 Thread Brian King
Make sure we have the host lock held when calling scsi_report_bus_reset. Fixes a crash seen as the __devices list in the scsi host was changing as we were iterating through it. Cc: Reviewed-by: Wen Xiong Reviewed-by: Gabriel Krisman Bertazi Signed-off-by: Brian King --- drivers/scsi/ipr.c |

[PATCH 2/3] [RESEND] ipr: Fix incorrect trace indexing

2015-07-14 Thread Brian King
When ipr's internal driver trace was changed to an atomic, a signed/unsigned bug slipped in which results in us indexing backwards in our memory buffer writing on memory that does not belong to us. This patch fixes this by removing the modulo and instead just mask off the low bits. Cc: Tested-by

Re: [PATCH 3/3] target: Return descriptor format sense data

2015-07-14 Thread Christoph Hellwig
On Tue, Jul 14, 2015 at 02:59:51PM +0300, Sagi Grimberg wrote: > diff --git a/include/target/target_core_backend.h > b/include/target/target_core_backend.h > index 1e5c8f9..6ce370f 100644 > --- a/include/target/target_core_backend.h > +++ b/include/target/target_core_backend.h > @@ -3,6 +3,9 @@ >

Re: [PATCH] fix host max depth checking for the 'queue_depth' sysfs interface

2015-07-14 Thread Hannes Reinecke
On 07/14/2015 04:20 PM, Martin K. Petersen wrote: >> "Jens" == Jens Axboe writes: > >>> Fully agreed. I would vote for making the host template read-only and >>> modify all drivers to use the shost setting. > > Jens> Indeed, that would be a much saner choice. The settings in a > Jens> (effec

[PATCH 1/1] Using the local variable instead of I/O flag to acquire io_req_lock in fnic_queuecommand() to avoid deadloack

2015-07-14 Thread Hiral Shah
We added changes in fnic driver patch 1.6.0.16 to acquire io_req_lock in fnic_queuecommand() before issuing I/O so that io completion is serialized. But when releasing the lock we check for the I/O flag and this could be modified if IO abort occurs before I/O completion. In this case we wont re

Re: [PATCH] fix host max depth checking for the 'queue_depth' sysfs interface

2015-07-14 Thread Martin K. Petersen
> "Jens" == Jens Axboe writes: >> Fully agreed. I would vote for making the host template read-only and >> modify all drivers to use the shost setting. Jens> Indeed, that would be a much saner choice. The settings in a Jens> (effectively already) read-only host template seems like somewhat J

Re: [PATCH] fix host max depth checking for the 'queue_depth' sysfs interface

2015-07-14 Thread Hannes Reinecke
On 07/14/2015 04:04 PM, Jens Axboe wrote: > On 07/14/2015 05:22 AM, Hannes Reinecke wrote: >> On 07/14/2015 09:13 AM, Christoph Hellwig wrote: >>> Looks good: >>> >>> Reviewed-by: Christoph Hellwig >>> >>> I wonder if we should start to gradually phase out these tuables >>> in the >>> host templat

Re: [PATCH] fix host max depth checking for the 'queue_depth' sysfs interface

2015-07-14 Thread Jens Axboe
On 07/14/2015 05:22 AM, Hannes Reinecke wrote: On 07/14/2015 09:13 AM, Christoph Hellwig wrote: Looks good: Reviewed-by: Christoph Hellwig I wonder if we should start to gradually phase out these tuables in the host template. It's not really more complicated to set them directly in the host

Re: [PATCH 3/3] target: Return descriptor format sense data

2015-07-14 Thread Bart Van Assche
On 07/14/15 04:59, Sagi Grimberg wrote: +#define TARGET_SENSE_DESC_FORMAT(dev) \ + dev->transport->get_blocks(dev) >= 0xULL From SPC-5: "4.4.4 Returning a value in the INFORMATION field in the sense data. To return a value less than or equal to _h in the INFORMA

Re: [PATCH 3/3] target: Return descriptor format sense data

2015-07-14 Thread Sagi Grimberg
On 7/14/2015 11:21 AM, Martin K. Petersen wrote: "Christoph" == Christoph Hellwig writes: Christoph> I think this needs to be a tunable as old initiators might Christoph> not be able to cope with descriptor sense data. My idea was Christoph> to only turn it own if the LU is large enough to ne

Re: [PATCH v2] aic7xxx: replace kmalloc/strcpy by kstrdup

2015-07-14 Thread walter harms
Am 14.07.2015 12:07, schrieb Hannes Reinecke: > On 07/14/2015 12:02 PM, Christophe JAILLET wrote: >> This replaces kmalloc + strcpy by an equivalent call to kstrdup. >> >> Signed-off-by: Christophe JAILLET >> --- >> v2: remove useless curly braces >> >> drivers/scsi/aic7xxx/aic79xx_osm.c | 6 ++

Re: [PATCH] Remove check for SAS expander when querying bay/enclosure IDs.

2015-07-14 Thread Hannes Reinecke
On 07/13/2015 04:27 PM, Jordan Hargrave wrote: > Dell Server backplanes can report bay/enclosure IDs without an > expander present. This patch allows the bay/enclosure IDs to be > propagaged to sysfs.we > > Signed-off-by: Jordan Hargrave > --- > drivers/scsi/scsi_transport_sas.c | 10 --

Re: [PATCH] fix host max depth checking for the 'queue_depth' sysfs interface

2015-07-14 Thread Hannes Reinecke
On 07/14/2015 09:13 AM, Christoph Hellwig wrote: > Looks good: > > Reviewed-by: Christoph Hellwig > > I wonder if we should start to gradually phase out these tuables in the > host template. It's not really more complicated to set them directly > in the host anyway. Fully agreed. I would vote

[PATCH v2] mpt2sas: setpci reset kernel oops fix

2015-07-14 Thread Nagarajkumar Narayanan
Patch Description: In mpt2sas driver due to lack of synchronization between ioctl, BRM status access through sysfs, pci resource removal kernel oops happen as ioctl path and BRM status sysfs access path still tries to access the removed resources kernel: BUG: unable to handle kernel paging reque

Re: [PATCH v2] aic7xxx: replace kmalloc/strcpy by kstrdup

2015-07-14 Thread Hannes Reinecke
On 07/14/2015 12:02 PM, Christophe JAILLET wrote: > This replaces kmalloc + strcpy by an equivalent call to kstrdup. > > Signed-off-by: Christophe JAILLET > --- > v2: remove useless curly braces > > drivers/scsi/aic7xxx/aic79xx_osm.c | 6 ++ > drivers/scsi/aic7xxx/aic7xxx_osm.c | 6 ++ >

[PATCH v2] aic7xxx: replace kmalloc/strcpy by kstrdup

2015-07-14 Thread Christophe JAILLET
This replaces kmalloc + strcpy by an equivalent call to kstrdup. Signed-off-by: Christophe JAILLET --- v2: remove useless curly braces drivers/scsi/aic7xxx/aic79xx_osm.c | 6 ++ drivers/scsi/aic7xxx/aic7xxx_osm.c | 6 ++ 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/dri

Re: [PATCH] aic7xxx: replace kmalloc/strcpy by kstrdup

2015-07-14 Thread Dan Carpenter
On Tue, Jul 14, 2015 at 09:25:16AM +0200, Christophe JAILLET wrote: > --- a/drivers/scsi/aic7xxx/aic79xx_osm.c > +++ b/drivers/scsi/aic7xxx/aic79xx_osm.c > @@ -1250,9 +1250,8 @@ ahd_linux_register_host(struct ahd_softc *ahd, struct > scsi_host_template *templa > ahd_set_unit(ahd, ahd_linux_u

Re: [PATCH 3/3] target: Return descriptor format sense data

2015-07-14 Thread Martin K. Petersen
> "Christoph" == Christoph Hellwig writes: Christoph> I think this needs to be a tunable as old initiators might Christoph> not be able to cope with descriptor sense data. My idea was Christoph> to only turn it own if the LU is large enough to need it. We could make it conditional and only

[PATCH] aic7xxx: replace kmalloc/strcpy by kstrdup

2015-07-14 Thread Christophe JAILLET
This replaces kmalloc + strcpy by an equivalent call to kstrdup. Signed-off-by: Christophe JAILLET --- drivers/scsi/aic7xxx/aic79xx_osm.c | 3 +-- drivers/scsi/aic7xxx/aic7xxx_osm.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/aic7xxx/aic79xx_osm.c b/driv

Re: [PATCH 3/3] target: Return descriptor format sense data

2015-07-14 Thread Christoph Hellwig
On Sun, Jul 12, 2015 at 01:37:03PM +0300, Sagi Grimberg wrote: > Fixed size sense data information field is only 32 bits which > means the sector (64 bits) information will be truncated. > > Move to descriptor format sense data to correctly report full > sector information. I think this needs to

Re: [PATCH] fix host max depth checking for the 'queue_depth' sysfs interface

2015-07-14 Thread Christoph Hellwig
Looks good: Reviewed-by: Christoph Hellwig I wonder if we should start to gradually phase out these tuables in the host template. It's not really more complicated to set them directly in the host anyway. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a m