Re: [PATCH v1 3/3] target: Use scsi helpers to build the sense data correctly

2015-07-05 Thread Hannes Reinecke
On 07/05/2015 09:31 AM, Sagi Grimberg wrote: > Instead of open coding the sense buffer construction, use > scsi scsi_build_sense_buffer() and scsi_set_sense_information() > helpers which moved to scsi_common. > > This patch also fixes wrong setting of descriptor format sense data > for t10-pi inte

Re: [PATCH v1 2/3] target: Split transport_send_check_condition_and_sense()

2015-07-05 Thread Hannes Reinecke
On 07/05/2015 09:31 AM, Sagi Grimberg wrote: > From: Bart Van Assche > > Move the code for translating a sense_reason_t code into a SCSI status > ASC and ASCQ codes from transport_send_check_condition_and_sense() into > the new function translate_sense_reason(). Convert the switch statement > tha

Re: [PATCH v1 1/3] target: Inline transport_get_sense_codes()

2015-07-05 Thread Hannes Reinecke
On 07/05/2015 09:31 AM, Sagi Grimberg wrote: > From: Bart Van Assche > > Inline this function in its call site since it performs a trivial > task and since it is only called once. > > Signed-off-by: Bart Van Assche > --- > drivers/target/target_core_transport.c | 16 ++-- > 1 file

RE: [PATCH] csiostor:Make the function csio_ln_prep_ecwr have a return type of void

2015-07-05 Thread Anish Bhatt
Acked-by: Anish Bhatt -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[Bug 101011] Kernel Oops when disconnecting a mounted ext4 usb stick

2015-07-05 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=101011 --- Comment #4 from konra...@gmail.com --- Created attachment 181971 --> https://bugzilla.kernel.org/attachment.cgi?id=181971&action=edit lspci -vvnn -- You are receiving this mail because: You are the assignee for the bug. -- To unsubscribe f

[Bug 101011] Kernel Oops when disconnecting a mounted ext4 usb stick

2015-07-05 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=101011 --- Comment #2 from konra...@gmail.com --- Created attachment 181951 --> https://bugzilla.kernel.org/attachment.cgi?id=181951&action=edit cat /proc/version -- You are receiving this mail because: You are the assignee for the bug. -- To unsubsc

[Bug 101011] Kernel Oops when disconnecting a mounted ext4 usb stick

2015-07-05 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=101011 --- Comment #3 from konra...@gmail.com --- Created attachment 181961 --> https://bugzilla.kernel.org/attachment.cgi?id=181961&action=edit dmesg -- You are receiving this mail because: You are the assignee for the bug. -- To unsubscribe from th

[Bug 101011] Kernel Oops when disconnecting a mounted ext4 usb stick

2015-07-05 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=101011 --- Comment #1 from konra...@gmail.com --- Created attachment 181941 --> https://bugzilla.kernel.org/attachment.cgi?id=181941&action=edit uname -a -- You are receiving this mail because: You are the assignee for the bug. -- To unsubscribe from

[Bug 101011] New: Kernel Oops when disconnecting a mounted ext4 usb stick

2015-07-05 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=101011 Bug ID: 101011 Summary: Kernel Oops when disconnecting a mounted ext4 usb stick Product: IO/Storage Version: 2.5 Kernel Version: 4.1.1-040101-generic Hardware: All

Re: [PATCH] libiscsi: Fix iscsi_check_transport_timeouts possible infinite loop

2015-07-05 Thread Sagi Grimberg
On 7/2/2015 11:11 PM, Mike Christie wrote: On 6/30/15, 9:55 AM, Sagi Grimberg wrote: From: Ariel Nahum Connection last_ping is not being updated when iscsi_send_nopout fails. Not updating the last_ping will cause firing a timer to a past time (last_ping + ping_tmo < current_time) which trigger

[Bug 100921] Kernel cannot read partition table automatically.But use partprobe command can.

2015-07-05 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=100921 --- Comment #1 from Wallance --- My USB devices have VFAT filesystem. -- You are receiving this mail because: You are the assignee for the bug. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to

[Bug 100921] Kernel cannot read partition table automatically.But use partprobe command can.

2015-07-05 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=100921 Wallance changed: What|Removed |Added Component|SCSI|USB Product|IO/Storage

Re: [PATCH RFC] target: Use scsi helpers to build the sense data correctly

2015-07-05 Thread Sagi Grimberg
On 7/4/2015 6:48 PM, Bart Van Assche wrote: Bart, any chance you could resend them? Bart, would you prefer to re-send your changes on top of v1 of this one? It should be easy enough. The modification needed is that struct sense_info needs a desc_format bool to indicate if the sense data is c

[PATCH v1] libiscsi: Fix iscsi_check_transport_timeouts possible infinite loop

2015-07-05 Thread Sagi Grimberg
From: Ariel Nahum Connection last_ping is not being updated when iscsi_send_nopout fails. Not updating the last_ping will cause firing a timer to a past time (last_ping + ping_tmo < current_time) which triggers an infinite loop of iscsi_check_transport_timeouts() and hogs the cpu. Fix this issue

Re: [PATCH RFC] target: Use scsi helpers to build the sense data correctly

2015-07-05 Thread Sagi Grimberg
On 7/3/2015 7:12 PM, Christoph Hellwig wrote: On Mon, Jun 29, 2015 at 06:05:25PM +0300, Sagi Grimberg wrote: Instead of open coding the sense buffer construction, use scsi scsi_build_sense_buffer() and scsi_set_sense_information() helpers. This patch also fixes wrong setting of descriptor forma

[Bug 100921] New: Kernel cannot read partition table automatically.But use partprobe command can.

2015-07-05 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=100921 Bug ID: 100921 Summary: Kernel cannot read partition table automatically.But use partprobe command can. Product: IO/Storage Version: 2.5 Kernel Version: 4.1.0 Hardware:

[GIT PULL] target updates for v4.2-rc1

2015-07-05 Thread Nicholas A. Bellinger
Hi Linus, Here are the outstanding target-pending updates for v4.2-rc1. Please go ahead and pull from: git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git for-next It's been a busy development cycle for target-core in a number of different areas. The fabric API usage for se

Re: [PATCH RFC] target: Use scsi helpers to build the sense data correctly

2015-07-05 Thread Bart Van Assche
On 07/04/2015 03:47 AM, Sagi Grimberg wrote: On 7/3/2015 7:12 PM, Christoph Hellwig wrote: On Mon, Jun 29, 2015 at 06:05:25PM +0300, Sagi Grimberg wrote: Instead of open coding the sense buffer construction, use scsi scsi_build_sense_buffer() and scsi_set_sense_information() helpers. This patc

[PATCH v1 0/3] Target sense data handling modifications

2015-07-05 Thread Sagi Grimberg
This patch set modifies the target sense data handling. The main changes are that the sense data handling moved to translate_sense_reason() and the sense reason switch statement was converted to a table. In addition the sense buffer construction is now done with scsi sense helpers which moved to sc

[PATCH v1 1/3] target: Inline transport_get_sense_codes()

2015-07-05 Thread Sagi Grimberg
From: Bart Van Assche Inline this function in its call site since it performs a trivial task and since it is only called once. Signed-off-by: Bart Van Assche --- drivers/target/target_core_transport.c | 16 ++-- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/drivers

[PATCH v1 2/3] target: Split transport_send_check_condition_and_sense()

2015-07-05 Thread Sagi Grimberg
From: Bart Van Assche Move the code for translating a sense_reason_t code into a SCSI status ASC and ASCQ codes from transport_send_check_condition_and_sense() into the new function translate_sense_reason(). Convert the switch statement that performs the translation into table-driven code. Signe

[PATCH v1 3/3] target: Use scsi helpers to build the sense data correctly

2015-07-05 Thread Sagi Grimberg
Instead of open coding the sense buffer construction, use scsi scsi_build_sense_buffer() and scsi_set_sense_information() helpers which moved to scsi_common. This patch also fixes wrong setting of descriptor format sense data for t10-pi integrity errors. Signed-off-by: Sagi Grimberg --- drivers