Re: [PATCH 3/3] hpsa: Convert DEVICE_ATTR macro usage to DEVICE_ATTR_RO|WR|WO

2015-06-30 Thread Greg KH (g...@kroah.com)
On Wed, Jul 01, 2015 at 03:47:10AM +, Seymour, Shane M wrote: > > Convert DEVICE_ATTR macro usage to DEVICE_ATTR_RO|WR|WO > Changes forced some function names to change. > > Signed-off-by: Shane Seymour Acked-by: Greg Kroah-Hartman -- To unsubscribe from this list: send the line "unsubscri

RE: [PATCH 1/1] SCSI/bfa: Use port pointer after NULL check

2015-06-30 Thread Anil Gurumurthy
Acked-by: Anil Gurumurthy -Original Message- From: Maninder Singh [mailto:maninder...@samsung.com] Sent: 29 June 2015 10:51 To: Anil Gurumurthy; Sudarsana Kalluru; jbottom...@odin.com; linux-scsi Cc: panka...@samsung.com; Maninder Singh Subject: [PATCH 1/1] SCSI/bfa: Use port pointer aft

[PATCH 3/3] hpsa: Convert DEVICE_ATTR macro usage to DEVICE_ATTR_RO|WR|WO

2015-06-30 Thread Seymour, Shane M
Convert DEVICE_ATTR macro usage to DEVICE_ATTR_RO|WR|WO Changes forced some function names to change. Signed-off-by: Shane Seymour --- --- a/drivers/scsi/hpsa.c 2015-06-30 16:34:01.403904650 -0500 +++ b/drivers/scsi/hpsa.c 2015-06-30 16:21:54.214954176 -0500 @@ -376,7 +376,7 @@ stati

[PATCH 2/3] hpsa: Remove unneccessary variable from raid_level_show

2015-06-30 Thread Seymour, Shane M
Remove unneccessary variable from raid_level_show Signed-off-by: Shane Seymour --- Was not in previous patch. --- a/drivers/scsi/hpsa.c 2015-06-30 16:15:42.631979483 -0500 +++ b/drivers/scsi/hpsa.c 2015-06-30 16:16:45.737975186 -0500 @@ -612,7 +612,6 @@ static const char * const raid

[PATCH 1/3] hpsa: convert show method snprintf usage to scnprintf

2015-06-30 Thread Seymour, Shane M
Changed all show method snprintf usage to scnprintf per Documentation/filesystems/sysfs.txt. Signed-off-by: Shane Seymour --- Please let me know if this is not the correct way to submit patches by separating them but keeping them logically together. --- a/drivers/scsi/hpsa.c 2015-06-25 15:

please confirm [86a93f19d29b7c17d8d6eb2986c92cb7]

2015-06-30 Thread Automated Anti-Spam Agent
Because I now receive too many spam messages each day, I installed a filtering agent that defers incoming mail message if it comes from an address it sees for the first time. This is the case with the message you sent me, I'm afraid. Before your message will be delivered to my mailbox, I need a co

Re: [PATCH v2] hpsa: convert DEVICE_ATTR to RO|WO|RW and show methods must not use snprintf

2015-06-30 Thread Greg KH
On Wed, Jul 01, 2015 at 01:56:03AM +, Seymour, Shane M wrote: > > Changed DEVICE_ATTR macro usage to DEVICE_ATTR_RO|WO|RW. > This also forced some show/store function names to change. > > Changed all show method snprintf() usage to scnprintf() per > Documentation/filesystems/sysfs.txt. Forgo

[PATCH v2] hpsa: convert DEVICE_ATTR to RO|WO|RW and show methods must not use snprintf

2015-06-30 Thread Seymour, Shane M
Changed DEVICE_ATTR macro usage to DEVICE_ATTR_RO|WO|RW. This also forced some show/store function names to change. Changed all show method snprintf() usage to scnprintf() per Documentation/filesystems/sysfs.txt. Signed-off-by: Shane Seymour --- Changes from v1: Dropped one sprintf() to scnprin

[PATCH] scsi/arcmsr: Fix typos in error log

2015-06-30 Thread Nik Nyby
This fixes some typos in one of the error logs. Signed-off-by: Nik Nyby --- drivers/scsi/arcmsr/arcmsr_hba.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c index 914c39f..6ac74fb 100644 --- a/drivers/scsi/ar

[PATCH] SCSI: DTC: Fixed a coding style issue on pointer

2015-06-30 Thread Rudhresh Kumar J
Fixed space coding style issue on pointer Signed-off-by: Rudhresh Kumar J --- drivers/scsi/dtc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/dtc.c b/drivers/scsi/dtc.c index 4c74c7b..edfe848 100644 --- a/drivers/scsi/dtc.c +++ b/drivers/scsi/dtc.c @@ -186,7 +

Re: [PATCH] hpsa: convert DEVICE_ATTR to RO|WO|RW and show methods must use scnprintf

2015-06-30 Thread Greg KH
On Tue, Jun 30, 2015 at 05:22:20AM +, Seymour, Shane M wrote: > > Changed DEVICE_ATTR macro usage to DEVICE_ATTR_RO|WO|RW. > This also forced some show/store function names to change. > > Changed all show method sprint/snprintf usage to scnprintf per > Documentation/filesystems/sysfs.txt. Th

[PATCH] SCSI: DTC: Adding KERN_ facility level

2015-06-30 Thread Rudhresh Kumar J
Fixed coding style issue by adding KERN_ facility level to some of the printk functions. Signed-off-by: Rudhresh Kumar J --- drivers/scsi/dtc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/dtc.c b/drivers/scsi/dtc.c index 4c74c7b..a3a2a71 100644 --- a/driv

[PATCH] libiscsi: Fix iscsi_check_transport_timeouts possible infinite loop

2015-06-30 Thread Sagi Grimberg
From: Ariel Nahum Connection last_ping is not being updated when iscsi_send_nopout fails. Not updating the last_ping will cause firing a timer to a past time (last_ping + ping_tmo < current_time) which triggers an infinite loop of iscsi_check_transport_timeouts() and hogs the cpu. Fix this issue

Re: [PATCH] SCSI-eata_pio: Deletion of an unnecessary check before the function call "pci_dev_put"

2015-06-30 Thread SF Markus Elfring
> From: Markus Elfring > Date: Thu, 20 Nov 2014 20:37:30 +0100 > > The pci_dev_put() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus E

Re: [PATCH] SCSI-aic94xx: Deletion of an unnecessary check before the function call "kfree"

2015-06-30 Thread SF Markus Elfring
> From: Markus Elfring > Date: Thu, 20 Nov 2014 23:18:56 +0100 > > The kfree() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring

Re: [PATCH] SCSI-bfa: Deletion of an unnecessary check before the function call "vfree"

2015-06-30 Thread SF Markus Elfring
> Patch looks good. > Thanks! > Acked-by: Anil Gurumurthy > > -Original Message- > From: SF Markus Elfring [mailto:elfr...@users.sourceforge.net] > Sent: 21 November 2014 04:17 > To: Anil Gurumurthy; James E. J. Bottomley; Sudarsana Kalluru; linux-scsi > Cc: linux-kernel; kernel-janit..

[Bug 98171] [Regression] Marvell SE91xx SATA 3 controllers not recognized correctly

2015-06-30 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=98171 --- Comment #3 from Tom Yan --- By the way why would it be related to mvsas/libsas? Aren't those controllers SATA ones which use the ahci driver? -- You are receiving this mail because: You are watching the assignee of the bug. -- To unsubscribe

[Bug 98171] [Regression] Marvell SE91xx SATA 3 controllers not recognized correctly

2015-06-30 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=98171 Tom Yan changed: What|Removed |Added CC||tom.t...@gmail.com --- Comment #2 from Tom Yan

RE: megaraid_sas: "FW in FAULT state!!", how to get more debug output? [BKO63661]

2015-06-30 Thread Kashyap Desai
Jean, Patch is available at below repo - git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git - b for-next Commit id - 6431f5d7c6025f8b007af06ea090de308f7e6881 If you share megaraid_sas driver code of your tree, I can provide patch for you. ` Kashyap > -Original Message- > From

[PATCH v2 05/20] [SCSI] mpt3sas: MPI 2.5 Rev I (2.5.4) specifications.

2015-06-30 Thread Sreekanth Reddy
Update MPI 2.5 Release: MPI 2.5 Rev I (2.5.4) specification and 2.00.33 header files Below is the change set from the MPI specification for I Rev 1) Added Base Enclosure Level bit to the Flags field of Manufacturing Page 7. 2) Updated description of the MaxTargetPortConnectTime field of SAS IO U

[PATCH v2 01/20] [SCSI] mpt3sas: Added Combined Reply Queue feature to extend up-to 96 MSIX vector support

2015-06-30 Thread Sreekanth Reddy
In this patch, increased the number of MSIX vector support for SAS3 C0 HBAs to up-to 96. Following are changes that are done in this patch 1. This feature is enabled only for SAS3 C0 and higher revision cards and also only when reply post free queue count is greater than 8. 2. To support this fe

[PATCH v2 15/20] [SCSI] mpt3sas: Return host busy error status to SML when DMA mapping of scatter gather list fails for a SCSI command

2015-06-30 Thread Sreekanth Reddy
scsi_dma_map API will return a negative value (i.e. -ENOMEM) if DMA mapping of sg lists fails and zero if the sg list in the SCSI cmd is NULL. But drivers doesn't handled sg list DMA mapping failure case properly. So, Updated the code to return host busy error status to SCSI MID Layer(SML), when D

[PATCH v2 06/20] [SCSI] mpt3sas: Provides the physical location of sas drives

2015-06-30 Thread Sreekanth Reddy
This Patch will provide more details of the devices such as slot number, enclosure logical id, enclosure level & connector name in the following scenarios, - When end device is added in the topology, - When the end device is removed from the setup, - When the SCSI mid layer issues TASK ABORT/ DE

[PATCH v2 14/20] [SCSI] mpt3sas: Complete the SCSI command with DID_RESET status for log_info value 0x0x32010081

2015-06-30 Thread Sreekanth Reddy
For any SCSI command, if the driver receives IOC status = SCSI_IOC_TERMINATED and log info = 0x32010081 then that command will be completed with DID_RESET host status. The definition of this log info value is "Virtual IO has failed and has to be retried". Firmware will provide this log info value

[PATCH v2 11/20] [SCSI] mpt3sas: Add branding string support for OEM custom HBA

2015-06-30 Thread Sreekanth Reddy
Add the following OEM's branding to the mpt3sas driver. "VendorID" "DeviceID" "SubsystemVendor ID" "SubsystemDevice ID" Cisco Branding String 0x1000 0x97 SVID = 0x1137 0x014C Cisco 9300-8E 12G SAS HBA Changes in v2: Patch version change only.

[PATCH v2 09/20] [SCSI] mpt3sas: MPI 2.5 Rev J (2.5.5) specification and 2.00.34 header files

2015-06-30 Thread Sreekanth Reddy
Following is the change set, 1. Added more defines for the BiosOptions field of MPI2_CONFIG_PAGE_BIOS_1. 2. Added MPI2_TOOLBOX_CLEAN_BIT26_PRODUCT_SPECIFIC definition. Changes in v2: Patch version change only. Signed-off-by: Sreekanth Reddy Reviewed-by: Martin K. Petersen Reviewed-by:

[PATCH v2 16/20] [SCSI] mpt3sas: Added support for customer specific branding

2015-06-30 Thread Sreekanth Reddy
Added support for below customer specific brandings "VendorID" "DeviceID" "SubsystemVendor ID" "SubsystemDevice ID" Cisco Branding String 0x1000 0x97 0x1137 0x154 Cisco 9300-8i 12Gbps SAS HBA 0x1000 0x97 0x1137 0

[PATCH v2 12/20] [SCSI] mpt3sas: Bump mpt3sas driver version to v6.100.00.00

2015-06-30 Thread Sreekanth Reddy
Bump mpt3sas driver version to v6.100.00.00. Changes in v2: Patch version change only. Signed-off-by: Sreekanth Reddy Reviewed-by: Martin K. Petersen Reviewed-by: Johannes Thumshirn --- drivers/scsi/mpt3sas/mpt3sas_base.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH v2 10/20] [SCSI] mpt3sas: Add branding string support for OEM's HBA

2015-06-30 Thread Sreekanth Reddy
Added the following Dell branding to the mpt3sas driver. "VendorID" "DeviceID" "SubsystemVendor ID" "SubsystemDevice ID" Dell Branding String 0x10000x0097 0x1028 0x1F46DELL 12Gbps HBA Changes in v2: Patch version change only. Signed-off

[PATCH v2 13/20] [SCSI] mpt3sas: MPI 2.5 Rev K (2.5.6) specifications

2015-06-30 Thread Sreekanth Reddy
Below are the new changes to MPI 2.5 Rev K(2.5.6) specification and 2.00.35 header files 1) Added a minimum size requirement for target mode command buffers. 2) Added MinMSIxIndex and MaxMSIxIndex fields to CommandBufferPostBase Request. 3) For BIOS Page 1, added SSUTimeout field, and added Produc

[PATCH v2 04/20] [SCSI] mpt3sas: Remove redundancy code while freeing the controller resources.

2015-06-30 Thread Sreekanth Reddy
Removed the redundancy code while freeing the controller resources. Changes in v2: Patch version change only. Signed-off-by: Sreekanth Reddy Reviewed-by: Martin K. Petersen Reviewed-by: Johannes Thumshirn --- drivers/scsi/mpt3sas/mpt3sas_base.c | 57 +--