Re: [PATCH RFC 1/2] cxlflash: Base support for IBM CXL Flash Adapter

2015-05-26 Thread Michael Neuling
Christoph, > On Sun, Apr 26, 2015 at 11:50:20PM -0500, Matthew R. Ochs wrote: > > SCSI device driver to support filesystem access on the IBM CXL Flash > > adapter. > > Please drop all the code related to your weird direct access ioctls > from this patch. Without that it looks mostly mergeable.

Re: [PATCH-v2 2/4] target: Drop lun_sep_lock for se_lun->lun_se_dev RCU usage

2015-05-26 Thread Nicholas A. Bellinger
On Tue, 2015-05-26 at 16:30 +0200, Bart Van Assche wrote: > On 05/26/15 08:57, Nicholas A. Bellinger wrote: > > @@ -625,6 +626,7 @@ int core_dev_add_initiator_node_lun_acl( > > u32 lun_access) > > { > > struct se_node_acl *nacl = lacl->se_lun_nacl; > > + struct se_device *dev = lockless

Re: [PATCH-v2 0/4] target: Eliminate se_port + t10_alua_tg_pt_gp_member

2015-05-26 Thread Nicholas A. Bellinger
On Tue, 2015-05-26 at 14:44 +0200, Bart Van Assche wrote: > On 05/26/15 08:57, Nicholas A. Bellinger wrote: > >- Add various rcu_dereference and lockless_dereference RCU notation > > Hello Nic, > > Feedback from an RCU expert (which I'm not) would be appreciated here. > But my understanding

[PATCH net-next] qla4xxx: add a missing include

2015-05-26 Thread Eric Dumazet
From: Eric Dumazet vmalloc.h used to be included from include/net/inet_hashtables.h but it is no longer the case. Fixes: 095dc8e0c368 ("tcp: fix/cleanup inet_ehash_locks_alloc()") Reported-by: kbuild test robot Signed-off-by: Eric Dumazet --- Given its broken in David net-next tree, its probab

Re: [PATCH] Documentation/scsi: Documentation about scsi_cmnd lifecycle

2015-05-26 Thread Rajat Jain
Hello James / linux-scsi folks, On Wed, May 13, 2015 at 12:36 PM, Jonathan Corbet wrote: > On Tue, 12 May 2015 14:33:46 -0700 > Rajat Jain wrote: > >> Add documentation to describe the various scenarios that the scsi_cmnd >> may go through in its life time in the mid level driver - aborts, >> fa

RE: [PATCH 1/9] [SCSI] aacraid: Fix for logical device name and UID not exposed to the OS

2015-05-26 Thread Rajinikanth Pandurangan
Hello Tomas, Yes, you are right. The mentioned comment is right for some cases where as in some cases it should actually be the size of response buffer instead of request buffer. To "get logical device name", it request size of response buffer instead of size of the request. Thanks, -Raj P.

RE

2015-05-26 Thread George Mendez
Attn; Brauchen Sie eine garantierte Darlehen der Zinssatz von 3 % Ihrer Schulden oder Rechnungen zu bezahlen oder geschäftliche Zwecke? Wenn ja, dann kontaktieren Sie uns heute per E-mail mit den folgenden Informationen: Vollständige Namen: Darlehensbetrag benötigt: Darlehen-Dauer: Persönl

Re: [PATCH-v2 2/4] target: Drop lun_sep_lock for se_lun->lun_se_dev RCU usage

2015-05-26 Thread Bart Van Assche
On 05/26/15 08:57, Nicholas A. Bellinger wrote: > @@ -625,6 +626,7 @@ int core_dev_add_initiator_node_lun_acl( > u32 lun_access) > { > struct se_node_acl *nacl = lacl->se_lun_nacl; > + struct se_device *dev = lockless_dereference(lun->lun_se_dev); > > if (!nacl) >

Re: [PATCH v2 12/15] lpfc: Fix rport leak.

2015-05-26 Thread James Bottomley
On Tue, 2015-05-26 at 09:30 -0400, James Smart wrote: > Sebastian, > > Re: more than 1 space between a type declaration and a variable name - I > do not believe that's a hard requirement. It fully passes checkpatch. > Yes, consistent style use (aligning all variable names at same offset, > or a

Re: [PATCH 3/9] lpfc: Devices are not discovered during takeaway/giveback testing

2015-05-26 Thread James Smart
uh - we're flagging issues with in a patch explanation (such as 2 spaces after a period) and not something in the patch itself ?? I'm not going to revise patches for minor typos or styles disagreements in patch descriptions. -- james On 5/24/2015 3:56 PM, Sebastian Herbszt wrote: James Sma

Re: [PATCH v2 12/15] lpfc: Fix rport leak.

2015-05-26 Thread James Smart
Sebastian, Re: more than 1 space between a type declaration and a variable name - I do not believe that's a hard requirement. It fully passes checkpatch. Yes, consistent style use (aligning all variable names at same offset, or always 1) would be good - but code has been there so long with al

Re: [PATCH-v2 0/4] target: Eliminate se_port + t10_alua_tg_pt_gp_member

2015-05-26 Thread Bart Van Assche
On 05/26/15 08:57, Nicholas A. Bellinger wrote: - Add various rcu_dereference and lockless_dereference RCU notation Hello Nic, Feedback from an RCU expert (which I'm not) would be appreciated here. But my understanding is that lockless_dereference(p) should be used for a pointer p that ha

Re: Backport of a fix for HPSA (Disabling a disabled device problem during kdump) driver

2015-05-26 Thread Jiri Slaby
On 05/22/2015, 09:19 PM, Vinson Lee wrote: > Please use the following list of kernels and patches for backporting. > > 3.18, 3.19 > 3b74729878 hpsa: turn off interrupts when kdump starts > > <= 3.17 > 132aa220b4 hpsa: refine the pci enable/disable handling > 859c75aba2 hpsa: add missing pci_set_m

Re: [PATCH-v2 0/4] target: Eliminate se_port + t10_alua_tg_pt_gp_member

2015-05-26 Thread Hannes Reinecke
On 05/26/2015 08:57 AM, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > Hi all, > > Here is v2 series with HCH's recent changes to go ahead and drop > all se_port + t10_alua_tg_pt_gp_member usage within target-core in > favor of direct se_lun pointer dereference. > > This includes t

Re: [PATCH target] target: se_dev_check_wce() can be static

2015-05-26 Thread Bart Van Assche
On 05/26/15 10:13, kbuild test robot wrote: Signed-off-by: Fengguang Wu --- target_core_device.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/target/target_core_device.c b/drivers/target/target_core_device.c index 2321884..1d309ad 100644 --- a/drivers/targe

Re: [PATCH-v3 00/10] target: se_node_acl + se_lun RCU conversions

2015-05-26 Thread Hannes Reinecke
On 05/26/2015 08:25 AM, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > Hi all, > > Here is -v3 series for converting LIO target se_node_acl + se_lun > mapping tables from fixed size arrays to dynamic RCU hlist_heads. > > This turns fast-path I/O into a lock-less RCU reader using ex

[target:for-next 53/60] drivers/target/target_core_device.c:652:6: sparse: symbol 'se_dev_check_wce' was not declared. Should it be static?

2015-05-26 Thread kbuild test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git for-next head: 9cfc3ea41c4f9db514a7fdde9b77657b5aeaa46c commit: 9c10e8080d9ac17ec5b0b9f7da1a5dd31215ef5e [53/60] target: simplify backend attribute implementation reproduce: # apt-get install sparse git checkout 9c

[PATCH target] target: se_dev_check_wce() can be static

2015-05-26 Thread kbuild test robot
Signed-off-by: Fengguang Wu --- target_core_device.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/target/target_core_device.c b/drivers/target/target_core_device.c index 2321884..1d309ad 100644 --- a/drivers/target/target_core_device.c +++ b/drivers/target/targ

[PATCH-v2 0/4] target: Eliminate se_port + t10_alua_tg_pt_gp_member

2015-05-26 Thread Nicholas A. Bellinger
From: Nicholas Bellinger Hi all, Here is v2 series with HCH's recent changes to go ahead and drop all se_port + t10_alua_tg_pt_gp_member usage within target-core in favor of direct se_lun pointer dereference. This includes the original patch + minor fixes, along with two other improvements for

[PATCH-v2 1/4] target: Subsume se_port + t10_alua_tg_pt_gp_member into se_lun

2015-05-26 Thread Nicholas A. Bellinger
From: Christoph Hellwig This patch eliminates all se_port + t10_alua_tg_pt_gp_member usage, and converts current users to direct se_lun pointer dereference. This includes the removal of core_export_port(), core_release_port() core_dev_export() and core_dev_unexport(). Along with conversion of s

[PATCH-v2 4/4] target: Drop unnecessary core_tpg_register TFO parameter

2015-05-26 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch drops unnecessary target_core_fabric_ops parameter usage for core_tpg_register() during fabric driver TFO->fabric_make_tpg() se_portal_group creation callback execution. Instead, use the existing se_wwn->wwn_tf->tf_ops pointer to ensure fabric driver is really

[PATCH-v2 3/4] target: Drop se_lun->lun_active for existing percpu lun_ref

2015-05-26 Thread Nicholas A. Bellinger
From: Nicholas Bellinger With se_port_t and t10_alua_tg_pt_gp_member being absored into se_lun, there is no need for an extra atomic_t based reference count for PR ALL_TG_PT=1 and ALUA access state transition. Go ahead and use the existing percpu se_lun->lun_ref instead, and convert the two spec

[PATCH-v2 2/4] target: Drop lun_sep_lock for se_lun->lun_se_dev RCU usage

2015-05-26 Thread Nicholas A. Bellinger
From: Nicholas Bellinger With se_port and t10_alua_tg_pt_gp_member being absored into se_lun, there is no need for an extra lock to protect se_lun->lun_se_dev assignment. This patch also converts backend drivers to use call_rcu() release to allow any se_device readers to complete. The call_rcu(

[PATCH-v3 05/10] target: Convert se_portal_group->tpg_lun_list[] to RCU hlist

2015-05-26 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch converts the fixed size se_portal_group->tpg_lun_list[] to use modern RCU with hlist_head in order to support an arbitary number of se_lun ports per target endpoint. It includes dropping core_tpg_alloc_lun() from core_dev_add_lun(), and calling it directly fro