Re: [PATCH-v2 0/9] target: se_node_acl + se_lun RCU conversions

2015-05-21 Thread Hannes Reinecke
On 05/22/2015 08:11 AM, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > Hi all, > > Here is -v2 series for converting LIO target se_node_acl + se_lun > mapping tables from fixed size arrays to dynamic RCU hlist_heads. > > This turns fast-path I/O into a lock-less RCU reader using ex

[PATCH-v2 0/9] target: se_node_acl + se_lun RCU conversions

2015-05-21 Thread Nicholas A. Bellinger
From: Nicholas Bellinger Hi all, Here is -v2 series for converting LIO target se_node_acl + se_lun mapping tables from fixed size arrays to dynamic RCU hlist_heads. This turns fast-path I/O into a lock-less RCU reader using existing percpu based se_lun->lun_ref logic, and converts the RCU updat

[PATCH-v2 2/9] target/pr: Use atomic bitop for se_dev_entry->pr_reg reservation check

2015-05-21 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch converts the core_scsi3_pr_seq_non_holder() check for non reservation holding registrations to use an atomic bitop. It also includes associated set_bit() in __core_scsi3_add_registration() and clear_bit() __core_scsi3_free_registration() for the updater path.

[PATCH-v2 5/9] target: Convert se_portal_group->tpg_lun_list[] to RCU hlist

2015-05-21 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch converts the fixed size se_portal_group->tpg_lun_list[] to use modern RCU with hlist_head in order to support an arbitary number of se_lun ports per target endpoint. It includes dropping core_tpg_alloc_lun() from core_dev_add_lun(), and calling it directly fro

[PATCH-v2 1/9] target: Convert se_node_acl->device_list[] to RCU hlist

2015-05-21 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch converts se_node_acl->device_list[] table for mappedluns to modern RCU hlist_head usage in order to support an arbitrary number of node_acl lun mappings. It converts transport_lookup_*_lun() fast-path code to use RCU read path primitives when looking up se_dev

[PATCH-v2 7/9] target: Convert core_tpg_deregister to use list splice

2015-05-21 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch converts core_tpg_deregister() to perform a list splice for any remaining dynamically generated se_node_acls attached to se_tpg, before calling kfree(nacl) to free memory. Cc: Hannes Reinecke Cc: Christoph Hellwig Cc: Sagi Grimberg Signed-off-by: Nicholas B

[PATCH-v2 3/9] target/pr: Change alloc_registration to avoid pr_reg_tg_pt_lun

2015-05-21 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch changes __core_scsi3_do_alloc_registration() code to drop pr_reg->pr_reg_tg_pt_lun pointer usage in favor of a new pr_reg RPTI + existing target_lun. It also includes changes to REGISTER, REGISTER_AND_MOVE and APTPL feature bit codepaths. Cc: Hannes Reinecke

[PATCH-v2 6/9] target: Convert se_tpg->acl_node_lock to ->acl_node_mutex

2015-05-21 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch converts se_tpg->acl_node_lock to struct mutex, so that ->acl_node_acl walkers in core_clear_lun_from_tpg() can block when calling core_disable_device_list_for_node(). It also updates core_dev_add_lun() to hold ->acl_node_mutex when calling core_tpg_add_node_t

[PATCH-v2 8/9] target: Drop unused se_lun->lun_acl_list

2015-05-21 Thread Nicholas A. Bellinger
From: Nicholas Bellinger Cc: Hannes Reinecke Cc: Christoph Hellwig Cc: Sagi Grimberg Signed-off-by: Nicholas Bellinger --- drivers/target/target_core_device.c | 15 --- drivers/target/target_core_tpg.c| 4 include/target/target_core_base.h | 3 --- 3 files changed, 2

[PATCH-v2 4/9] target/pr: cleanup core_scsi3_pr_seq_non_holder

2015-05-21 Thread Nicholas A. Bellinger
From: Christoph Hellwig Clean up the mess of registered variables, and pass the isid mismatch flag explicitly instead of overloading the registration type. Signed-off-by: Christoph Hellwig Signed-off-by: Nicholas Bellinger --- drivers/target/target_core_pr.c | 43 -

[PATCH-v2 9/9] target: Only reset specific dynamic entries during lun_group creation

2015-05-21 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch changes core_tpg_add_node_to_devs() to avoid unnecessarly resetting every se_dev_entry in se_node_acl->tpg_lun_hlist when the operation is driven by an explicit configfs se_lun->lun_group creation via core_dev_add_lun() to only update a single se_lun. Otherwis

Re

2015-05-21 Thread Mrs. Bozena
Dear Friend, You might be letter bite apprehensive because you do not know me, I am Mrs. Horniakova Bozena a bank officer with the international bank of Taipei (Taiwan) I need your partnership in reprofilling funds I will need your reply so that I can send you more details as soon as possib

Re: [PATCH 1/1] cxlflash: Base support for IBM CXL Flash Adapter

2015-05-21 Thread Michael Neuling
> >> +#define CXLFLASH_MAX_CMDS 16 > >> +#define CXLFLASH_MAX_CMDS_PER_LUN CXLFLASH_MAX_CMDS > >> + > >> +#define NOT_POW2(_x) ((_x) & ((_x) & ((_x) - 1))) > > > > include/linux/log2 has is_power_of_2() > > > > This is used for compile-time enforcement. The items in the log2

Re: [PATCH 1/1] cxlflash: Base support for IBM CXL Flash Adapter

2015-05-21 Thread Matthew R. Ochs
Mikey, Thanks for reviewing this patch. Responses are inline below. -matt On May 20, 2015, at 12:51 AM, Michael Neuling wrote: > Does this driver work when compiled big endian? We haven't tested on big endian but agree that the code should support both little and big endian. >> >> +#define

[PATCH for-next] scsi: qla2xxx: Hide unavailable firmware

2015-05-21 Thread Julian Calaby
Some qla2xxx devices have firmware stored in flash on the device, however for debugging and triage purposes, Qlogic staff like to be able to load known-good versions of these firmwares through request_firmware(). These firmware files were never distributed and are unlikely to ever be released publ

Re: [PATCH for-next] scsi: qla2xxx: Hide unavailable firmware

2015-05-21 Thread Julian Calaby
Hi Xose, Adding you to CC. On Fri, May 22, 2015 at 10:00 AM, Julian Calaby wrote: > Some qla2xxx devices have firmware stored in flash on the device, > however for debugging and triage purposes, Qlogic staff like to > be able to load known-good versions of these firmwares through > request_firmw

Re: [PATCH for-next] qla2xxx: delete references to unused firmware files

2015-05-21 Thread Julian Calaby
Hi All, On Thu, May 21, 2015 at 8:42 PM, Xose Vazquez Perez wrote: > On 05/19/2015 05:51 PM, Himanshu Madhani wrote: > >> On 5/18/15, 6:50 PM, "Julian Calaby" wrote: > >>> Do the devices these firmware files are for exist and is there any >>> chance of the files being released? >> >> Yes. These

iscsi flashnode bus? Re: [RFC PATCH 2/4] iscsi: sysfs filtering by network namespace

2015-05-21 Thread Chris Leech
On Wed, May 13, 2015 at 03:12:45PM -0700, Chris Leech wrote: > This makes the iscsi_host, iscsi_session, iscsi_connection, and > iscsi_endpoint transport class devices only visible in sysfs under a > matching network namespace. The network namespace for all of these > objects is tracked in the isc

Re: [RFC PATCH 0/4] Make iSCSI network namespace aware

2015-05-21 Thread Chris Leech
On Wed, May 20, 2015 at 11:45:43AM -0700, Andy Grover wrote: > On 05/13/2015 03:12 PM, Chris Leech wrote: > >This is only about the structures and functionality involved in maintaining > >the > >iSCSI session, the SCSI host along with it's discovered targets and devices > >has > >no association w

Re: Proposal for annotating _unstable_ pages

2015-05-21 Thread Jan Kara
On Thu 21-05-15 11:09:55, Kent Overstreet wrote: > On Thu, May 21, 2015 at 06:54:53PM +0200, Jan Kara wrote: > > On Wed 20-05-15 18:04:40, Kent Overstreet wrote: > > > > Yeah. I never figured out a sane way to migrate pages and keep > > > > everything > > > > else happy. Daniel Phillips is havin

Re: Proposal for annotating _unstable_ pages

2015-05-21 Thread Kent Overstreet
On Thu, May 21, 2015 at 06:54:53PM +0200, Jan Kara wrote: > On Wed 20-05-15 18:04:40, Kent Overstreet wrote: > > > Yeah. I never figured out a sane way to migrate pages and keep everything > > > else happy. Daniel Phillips is having a go at page forking for tux3; > > > let's > > > see if the que

Re: [PATCH 01/12] target: Convert se_node_acl->device_list[] to RCU hlist

2015-05-21 Thread Nicholas A. Bellinger
On Thu, 2015-05-21 at 19:03 +0200, Christoph Hellwig wrote: > On Tue, May 19, 2015 at 08:22:31AM +0200, Christoph Hellwig wrote: > > On Mon, May 18, 2015 at 11:05:47PM -0700, Nicholas A. Bellinger wrote: > > > > [ 12.830576] kernel BUG at ../drivers/target/target_core_device.c:337! > > > > > > >

[PATCH v2 09/15] lpfc: Fix to remove IRQF_SHARED flag for MSI/MSI-X vectors.

2015-05-21 Thread James Smart
Fix to remove IRQF_SHARED flag for MSI/MSI-X vectors. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_init.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c index 15

[PATCH v2 05/15] lpfc: Fix ABORTs WQ selection in terminate_rport_io

2015-05-21 Thread James Smart
Fix ABORTs WQ selection in terminate_rport_io Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_sli.c | 32 +--- 1 file changed, 21 insertions(+), 11 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli

[PATCH v2 04/15] lpfc: Correct reference counting of rport

2015-05-21 Thread James Smart
Correct reference counting of rport Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_hbadisc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/scsi/lpfc/lpfc_hbadisc.c index 72388a6..e93705d 10064

[PATCH v2 06/15] lpfc: Add support for RDP ELS command.

2015-05-21 Thread James Smart
Add support for RDP ELS command. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc.h | 1 + drivers/scsi/lpfc/lpfc_crtn.h | 2 + drivers/scsi/lpfc/lpfc_els.c | 420 ++ drivers/scsi/lpfc/lpfc_hw.h | 169

[PATCH v2 10/15] lpfc: Fix crash in vport_delete.

2015-05-21 Thread James Smart
Fix crash in vport_delete. We inadvertantly took the path to recreate the vport while in a driver teardown path Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_init.c | 8 +++- drivers/scsi/lpfc/lpfc_nportdisc.c | 8 +++- drivers/scsi/lpfc/lpfc_v

[PATCH v2 08/15] lpfc: Fix discovery issue when changing from Pt2Pt to Fabric.

2015-05-21 Thread James Smart
Fix discovery issue when changing from Pt2Pt to Fabric. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_hbadisc.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/scsi/lpfc/lpfc_hbadisc

[PATCH v2 12/15] lpfc: Fix rport leak.

2015-05-21 Thread James Smart
Fix rport leak. Correct locking and refcounting in tracking our rports Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_disc.h| 4 +- drivers/scsi/lpfc/lpfc_els.c | 12 +++- drivers/scsi/lpfc/lpfc_hbadisc.c | 145 +++-

[PATCH v2 11/15] lpfc: Correct loss of RSCNs during array takeaway/giveback testing.

2015-05-21 Thread James Smart
Correct loss of RSCNs during array takeaway/giveback testing. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_els.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c ind

[PATCH v2 03/15] lpfc: Add support for ELS LCB.

2015-05-21 Thread James Smart
Add support for ELS LCB. Also has a little whitespace fixing. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc.h | 1 + drivers/scsi/lpfc/lpfc_els.c | 239 +- drivers/scsi/lpfc/lpfc_hw.h | 32 ++ drivers/s

[PATCH v2 15/15] lpfc: Update driver version for upstream patch set 10.6.0.1.

2015-05-21 Thread James Smart
Update driver version for upstream patch set 10.6.0.1. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_version.h b/drivers/scsi/lpfc/lpfc_version.h index c37bb

[PATCH v2 14/15] lpfc: Change buffer pool empty message to miscellaneous category

2015-05-21 Thread James Smart
Change buffer pool empty message to miscellaneous category Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_scsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c index c140f99..1

[PATCH v2 07/15] lpfc: Correct reporting of vport state on fdisc command failure.

2015-05-21 Thread James Smart
Correct reporting of vport state on fdisc command failure. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_els.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c index 724b61c..b4

[PATCH v2 13/15] lpfc: Fix incorrect log message reported for empty FCF record.

2015-05-21 Thread James Smart
Fix incorrect log message reported for empty FCF record. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_hbadisc.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/scsi/lpfc/lpfc_hbadisc.c ind

[PATCH v2 02/15] lpfc: Correct loss of target discovery after cable swap.

2015-05-21 Thread James Smart
Correct loss of target discovery after cable swap. Fix incorrect reference counting Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_hbadisc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/sc

[PATCH v2 01/15] lpfc: The lpfc driver does not issue RFF_ID and RFT_ID in the correct sequence

2015-05-21 Thread James Smart
The lpfc driver does not issue RFF_ID and RFT_ID in the correct sequence Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_hbadisc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/scsi/lpfc/lpfc_hba

[PATCH v2 00/15] lpfc: Update to revision 10.6.0.1

2015-05-21 Thread James Smart
This patch set updates the lpfc driver to revision 10.6.0.1 This is version 2. v2 changes: Patch 3: Revised for review comments from Sebastian Herbszt Replaced double spacing with single spacing Patch 6: Revised for review comments from Sebastian Herbszt Replaced doubl

Re: [PATCH v1 3/3] scsi: ufs-qcom: update configuration option of SCSI_UFS_QCOM component

2015-05-21 Thread ygardi
> On Thu, 2015-05-21 at 10:09 +, yga...@codeaurora.org wrote: >> > On Wed, 2015-05-20 at 10:22 +0200, Paul Bolle wrote: >> > Am I missing something obvious here? Because ufs-qcom currently looks >> > pointless to me, and I actually see little reason to even have it in >> the >> > mainline tree.

Re: [PATCH 01/12] target: Convert se_node_acl->device_list[] to RCU hlist

2015-05-21 Thread Christoph Hellwig
On Tue, May 19, 2015 at 08:22:31AM +0200, Christoph Hellwig wrote: > On Mon, May 18, 2015 at 11:05:47PM -0700, Nicholas A. Bellinger wrote: > > > [ 12.830576] kernel BUG at ../drivers/target/target_core_device.c:337! > > > > > > > How did you hit this..? > > tcm_node --block iblock_0/array /de

Re: Proposal for annotating _unstable_ pages

2015-05-21 Thread Jan Kara
On Wed 20-05-15 18:04:40, Kent Overstreet wrote: > > Yeah. I never figured out a sane way to migrate pages and keep everything > > else happy. Daniel Phillips is having a go at page forking for tux3; let's > > see if the questions about that get resolved. > > That would be great, we need somethi

Re: [PATCH trivial] lpfc: Grammar s/an negative/a negative/

2015-05-21 Thread James Smart
Reviewed-By: James Smart looks fine. Thanks -- james s On 5/21/2015 8:11 AM, Geert Uytterhoeven wrote: Signed-off-by: Geert Uytterhoeven --- drivers/scsi/lpfc/lpfc_debugfs.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_debugfs.c

[PATCH trivial] lpfc: Grammar s/an negative/a negative/

2015-05-21 Thread Geert Uytterhoeven
Signed-off-by: Geert Uytterhoeven --- drivers/scsi/lpfc/lpfc_debugfs.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_debugfs.c b/drivers/scsi/lpfc/lpfc_debugfs.c index 513edcb0c2dae379..25aa9b98d53aa345 100644 --- a/drivers/scsi/lpfc/lpfc_

Re: [PATCH] scsi: debug: fix type mismatch warning for sg_pcopy_from_buffer

2015-05-21 Thread Arnd Bergmann
On Thursday 21 May 2015 12:09:58 Dave Gordon wrote: > From b304c5a99ea260eac1cf98ced5f3c79c793ad4fd Mon Sep 17 00:00:00 2001 > From: Dave Gordon > Date: Thu, 21 May 2015 12:06:27 +0100 > Subject: [PATCH] scsi: resolve sg buffer const-ness issue > > do_device_access() takes a separate parameter to

Re: [PATCH] scsi: debug: fix type mismatch warning for sg_pcopy_from_buffer

2015-05-21 Thread Dave Gordon
On 20/05/15 21:31, Arnd Bergmann wrote: > On Wednesday 20 May 2015 12:53:29 Andrew Morton wrote: >> On Tue, 19 May 2015 23:22:39 +0200 Arnd Bergmann wrote: >>> >>> I can't decide if this is actually a good idea, or if we should rather drop >>> the sg_pcopy_from_buffer() patch. Maybe someone else s

Re: [PATCH for-next] qla2xxx: delete references to unused firmware files

2015-05-21 Thread Xose Vazquez Perez
On 05/21/2015 12:42 PM, Xose Vazquez Perez wrote: > ql2400_fw.bin: COPYRIGHT 2015 QLOGIC CORPORATION ISP24xx Firmware > Version 8.01.00 $ > ql2500_fw.bin: COPYRIGHT 2015 QLOGIC CORPORATION ISP24xx Firmware > Version 8.01.00 $ > ql2600_fw.bin: COPYRIGHT 2015 QLOGIC CORPORATION

Re: [PATCH for-next] qla2xxx: delete references to unused firmware files

2015-05-21 Thread Xose Vazquez Perez
On 05/19/2015 05:51 PM, Himanshu Madhani wrote: > On 5/18/15, 6:50 PM, "Julian Calaby" wrote: >> Do the devices these firmware files are for exist and is there any >> chance of the files being released? > > Yes. These devices are available and we read firmware from FLASH on these > adapters. >

Re: [PATCH v1 3/3] scsi: ufs-qcom: update configuration option of SCSI_UFS_QCOM component

2015-05-21 Thread Paul Bolle
On Thu, 2015-05-21 at 10:09 +, yga...@codeaurora.org wrote: > > On Wed, 2015-05-20 at 10:22 +0200, Paul Bolle wrote: > > Am I missing something obvious here? Because ufs-qcom currently looks > > pointless to me, and I actually see little reason to even have it in the > > mainline tree. > > > >

Re: [PATCH v1 3/3] scsi: ufs-qcom: update configuration option of SCSI_UFS_QCOM component

2015-05-21 Thread ygardi
> On Wed, 2015-05-20 at 10:22 +0200, Paul Bolle wrote: >> By the way, as far as I can see, this (new) module can only be loaded >> manually (or via scripts). Is that what people want? > > This comment wasn't well thought through. So I hand another look at the > code of usf-qcom. > > I noticed that

Re: [RFC PATCH 0/4] Make iSCSI network namespace aware

2015-05-21 Thread Hannes Reinecke
On 05/20/2015 08:45 PM, Andy Grover wrote: > On 05/13/2015 03:12 PM, Chris Leech wrote: >> This is only about the structures and functionality involved in >> maintaining the >> iSCSI session, the SCSI host along with it's discovered targets >> and devices has >> no association with network namespac

Re: [PATCH v2] libsas: fix "sysfs group not found" warnings at port teardown time

2015-05-21 Thread Luis Henriques
On Wed, May 20, 2015 at 07:00:53PM -0400, Dan Williams wrote: > Praveen reports: > > After some debugging this is what I have found > > sas_phye_loss_of_signal gets triggered on phy_event from mvsas > sas_phye_loss_of_signal calls sas_deform_port > sas_deform_port pos

Re: [PATCH v1 3/3] scsi: ufs-qcom: update configuration option of SCSI_UFS_QCOM component

2015-05-21 Thread Paul Bolle
On Wed, 2015-05-20 at 10:22 +0200, Paul Bolle wrote: > By the way, as far as I can see, this (new) module can only be loaded > manually (or via scripts). Is that what people want? This comment wasn't well thought through. So I hand another look at the code of usf-qcom. I noticed that the single t