Add a variant of blk_mq_init_queue that allows a previously allocated
queue to be initialized. blk_mq_init_allocated_queue models
blk_init_allocated_queue -- which was also created for DM's use.
DM's approach to device creation requires a placeholder request_queue be
allocated for use with alloc_
If percpu_ref_init() fails the allocated q and hctxs must get cleaned
up; using 'err_map' doesn't allow that to happen.
Signed-off-by: Mike Snitzer
Reviewed-by: Ming Lei
---
block/blk-mq.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/block/blk-mq.c b/block/blk-mq.c
On Thu, Mar 12 2015 at 9:51am -0400,
Mike Snitzer wrote:
> On Thu, Mar 12 2015 at 3:48am -0400,
> Ming Lei wrote:
>
> > On Thu, Mar 12, 2015 at 11:56 AM, Mike Snitzer wrote:
> > > If percpu_ref_init() fails the 'err_hctxs' label should be used instead
> > > of 'err_map'.
> > >
> > > Signed-o
Hello Bart, Quinn Tran
Thanks for the feedback.
Revision3
Moved the discard to the __qlt_do_work code to prevent the memory leak, this
cleans up the allocations.
I will look at seeing how best this can be done for the other transports, or in
the core but for me the most useful case has been F/C
Hello Quinn Tran
Thank you for the feedback. There is a revision2 of this patch I sent as a
follow on to Bart that is much cleaner but its still exposed to the memory
leaks.
The newer version has a single jam_host parameter as suggested by Bart and the
messaging removed. Have a look for it.
Bar
This idea definitely help flush out additional interaction issues between
fabric drivers and TCM.
However, the current spot where the error injection is placed will cause
memory leak. The error injection tries to drop the command before
submission to TCM. TCM & QLA drivers will loose track of th
On Thu, 12 Mar 2015 17:55:00 +0200
Gilad Broner wrote:
> Add trace events to driver to allow monitoring and profilig
> of activities such as PM suspend/resume, hibernate enter/exit,
> clock gating and clock scaling up/down.
> In addition, add UFS host controller register dumps to provide
> detail
From: Lee Susman
Adding debugfs capability for ufshcd.
debugfs attributes introduced in this patch:
- View driver/controller runtime data
- Command tag statistics for performance analisis
- Dump device descriptor info
- Track recoverable errors statistics during runtime
- Change UFS power m
Changes from V6:
Moved NULL user argument check from ufshcd_ioctl to ufshcd_query_ioctl.
Add comment in include/scsi/scsi.h to note 0x5388 is in use.
*** BLURB HERE ***
Dolev Raviv (1):
scsi: ufs: add ioctl interface for query request
Gilad Broner (1):
scsi: ufs: add trace events and dump pr
From: Dolev Raviv
This patch exposes the ioctl interface for UFS driver via SCSI device
ioctl interface. As of now UFS driver would provide the ioctl for query
interface to connected UFS device.
Signed-off-by: Dolev Raviv
Signed-off-by: Noa Rubens
Signed-off-by: Raviv Shvili
Signed-off-by: Ya
From: Dolev Raviv
This patch exposes the ioctl interface for UFS driver via SCSI device
ioctl interface. As of now UFS driver would provide the ioctl for query
interface to connected UFS device.
Signed-off-by: Dolev Raviv
Signed-off-by: Noa Rubens
Signed-off-by: Raviv Shvili
Signed-off-by: Ya
Changes from V6:
Moved NULL user argument check from ufshcd_ioctl to ufshcd_query_ioctl.
Add comment in include/scsi/scsi.h to note 0x5388 is in use.
Dolev Raviv (1):
scsi: ufs: add ioctl interface for query request
Gilad Broner (1):
scsi: ufs: add trace events and dump prints for debug
Lee
Add trace events to driver to allow monitoring and profilig
of activities such as PM suspend/resume, hibernate enter/exit,
clock gating and clock scaling up/down.
In addition, add UFS host controller register dumps to provide
detailed information in case of errors to assist in analysis
of issues.
>> + if (!buffer) {
>> + dev_err(hba->dev, "%s: User buffer is NULL!\n",
>> __func__);
>> + return -EINVAL;
>> + }
>> +
>
> Should we remove this check or move it into ufshcd_query_ioctl()?
> For example, BLKFLS ioctl without argument is correct usage, but
>
Add a variant of blk_mq_init_queue that allows a previously allocated
queue to be initialized. blk_mq_init_allocated_queue models
blk_init_allocated_queue -- which was also created for DM's use.
DM's approach to device creation requires a placeholder request_queue be
allocated for use with alloc_
If percpu_ref_init() fails the 'err_hctxs' label should be used instead
of 'err_map'.
Rather than reuse 'err_hw', which was introduced if the later
blk_mq_init_hw_queues() call fails, move percpu_ref_init() before
blk_alloc_queue_node().
Signed-off-by: Mike Snitzer
Reviewed-by: Ming Lei
---
bl
On Thu, Mar 12 2015 at 3:48am -0400,
Ming Lei wrote:
> On Thu, Mar 12, 2015 at 11:56 AM, Mike Snitzer wrote:
> > If percpu_ref_init() fails the 'err_hctxs' label should be used instead
> > of 'err_map'.
> >
> > Signed-off-by: Mike Snitzer
> > ---
> > block/blk-mq.c | 2 +-
> > 1 file changed,
2015-03-12 21:27 GMT+09:00 Gilad Broner :
> From: Dolev Raviv
>
> This patch exposes the ioctl interface for UFS driver via SCSI device
> ioctl interface. As of now UFS driver would provide the ioctl for query
> interface to connected UFS device.
>
> Signed-off-by: Dolev Raviv
> Signed-off-by: No
On 03/08/2015 11:38 AM, Laurence Oberman wrote:
> Here is revision2
>
> I added unlikely and removed messaging control as it not necessary and adds
> overhead.
>
> I use target LIO for all my storage array test targets and customer problem
> resolution here at Red Hat.
> This patch resulted from
From: Lee Susman
Adding debugfs capability for ufshcd.
debugfs attributes introduced in this patch:
- View driver/controller runtime data
- Command tag statistics for performance analisis
- Dump device descriptor info
- Track recoverable errors statistics during runtime
- Change UFS power m
Add trace events to driver to allow monitoring and profilig
of activities such as PM suspend/resume, hibernate enter/exit,
clock gating and clock scaling up/down.
In addition, add UFS host controller register dumps to provide
detailed information in case of errors to assist in analysis
of issues.
From: Dolev Raviv
This patch exposes the ioctl interface for UFS driver via SCSI device
ioctl interface. As of now UFS driver would provide the ioctl for query
interface to connected UFS device.
Signed-off-by: Dolev Raviv
Signed-off-by: Noa Rubens
Signed-off-by: Raviv Shvili
Signed-off-by: Ya
Changes from V5:
Created a common trace event class for driver state changes instead
of individual trace events definitions.
Dolev Raviv (1):
scsi: ufs: add ioctl interface for query request
Gilad Broner (1):
scsi: ufs: add trace events and dump prints for debug
Lee Susman (1):
scsi: ufs:
> This and the auto_bkops_state is pretty much the same. Can't you use
> the same TP_printk() and just have a DECLARE_EVENT_CLASS? The trace
> point name is printed with the event to see different events.
I agree. will upload the fix in next patchset.
--
Qualcomm Israel, on behalf of Qualcomm In
Proposal,
Respond to my personal email; mrs.zhangxiao1962@outlook.
com
Yours Sincerely.
Mrs. Zhang Xiao (Accounts book Keeper)
Angang
Steel Company Limited
396 Nan Zhong Hua Lu, Tie Dong District Anshan,
Liaoning 114021, China.
--
To unsubscribe from this list: send the line "unsubscribe li
On 03/11/2015 11:13 PM, Scott Wood wrote:
> Use %pS for actual addresses, otherwise you'll get bad output
> on arches like ppc64 where %pF expects a function descriptor.
>
> Signed-off-by: Scott Wood
> Cc: linux-scsi@vger.kernel.org
> Cc: Hannes Reinecke
Acked-by: Hannes Reinecke
Cheers,
Hann
Kconfig for kbuild
Makefile to build snic module
Updated MAINTAINERS file
v2
Added compile time flags for debugfs dependent functionality.
Signed-off-by: Narsimhulu Musini
Signed-off-by: Sesidhar Baddela
---
MAINTAINERS| 7 +++
drivers/scsi/Kconfig | 10 ++
snic_disc.h contains snic target structure definition.
snic_disc.c contains target discovery, setup, lookup, and cleanup
snic_ctl.c contains retrieval of snic capabilities includes
max ios, size, SGs per request, and max concurrent requests.
Signed-off-by: Narsimhulu Musini
Signed-off-by: Sesid
snic_stats.h contains stats structre definitions for various events
in snic driver.
snic_debugfs.c contains setup and cleanup of sysfs entries for listing stats,
resetting stats, enabling/disabling trace, and listing trace data.
Signed-off-by: Narsimhulu Musini
Signed-off-by: Sesidhar Baddela
-
From: Julia Lawall
The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)
//
@r@
type T;
identifier f;
@@
static T f (...) { ... }
@@
identifier r.f;
declarer name EXPORT_SYMBOL;
@@
-EXPORT_SYMBOL(f);
//
Signed-off-by: Julia Lawall
---
drivers/target/iscs
snic_main.c contains module load and unload, global driver context,
PCI Registration, PCI probe and remove, SCSI ML registration functionality.
snic.h contains snic structure definition, snic global context, and
prototypes.
snic_os.h contains OS specific interfaces.
snic_attrs.c contains device
snic_fwint.h contains firmware interface structures.
snic_res.h contains firmware request initialization
snic_res.c contains retrieval of resource configuration, and allocation,
and initialization of HW Queues.
snic_isr.c contains interrupt request, release, and handling
Signed-off-by: Narsimhu
On Thu, Mar 12, 2015 at 11:56 AM, Mike Snitzer wrote:
> Add a variant of blk_mq_init_queue that allows a previously allocated
> queue to be initialized. blk_mq_init_allocated_queue models
> blk_init_allocated_queue -- which was also created for DM's use.
>
> DM's approach to device creation requi
On Thu, Mar 12, 2015 at 11:56 AM, Mike Snitzer wrote:
> If percpu_ref_init() fails the 'err_hctxs' label should be used instead
> of 'err_map'.
>
> Signed-off-by: Mike Snitzer
> ---
> block/blk-mq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/blk-mq.c b/block/b
34 matches
Mail list logo
