[PATCH ] tcm_qla2xxx Add SCSI command jammer/discard capabilty to the tcm_qla2xxx module

2015-03-07 Thread Laurence Oberman
Hello I use target LIO for all my storage array test targets and customer problem resolution here at Red Hat. This patch resulted from a requirement to mimic behaviour of an expensive hardware jammer for a customer. I have used this for some time with good success to simulate and reproduce late

Re: [PATCH 14/21] lpfc: Fix premature release of rpi bit in bitmask

2015-03-07 Thread James Bottomley
On Thu, 2015-02-05 at 14:25 -0500, James Smart wrote: > --- This is a bit big for an empty explanation. You're adding a lot of unexplained debug statements, but your own words in the comment seem to be the best changelog: > + * lpfc_sli4_unreg_rpi_cmpl_clr - mailbox completion handler > + * @phb

Re: [PATCH 09/21] lpfc: Parse the new 20G, 25G and 40G link speeds in the lpfc driver

2015-03-07 Thread James Bottomley
On Thu, 2015-02-05 at 14:24 -0500, James Smart wrote: > --- > drivers/scsi/lpfc/lpfc_hw4.h | 5 - > drivers/scsi/lpfc/lpfc_init.c | 39 +++ > 2 files changed, 31 insertions(+), 13 deletions(-) > > diff --git a/drivers/scsi/lpfc/lpfc_hw4.h b/drivers/scsi/l

Re: [PATCH 06/21] lpfc: Fix host reset escalation killing all IOs.

2015-03-07 Thread James Bottomley
On Thu, 2015-02-05 at 14:23 -0500, James Smart wrote: > --- This one really requires more than a one-line explanation because the one liner doesn't really describe what you've done. It looks like the description should be: Only the SLI rev 4 card has a host reset capability, so only activate it

Re: [PATCH 01/21] lpfc: Fix the iteration count to match the 30 sec comment

2015-03-07 Thread James Bottomley
On Thu, 2015-02-05 at 14:23 -0500, James Smart wrote: > --- Could you put the signoffs (and any changelog) above here, please. You seem to be using git to generate the patches, so if you just put them in the git change log the right thing will happen. If you don't do this, all your patches have

Re: [PATCH] SCSI: sd: fix null dereference

2015-03-07 Thread Martin K. Petersen
> "Sudip" == Sudip Mukherjee writes: Sudip> we were dereferencing sdkp first and then we were checking for it Sudip> being NULL. http://marc.info/?l=linux-kernel&m=142564395705827&w=2 -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsub