Re: [hpsa] regression, does not recognise tape robot changer

2015-03-02 Thread Kjetil Torgrim Homme
Don Brace writes: > On 02/19/2015 11:09 AM, Kjetil Torgrim Homme wrote: >> this regression is getting old, but it's still present in the newest >> Linus kernels. >> >> I have a HP server with a P411 card with a MSL G3 48 slot tape changer >> attached. the tape changer has two LTO5 and one LTO6 ta

[PATCH v4 4/4] scsi: ufs: inject errors to verify error handling

2015-03-02 Thread Gilad Broner
From: Sujit Reddy Thumma Use fault-injection framework to simulate error conditions in the controller and verify error handling mechanisms implemented in UFS host controller driver. This is used only during development and hence guarded by CONFIG_UFS_FAULT_INJECTION debug config option. Signed-

[PATCH v4 3/4] scsi: ufs: add trace events and dump prints for debug

2015-03-02 Thread Gilad Broner
Add trace events to driver to allow monitoring and profilig of activities such as PM suspend/resume, hibernate enter/exit, clock gating and clock scaling up/down. In addition, add UFS host controller register dumps to provide detailed information in case of errors to assist in analysis of issues.

[PATCH v4 1/4] scsi: ufs: add ioctl interface for query request

2015-03-02 Thread Gilad Broner
From: Dolev Raviv This patch exposes the ioctl interface for UFS driver via SCSI device ioctl interface. As of now UFS driver would provide the ioctl for query interface to connected UFS device. Signed-off-by: Dolev Raviv Signed-off-by: Noa Rubens Signed-off-by: Raviv Shvili Signed-off-by: Ya

[PATCH v4 2/4] scsi: ufs: add debugfs for ufs

2015-03-02 Thread Gilad Broner
From: Lee Susman Adding debugfs capability for ufshcd. debugfs attributes introduced in this patch: - View driver/controller runtime data - Command tag statistics for performance analisis - Dump device descriptor info - Track recoverable errors statistics during runtime - Change UFS power m

[PATCH v4 0/4] Add ioctl and debug utilities to UFS driver

2015-03-02 Thread Gilad Broner
Changes from V3: Changed tag statistics macros to functions and removed redundant call to ufsdbg_remove_debugfs(). Other minor changes fixing previous comments. Dolev Raviv (1): scsi: ufs: add ioctl interface for query request Gilad Broner (1): scsi: ufs: add trace events and dump prints for

Re: [PATCH 9/9] snic:Add Makefile, patch Kconfig, MAINTAINERS

2015-03-02 Thread Hannes Reinecke
On 02/10/2015 05:43 PM, Narsimhulu Musini wrote: > Kconfig for kbuild > Makefile to build snic module > > Updated MAINTAINERS file > > Signed-off-by: Narsimhulu Musini > Signed-off-by: Sesidhar Baddela > --- > MAINTAINERS| 7 +++ > drivers/scsi/Kconfig | 10 +

Re: [PATCH 8/9] snic:Add event tracing to capture IO events.

2015-03-02 Thread Hannes Reinecke
On 02/10/2015 05:43 PM, Narsimhulu Musini wrote: > snic_trc.h contains global trace structure definitions for snic driver > > snic_trc.c adds tracing functionality to capture various IO events. > It maintains global trace buffer to maintain recent history of IO events. > It helps to understand the

Re: [PATCH 7/9] snic:Add sysfs entries to list stats and trace data

2015-03-02 Thread Hannes Reinecke
On 02/10/2015 05:43 PM, Narsimhulu Musini wrote: > snic_stats.h contains stats structre definitions for various events > in snic driver. > > snic_debugfs.c contains setup and cleanup of sysfs entries for listing stats, > resetting stats, enabling/disabling trace, and listing trace data. > > Signe

Re: [PATCH 6/9] snic:Add low level queuing interfaces

2015-03-02 Thread Hannes Reinecke
On 02/10/2015 05:43 PM, Narsimhulu Musini wrote: > These files contain low level queueing interfaces includes > hardware queues, and management of hardware features. > > Signed-off-by: Narsimhulu Musini > Signed-off-by: Sesidhar Baddela > --- > drivers/scsi/snic/cq_desc.h | 77 > dr

Re: [PATCH 5/9] snic:add SCSI handling, AEN, and fwreset handling

2015-03-02 Thread Hannes Reinecke
Hi Narsimhulu, please find comments inline. On 02/10/2015 05:43 PM, Narsimhulu Musini wrote: > snic_scsi.c contains scsi handling, includes queuing io, abort, lun reset, > and host reset. Also it handles asynchronous event notifications from FW. > > Signed-off-by: Narsimhulu Musini > Signed-off

Re: [PATCH 4/9] snic:Add snic target discovery

2015-03-02 Thread Hannes Reinecke
On 02/10/2015 05:43 PM, Narsimhulu Musini wrote: > snic_disc.h contains snic target structure definition. > > snic_disc.c contains target discovery, setup, lookup, and cleanup > > snic_ctl.c contains retrieval of snic capabilities includes > max ios, size, SGs per request, and max concurrent requ

Re: [PATCH 3/9] snic:Add meta request, handling of meta requests.

2015-03-02 Thread Hannes Reinecke
On 02/10/2015 05:43 PM, Narsimhulu Musini wrote: > snic_io.h contains meta request structure definition > meta request contains high level information about firmware requests. > such as request information, size, SGLs. > > snic_io.c contains interfaces to handle meta request, firmware acknowledgme

Re: [PATCH 2/9] snic:Add interrupt, resource firmware interfaces

2015-03-02 Thread Hannes Reinecke
Hi Narsimhulu, please find comments inline. On 02/10/2015 05:43 PM, Narsimhulu Musini wrote: > snic_fwint.h contains firmware interface structures. > > snic_res.h contains firmware request initialization > > snic_res.c contains retrieval of resource configuration, and allocation, > and initiali

Re: [PATCH 1/9] snic: snic module infrastructure

2015-03-02 Thread Hannes Reinecke
Hi Narsimhulu, please find comments inline. On 02/10/2015 05:43 PM, Narsimhulu Musini wrote: > snic_main.c contains module load and unload, global driver context, > PCI Registration, PCI probe and remove, SCSI ML registration functionality. > > snic.h contains snic structure definition, snic glo

Re: [PATCH 1/9] target: Convert DIF emulation to use cmd->prot_type

2015-03-02 Thread Sagi Grimberg
On 2/28/2015 12:35 PM, Nicholas A. Bellinger wrote: From: Nicholas Bellinger This patch changes existing DIF emulation to check the command descriptor's prot_type, instead of what the backend device is exposing in pi_prot_type. Since this value is already set in sbc_check_prot(), go ahead and