Re: [PATCH] scsi/lpfc: use remove handler as shutdown handler

2015-02-16 Thread James Smart
Looks good. Acked-By: James Smart -- james On 1/26/2015 10:18 AM, Thadeu Lima de Souza Cascardo wrote: Without a shutdown handler, some cards behave very badly after a kexec. During probe, pending DMA writes will corrupt kernel memory, for example. Using the remove handler guarantees we w

RE: chelsio: Use a more common const struct pci_device_id foo[] style

2015-02-16 Thread Casey Leedom
Okay, thanks for your patience with my lack of understanding. I'll work with Hariprasad tomorrow to get a revised patch out with the "const" change and eliminate the redundant check of CH_PCI_DEVICE_ID_TABLE_DEFINE_BEGIN to guard the file contents. Thanks for caching these improvements! A

Re: chelsio: Use a more common const struct pci_device_id foo[] style

2015-02-16 Thread Joe Perches
On Mon, 2015-02-16 at 19:07 +, Casey Leedom wrote: > I understand that OS-independence issues aren't something which are > normally accommodated, but as long as definitions don't introduce > unnecessary "foreign intrusion" I would hope that it would be okay. > As I noted, our t4_regs.h file i

RE: chelsio: Use a more common const struct pci_device_id foo[] style

2015-02-16 Thread Casey Leedom
I understand that OS-independence issues aren't something which are normally accommodated, but as long as definitions don't introduce unnecessary "foreign intrusion" I would hope that it would be okay. As I noted, our t4_regs.h file is also OS-independent and used by six other OS device drive

Re: chelsio: Use a more common const struct pci_device_id foo[] style

2015-02-16 Thread Joe Perches
On Mon, 2015-02-16 at 18:05 +, Casey Leedom wrote: > I can't quite tell if this is a patch request being sent to > netdev/David Miller or if it's a suggestion sent to Chelsio that you'd > like Chelsio to adopt. I ~think~ it's the latter because the subject > doesn't include the standard form

RE: chelsio: Use a more common const struct pci_device_id foo[] style

2015-02-16 Thread Casey Leedom
I can't quite tell if this is a patch request being sent to netdev/David Miller or if it's a suggestion sent to Chelsio that you'd like Chelsio to adopt. I ~think~ it's the latter because the subject doesn't include the standard formatting for a patch request but I'm not 100% familiar with th

Re: [PATCH 10/21] lpfc: Fix provide host name and OS name in RSNN-NN FC-GS command

2015-02-16 Thread James Smart
agree - nice nit. I'll add this to the list of things to merge in the next patch update. -- james On 2/6/2015 7:20 AM, Tomas Henzl wrote: On 02/05/2015 08:24 PM, James Smart wrote: --- drivers/scsi/lpfc/lpfc_ct.c | 23 --- 1 file changed, 20 insertions(+), 3 deletions(

Re: [PATCH 07/21] lpfc: Fix setting of EQ delay Multiplier

2015-02-16 Thread James Smart
Tomas, This one I'm going to leave as is. bf_set is a macro and I'd prefer we kept the variable with a real data type and not be subject to any compiler-based type conversions in the equations. I'd rather not risk any disruption to the macro to add all the paren'd type declarations. -- jam

Re: [PATCH 02/21] lpfc: Add Lancer Temperature Event support to the lpfc driver

2015-02-16 Thread James Smart
On 2/6/2015 7:16 AM, Tomas Henzl wrote: On 02/05/2015 08:23 PM, James Smart wrote: --- drivers/scsi/lpfc/lpfc_hw4.h | 1 + drivers/scsi/lpfc/lpfc_init.c | 179 +- 2 files changed, 125 insertions(+), 55 deletions(-) diff --git a/drivers/scsi/lpfc/l

Re: [PATCH 0/2] SCSI-lpfc: Deletion of an unnecessary check

2015-02-16 Thread James Smart
Markus, Suggestions noted. If not merged, I'll pull them into the next patch set. -- james Acked-By: James Smart On 2/5/2015 5:25 PM, SF Markus Elfring wrote: From: Markus Elfring Date: Thu, 5 Feb 2015 23:17:52 +0100 Another update suggestion was taken into account after a patch was app

Re: [PATCH 5/8] target: Add sanity checks for DPO/FUA bit usage

2015-02-16 Thread Sagi Grimberg
On 2/14/2015 5:27 AM, Nicholas A. Bellinger wrote: From: Nicholas Bellinger This patch adds a sbc_check_dpofua() function that performs sanity checks for DPO/FUA command bits. It introduces checks to fail when either bit is set, but the backend device is not advertising support for them. It a

Re: General protection fault in iscsi_rx_thread_pre_handler

2015-02-16 Thread Gavin Guo
Hi Nicholas, On Mon, Feb 16, 2015 at 6:52 PM, Gavin Guo wrote: > Hi Nicholas, > > On Thu, Feb 12, 2015 at 3:16 PM, Nicholas A. Bellinger > wrote: >> Hi Gavin, >> >> On Tue, 2015-02-03 at 08:28 +0800, Gavin Guo wrote: >>> Hi Nicholas, >>> >>> On Sun, Feb 1, 2015 at 11:47 AM, Gavin Guo wrote: >>>

Re: General protection fault in iscsi_rx_thread_pre_handler

2015-02-16 Thread Gavin Guo
Hi Nicholas, On Thu, Feb 12, 2015 at 3:16 PM, Nicholas A. Bellinger wrote: > Hi Gavin, > > On Tue, 2015-02-03 at 08:28 +0800, Gavin Guo wrote: >> Hi Nicholas, >> >> On Sun, Feb 1, 2015 at 11:47 AM, Gavin Guo wrote: >> > Hi Nicholas, >> > >> > On Sat, Jan 31, 2015 at 6:53 AM, Nicholas A. Bellinge