Re: [PATCH] st: implement sysfs based tape statistics v2

2015-02-10 Thread Dale R. Worley
"Seymour, Shane M" writes: > Both of those things would have to be futures and require discussion - > the very original version cleared stats on a device open but I got > asked to keep it the stats cumulative so they would be more similar to > disk stats. Yes, this is a futures question. But in

Re: [RFC] implementing tape statistics single file vs multi-file in sysfs

2015-02-10 Thread Greg KH
On Tue, Feb 10, 2015 at 02:27:20PM +, Bryn M. Reeves wrote: > On Sat, Feb 07, 2015 at 12:07:43PM +0800, Greg KH wrote: > > $ cat /sys/fs/selinux/avc/cache_stats > lookups hits misses allocations reclaims frees > 18938916 18921707 17209 17209 17328 22215 > 38164283 38146514 17769 17769 16800 1

Re: CONFIG_SCSI_MQ_DEFAULT cause slow direct write speed to usb stick

2015-02-10 Thread Douglas Gilbert
On 15-02-10 01:50 PM, Andrej Gelenberg wrote: Hi, i had found a problem with CONFIG_SCSI_MQ_DEFAULT config option. If it activated, then the write speeds to the /dev/sd* of an usb stick drops dramatically: it's only about 250 kb/CONFIG_SCSI_MQ_DEFAULTs, but should be about 7 Mb/s. Git bisect als

CONFIG_SCSI_MQ_DEFAULT cause slow direct write speed to usb stick

2015-02-10 Thread Andrej Gelenberg
Hi, i had found a problem with CONFIG_SCSI_MQ_DEFAULT config option. If it activated, then the write speeds to the /dev/sd* of an usb stick drops dramatically: it's only about 250 kb/CONFIG_SCSI_MQ_DEFAULTs, but should be about 7 Mb/s. Git bisect also points to commit 24c20f10583647e30afe87b6f6d5e

Re: [PATCH] scsi: megaraid_sas: Prevent future %p disaster

2015-02-10 Thread Joe Perches
Convert printks to pr_ Miscellaneous: o Coalesce formats Add and remove spaces where appropriate when coalescing o Add pr_fmt o Remove embedded prefixes o Convert embedded function names to "%s:", __func__ o Realign arguments o Outdent one block that was inappropriately indented o Use pr_cont w

Re: [PATCH] hpsa: correct compiler warnings introduced by hpsa-add-local-workqueue patch

2015-02-10 Thread Tejun Heo
On Tue, Feb 10, 2015 at 08:56:30AM -0800, James Bottomley wrote: > > + wq = alloc_ordered_workqueue("%s_%d_hpsa", 0, name, h->ctlr); > > It's not an objection to your patch, but what idiot did this? There's > an extra variable there between the format and the arguments. That > makes the patter

Re: [PATCH] scsi: megaraid_sas: Prevent future %p disaster

2015-02-10 Thread Joe Perches
On Tue, 2015-02-10 at 22:16 +0530, Kashyap Desai wrote: > Acked-by: Kashyap Desai > > > -Original Message- > > From: Rasmus Villemoes [mailto:li...@rasmusvillemoes.dk] > > Sent: Friday, February 06, 2015 8:04 PM [] > > There is currently no %po format extension, so currently the letters >

[Bug 93051] Oops in kmem_cache_alloc / scsi_host_alloc_command

2015-02-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=93051 --- Comment #3 from Nathan R --- Created attachment 166371 --> https://bugzilla.kernel.org/attachment.cgi?id=166371&action=edit oops 2015-02-01 -- You are receiving this mail because: You are watching the assignee of the bug. -- To unsubscribe

[Bug 93051] Oops in kmem_cache_alloc / scsi_host_alloc_command

2015-02-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=93051 --- Comment #2 from Nathan R --- Created attachment 166361 --> https://bugzilla.kernel.org/attachment.cgi?id=166361&action=edit oops 2015-01-31 (2) -- You are receiving this mail because: You are watching the assignee of the bug. -- To unsubsc

[Bug 93051] Oops in kmem_cache_alloc / scsi_host_alloc_command

2015-02-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=93051 --- Comment #1 from Nathan R --- Created attachment 166351 --> https://bugzilla.kernel.org/attachment.cgi?id=166351&action=edit oops 2015-01-31 (1) -- You are receiving this mail because: You are watching the assignee of the bug. -- To unsubsc

Re: [PATCH] hpsa: correct compiler warnings introduced by hpsa-add-local-workqueue patch

2015-02-10 Thread James Bottomley
On Fri, 2015-02-06 at 17:44 -0600, Don Brace wrote: > Correct compiler warning introduced by hpsa-add-local-workqueue patch > 6636e7f455b33b957c5ee016daa6de46148026ab hpsa: Use local workqueues > instead of system workqueues > > Suggested-by: Kees Cook > Reviewed-by: Scott Teel > Reviewed-by: We

[Bug 93051] New: Oops in kmem_cache_alloc / scsi_host_alloc_command

2015-02-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=93051 Bug ID: 93051 Summary: Oops in kmem_cache_alloc / scsi_host_alloc_command Product: SCSI Drivers Version: 2.5 Kernel Version: 3.16.0-29-generic #39-Ubuntu Hardware: All OS: L

[PATCH 0/9] snic:initial submission of snic driver for Cisco SCSI HBA

2015-02-10 Thread Narsimhulu Musini
The following patch series adds snic driver for Cisco SCSI HBA Cisco has developed a new PCI HBA interface called sNIC, which stands for SCSI NIC. This is a new storage feature supported on specialized network adapter. The new PCI function provides a uniform host interface and abstracts backend s

[PATCH 6/9] snic:Add low level queuing interfaces

2015-02-10 Thread Narsimhulu Musini
These files contain low level queueing interfaces includes hardware queues, and management of hardware features. Signed-off-by: Narsimhulu Musini Signed-off-by: Sesidhar Baddela --- drivers/scsi/snic/cq_desc.h | 77 drivers/scsi/snic/cq_enet_desc.h | 38 ++ drivers/scsi/snic/vnic_

[PATCH 7/9] snic:Add sysfs entries to list stats and trace data

2015-02-10 Thread Narsimhulu Musini
snic_stats.h contains stats structre definitions for various events in snic driver. snic_debugfs.c contains setup and cleanup of sysfs entries for listing stats, resetting stats, enabling/disabling trace, and listing trace data. Signed-off-by: Narsimhulu Musini Signed-off-by: Sesidhar Baddela -

[PATCH 2/9] snic:Add interrupt, resource firmware interfaces

2015-02-10 Thread Narsimhulu Musini
snic_fwint.h contains firmware interface structures. snic_res.h contains firmware request initialization snic_res.c contains retrieval of resource configuration, and allocation, and initialization of HW Queues. snic_isr.c contains interrupt request, release, and handling Signed-off-by: Narsimhu

[PATCH 1/9] snic: snic module infrastructure

2015-02-10 Thread Narsimhulu Musini
snic_main.c contains module load and unload, global driver context, PCI Registration, PCI probe and remove, SCSI ML registration functionality. snic.h contains snic structure definition, snic global context, and prototypes. snic_os.h contains OS specific interfaces. snic_attrs.c contains device

[PATCH 4/9] snic:Add snic target discovery

2015-02-10 Thread Narsimhulu Musini
snic_disc.h contains snic target structure definition. snic_disc.c contains target discovery, setup, lookup, and cleanup snic_ctl.c contains retrieval of snic capabilities includes max ios, size, SGs per request, and max concurrent requests. Signed-off-by: Narsimhulu Musini Signed-off-by: Sesid

[PATCH 9/9] snic:Add Makefile, patch Kconfig, MAINTAINERS

2015-02-10 Thread Narsimhulu Musini
Kconfig for kbuild Makefile to build snic module Updated MAINTAINERS file Signed-off-by: Narsimhulu Musini Signed-off-by: Sesidhar Baddela --- MAINTAINERS| 7 +++ drivers/scsi/Kconfig | 10 ++ drivers/scsi/Makefile | 1 + drivers/scsi/snic/Makefile | 17

[PATCH 8/9] snic:Add event tracing to capture IO events.

2015-02-10 Thread Narsimhulu Musini
snic_trc.h contains global trace structure definitions for snic driver snic_trc.c adds tracing functionality to capture various IO events. It maintains global trace buffer to maintain recent history of IO events. It helps to understand the sequence of events prior to particular IO event, or hung,

[PATCH 3/9] snic:Add meta request, handling of meta requests.

2015-02-10 Thread Narsimhulu Musini
snic_io.h contains meta request structure definition meta request contains high level information about firmware requests. such as request information, size, SGLs. snic_io.c contains interfaces to handle meta request, firmware acknowledgment, and high level generic queueing interface. Signed-off-

[PATCH 5/9] snic:add SCSI handling, AEN, and fwreset handling

2015-02-10 Thread Narsimhulu Musini
snic_scsi.c contains scsi handling, includes queuing io, abort, lun reset, and host reset. Also it handles asynchronous event notifications from FW. Signed-off-by: Narsimhulu Musini Signed-off-by: Sesidhar Baddela --- drivers/scsi/snic/snic_scsi.c | 2630

RE: [PATCH] scsi: megaraid_sas: Prevent future %p disaster

2015-02-10 Thread Kashyap Desai
Acked-by: Kashyap Desai > -Original Message- > From: Rasmus Villemoes [mailto:li...@rasmusvillemoes.dk] > Sent: Friday, February 06, 2015 8:04 PM > To: Kashyap Desai; Sumit Saxena; Uday Lingala; James E.J. Bottomley > Cc: Rasmus Villemoes; megaraidlinux@avagotech.com; linux- > s...@vg

Re: [RFC] implementing tape statistics single file vs multi-file in sysfs

2015-02-10 Thread Bryn M. Reeves
On Sat, Feb 07, 2015 at 12:07:43PM +0800, Greg KH wrote: > On Fri, Feb 06, 2015 at 03:41:58PM +, Bryn M. Reeves wrote: > > I can't speak for Shane but wouldn't spend too much time looking at the > > current v2 patch: it's the result of a pretty ugly compromise suggested > > on linux-scsi. > >

Re: [PATCH v1 2/4] scsi: ufs: add debugfs for ufs

2015-02-10 Thread Gilad Broner
> Should we append the index for unique directory > name for each contoroller like "ufs0", "ufs1", ...? I agree - uploaded patch V2 in which this is handled. Thanks, Gilad. -- Qualcomm Israel, on behalf of Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the

[PATCH v2 0/4] Add ioctl and debug utilities to UFS driver

2015-02-10 Thread Gilad Broner
Changes from V1: - Renamed debugfs.* to ufs-debugfs.* - Added host controller instance number to ufs debug-fs entry name. - Removed FTRACE_EVENT_ENABLED macro as it was redundant. Dolev Raviv (1): scsi: ufs: add ioctl interface for query request Gilad Broner (1): scsi: ufs: add trace events

[PATCH v2 1/4] scsi: ufs: add ioctl interface for query request

2015-02-10 Thread Gilad Broner
From: Dolev Raviv This patch exposes the ioctl interface for UFS driver via SCSI device ioctl interface. As of now UFS driver would provide the ioctl for query interface to connected UFS device. Signed-off-by: Dolev Raviv Signed-off-by: Noa Rubens Signed-off-by: Raviv Shvili Signed-off-by: Ya

[PATCH v2 2/4] scsi: ufs: add debugfs for ufs

2015-02-10 Thread Gilad Broner
From: Lee Susman Adding debugfs capability for ufshcd. debugfs attributes introduced in this patch: - View driver/controller runtime data - Command tag statistics for performance analisis - Dump device descriptor info - Track recoverable errors statistics during runtime - Change UFS power m

[PATCH v2 4/4] scsi: ufs: inject errors to verify error handling

2015-02-10 Thread Gilad Broner
From: Sujit Reddy Thumma Use fault-injection framework to simulate error conditions in the controller and verify error handling mechanisms implemented in UFS host controller driver. This is used only during development and hence guarded by CONFIG_UFS_FAULT_INJECTION debug config option. Signed-

[PATCH v2 3/4] scsi: ufs: add trace events and dump prints for debug

2015-02-10 Thread Gilad Broner
Add trace events to driver to allow monitoring and profilig of activities such as PM suspend/resume, hibernate enter/exit, clock gating and clock scaling up/down. In addition, add UFS host controller register dumps to provide detailed information in case of errors to assist in analysis of issues.

Re: [PATCH] IB/srp: Add 64-bit LUN support

2015-02-10 Thread Yann Droneaud
Hi Bart, Le mardi 10 février 2015 à 12:41 +0100, Bart Van Assche a écrit : > On 02/10/15 11:13, Yann Droneaud wrote: > > Le lundi 02 février 2015 à 18:21 +0100, Bart Van Assche a écrit : > >> The largest LUN number that has been tested is 0xd2003fff. > >> > >> Checked the following structu

Re: [PATCH] IB/srp: Add 64-bit LUN support

2015-02-10 Thread Bart Van Assche
Hello Yann, On 02/10/15 11:13, Yann Droneaud wrote: > Le lundi 02 février 2015 à 18:21 +0100, Bart Van Assche a écrit : >> The largest LUN number that has been tested is 0xd2003fff. >> >> Checked the following structure sizes with gdb: >> * sizeof(struct srp_cmd) = 48 >> * sizeof(struct sr

[PATCH RESEND v5] st implement tape statistics

2015-02-10 Thread Seymour, Shane M
The following patch exposes statistics for the st driver via sysfs. There is a need for companies with large numbers of tape drives numbering in the tens of thousands to track the performance of those tape drives (e.g. when a backup exceeds its window). The statistics provided should allow the calc

Re: [PATCH] IB/srp: Add 64-bit LUN support

2015-02-10 Thread Yann Droneaud
Hi, Le lundi 02 février 2015 à 18:21 +0100, Bart Van Assche a écrit : > The largest LUN number that has been tested is 0xd2003fff. > > Checked the following structure sizes with gdb: > * sizeof(struct srp_cmd) = 48 > * sizeof(struct srp_tsk_mgmt) = 48 > * sizeof(struct srp_aer_req) = 36 >