[PATCH 3.4 100/177] scsi: Fix error handling in SCSI_IOCTL_SEND_COMMAND

From: Jan Kara 3.4.106-rc1 review patch. If anyone has any objections, please let me know. -- commit 84ce0f0e94ac97217398b3b69c21c7a62ebeed05 upstream. When sg_scsi_ioctl() fails to prepare request to submit in blk_rq_map_kern() we jump to a label where we just end up copying

Re: [PATCH] ahci_xgene: Fix the dma state machine lockup for the ATA_CMD_SMART PIO mode command.

On Tue, Jan 27, 2015 at 11:26:11PM +0530, Suman Tripathi wrote: > This patch addresses the issue with ATA_CMD_SMART pio mode > command for enumeration and device detection with ATA devices.It is the > same issue as in patch > > www.spinics.net/lists/linux-ide/msg49092.html The link is broken. Can

Re: [PATCH] csiostor:T5 Firmware fix and cleanup.

From: Praveen Madhavan Date: Tue, 27 Jan 2015 19:46:37 +0530 > This patch fix is to use default firmware configuration files > present in the adapter incase if not available in standard > /lib/firmware/* dir. Additional cleanup is done to reuse flash > related defines from cxgb4 header file. > >

Re: Backport of a fix for HPSA (Disabling a disabled device problem during kdump) driver

On Tue, Jan 06, 2015 at 05:15:19PM +0100, Tomas Henzl wrote: > On 01/05/2015 07:41 PM, Masoud Sharbiani wrote: > > Dear stable maintainers, > > Can you please backport commitid 132aa220b45d60e9b20def1e9d8be9422eed9616 > > (hpsa: refine the pci enable/disable handling) to 3.10 stable (and > > earli

Re: [PATCH 08/17] ibmvscsi: Fix bidi command test

On 01/23/2015 04:10 AM, Bart Van Assche wrote: > Signed-off-by: Bart Van Assche > Cc: Brian King > Cc: Nathan Fontenot > --- > drivers/scsi/ibmvscsi/ibmvscsi.c | 10 ++ > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c > b/drivers/scsi

[PATCH] scsi: use kzalloc instead of kmalloc/memset

Hint given by Coccinelle. Signed-off-by: Liviu Gheorghisan --- drivers/scsi/aic7xxx/aic7xxx_osm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/scsi/aic7xxx/aic7xxx_osm.c b/drivers/scsi/aic7xxx/aic7xxx_osm.c index 8836011..a2f2c77 100644 --- a/drivers/scsi/aic7xx

Re: old linux scsi headers

On 01/10/2015 02:10 AM, Christoph Hellwig wrote: On Fri, Jan 09, 2015 at 09:38:50AM -0800, Andy Grover wrote: Hello glibc people, This concerns sysdeps/unix/sysv/linux/scsi/{scsi, scsi_ioctl, sg}.h They define common SCSI values, as well as Linux's SCSI-related ioctls. Apparently they were co

Re: [PATCH] ahci_xgene: Fix the dma state machine lockup for the ATA_CMD_SMART PIO mode command.

On Tue, Jan 27, 2015 at 11:26:11PM +0530, Suman Tripathi wrote: > This patch addresses the issue with ATA_CMD_SMART pio mode > command for enumeration and device detection with ATA devices.It is the > same issue as in patch > > www.spinics.net/lists/linux-ide/msg49092.html The link is broken. Ca

[PATCH] Fix the dma state machine lockup for the ATA_CMD_SMART PIO mode command.

Signed-off-by: Suman Tripathi --- Suman Tripathi (1): ahci_xgene: Fix the dma state machine lockup for the ATA_CMD_SMART PIO mode command. drivers/ata/ahci_xgene.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 1.8.2.1 -- To unsubscribe from this list: send the line "unsubsc

[PATCH] ahci_xgene: Fix the dma state machine lockup for the ATA_CMD_SMART PIO mode command.

This patch addresses the issue with ATA_CMD_SMART pio mode command for enumeration and device detection with ATA devices.It is the same issue as in patch www.spinics.net/lists/linux-ide/msg49092.html Signed-off-by: Suman Tripathi --- --- drivers/ata/ahci_xgene.c | 3 ++- 1 file changed, 2 inser

Re: [PATCH 0/2 v2] hpsa: workqueue + minor fix

On 01/27/2015 05:56 PM, Tomas Henzl wrote: > I've adapted previously posted changes on top of the latest hpsa series. > And once again. And because I haven't read the code in the last hpsa series properly I haven't realised that the body of this patch is already there. Please ignore this series.

Re: [PATCH v2 48/48] hpsa: Use local workqueues instead of system workqueues

On 01/27/2015 05:55 PM, Tomas Henzl wrote: > On 01/23/2015 11:45 PM, Don Brace wrote: >> Suggested-by: Tomas Henzl > Yes i have suggested something but it was something different > I wanted to move to his own workqueue the hpsa_monitor_ctlr_worker > and exactly that is what you have left out in th

[PATCH 1/2] hpsa: use a driver's own workqueue instead of a shared wq

hpsa driver uses a shared wq, max sleep time in function spent hpsa_wait_for_clear_event_notify_ack may take up to 40sec and that is too much for a shared workqueue. This patch takes the easiest approach and just creates a driver's own workqueue. Signed-off-by: Tomas Henzl --- drivers/scsi/hpsa.

[PATCH 2/2] hpsa: remove a needless call - pci_get_drvdata

Signed-off-by: Tomas Henzl --- drivers/scsi/hpsa.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index af32962259..6e4abba285 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi/hpsa.c @@ -7102,14 +7102,13 @@ static void hpsa_fr

[PATCH 0/2 v2] hpsa: workqueue + minor fix

I've adapted previously posted changes on top of the latest hpsa series. And once again. Tomas -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 48/48] hpsa: Use local workqueues instead of system workqueues

On 01/23/2015 11:45 PM, Don Brace wrote: > Suggested-by: Tomas Henzl Yes i have suggested something but it was something different I wanted to move to his own workqueue the hpsa_monitor_ctlr_worker and exactly that is what you have left out in this patch. I'm going to post a patch on top of this

Re: [PATCH 1/2] ata: ahci_platform: fix owner module reference mismatch for scsi host

Hello, On Tue, Jan 27, 2015 at 08:34:58AM +0900, Akinobu Mita wrote: > The owner module reference of the ahci platform's scsi_host is > initialized to libahci_platform's one, because these drivers use a > scsi_host_template defined in libahci_platform. So these drivers can > be unloaded even if t

[PATCH] csiostor:T5 Firmware fix and cleanup.

This patch fix is to use default firmware configuration files present in the adapter incase if not available in standard /lib/firmware/* dir. Additional cleanup is done to reuse flash related defines from cxgb4 header file. Please apply over net-next since it depends on previous commit. Signed-of

[PATCH 10/10] qla2xxx: Comment out dead code

Comment out the code that is never reached in qlt_set_data_offset() to avoid that static source code analysis tools report warnings for this code. Signed-off-by: Bart Van Assche Cc: Quinn Tran Cc: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_target.c | 16 +--- 1 file changed, 9 ins

[PATCH 09/10] qla2xxx: Remove dead code

The "return QLA_SUCCESS" statement just above the "fw_load_failed" label cannot be reached, hence remove it. Additionally remove the "else" keyword since the code block below the if-statement ends with a return statement. Signed-off-by: Bart Van Assche Cc: Quinn Tran Cc: Saurav Kashyap --- dri

[PATCH 08/10] qla2xxx: Remove a superfluous test

Avoid that smatch reports the following warning: drivers/scsi/qla2xxx/qla_attr.c:1081: qla2x00_model_desc_show() warn: this array is probably non-NULL. 'vha->hw->model_desc' Signed-off-by: Bart Van Assche Cc: Quinn Tran Cc: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_attr.c | 3 +-- 1 file c

[PATCH 07/10] qla2xxx: Fix sparse annotations

This patch removes 21 casts between an __iomem pointer type and another data type but also introduces five new casts (see also the casts with "__force"). Although this patch does not change any functionality, IMHO the code with __force casts needs further review. Signed-off-by: Bart Van Assche Cc

[PATCH 04/10] qla2xxx: Replace two macros with an inline function

Replace the QLA82XX_ADDR_IN_RANGE() and QLA8044_ADDR_IN_RANGE() macros with the inline function addr_in_range(). This avoids that the compiler reports the following warning when building with W=1: comparison of unsigned expression >= 0 is always true. Signed-off-by: Bart Van Assche Cc: Quinn Tran

[PATCH 05/10] qla2xxx: Remove __constant_ prefix

Whether htonl() or __constant_htonl() is used, if the argument is a constant the conversion happens at compile time. Hence leave out the __constant_ prefix for this and other endianness conversion functions. This improves source code readability. Signed-off-by: Bart Van Assche Cc: Quinn Tran Cc:

[PATCH 06/10] qla2xxx: Avoid that sparse complains about duplicate [noderef] attributes

Signed-off-by: Bart Van Assche Cc: Quinn Tran Cc: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_dbg.c | 2 +- drivers/scsi/qla2xxx/qla_init.c | 2 +- drivers/scsi/qla2xxx/qla_iocb.c | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_dbg.c b/drivers/

[PATCH 03/10] qla2xxx: Remove set-but-not-used variables

Signed-off-by: Bart Van Assche Cc: Quinn Tran Cc: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_attr.c | 2 -- drivers/scsi/qla2xxx/qla_bsg.c| 5 - drivers/scsi/qla2xxx/qla_dbg.c| 24 ++-- drivers/scsi/qla2xxx/qla_init.c | 2 -- drivers/scsi/qla2xxx/qla_iocb

[PATCH 02/10] qla2xxx: Declare local functions static

Signed-off-by: Bart Van Assche Cc: Quinn Tran Cc: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_bsg.c | 2 +- drivers/scsi/qla2xxx/qla_iocb.c | 4 ++-- drivers/scsi/qla2xxx/qla_nx.c | 2 +- drivers/scsi/qla2xxx/qla_nx2.c | 4 ++-- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a

[PATCH 01/10] qla2xxx: Report both rsp_info and rsp_info_len

Let the debug statement in qlafx00_tm_iocb_entry() report both rsp_info and rsp_info_len instead of reporting rsp_info_len twice. Signed-off-by: Bart Van Assche Cc: Quinn Tran Cc: Saurav Kashyap --- drivers/scsi/qla2xxx/qla_mr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -

[PATCH 0/10] qla2xxx: Fix various warnings reported by static source code analysis tools

This patch series addresses several warnings reported by static source code analysis tools for the qla2xxx driver (gcc (W=1), sparse (C=2) and smatch (C=2 CHECK="smatch -p=kernel")). The patches in this series are: 0001-qla2xxx-Report-both-rsp_info-and-rsp_info_len.patch 0002-qla2xxx-Declare-local