Re: [PATCH 1/5] PCI: Add defines for max read request sizes

2015-01-26 Thread Bjorn Helgaas
On Mon, Jan 26, 2015 at 06:05:22PM +0100, Rafał Miłecki wrote: > There are few drivers using magic numbers when operating with PCIe > capabilities and PCI_EXP_DEVCTL_READRQ. Define known values to allow > cleaning their code a bit. > > Signed-off-by: Rafał Miłecki I applied this whole series, wi

RE: [PATCH] st: implement sysfs based tape statistics v2

2015-01-26 Thread Seymour, Shane M
I was wondering if anyone had any feedback or had any chance to review the changes? -Original Message- From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi-ow...@vger.kernel.org] On Behalf Of Seymour, Shane M Sent: Tuesday, January 13, 2015 2:43 PM To: linux-scsi@vger.kernel.org Cc:

[PATCH 1/2] ata: ahci_platform: fix owner module reference mismatch for scsi host

2015-01-26 Thread Akinobu Mita
The owner module reference of the ahci platform's scsi_host is initialized to libahci_platform's one, because these drivers use a scsi_host_template defined in libahci_platform. So these drivers can be unloaded even if the scsi device is being accessed. This fixes it by pushing the scsi_host_temp

[PATCH 2/2] ata: pata_platform: fix owner module reference mismatch for scsi host

2015-01-26 Thread Akinobu Mita
The owner module reference of the pata_of_platform's scsi_host is initialized to pata_platform's one, because pata_of_platform driver use a scsi_host_template defined in pata_platform. So this drivers can be unloaded even if the scsi device is being accessed. This fixes it by propagating the scsi

[Bug 81861] Oops by mvsas v0.8.16: sas: ataX: end_device-Y:0:Z: dev error handler -> general protection fault, RIP: mvs_task_prep_ata+0x80/0x3a0

2015-01-26 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=81861 --- Comment #22 from Nathan R --- Created attachment 164841 --> https://bugzilla.kernel.org/attachment.cgi?id=164841&action=edit Patched mvsas dmesg in kernel 3.18.3 -- You are receiving this mail because: You are watching the assignee of the

[Bug 81861] Oops by mvsas v0.8.16: sas: ataX: end_device-Y:0:Z: dev error handler -> general protection fault, RIP: mvs_task_prep_ata+0x80/0x3a0

2015-01-26 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=81861 --- Comment #21 from Nathan R --- (In reply to Nathan R from comment #20) > There seems to be various issues with this driver. After reverting that > commit, I can load the driver, but insmod takes a long time to return. One > time was about 3mins

[Bug 81861] Oops by mvsas v0.8.16: sas: ataX: end_device-Y:0:Z: dev error handler -> general protection fault, RIP: mvs_task_prep_ata+0x80/0x3a0

2015-01-26 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=81861 nathan.renniewaldock+kernelb...@gmail.com changed: What|Removed |Added CC||nathan.renniewa

Re: sysfs methods can race with ->remove

2015-01-26 Thread Alan Stern
On Mon, 26 Jan 2015, Christoph Hellwig wrote: > On Thu, Jan 15, 2015 at 02:40:31PM -0500, Tejun Heo wrote: > > > If a method is registered by the driver, then the driver will > > > unregister it when the ->remove routine runs. I don't know for > > > certain, but I would expect that the sysfs/kern

Re: sysfs methods can race with ->remove

2015-01-26 Thread Christoph Hellwig
On Thu, Jan 15, 2015 at 02:40:31PM -0500, Tejun Heo wrote: > > If a method is registered by the driver, then the driver will > > unregister it when the ->remove routine runs. I don't know for > > certain, but I would expect that the sysfs/kernfs core will make sure > > that any existing method cal

Re: module: fix module_refcount() return when running in a module exit routine

2015-01-26 Thread Christoph Hellwig
On Fri, Jan 23, 2015 at 10:42:47AM -0800, James Bottomley wrote: > To that point, Rusty's patch just keeps the status quo in the new > module_refcount() environment, so it's the quick bandaid. > > I think the use case you're worrying about is what happens if someone > tries to use a device after m

[PATCH 4/5] [SCSI] esas2r: use PCI define for max read request size

2015-01-26 Thread Rafał Miłecki
Signed-off-by: Rafał Miłecki --- drivers/scsi/esas2r/esas2r_init.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/esas2r/esas2r_init.c b/drivers/scsi/esas2r/esas2r_init.c index 6776931..c0b37a5 100644 --- a/drivers/scsi/esas2r/esas2r_init.c +++ b/drivers/sc

[PATCH 1/5] PCI: Add defines for max read request sizes

2015-01-26 Thread Rafał Miłecki
There are few drivers using magic numbers when operating with PCIe capabilities and PCI_EXP_DEVCTL_READRQ. Define known values to allow cleaning their code a bit. Signed-off-by: Rafał Miłecki --- include/uapi/linux/pci_regs.h | 4 1 file changed, 4 insertions(+) diff --git a/include/uapi/l

[PATCH] scsi/lpfc: use remove handler as shutdown handler

2015-01-26 Thread Thadeu Lima de Souza Cascardo
Without a shutdown handler, some cards behave very badly after a kexec. During probe, pending DMA writes will corrupt kernel memory, for example. Using the remove handler guarantees we will use a well tested path. With this patch I applied, I managed to use kexec multiple times and probe and SCSI

[Bug 91711] 3w-9xxx: DMA-API: device driver tries to free DMA memory it has not allocated

2015-01-26 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=91711 Orion changed: What|Removed |Added Component|SCSI|Other Product|IO/Storage

Re: [PATCH 0/17] Clear up bidi command confusion

2015-01-26 Thread Bart Van Assche
On 01/23/15 14:12, Christoph Hellwig wrote: > On Fri, Jan 23, 2015 at 01:05:30PM +0100, Bart Van Assche wrote: >> There is some confusion in the SCSI core and in SCSI LLDs around the >> meaning of sc_data_direction and whether or not this member can have the >> value DMA_BIDIRECTIONAL. Clear up thi