Re: module: fix module_refcount() return when running in a module exit routine

James Bottomley writes: > On Fri, 2015-01-23 at 05:17 -0800, Christoph Hellwig wrote: >> On Fri, Jan 23, 2015 at 01:24:15PM +1030, Rusty Russell wrote: >> > The correct fix is to turn try_module_get() into __module_get(), and >> > always do the module_put(). >> >> Is this really safe? __module_g

[PATCH v2 38/48] hpsa: return failed from device reset/abort handlers

Returning failed from the device reset handler will get the device kicked offline, which is fine if the controller is locked up anyhow. Cannot abort a command from a failed controller. Reviewed-by: Scott Teel Reviewed-by: Justin Lindley Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |7

[PATCH v2 48/48] hpsa: Use local workqueues instead of system workqueues

Suggested-by: Tomas Henzl Reviewed-by: Webb Scales Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 68 +-- drivers/scsi/hpsa.h |2 ++ 2 files changed, 56 insertions(+), 14 deletions(-) diff --git a/drivers/scs

[PATCH v2 41/48] hpsa: do not use function pointers in fast path command submission

From: Stephen Cameron Performance tweak, avoid unnecessary function calls. Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |8 +--- drivers/scsi/hpsa.h |5 + 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/s

[PATCH v2 47/48] hpsa: add in P840ar controller model name

Add in P840ar model name for gen9 Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 6568da5..15ef65c 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi/

[PATCH v2 46/48] hpsa: add in gen9 controller model names

Add in gen9 controller model names Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index c1f4a95..6568da5 100644 --- a/drivers/sc

[PATCH v2 39/48] hpsa: do not use a void pointer for scsi_cmd field of struct CommandList

From: Stephen Cameron There's no reason for it to be a void *, it should be a struct scsi_cmnd * Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |6 +++--- drivers/scsi/hpsa_cmd.h |2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/driver

[PATCH v2 43/48] hpsa: refactor duplicated scan completion code into a new routine

From: Webb Scales Hoist the conditional out of do_not_scan_if_controller_locked_up() and place it in the caller (this improves the code structure, making it more consistent with other uses and enabling tail-call optimization); rename the function to hpsa_scan_complete(), and use it at the end of

[PATCH v2 44/48] hpsa: shorten the wait for the CISS doorbell mode change ack

From: Robert Elliott Shorten the wait for the CISS configuration table doorbell mode change acknowledgment from 300-600 s to 20 s, which is the value specified in the CISS specification that should be honored by all controllers. Wait using interruptible msleep() rather than uninterruptible uslee

[PATCH v2 45/48] hpsa: detect and report failures changing controller transport modes

From: Robert Elliott Detect failues when attempting to change controller to use simple or performant transport modes (mode change ack) rather than just proceeding ahead after timeouts. Return values are added to: hpsa_put_ctlr_into_performant_mode hpsa_wait_for_mode_change_ack an

[PATCH v2 42/48] hpsa: move SG descriptor set-up out of hpsa_scatter_gather()

From: Webb Scales Move the code which sets up the SG descriptor out of hpsa_scatter_gather() and into a subroutine where it can be reused (in the next patch). The Ext field is now assigned unconditionally: this makes the refactor much simpler, but more importantly it removes a conditional operat

[PATCH v2 40/48] hpsa: print CDBs instead of kernel virtual addresses for uncommon errors

From: Stephen Cameron Printing the address of the command pointer is of little value, change to print the CDB. Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 29 - 1 file changed, 16 insertions(+), 13 deletions(-) diff --git a/drivers

[PATCH v2 37/48] hpsa: check for ctlr lockup after command allocation in main io path

From: Stephen Cameron Command allocation is the thing that takes the longest in the main i/o path, so check for controller lockup immediately after this to prevent submitting commands to locked up controller as much as possible. Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scs

[PATCH v2 36/48] hpsa: guard against overflowing raid map array

From: Stephen Cameron In the code that translates logical drive LBAs to physical drive LBAs if we overflow the raid map disk data array we will get the wrong answers. We do not expect that to happen, but best to be on the safe side and guard against it anyway. Reviewed-by: Scott Teel Signed-of

[PATCH v2 35/48] hpsa: do not ack controller events on controllers that do not support it

From: Stephen Cameron Acking controller events on controllers that do not support it can cause such controllers to lock up. Reviewed-by: Scott Teel Signed-off-by: Joe Handzik Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/sc

[PATCH v2 34/48] hpsa: remove incorrect BUG_ONs checking for raid offload enable

From: Stephen Cameron In set_encrypt_ioaccel2() and in hpsa_scsi_ioaccel_raid_map there were BUG_ONs that looked like this: BUG_ON(!(dev->offload_config && dev->offload_enabled)); But, In hpsa_ack_ctlr_events() we have this, /* Stop sending new RAID offload reqs via the IO acce

[PATCH v2 33/48] hpsa: do not check for msi(x) in interrupt_pending

From: Stephen Cameron No need to check whether interrupt pending for MSI(X) and conversely, no need to check whether MSI(X) interrupts are being used when checking if interrupts are pending. Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/hpsa.h |3 --- 1 file changed, 3

[PATCH v2 28/48] hpsa: honor queue depth of physical devices

When using the ioaccel submission methods, requests destined for RAID volumes are sometimes diverted to physical devices. The OS has no or limited knowledge of these physical devices, so it is up to the driver to avoid pushing the device too hard. It is better to honor the physical device queue l

[PATCH v2 32/48] hpsa: slightly optimize SA5_performant_completed

Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/hpsa.h |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/hpsa.h b/drivers/scsi/hpsa.h index 1856445..aa6cb0b 100644 --- a/drivers/scsi/hpsa.h +++ b/drivers/scsi/hpsa.h @@ -412,19 +412,19 @

[PATCH v2 27/48] hpsa: use workqueue to resubmit failed ioaccel commands

Instead of kicking the commands all the way back to the mid layer, use a work queue. This enables having a mechanism for the driver to be able to resubmit the commands down the "normal" raid path without turning off the ioaccel feature entirely whenever an error is encountered on the ioaccel path,

[PATCH v2 29/48] hpsa: fix race between abort handler and main i/o path

From: Webb Scales This means changing the allocator to reference count commands. The reference count is now the authoritative indicator of whether a command is allocated or not. The h->cmd_pool_bits bitmap is now only a heuristic hint to speed up the allocation process, it is no longer the autho

[PATCH v2 26/48] hpsa: factor out hpsa_ciss_submit function

From: Stephen Cameron Factor out the bottom part of the queuecommand function which is the part that builds commands for submitting down the "normal' RAID stack path of a Smart Array. Need to factor this out to improve how commands that were initially sent down one of the "ioaccellerated" paths

[PATCH v2 31/48] hpsa: count passthru cmds with atomics, not a spin locked int

Performance enhancement. Remove spin_locks from the driver. Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 39 +-- drivers/scsi/hpsa.h |3 +-- 2 files changed, 6 insertions(+), 36 deletions(-) diff --git a/drivers/scsi/hpsa.

[PATCH v2 30/48] hpsa: optimize cmd_alloc function by remembering last allocation

From: Robert Elliott Empirically, this improves performance slightly (~2% max IOPS) by allowing cmd_alloc to remember where it left off searching for free commands between calls instead of always starting its search at command 0. Reviewed-by: Scott Teel Signed-off-by: Robert Elliott Signed-off

[PATCH v2 25/48] hpsa: do not request device rescan on every ioaccel path error

From: Stephen Cameron The original reasoning behind doing this was faulty. An error of some sort would be encountered, accelerated i/o would be disabled for that logical drive, the command would be kicked back out to the SCSI midlayer for a retry, and since i/o accelerator mode was disabled, it

[PATCH v2 23/48] hpsa: get rid of cmd_special_alloc and cmd_special_free

From: Stephen Cameron We have commands reserved for internal use. This is laying the groundwork for removing the internal queue of commands from the driver so that the locks that protect that queue may be removed. Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 10

[PATCH v2 21/48] hpsa: avoid unneccesary calls to resource freeing functions

From: Robert Elliott If hpsa_allocate_cmd_pool failed, we were calling two functions unnecessarily: hpsa_free_sg_chain_blocks(h); hpsa_free_cmd_pool(h); This didn't cause any problem, as those functions can tolerate being called when what they free hasn't been allocated (relevant pointers w

[PATCH v2 20/48] hpsa: fix memory leak in hpsa_alloc_cmd_pool

From: Robert Elliott Partial allocation failure wasn't handled correctly Reviewed-by: Scott Teel Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.

[PATCH v2 15/48] hpsa: trivial message and comment clean ups

From: Stephen Cameron Cleanup comments to be more specific. Make messages more informational. Reviewed-by: Scott Teel Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/d

[PATCH v2 16/48] hpsa: report failure to ioremap config table

From: Robert Elliott Enhance error reporting. Reviewed-by: Scott Teel Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 5973018..354e7f8 1006

[PATCH v2 24/48] hpsa: do not queue commands internally in driver

By not doing maintaining a list of queued commands, we can eliminate some spin locking in the main i/o path and gain significant improvement in IOPS. Remove the queuing code and the code that calls it; remove now-unused interrupt code; remove DIRECT_LOOKUP_BIT. Now that the passthru commands shar

[PATCH v2 17/48] hpsa: rename hpsa_request_irq to hpsa_request_irqs

From: Robert Elliott Make the function name more descriptive. We use more than one interrupt. Reviewed-by: Scott Teel Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/

[PATCH v2 22/48] hpsa: reserve some commands for use by driver

From: Stephen Cameron We need to reserve some commands for device rescans, aborts, and the pass through ioctls, etc. so we cannot give them all to the scsi mid layer. This is in preparation for removing cmd_special_alloc and cmd_special_free so that we can stop queuing commands internally in the

[PATCH v2 14/48] hpsa: refactor hpsa_find_board_params() to encapsulate legacy test

From: Webb Scales Encapsulate the conditional predicate which tests for legacy controllers in a separate function and rework the code comments. Reviewed-by: Scott Teel Signed-off-by: Webb Scales Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 30 +- 1 file ch

[PATCH v2 18/48] hpsa: pass error from pci_set_consistent_dma_mask from hpsa_message

From: Robert Elliott Return the actual error code instead of a generic error code. Reviewed-by: Scott Teel Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/

[PATCH v2 19/48] hpsa: report allocation failures while allocating SG chain blocks

From: Robert Elliott Reviewed-by: Scott Teel Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 64d17d1..dc328ce 100644 --- a/drivers/scsi

[PATCH v2 09/48] hpsa: notice all request_irq errors

From: Robert Elliott In MSI and MSI-X mode, where hpsa asks for more than one interrupt, hpsa_request_irqs forgets if the first request_irq call failed if later ones succeed. It needs to exit the loop on any failure rather than continue, freeing all irqs that were requested until that point. Al

[PATCH v2 07/48] hpsa: rename free_irqs to hpsa_free_irqs

From: Robert Elliott Change the function names to have hpsa prefix. Reviewed-by: Scott Teel Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 43 ++- 1 file changed, 22 insertions(+), 21 deletions(-) diff --git a/drive

[PATCH v2 04/48] hpsa: change how SA controllers are reset

Change how SA controllers are reset by changing PCI power levels. The hpsa driver was finding the PCI_PM_CTRL_STATE_MASK offset then reading/writing a bitmask to change the power state. There are kernel functions that do the same operations. Better to use the kernel functions. Signed-off-by: Don B

[PATCH v2 02/48] hpsa: fix memory leak in kdump hard reset

From: Tomas Henzl There is a potential memory leak in hpsa_kdump_hard_reset_controller. Reviewed-by: Don Brace Reviewed-by: Scott Teel Signed-off-by: Tomas Henzl Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/

[PATCH v2 12/48] hpsa: propagate return value from board ID lookup

From: Robert Elliott If the board ID lookup function fails, return the return code rather than return -ENODEV. The only board ID failure reason right now is -ENODEV, so this just provides more informative prints in kdump and adapts to future changes. Tested with error injection while booting wi

[PATCH v2 03/48] hpsa: turn off interrupts when kdump starts

From: Tomas Henzl Sometimes when the card is restarted it may cause - "irq 16: nobody cared (try booting with the "irqpoll" option)" that is likely caused so, that the card, after the hard reset finishes, pulls on the irq. Disabling the ints before or after the hpsa_kdump_hard_reset_controller fi

[PATCH v2 13/48] hpsa: downgrade the Waiting for no-op print to dev_info

From: Robert Elliott There is nothing worrisome about the "Waiting for controller to respond to no-op" print, so use dev_info rather than dev_warn. Reviewed-by: Scott Teel Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |2 +- 1 file changed, 1 insertion(+)

[PATCH v2 06/48] hpsa: adjust RAID-1, RAID-1ADM, and RAID-6 names

From: Robert Elliott HP now uses RAID-6 rather than RAID-ADG (Advanced Data Guarding) as the marketing name for our implementation of RAID-6. The driver considers RAID-1 and RAID-1+0 to be the same level, and considers RAID-1ADM and RAID-1+0ADM to be the same level. Parenthesis can be used to r

[PATCH v2 05/48] hpsa: correct change_queue_depth

We change drive queue depths to match drive reported queue depths. The name of the SML function was changed from scsi_adjust_queue_depth changed to scsi_change_queue_depth. Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/hpsa.c | 16 +++- 1 file changed, 15 inser

[PATCH v2 08/48] hpsa: Fix -Wunused-but-set-variable warning

From: Fabian Frederick Remove unused variable in hpsa_free_cmd_pool. Reviewed-by: Scott Teel Signed-off-by: Fabian Frederick Acked-by: Don Brace Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/hpsa.c b/

[PATCH v2 11/48] hpsa: propagate hard_reset failures in reset_devices mode

From: Robert Elliott Return the real reason for kdump_hard_reset failure rather than change them all to -ENODEV. Reviewed-by: Scott Teel Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/d

[PATCH v2 10/48] hpsa: remove 0x from queue depth print which is in decimal

From: Robert Elliott The queue depth printed at startup is in decimal, so shouldn't have a 0x prefix. Reviewed-by: Scott Teel Signed-off-by: Robert Elliott Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/hps

[PATCH v2 00/48] hpsa driver updates

This patch set is based on Linus's tree. The changes are: - correct sparse warnings - correct memory leaks - correct kdump issues - correct queue depth updates - cleanup function return values - cleanup and enhance messages - cleanup and enhance error handling - minor code refactoring - p

[PATCH v2 01/48] hpsa: correct endian sparse warnings

Correct endiness issues reported by sparse. SA controllers are little endian. This patch ensures endiness correctness. Signed-off-by: Don Brace Reviewed-by: Scott Teel Reviewed-by: Webb Scales --- drivers/scsi/hpsa.c | 275 +++ drivers/scsi/hpsa

Re: module: fix module_refcount() return when running in a module exit routine

On Fri, 2015-01-23 at 05:17 -0800, Christoph Hellwig wrote: > On Fri, Jan 23, 2015 at 01:24:15PM +1030, Rusty Russell wrote: > > The correct fix is to turn try_module_get() into __module_get(), and > > always do the module_put(). > > Is this really safe? __module_get sais it needs a non-zero refc

Re: [PATCH 00/48] hpsa driver updates

On 01/23/2015 06:01 PM, Christoph Hellwig wrote: > On Fri, Jan 23, 2015 at 04:58:52PM +, brace wrote: >> I made your requested changes. Do you want me to just send those up or the >> whole set up again? >> >> Tomas Henzl asked me to add a workqueue change also... I have rebased the patch on t

RE: [PATCH 00/48] hpsa driver updates

I made your requested changes. Do you want me to just send those up or the whole set up again? Tomas Henzl asked me to add a workqueue change also... > -Original Message- > From: Christoph Hellwig [mailto:h...@infradead.org] > Sent: Friday, January 23, 2015 7:22 AM > To: Don Brace > Cc

Re: block layer copying user io vectors

On Thu, Jan 22, 2015 at 09:33:08PM +, Andy Falanga (afalanga) wrote: > Please CC me directly. > > I am working in kernel 2.6.32 (CentOS 6). To increase the upper limit > of sg from 4mb to at least 128mb in a single SCSI command. At first I > thought this issue was in sg, but have tracked the

Re: [PATCH 00/48] hpsa driver updates

On Fri, Jan 23, 2015 at 04:58:52PM +, brace wrote: > I made your requested changes. Do you want me to just send those up or the > whole set up again? > > Tomas Henzl asked me to add a workqueue change also... Just resend the whole series, looks like you're using git-end-email already. -- To

[PATCH 2/2] hpsa: remove a needless call - pci_get_drvdata

Signed-off-by: Tomas Henzl --- drivers/scsi/hpsa.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 909562c09f..7fdc4d2a91 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi/hpsa.c @@ -7069,13 +7069,12 @@ static void hpsa_fr

[PATCH 0/2] hpsa: workqueue + minor fix

I've adapted previously posted changes on top of the latest hpsa series. Tomas -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 1/2] hpsa: use a driver's own workqueue instead of a shared wq

hpsa driver uses a shared wq, max sleep time in function spent hpsa_wait_for_clear_event_notify_ack may take up to 20sec and that is too much for a shared workqueue. This patch takes the easiest approach and just creates a driver's own workqueue. Signed-off-by: Tomas Henzl --- drivers/scsi/hpsa.

Re: [PATCH 07/17] sbp2: Fix bidi command test

On Jan 23 Bart Van Assche wrote: > The SCSI core never sets sc_data_direction to DMA_BIDIRECTIONAL. > > Signed-off-by: Bart Van Assche > Cc: Stefan Richter > --- > drivers/firewire/sbp2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/firewire/sbp2.c b/drivers

Re: [PATCH 00/48] hpsa driver updates

Any comments on the reviews? Should I just take the patches that didn't have objections for now? -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: module: fix module_refcount() return when running in a module exit routine

On Fri, Jan 23, 2015 at 01:24:15PM +1030, Rusty Russell wrote: > The correct fix is to turn try_module_get() into __module_get(), and > always do the module_put(). Is this really safe? __module_get sais it needs a non-zero refcount to start with, but scsi_device_get is the only thing every increm

Re: [PATCH 0/17] Clear up bidi command confusion

On Fri, Jan 23, 2015 at 01:05:30PM +0100, Bart Van Assche wrote: > There is some confusion in the SCSI core and in SCSI LLDs around the > meaning of sc_data_direction and whether or not this member can have the > value DMA_BIDIRECTIONAL. Clear up this confusion. The patches in this > series are: I

Re: [PATCH 03/17] sg: Remove an unused variable

On 15-01-23 01:07 PM, Bart Van Assche wrote: Signed-off-by: Bart Van Assche Acked-by: Douglas Gilbert --- drivers/scsi/sg.c | 17 + 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c index b14f64c..a668c88 100644 --- a/driv

[PATCH 12/17] ncr53c8xx: Fix bidi command support

Signed-off-by: Bart Van Assche Cc: Finn Thain Cc: Michael Schmitz --- drivers/scsi/ncr53c8xx.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/ncr53c8xx.c b/drivers/scsi/ncr53c8xx.c index 5b93ed8..b9c489a 100644 --- a/drivers/scsi/ncr53c8xx.c +++ b/driver

[PATCH 13/17] qla1280: Fix bidi command support

The SCSI core never sets sc_data_direction to DMA_BIDIRECTIONAL. Signed-off-by: Bart Van Assche Cc: Michael Reed --- drivers/scsi/qla1280.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qla1280.c b/drivers/scsi/qla1280.c index c68a66e..ede9563 100644 ---

[PATCH 07/17] sbp2: Fix bidi command test

The SCSI core never sets sc_data_direction to DMA_BIDIRECTIONAL. Signed-off-by: Bart Van Assche Cc: Stefan Richter --- drivers/firewire/sbp2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firewire/sbp2.c b/drivers/firewire/sbp2.c index 64ac8f8..ab1b114 100644 ---

[PATCH 17/17] IB/srp: Detect bidi commands properly

The SCSI core never sets sc_data_direction to DMA_BIDIRECTIONAL. This allows to simplify srp_unmap_data(). Fix the bidi test in srp_map_data(). Signed-off-by: Bart Van Assche Cc: Roland Dreier --- drivers/infiniband/ulp/srp/ib_srp.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(

[PATCH 16/17] sym_glue: Fix bidi command test

Signed-off-by: Bart Van Assche --- drivers/scsi/sym53c8xx_2/sym_glue.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/sym53c8xx_2/sym_glue.c b/drivers/scsi/sym53c8xx_2/sym_glue.c index 5d00e51..c33c697 100644 --- a/drivers/scsi/sym53c8xx_2/sym_glue.c

[PATCH 15/17] mvumi: Remove dead code

The SCSI core never sets sc_data_direction to DMA_BIDIRECTIONAL. Hence remove the code that tests for this value. Signed-off-by: Bart Van Assche --- drivers/scsi/mvumi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/scsi/mvumi.c b/drivers/scsi/mvumi.c index 3e6b866..eae3cb2 100644 -

[PATCH 14/17] 53c700: Remove dead code

The SCSI core never sets sc_data_direction to DMA_BIDIRECTIONAL. Hence remove the code that tests for this value. Signed-off-by: Bart Van Assche --- drivers/scsi/53c700.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/scsi/53c700.c b/drivers/scsi/53c700.c index 82

[PATCH 11/17] 3w-9xxx: Remove dead code

The SCSI core never sets sc_data_direction to DMA_BIDIRECTIONAL. Hence remove the code that tests for this value. Signed-off-by: Bart Van Assche Cc: Adam Radford --- drivers/scsi/3w-9xxx.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/3w-9xxx.c b/drivers

[PATCH 10/17] hpsa: Remove dead code

The SCSI core never sets sc_data_direction to DMA_BIDIRECTIONAL. Hence remove the code that tests for this value. Signed-off-by: Bart Van Assche Cc: Don Brace --- drivers/scsi/hpsa.c | 18 -- 1 file changed, 18 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c

[PATCH 09/17] cciss: Remove dead code

The code that could set sc_data_direction to DMA_BIDIRECTIONAL has been removed eight years ago. Hence remove the code that handles this case. See also patch "unify SCSI_IOCTL_SEND_COMMAND implementations" (commit 21b2f0c803ad). Signed-off-by: Bart Van Assche Cc: Don Brace --- drivers/block/cci

[PATCH 08/17] ibmvscsi: Fix bidi command test

Signed-off-by: Bart Van Assche Cc: Brian King Cc: Nathan Fontenot --- drivers/scsi/ibmvscsi/ibmvscsi.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c index acea5d6..cf26b33 100644 --- a/drivers/s

[PATCH 06/17] eata: Remove dead code

The SCSI core never sets sc_data_direction to DMA_BIDIRECTIONAL. Hence remove the code that tests for this value. Signed-off-by: Bart Van Assche Cc: Dario Ballabio --- drivers/scsi/eata.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/eata.c b/drivers/scsi

[PATCH 05/17] aachba: Fix bidi command test

Signed-off-by: Bart Van Assche --- drivers/scsi/aacraid/aachba.c | 17 + 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/drivers/scsi/aacraid/aachba.c b/drivers/scsi/aacraid/aachba.c index b32e77d..5ade84a 100644 --- a/drivers/scsi/aacraid/aachba.c +++ b/drivers/scs

[PATCH 04/17] dpt_i2o: Fix bidi command test

Signed-off-by: Bart Van Assche Cc: Adaptec OEM Raid Solutions --- drivers/scsi/dpt_i2o.c | 21 ++--- 1 file changed, 6 insertions(+), 15 deletions(-) diff --git a/drivers/scsi/dpt_i2o.c b/drivers/scsi/dpt_i2o.c index 0bf9769..9bab86c 100644 --- a/drivers/scsi/dpt_i2o.c +++ b/dri

[PATCH 03/17] sg: Remove an unused variable

Signed-off-by: Bart Van Assche --- drivers/scsi/sg.c | 17 + 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c index b14f64c..a668c88 100644 --- a/drivers/scsi/sg.c +++ b/drivers/scsi/sg.c @@ -763,7 +763,7 @@ static int sg_common_

[PATCH 02/17] Clean up scsi_ioctl_reset()

Since SG_SCSI_RESET causes a task management function to be sent and since LLDs only check the sc_data_direction field inside the queueucommand callback function, the sc_data_direction member does not have to be set here. Hence remove the sc_data_direction assignment. Signed-off-by: Bart Van Assch

[PATCH 01/17] Clear up sc_data_direction documentation

Signed-off-by: Bart Van Assche --- Documentation/DMA-API-HOWTO.txt | 6 +++--- Documentation/scsi/scsi_mid_low_api.txt | 5 +++-- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/Documentation/DMA-API-HOWTO.txt b/Documentation/DMA-API-HOWTO.txt index 0f7afb2..3999ec3 100644

[PATCH 0/17] Clear up bidi command confusion

There is some confusion in the SCSI core and in SCSI LLDs around the meaning of sc_data_direction and whether or not this member can have the value DMA_BIDIRECTIONAL. Clear up this confusion. The patches in this series are: 0001-Clear-up-sc_data_direction-documentation.patch 0002-Clean-up-scsi_ioc

Re: [PATCH v7 5/5] scsi: ufs-qcom-ice: add Inline Crypto Engine (ICE) support for UFS

gned-off-by: Yaniv Gardi This patch became commit 8805ccd069b7 ("ufs-qcom-ice: add Inline Crypto Engine (ICE) support for UFS") in today's linux-next (ie, next-20150123). I noticed because a script I use to check linux-next spotted a problem with it. > --- > drivers/scsi/u