Re: [Lsf-pc] [LSF/MM TOPIC] iSCSI MQ adoption via MCS discussion

2015-01-08 Thread James Bottomley
On Thu, 2015-01-08 at 21:03 -0800, Nicholas A. Bellinger wrote: > On Thu, 2015-01-08 at 15:22 -0800, James Bottomley wrote: > > On Thu, 2015-01-08 at 14:57 -0800, Nicholas A. Bellinger wrote: > > > On Thu, 2015-01-08 at 14:29 -0800, James Bottomley wrote: > > > > On Thu, 2015-01-08 at 14:16 -0800,

[PATCH net-next 2/2] iw_cxgb4/cxgb4/cxgb4vf/cxgb4i/csiostor: Cleanup register defines/macros related to all other cpl messages

2015-01-08 Thread Anish Bhatt
From: Hariprasad Shenai This patch cleanups all other macros/register define related to CPL messages that are defined in t4_msg.h and the affected files Signed-off-by: Anish Bhatt Signed-off-by: Hariprasad Shenai --- drivers/infiniband/hw/cxgb4/cm.c | 20 +-- drivers/infini

[PATCH net-next 1/2] iw_cxgb4/cxgb4/cxgb4i: Cleanup register defines/MACROS related to CM CPL messages

2015-01-08 Thread Anish Bhatt
From: Hariprasad Shenai This patch cleanups all macros/register define related to connection management CPL messages that are defined in t4_msg.h and the affected files Signed-off-by: Anish Bhatt Signed-off-by: Hariprasad Shenai --- drivers/infiniband/hw/cxgb4/cm.c | 78 +++

[PATCH net-next 0/2] All Chelsio drivers : Cleanup CPL messages macros

2015-01-08 Thread Anish Bhatt
This patch series cleans up all register defines/MACROS defined in t4_msg.h and affected files as part of the continuing cleanup effort The patches series is created against 'net-next' tree and includes patches to the cxgb4, cxgb4vf, iw_cxgb4, cxgb4i and csiostor drivers. We have included all t

Re: [Lsf-pc] [LSF/MM TOPIC] iSCSI MQ adoption via MCS discussion

2015-01-08 Thread Nicholas A. Bellinger
On Thu, 2015-01-08 at 15:22 -0800, James Bottomley wrote: > On Thu, 2015-01-08 at 14:57 -0800, Nicholas A. Bellinger wrote: > > On Thu, 2015-01-08 at 14:29 -0800, James Bottomley wrote: > > > On Thu, 2015-01-08 at 14:16 -0800, Nicholas A. Bellinger wrote: > > The point is that a simple session w

[net-next:master 62/63] drivers/scsi/csiostor/csio_hw.c:2012:5: sparse: symbol 'csio_hw_prep_fw' was not declared. Should it be static?

2015-01-08 Thread kbuild test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: fb57720daf6e56ba453414b5e8dd9cb3c0c80257 commit: f40e74ffa3de44f7ef4c09653b070dd115ab7fbe [62/63] csiostor:firmware upgrade fix reproduce: # apt-get install sparse git checkout f40e74ffa3de44f7ef4c09653b070

Re: [PATCH] csiostor:firmware upgrade fix

2015-01-08 Thread David Miller
From: Praveen Madhavan Date: Wed, 7 Jan 2015 19:16:28 +0530 > This patch fixes removes older means of upgrading Firmware using MAJOR version > and adds newer interface version checking mechanism. > > Please apply this patch on net-next since it depends on previous commits. > > Signed-off-by: P

Re: [LSF/MM TOPIC] iSCSI MQ adoption via MCS discussion

2015-01-08 Thread Mike Christie
On 1/7/15, 3:39 PM, Mike Christie wrote: So pretty non controversial I hope Ok, maybe a little controversial. Let me work with Sagi on his MCS (tcp connection per CPU approach) patch and update my session per CPU patch and we can do some benchmarking and tracing and see what is up. -- To uns

Re: [LSF/MM ATTEND] iSCSI/iSER MQ + EXTENDED_COPY host support

2015-01-08 Thread Andy Grover
On 01/08/2015 03:11 PM, Douglas Gilbert wrote: Andy, XCOPY is huge and keeps getting bigger (apart from the recent trimming of the "LID1" generation mentioned above). Most SCSI commands are sent to the LU involved, but for EXTENDED COPY command itself, should it be sent to the source or destinati

Re: [LSF/MM TOPIC] iSCSI MQ adoption via MCS discussion

2015-01-08 Thread Mike Christie
On 1/8/15, 4:57 PM, Nicholas A. Bellinger wrote: On Thu, 2015-01-08 at 14:29 -0800, James Bottomley wrote: On Thu, 2015-01-08 at 14:16 -0800, Nicholas A. Bellinger wrote: On Thu, 2015-01-08 at 08:50 +0100, Bart Van Assche wrote: On 01/07/15 22:39, Mike Christie wrote: On 01/07/2015 10:57 AM,

Re: [Lsf-pc] [LSF/MM TOPIC] iSCSI MQ adoption via MCS discussion

2015-01-08 Thread James Bottomley
On Thu, 2015-01-08 at 14:57 -0800, Nicholas A. Bellinger wrote: > On Thu, 2015-01-08 at 14:29 -0800, James Bottomley wrote: > > On Thu, 2015-01-08 at 14:16 -0800, Nicholas A. Bellinger wrote: > > > On Thu, 2015-01-08 at 08:50 +0100, Bart Van Assche wrote: > > > > On 01/07/15 22:39, Mike Christie wr

Re: [LSF/MM ATTEND] iSCSI/iSER MQ + EXTENDED_COPY host support

2015-01-08 Thread Douglas Gilbert
On 15-01-08 01:58 PM, Andy Grover wrote: On 01/07/2015 02:11 PM, Douglas Gilbert wrote: T10 have now dropped the LID1 and LID4 stuff (its the length of the LIST IDENTIFIER field: 1 byte or 4 bytes) by obsoleting all LID1 variants in SPC-5 revision 01. So the LID1 variants are now gone and the LI

Re: [LSF/MM TOPIC] iSCSI MQ adoption via MCS discussion

2015-01-08 Thread Mike Christie
On 1/8/15, 1:50 AM, Bart Van Assche wrote: On 01/07/15 22:39, Mike Christie wrote: On 01/07/2015 10:57 AM, Hannes Reinecke wrote: On 01/07/2015 05:25 PM, Sagi Grimberg wrote: Hi everyone, Now that scsi-mq is fully included, we need an iSCSI initiator that would use it to achieve scalable perf

Re: [LSF/MM TOPIC] iSCSI MQ adoption via MCS discussion

2015-01-08 Thread Nicholas A. Bellinger
On Thu, 2015-01-08 at 14:29 -0800, James Bottomley wrote: > On Thu, 2015-01-08 at 14:16 -0800, Nicholas A. Bellinger wrote: > > On Thu, 2015-01-08 at 08:50 +0100, Bart Van Assche wrote: > > > On 01/07/15 22:39, Mike Christie wrote: > > > > On 01/07/2015 10:57 AM, Hannes Reinecke wrote: > > > >> On

[PATCH] scsi: Allow retry on UNIT_ATTENTION media changed if not CDROM drive

2015-01-08 Thread Al Cooper
Previous commit dfcf7775815504d13a1d273073810058caf84b9d added a workaround for CD-ROM drives that were out of spec. This is causing scsi_check_sense() to return an error instead of NEEDS_RETRY on some USB thumb drives that return UNIT_ATTENTION Media Changed (ASC/ASCQ 28/00) after resuming from S3

Re: [PATCH 1/2] target: Don't arbitrary limit I/O size to fabric_max_sectors

2015-01-08 Thread Nicholas A. Bellinger
On Thu, 2015-01-08 at 09:37 -0500, Martin K. Petersen wrote: > > "nab" == Nicholas A Bellinger writes: > > nab> IIRC, most modern hardware is reporting a large enough value for > nab> queue_max_hw_sectors() to support 8 MB I/Os, but I'm thinking that > nab> this could end up being problematic

Re: [LSF/MM TOPIC] iSCSI MQ adoption via MCS discussion

2015-01-08 Thread James Bottomley
On Thu, 2015-01-08 at 14:16 -0800, Nicholas A. Bellinger wrote: > On Thu, 2015-01-08 at 08:50 +0100, Bart Van Assche wrote: > > On 01/07/15 22:39, Mike Christie wrote: > > > On 01/07/2015 10:57 AM, Hannes Reinecke wrote: > > >> On 01/07/2015 05:25 PM, Sagi Grimberg wrote: > > >>> Hi everyone, > > >

Re: [LSF/MM ATTEND] iSCSI/iSER MQ + EXTENDED_COPY host support

2015-01-08 Thread Nicholas A. Bellinger
On Thu, 2015-01-08 at 10:58 -0800, Andy Grover wrote: > On 01/07/2015 02:11 PM, Douglas Gilbert wrote: > > T10 have now dropped the LID1 and LID4 stuff (its the length > > of the LIST IDENTIFIER field: 1 byte or 4 bytes) by obsoleting > > all LID1 variants in SPC-5 revision 01. So the LID1 variants

Re: [LSF/MM TOPIC] iSCSI MQ adoption via MCS discussion

2015-01-08 Thread Nicholas A. Bellinger
On Thu, 2015-01-08 at 08:50 +0100, Bart Van Assche wrote: > On 01/07/15 22:39, Mike Christie wrote: > > On 01/07/2015 10:57 AM, Hannes Reinecke wrote: > >> On 01/07/2015 05:25 PM, Sagi Grimberg wrote: > >>> Hi everyone, > >>> > >>> Now that scsi-mq is fully included, we need an iSCSI initiator that

Re: [PATCH 3/3] scsi: Remove scsi_ioctl.h

2015-01-08 Thread Andy Grover
On 01/08/2015 12:35 PM, James Bottomley wrote: On Thu, 2015-01-08 at 11:47 -0800, Andy Grover wrote: Now that we have uapi/scsi/scsi.h, that is the logical place for SCSI ioctl definitions to go. The kernel-specific stuff that remains is so little that it can be folded into scsi/scsi.h, and scsi

Re: [PATCH 3/3] scsi: Remove scsi_ioctl.h

2015-01-08 Thread James Bottomley
On Thu, 2015-01-08 at 11:47 -0800, Andy Grover wrote: > Now that we have uapi/scsi/scsi.h, that is the logical place for SCSI ioctl > definitions to go. The kernel-specific stuff that remains is so little that > it can be folded into scsi/scsi.h, and scsi_ioctl.h removed. > > Remove all scsi_ioctl

Re: scsi: non atomic allocation in mempool_alloc in atomic context

2015-01-08 Thread Alexei Starovoitov
On Thu, Jan 8, 2015 at 1:29 AM, Christoph Hellwig wrote: > On Wed, Jan 07, 2015 at 07:55:42PM -0800, Alexei Starovoitov wrote: >> I'm seeing the same splats... what tree I can pull the fix from ? > > None so far. I'll still need a review to apply it to the scsi-queue tree. applied it manually an

[PATCH 0/3] Add uapi/scsi/scsi.h

2015-01-08 Thread Andy Grover
Hi James, This patchset against scsi/for-next moves SCSI opcodes and other useful defines into a user-available header. This should help projects like tgt and glibc that have copied these opcode definitions and then experience bitrot. (e.g. glibc-headers provides /usr/include/scsi/scsi.h on my sy

[PATCH 3/3] scsi: Remove scsi_ioctl.h

2015-01-08 Thread Andy Grover
Now that we have uapi/scsi/scsi.h, that is the logical place for SCSI ioctl definitions to go. The kernel-specific stuff that remains is so little that it can be folded into scsi/scsi.h, and scsi_ioctl.h removed. Remove all scsi_ioctl.h #includes since they all also include scsi/scsi.h, except for

[PATCH 1/3] scsi: add WRITE_VERIFY_16 to scsi.h

2015-01-08 Thread Andy Grover
Signed-off-by: Andy Grover --- include/scsi/scsi.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/scsi/scsi.h b/include/scsi/scsi.h index 8a7f8ad..faf2118 100644 --- a/include/scsi/scsi.h +++ b/include/scsi/scsi.h @@ -150,6 +150,7 @@ enum scsi_timeouts { #define WRITE_16

[PATCH 2/3] scsi: Move user-shareable stuff in scsi/scsi.h to uapi/scsi/scsi.h

2015-01-08 Thread Andy Grover
A great many SCSI codes and ioctl values can be made available to userspace in a uapi header, while the kernel-only definitions stay in scsi/scsi.h. scsi/scsi.h also includes uapi/scsi/scsi.h so kernel code need not update includes. Signed-off-by: Andy Grover --- include/scsi/scsi.h | 522

Re: [LSF/MM ATTEND] iSCSI/iSER MQ + EXTENDED_COPY host support

2015-01-08 Thread Andy Grover
On 01/07/2015 02:11 PM, Douglas Gilbert wrote: T10 have now dropped the LID1 and LID4 stuff (its the length of the LIST IDENTIFIER field: 1 byte or 4 bytes) by obsoleting all LID1 variants in SPC-5 revision 01. So the LID1 variants are now gone and the LID4 appendage is dropped from the remaining

Re: [LSF/MM TOPIC] iSCSI MQ adoption via MCS discussion

2015-01-08 Thread Sagi Grimberg
On 1/8/2015 4:50 PM, James Bottomley wrote: If people want to add something like round robin connection selection in the iscsi layer, then I think we want to leave that for after the initial merge, so people can argue about that separately. Well, you're right, we can argue about it later, but

Re: [PATCH v4] virtio-scsi: Fix the race condition in virtscsi_handle_event

2015-01-08 Thread Venkatesh Srinivas
On Wed, Jan 7, 2015 at 6:57 PM, Fam Zheng wrote: > > There is a race condition in virtscsi_handle_event, when many device > hotplug/unplug events flush in quickly. > > The scsi_remove_device in virtscsi_handle_transport_reset may trigger > the BUG_ON in scsi_target_reap, because the state is alter

Re: [LSF/MM TOPIC] iSCSI MQ adoption via MCS discussion

2015-01-08 Thread Paul Koning
> On Jan 8, 2015, at 9:11 AM, Bart Van Assche wrote: > > On 01/08/15 14:45, Sagi Grimberg wrote: >> Actually I started with that approach, but the independent connections >> under a single session (I-T-Nexus) violates the command ordering >> requirement. Plus, such a solution is specific to iSER

Re: [PATCH 1/8] megaraid_sas : Endianness related bug fixes and code optimization

2015-01-08 Thread Martin K. Petersen
> "Christoph" == Christoph Hellwig writes: > -#if defined(__BIG_ENDIAN_BITFIELD) > - u32 MessageAddress1:24; /* bits 31:8*/ > - u32 RequestFlags:8; > -#else > u32 RequestFlags:8; > - u32 MessageAddress1:24; /* bits 31:8*/ > -#endif > - u32 MessageAd

Re: [PATCH v2 0/3] scsi: ufs & ums-*: fix module reference counting

2015-01-08 Thread Alan Stern
On Thu, 8 Jan 2015, Akinobu Mita wrote: > >> Why don't ufs and usb-storage define the host templates in the sub drivers? > >> That's what libata or the mpt fusion driver do. > > > > Originally the subdrivers were all part of usb-storage. When they were > > split out into separate modules, there d

Re: [LSF/MM TOPIC] iSCSI MQ adoption via MCS discussion

2015-01-08 Thread James Bottomley
On Wed, 2015-01-07 at 15:39 -0600, Mike Christie wrote: > On 01/07/2015 10:57 AM, Hannes Reinecke wrote: > > On 01/07/2015 05:25 PM, Sagi Grimberg wrote: > >> Hi everyone, > >> > >> Now that scsi-mq is fully included, we need an iSCSI initiator that > >> would use it to achieve scalable performance

Re: [dm-devel] [LSF/MM ATTEND] discuss blk-mq related to DM-multipath and status of XCOPY

2015-01-08 Thread Martin K. Petersen
> "Hannes" == Hannes Reinecke writes: Hannes> But the array might prioritize 'normal' I/O requests, and treat Hannes> XCOPY with a lower priority. So given enough load XCOPY might Hannes> actually be slower than a normal copy ... Yes, but may have lower impact on concurrent I/O. -- Martin

Re: [PATCH 1/2] target: Don't arbitrary limit I/O size to fabric_max_sectors

2015-01-08 Thread Martin K. Petersen
> "nab" == Nicholas A Bellinger writes: nab> IIRC, most modern hardware is reporting a large enough value for nab> queue_max_hw_sectors() to support 8 MB I/Os, but I'm thinking that nab> this could end up being problematic for older hardware that is nab> reporting much smaller values. Report

[PATCH 2/2] uas: Add US_FL_NO_ATA_1X for 2 more Seagate disk enclosures

2015-01-08 Thread Hans de Goede
Just like all previous UAS capable Seagate disk enclosures, these need the US_FL_NO_ATA_1X to not crash when udev probes them. Cc: sta...@vger.kernel.org # 3.16 Signed-off-by: Hans de Goede --- drivers/usb/storage/unusual_uas.h | 14 ++ 1 file changed, 14 insertions(+) diff --git a/

[PATCH 1/2] uas: Do not blacklist ASM1153 disk enclosures

2015-01-08 Thread Hans de Goede
Our detection logic to avoid doing UAS on ASM1051 bridge chips causes problems with newer ASM1153 disk enclosures in 2 ways: 1) Some ASM1153 disk enclosures re-use the ASM1051 device-id of 5106, which we assume is always an ASM1051, so remove the quirk for 5106, and instead use the same dete

Re: [LSF/MM TOPIC] iSCSI MQ adoption via MCS discussion

2015-01-08 Thread Bart Van Assche
On 01/08/15 14:45, Sagi Grimberg wrote: Actually I started with that approach, but the independent connections under a single session (I-T-Nexus) violates the command ordering requirement. Plus, such a solution is specific to iSER... Hello Sagi, Which command ordering requirement are you refer

Re: [PATCH v2 0/3] scsi: ufs & ums-*: fix module reference counting

2015-01-08 Thread Akinobu Mita
2015-01-08 0:09 GMT+09:00 Alan Stern : > On Wed, 7 Jan 2015, Christoph Hellwig wrote: > >> On Wed, Jan 07, 2015 at 11:02:59PM +0900, Akinobu Mita wrote: >> > While accessing a scsi_device, the use count of the underlying LLDD module >> > is incremented. The module reference is retrieved through .m

Re: [LSF/MM TOPIC] iSCSI MQ adoption via MCS discussion

2015-01-08 Thread Sagi Grimberg
On 1/8/2015 9:50 AM, Bart Van Assche wrote: On 01/07/15 22:39, Mike Christie wrote: On 01/07/2015 10:57 AM, Hannes Reinecke wrote: On 01/07/2015 05:25 PM, Sagi Grimberg wrote: Hi everyone, Now that scsi-mq is fully included, we need an iSCSI initiator that would use it to achieve scalable per

RE: [PATCH 1/8] megaraid_sas : Endianness related bug fixes and code optimization

2015-01-08 Thread Sumit Saxena
>-Original Message- >From: Christoph Hellwig [mailto:h...@infradead.org] >Sent: Thursday, January 08, 2015 4:09 PM >To: sumit.sax...@avagotech.com >Cc: linux-scsi@vger.kernel.org; sta...@vger.kernel.org; >martin.peter...@oracle.com; h...@infradead.org; >jbottom...@parallels.com; kashyap.de.

Re: [PATCH for v3.19, v2] Avoid that sd_shutdown() triggers a kernel warning

2015-01-08 Thread Christoph Hellwig
On Wed, Jan 07, 2015 at 02:03:22PM +0100, Bart Van Assche wrote: > Since kernel v3.19-rc1 module_refcount() returns 1 instead of 0 > when called from inside module_exit(). This breaks the > module_refcount() test in scsi_device_put() and hence causes the > following kernel warning to be reported wh

Re: [PATCH v4] virtio-scsi: Fix the race condition in virtscsi_handle_event

2015-01-08 Thread Paolo Bonzini
On 08/01/2015 03:57, Fam Zheng wrote: > There is a race condition in virtscsi_handle_event, when many device > hotplug/unplug events flush in quickly. > > The scsi_remove_device in virtscsi_handle_transport_reset may trigger > the BUG_ON in scsi_target_reap, because the state is altered behind i

RE: [PATCH 6/8] megaraid_sas : Reserve commands for IOCTLs and internal DCMDs

2015-01-08 Thread Sumit Saxena
>-Original Message- >From: Christoph Hellwig [mailto:h...@infradead.org] >Sent: Thursday, January 08, 2015 4:11 PM >To: sumit.sax...@avagotech.com >Cc: linux-scsi@vger.kernel.org; martin.peter...@oracle.com; >h...@infradead.org; jbottom...@parallels.com; >kashyap.de...@avagotech.com >Subjec

Re: [PATCH 2/8] megaraid_sas : Support for secure JBOD

2015-01-08 Thread Christoph Hellwig
> #if defined(__BIG_ENDIAN_BITFIELD) > - u32 reserved:25; > + u32 reserved:12; > + u32 discardCacheDuringLDDelete:1; > + u32 supportSecurityonJBOD:1; > + u32 supportCacheBypassModes:1; > + u32 supportDi

Re: [PATCH 6/8] megaraid_sas : Reserve commands for IOCTLs and internal DCMDs

2015-01-08 Thread Christoph Hellwig
Btw, what happend to the plan of using block layer host wide tags? -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/8] megaraid_sas : Endianness related bug fixes and code optimization

2015-01-08 Thread Christoph Hellwig
> -#if defined(__BIG_ENDIAN_BITFIELD) > - u32 MessageAddress1:24; /* bits 31:8*/ > - u32 RequestFlags:8; > -#else > u32 RequestFlags:8; > - u32 MessageAddress1:24; /* bits 31:8*/ > -#endif > - u32 MessageAddress2; /* bits 61:32 */ > + u32 Mes

Re: scsi: non atomic allocation in mempool_alloc in atomic context

2015-01-08 Thread Christoph Hellwig
On Wed, Jan 07, 2015 at 07:55:42PM -0800, Alexei Starovoitov wrote: > I'm seeing the same splats... what tree I can pull the fix from ? None so far. I'll still need a review to apply it to the scsi-queue tree. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of