Re: [PATCH 3/4 v3] scsi:stex.c Add reboot support

2014-12-22 Thread Charles Chiou
On 12/18/2014 11:41 AM, Charles Chiou wrote: On 12/17/2014 05:30 PM, Christoph Hellwig wrote: I'm not going to add a new reboot notifier for a driver. If you can convince the driver model / PM people to pass this information to ->shutdown we can add support for this difference, but not in t

Re: [PATCH V2 1/4] be2iscsi : Fix the retry count for boot targets

2014-12-22 Thread Mike Christie
On 12/22/2014 05:47 PM, Mike Christie wrote: > On 12/19/2014 06:51 PM, John Soni Jose wrote: >> @@ -5376,8 +5387,14 @@ beiscsi_hw_health_check(struct work_struct *work) >> be_eqd_update(phba); >> >> if (phba->state & BE_ADAPTER_CHECK_BOOT) { >> -phba->state &= ~BE_ADAPTER_CH

Re: [PATCH V2 1/4] be2iscsi : Fix the retry count for boot targets

2014-12-22 Thread Mike Christie
On 12/19/2014 06:51 PM, John Soni Jose wrote: > @@ -5376,8 +5387,14 @@ beiscsi_hw_health_check(struct work_struct *work) > be_eqd_update(phba); > > if (phba->state & BE_ADAPTER_CHECK_BOOT) { > - phba->state &= ~BE_ADAPTER_CHECK_BOOT; > - be_check_boot_session(p

Re: [PATCH] scsi: 3w-9xxx.c: Cleaning up missing null-terminate in conjunction with strncpy

2014-12-22 Thread adam radford
On Mon, Dec 22, 2014 at 2:52 PM, Rickard Strandqvist wrote: > 2014-08-01 0:19 GMT+02:00 adam radford : >> On Sun, Jul 27, 2014 at 8:11 AM, Rickard Strandqvist >> wrote: >>> Replacing strncpy with strlcpy to avoid strings that lacks null terminate. >>> And use the sizeof on the to string rather th

Re: [PATCH] scsi: 3w-9xxx.c: Cleaning up missing null-terminate in conjunction with strncpy

2014-12-22 Thread Rickard Strandqvist
2014-08-01 0:19 GMT+02:00 adam radford : > On Sun, Jul 27, 2014 at 8:11 AM, Rickard Strandqvist > wrote: >> Replacing strncpy with strlcpy to avoid strings that lacks null terminate. >> And use the sizeof on the to string rather than strlen on the from string. >> >> Signed-off-by: Rickard Strandqv

Re: [PATCH] scsi_debug: fix sanity check in resp_rsup_opcodes

2014-12-22 Thread Ewan Milne
On Mon, 2014-12-22 at 11:37 -0500, Douglas Gilbert wrote: > David Binderman pointed out in this post: > > http://marc.info/?l=linux-scsi&m=141924469523474&w=2 > > a sanity check that was flawed. See attached fix. Should > be applied to lk 3.19.0-rc1 and Christoph's branches. > > ChangeLog: >

[PATCH] scsi_debug: fix sanity check in resp_rsup_opcodes

2014-12-22 Thread Douglas Gilbert
David Binderman pointed out in this post: http://marc.info/?l=linux-scsi&m=141924469523474&w=2 a sanity check that was flawed. See attached fix. Should be applied to lk 3.19.0-rc1 and Christoph's branches. ChangeLog: fix alloc_len sanity check in resp_rsup_opcodes() --- drivers/scsi/scsi

scsi_debug.c:1626: possible bad test ?

2014-12-22 Thread David Binderman
Hello there, drivers/scsi/scsi_debug.c:1626:20: warning: logical ‘and’ of mutually exclusive tests is always false [-Wlogical-op] Source code is     if (alloc_len < 4 && alloc_len> 0x) { Suggest swap && for ||. Adding -Wlogical-op to the build might also help Regards David Binderman