[PATCH 3.2 075/164] scsi: Fix error handling in SCSI_IOCTL_SEND_COMMAND

2014-12-11 Thread Ben Hutchings
3.2.65-rc1 review patch. If anyone has any objections, please let me know. -- From: Jan Kara commit 84ce0f0e94ac97217398b3b69c21c7a62ebeed05 upstream. When sg_scsi_ioctl() fails to prepare request to submit in blk_rq_map_kern() we jump to a label where we just end up copying (

Re: Backport of a fix for a race condition in HPSA driver (3rd time is the charm)

2014-12-11 Thread Ben Hutchings
On Fri, 2014-11-14 at 11:26 -0800, Masoud Sharbiani wrote: > Dear stable maintainers, > Can you please backport commitid > 2cc5bfaf854463d9d1aa52091f60110fbf102a9 ([SCSI] hpsa: fix a race in > cmd_free/scsi_done) to 3.10 stable (and earlier, if applicable)? It > seems to fix an issue that we have r

[PATCH net-next v10 6/7] cxgb4i: use set_wr_txq() to set tx queues

2014-12-11 Thread Karen Xie
From: Karen Xie use cxgb4's set_wr_txq() for setting of the tx queue for a outgoing packet. remove the similar function in cxgb4i. Signed-off-by: Karen Xie --- drivers/scsi/cxgbi/cxgb4i/cxgb4i.c | 16 +--- 1 files changed, 5 insertions(+), 11 deletions(-) diff --git a/drivers/sc

[PATCH net-next v10 0/7] cxgb4/cxgbi: misc. fixes for cxgb4i

2014-12-11 Thread Karen Xie
This patch set fixes cxgb4i's tx credit calculation and adds handling of additional rx message and negative advice types. It also removes the duplicate code in cxgb4i to set the outgoing queues of a packet. Karen Xie (7): cxgb4i: fix tx immediate data credit check cxgb4i: fix credit check for tx_

[PATCH net-next v10 3/7] cxgb4/cxgb4i: set the max. pdu length in firmware

2014-12-11 Thread Karen Xie
From: Karen Xie Programs the firmware of the maximum outgoing iscsi pdu length per connection. Signed-off-by: Karen Xie --- drivers/net/ethernet/chelsio/cxgb4/t4fw_api.h |1 drivers/scsi/cxgbi/cxgb4i/cxgb4i.c| 69 ++--- 2 files changed, 52 insertions(+),

[PATCH net-next v10 7/7] libcxgbi: fix freeing skb prematurely

2014-12-11 Thread Karen Xie
From: Karen Xie With debug turned on the debug print would access the skb after it is freed. Fix it to free the skb after the debug print. Signed-off-by: Karen Xie --- drivers/scsi/cxgbi/libcxgbi.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/cxgbi/l

[PATCH net-next v10 1/7] cxgb4i: fix tx immediate data credit check

2014-12-11 Thread Karen Xie
From: Karen Xie Only data skbs need the wr header added while control skbs do not. Make sure they are treated differently. Signed-off-by: Karen Xie --- drivers/scsi/cxgbi/cxgb4i/cxgb4i.c | 22 +++--- drivers/scsi/cxgbi/libcxgbi.h |4 ++-- 2 files changed, 17 insertio

[PATCH net-next v10 4/7] cxgb4i: additional types of negative advice

2014-12-11 Thread Karen Xie
From: Karen Xie Treat both CPL_ERR_KEEPALV_NEG_ADVICE and CPL_ERR_PERSIST_NEG_ADVICE as negative advice. Signed-off-by: Karen Xie --- drivers/scsi/cxgbi/cxgb4i/cxgb4i.c | 12 +--- 1 files changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c b/dri

[PATCH net-next v10 2/7] cxgb4i: fix credit check for tx_data_wr

2014-12-11 Thread Karen Xie
From: Karen Xie make sure any tx credit related checking is done before adding the wr header. Signed-off-by: Karen Xie --- drivers/scsi/cxgbi/cxgb4i/cxgb4i.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c b/drivers/scsi/cxgbi/cxgb

[PATCH net-next v10 5/7] cxgb4i: handle non-pdu-aligned rx data

2014-12-11 Thread Karen Xie
From: Karen Xie Abort the connection upon receiving of cpl_rx_data, which means the pdu cannot be recovered from the tcp stream. This generally is due to pdu header corruption. Signed-off-by: Karen Xie --- drivers/scsi/cxgbi/cxgb4i/cxgb4i.c | 22 ++ 1 files changed, 22 in

Re: T10-PI: Getting failed tag info

2014-12-11 Thread Martin K. Petersen
> "Vlad" == Vladislav Bolkhovitin writes: Vlad, Vlad> We are currently developing a SCSI target system with T10-PI. We Vlad> are using block integrity interface and found a problem that this Vlad> interface fundamentally can not pass Oracle T10-PI certification Vlad> tests. Those tests requi

Re: [PATCH] scsi:storvsc enable reading from VPD pages on SPC-2

2014-12-11 Thread Martin K. Petersen
> "Long" == Long Li writes: >> Handle the issues or handle WRITE SAME(10/16)? Long> With this patch, the SCSI layer will be able to correctly send Long> WRITE_SAME_16 to the Hyper-V host. It will not send WRITE_SAME_10: Long> it has been disabled in the driver template. Do you want me to Lon

Re: [PATCH] scsi: fix random memory corruption with scsi-mq + T10 PI

2014-12-11 Thread Nicholas A. Bellinger
Hi Tony, On Mon, 2014-12-08 at 17:20 -0500, Tony Battersby wrote: > This fixes random memory corruption triggered when all three of the > following are true: > > * scsi-mq enabled > * T10 Protection Information (DIF) enabled > * SCSI host with sg_tablesize > SCSI_MAX_SG_SEGMENTS (128) > > The sy

Re: [PATCH net v9 0/7] cxgb4/cxgbi: misc. fixes for cxgb4i

2014-12-11 Thread David Miller
From: Anish Bhatt Date: Thu, 11 Dec 2014 20:24:48 + >> This series does not apply cleanly at all to net-next, it gets many >> rejects. > > Hey Dave, this patchset was mostly bugfixes and hence meant for net where it > applies cleanly. not net-next. We can rebase to net-next and send if you'r

RE: [PATCH net v9 0/7] cxgb4/cxgbi: misc. fixes for cxgb4i

2014-12-11 Thread Anish Bhatt
> This series does not apply cleanly at all to net-next, it gets many > rejects. Hey Dave, this patchset was mostly bugfixes and hence meant for net where it applies cleanly. not net-next. We can rebase to net-next and send if you're still willing to take it before net-next closes. -Anish-- To u

Re: [PATCH net v9 0/7] cxgb4/cxgbi: misc. fixes for cxgb4i

2014-12-11 Thread David Miller
From: Karen Xie Date: Thu, 11 Dec 2014 07:25:37 -0800 > This patch set fixes cxgb4i's tx credit calculation and adds handling of > additional rx message and negative advice types. It also removes the duplicate > code in cxgb4i to set the outgoing queues of a packet. This series does not apply c

Re: [PATCH] cxgb4/csiostor: Don't use MASTER_MUST for fw_hello call

2014-12-11 Thread David Miller
From: Hariprasad Shenai Date: Thu, 11 Dec 2014 11:11:43 +0530 > Remove use of calls into t4_fw_hello() with MASTER_MUST, which results in > FW_HELLO_CMD_MASTERFORCE being set. The firmware doesn't support this and of > course any existing PF Drivers will totally go for a toss. > > Signed-off-by:

RE: [PATCH] scsi:storvsc enable reading from VPD pages on SPC-2

2014-12-11 Thread KY Srinivasan
> -Original Message- > From: Sitsofe Wheeler [mailto:sits...@gmail.com] > Sent: Thursday, December 11, 2014 2:54 AM > To: KY Srinivasan > Cc: Long Li; Martin K. Petersen; Haiyang Zhang; jbottom...@parallels.com; > linux-scsi@vger.kernel.org; de...@linuxdriverproject.org; linux- > ker...@v

[PATCH] uas: disable UAS on Apricorn SATA dongles

2014-12-11 Thread Darrick J. Wong
The Apricorn SATA dongle will occasionally return "USBSUSBSUSB" in response to SCSI commands when running in UAS mode. Therefore, disable UAS mode on this dongle. Signed-off-by: Darrick J. Wong --- drivers/usb/storage/unusual_uas.h | 10 ++ 1 file changed, 10 insertions(+) diff --git

[PATCH net v9 7/7] libcxgbi: fix freeing skb prematurely

2014-12-11 Thread Karen Xie
From: Karen Xie With debug turned on the debug print would access the skb after it is freed. Fix it to free the skb after the debug print. Signed-off-by: Karen Xie --- drivers/scsi/cxgbi/libcxgbi.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/cxgbi/l

RE: [PATCH net v8 1/7] cxgb4i: fix tx immediate data credit check

2014-12-11 Thread Karen Xie
From: David Miller [mailto:da...@davemloft.net] Sent: Wednesday, December 10, 2014 7:55 PM > Please text format your commit messages to 80 characters or less per line. > > People are going to read your commits using text tools, not necessarily GUI > tools which will auto-format your commit messag

[PATCH net v9 0/7] cxgb4/cxgbi: misc. fixes for cxgb4i

2014-12-11 Thread Karen Xie
This patch set fixes cxgb4i's tx credit calculation and adds handling of additional rx message and negative advice types. It also removes the duplicate code in cxgb4i to set the outgoing queues of a packet. Karen Xie (7): cxgb4i: fix tx immediate data credit check cxgb4i: fix credit check for tx_

[PATCH net v9 5/7] cxgb4i: handle non-pdu-aligned rx data

2014-12-11 Thread Karen Xie
From: Karen Xie Abort the connection upon receiving of cpl_rx_data, which means the pdu cannot be recovered from the tcp stream. This generally is due to pdu header corruption. Signed-off-by: Karen Xie --- drivers/scsi/cxgbi/cxgb4i/cxgb4i.c | 22 ++ 1 files changed, 22 i

[PATCH net v9 4/7] cxgb4i: additional types of negative advice

2014-12-11 Thread Karen Xie
From: Karen Xie Treat both CPL_ERR_KEEPALV_NEG_ADVICE and CPL_ERR_PERSIST_NEG_ADVICE as negative advice. Signed-off-by: Karen Xie --- drivers/scsi/cxgbi/cxgb4i/cxgb4i.c | 12 +--- 1 files changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c b/dri

[PATCH net v9 6/7] cxgb4i: use set_wr_txq() to set tx queues

2014-12-11 Thread Karen Xie
From: Karen Xie use cxgb4's set_wr_txq() for setting of the tx queue for a outgoing packet. Remove the similar function in cxgb4i. Signed-off-by: Karen Xie --- drivers/scsi/cxgbi/cxgb4i/cxgb4i.c | 16 +--- 1 files changed, 5 insertions(+), 11 deletions(-) diff --git a/drivers/sc

[PATCH net v9 2/7] cxgb4i: fix credit check for tx_data_wr

2014-12-11 Thread Karen Xie
From: Karen Xie make sure any tx credit related checking is done before adding the wr header. Signed-off-by: Karen Xie --- drivers/scsi/cxgbi/cxgb4i/cxgb4i.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c b/drivers/scsi/cxgbi/cxgb

[PATCH net v9 3/7] cxgb4/cxgb4i: set the max. pdu length in firmware

2014-12-11 Thread Karen Xie
From: Karen Xie Programs the firmware of the maximum outgoing iscsi pdu length per connection. Signed-off-by: Karen Xie --- drivers/scsi/cxgbi/cxgb4i/cxgb4i.c | 69 +++- 1 files changed, 51 insertions(+), 18 deletions(-) diff --git a/drivers/net/ethernet/chel

[PATCH net v9 1/7] cxgb4i: fix tx immediate data credit check

2014-12-11 Thread Karen Xie
From: Karen Xie Only data skbs need the wr header added while control skbs do not. Make sure they are treated differently. Signed-off-by: Karen Xie --- drivers/scsi/cxgbi/cxgb4i/cxgb4i.c | 22 +++--- drivers/scsi/cxgbi/libcxgbi.h |4 ++-- 2 files changed, 17 insertio

Re: [PATCH 07/22] [SCSI] mpt2sas: Complete the SCSI command with DID_RESET status for log_info value 0x0x32010081

2014-12-11 Thread Sreekanth Reddy
> Sreekanth> For any SCSI command, if the driver receives IOC status = > Sreekanth> SCSI_IOC_TERMINATED and log info = 0x32010081 then that > Sreekanth> command will be completed with DID_RESET host status. >>> >>> What does that log info value mean? > > Sreekanth> The meaning of this log info valu

Re: [PATCH 06/22] [SCSI] mpt2sas, mpt3sas: Removing uppper boundary restriction for the module parameter max_sgl_entries

2014-12-11 Thread Sreekanth Reddy
> @@ -2486,9 +2486,13 @@ _base_allocate_memory_pools(struct MPT2SAS_ADAPTER > *ioc, int sleep_flag) > > /* command line tunables for max sgl entries */ > if (max_sgl_entries != -1) { > - ioc->shost->sg_tablesize = (max_sgl_entries < > - MPT2SAS_SG_

Re: [PATCH 09/22] [SCSI] mpt2sas, mpt3sas: Added a support to set cpu affinity for each MSIX vector enabled by the HBA

2014-12-11 Thread Sreekanth Reddy
>> @@ -1609,6 +1611,10 @@ _base_request_irq(struct MPT3SAS_ADAPTER *ioc, u8 >> index, u32 vector) >> reply_q->ioc = ioc; >> reply_q->msix_index = index; >> reply_q->vector = vector; >> + >> + if (!zalloc_cpumask_var(&reply_q->affinity_hint, GFP_KERNEL)) >> + return

Re: [PATCH 09/22] [SCSI] mpt2sas, mpt3sas: Added a support to set cpu affinity for each MSIX vector enabled by the HBA

2014-12-11 Thread Sreekanth Reddy
> @@ -1373,20 +1380,30 @@ _base_assign_reply_queues(struct MPT2SAS_ADAPTER *ioc) > > cpu = cpumask_first(cpu_online_mask); > > - do { > + list_for_each_entry(reply_q, &ioc->reply_queue_list, list) { > + > > Why are you reverting to iterating over the queues? A while back I fixed

Re: [PATCH] scsi:storvsc enable reading from VPD pages on SPC-2

2014-12-11 Thread Sitsofe Wheeler
On Wed, Dec 10, 2014 at 11:30:30PM +, KY Srinivasan wrote: > > > > > > > + {"Msft", "Virtual Disk", "1.0", BLIST_TRY_VPD_PAGES}, > > > > > > Is that version field meaningful or is it safe for us to inquire about > > > VPD pages without problems on older versions? > > > > This version is used

Re: UAS crash with Apricorn USB3 SATA bridge

2014-12-11 Thread Darrick J. Wong
On Wed, Dec 10, 2014 at 05:41:54PM -0800, Darrick J. Wong wrote: > On Wed, Dec 10, 2014 at 02:29:29AM -0800, Darrick J. Wong wrote: > > On Wed, Dec 10, 2014 at 02:15:14AM -0800, Darrick J. Wong wrote: > > > On Wed, Dec 10, 2014 at 01:04:58AM -0800, Darrick J. Wong wrote: > > > > On Wed, Dec 10, 201