> "Mike" == Michael Christie writes:
Mike,
Mike> This was the issue we worked with Microsoft on wasn’t it? You guys
Mike> figured out it was fixed in their target in a recent release
Mike> right?
The issue we worked recently was wrt. the thin provisioning reporting.
The WRITE SAME problem
Note:
There are more instances of the problem described below, but I
thought I'd explain the first one in detail, to make sure it's
worth fixing the others (and to make sure I didn't do anything
stupid, which I may have. I'm new to this :-). Alright, here we go!
A few drivers seem to return positi
Using seq_printf to print a simple string is a lot more expensive than
it needs to be, since seq_puts exists. Replace seq_printf with
seq_puts when possible.
Signed-off-by: Rasmus Villemoes
---
drivers/scsi/advansys.c | 155 +++-
1 file changed, 75 ins
Using seq_printf to print a simple string is a lot more expensive than
it needs to be, since seq_puts exists. Replace seq_printf with
seq_puts when possible.
Signed-off-by: Rasmus Villemoes
---
drivers/scsi/BusLogic.c | 10 +-
drivers/scsi/NCR5380.c | 4 ++--
dr
The macro SPRINTF doesn't save a lot of typing or make the code more
readable, and depending on a specific identifier (m) in the
surrounding scope is generally frowned upon. Nuke it.
Signed-off-by: Rasmus Villemoes
---
drivers/scsi/NCR5380.c | 20 ++-
drivers/scsi/aha152x.c | 295 ++
Consecutive seq_puts calls with literal strings may be replaced by a
single call, saving a little .text.
Signed-off-by: Rasmus Villemoes
---
drivers/scsi/advansys.c | 43 +++
drivers/scsi/atp870u.c | 5 ++---
drivers/scsi/dc395x.c| 4 +
Using seq_printf to print a simple string is a lot more expensive than
it needs to be, since seq_puts exists. Replace seq_printf with
seq_puts when possible.
Signed-off-by: Rasmus Villemoes
---
drivers/scsi/aha152x.c | 248 -
1 file changed, 124 in
Using seq_putc to print a single character saves at least a strlen()
call and a memory access, and may also give a small .text reduction.
Signed-off-by: Rasmus Villemoes
---
drivers/scsi/NCR5380.c | 2 +-
drivers/scsi/advansys.c | 34 +-
These patches mostly replace seq_printf with simpler and faster
equivalents, e.g. seq_printf(m, "something") => seq_puts(m,
"something") and seq_printf(m, "\n") => seq_putc(m, '\n). But before
my Coccinelle scripts could be unleashed I had to clean up an
unnecessary macro.
The patches don't change
> -Original Message-
> From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi-
> ow...@vger.kernel.org] On Behalf Of Alex Thorlton
> Sent: Tuesday, 02 December, 2014 3:58 PM
...
> We've recently upgraded our big machine up to 6144 cores, and we're
> shaking out a number of bugs related
Hey guys,
We've recently upgraded our big machine up to 6144 cores, and we're
shaking out a number of bugs related to booting at that large core
count. Last night I tripped a warning from the lpfc driver that appears
to be related to a kzalloc that uses the number of cores as part of it's
size ca
Reviewed-by: Wen Xiong
Thanks,
Wendy
Quoting Brian King :
Bump driver version.
Signed-off-by: Brian King
---
drivers/scsi/ipr.h |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff -puN drivers/scsi/ipr.h~ipr_version_2_6_1 drivers/scsi/ipr.h
--- scsi-queue/drivers/scsi/ipr.
Reviewed-by: Wen Xiong
Thanks,
Wendy
Quoting Brian King :
Set the scsi_level correctly for disk arrays such
that things like the rotational field get set
properly by sd.c.
Signed-off-by: Brian King
---
drivers/scsi/ipr.c |1 +
1 file changed, 1 insertion(+)
diff -puN drivers/scsi/ipr.
Reviewed-by: Wen Xiong
Thanks,
Wendy
Quoting Brian King :
Currently when performing a kexec boot with an ipr adapter,
the adapter gets shutdown completely, flushing all write
cache, as well as performing a full hardware reset of the card
during the shutdown phase of the old kernel. This force
Reviewed-by: Wen Xiong
Thanks,
Wendy
Quoting Brian King :
A kexec boot for some ipr SAS adapters was seen to take ~20 seconds
just doing ipr adapter initialization. This is due to the fact that
a kexec invokes the driver's shutdown handler which places the adapter
into a state that requires a
Reviewed-by: Wen Xiong
Thanks,
Wendy
Quoting Brian King :
Switch device scanning logic in the ipr driver to use
the async scan API. This speeds up boot times, particularly
on large systems.
Signed-off-by: Brian King
---
drivers/scsi/ipr.c | 88
+
Acked-by: Bradley Grove
Thanks,
Brad
On 11/27/2014 11:13 AM, Boris Bodemann wrote:
From: Boris Bodemann
Correct typos of "validate" in a comment
Signed-off-by: Boris Bodemann
---
diff -up a/drivers/scsi/esas2r/esas2r_flash.c
b/drivers/scsi/esas2r/esas2r_flash.c
--- a/drivers/scsi/esas2r/e
On 12/02/2014 12:47 PM, Brian King wrote:
> A kexec boot for some ipr SAS adapters was seen to take ~20 seconds
> just doing ipr adapter initialization. This is due to the fact that
> a kexec invokes the driver's shutdown handler which places the adapter
> into a state that requires a hard reset an
A kexec boot for some ipr SAS adapters was seen to take ~20 seconds
just doing ipr adapter initialization. This is due to the fact that
a kexec invokes the driver's shutdown handler which places the adapter
into a state that requires a hard reset and resulting firmware initialization
to be usable
Set the scsi_level correctly for disk arrays such
that things like the rotational field get set
properly by sd.c.
Signed-off-by: Brian King
---
drivers/scsi/ipr.c |1 +
1 file changed, 1 insertion(+)
diff -puN drivers/scsi/ipr.c~ipr_array_scsi_level drivers/scsi/ipr.c
--- scsi-queue/drive
Bump driver version.
Signed-off-by: Brian King
---
drivers/scsi/ipr.h |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff -puN drivers/scsi/ipr.h~ipr_version_2_6_1 drivers/scsi/ipr.h
--- scsi-queue/drivers/scsi/ipr.h~ipr_version_2_6_1 2014-12-02
12:25:20.232176757 -0600
+++
Currently when performing a kexec boot with an ipr adapter,
the adapter gets shutdown completely, flushing all write
cache, as well as performing a full hardware reset of the card
during the shutdown phase of the old kernel. This forces
the new kernel to then wait for the adapter firmware to
reini
Switch device scanning logic in the ipr driver to use
the async scan API. This speeds up boot times, particularly
on large systems.
Signed-off-by: Brian King
---
drivers/scsi/ipr.c | 88 +
drivers/scsi/ipr.h |4 --
2 files changed, 44 i
If the asd_find_flash_de() function returns ENOENT the off value will
be used uninitialized in the call to asd_read_flash_seg().
Signed-off-by: Eric B Munson
Cc: sta...@vger.kernel.org
---
drivers/scsi/aic94xx/aic94xx_sds.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/driv
Reverting the below commit IDs
1. [PATCH 1/2] mpt2sas: Remove phys on topology change
commit ID: 3520f9c779bed098ca76dd3fb6377264301d57ed
2. [PATCH 2/2] mpt3sas: Remove phys on topology change
commit ID: 963ba22b90a955363644cd397b20226928eab976
Sreekanth Reddy (2):
Revert "[SCSI] mpt2sas
This reverts commit 963ba22b90a955363644cd397b20226928eab976
("mpt3sas: Remove phys on topology change")
Reverting the previous mpt3sas drives patch changes,
since we will observe below issue
Issue:
Drives connected Enclosure/Expander will unregister with
SCSI Transport Layer, if any one remove a
This reverts commit 3520f9c779bed098ca76dd3fb6377264301d57ed
("mpt2sas: Remove phys on topology change")
Reverting the previous mpt2sas drives patch changes,
since we will observe below issue
Issue:
Drives connected Enclosure/Expander will unregister with
SCSI Transport Layer, if any one remove a
On Tue, 2014-12-02 at 14:07 +0300, Dan Carpenter wrote:
> One of the two callers passes an unintialized pointer as "fmt" and
> expects it to be set to NULL if there is no format string. Let's make
> this function work as expected.
>
> Fixes: d811b848ebb7 ('scsi: use sdev as argument for sense cod
Ok. Thanks Tomas, I will follow the same and will send the revert
patch to Upstream.
Thanks,
Sreekanth.
On Tue, Dec 2, 2014 at 7:37 PM, Tomas Henzl wrote:
> Hi Sreekanth,
>
> I think this should be handled as any other change with an usual
> patch sent to the list, 'git revert 3520f9c779' and 'g
Hi Sreekanth,
I think this should be handled as any other change with an usual
patch sent to the list, 'git revert 3520f9c779' and 'git revert 963ba22b90'
will create the patches for you.
Cheers,
Tomas
On 12/02/2014 02:18 PM, Sreekanth Reddy wrote:
> Hi James/Chris
>
> We are observing below iss
Hi James/Chris
We are observing below issue due to this patch set code changes
Issue Description:
Drives connected Enclosure/Expander won't be visible to the OS if any
one remove and add expander cable with in DMD (Device Missing Delay) time
period (also if any power-off and power-on the Enc
One of the two callers passes an unintialized pointer as "fmt" and
expects it to be set to NULL if there is no format string. Let's make
this function work as expected.
Fixes: d811b848ebb7 ('scsi: use sdev as argument for sense code printing')
Signed-off-by: Dan Carpenter
---
v2: Change scsi_ex
32 matches
Mail list logo
