Looks good to me,
Reviewed-by: Subhash Jadavani
-Original Message-
From: Akinobu Mita [mailto:akinobu.m...@gmail.com]
Sent: Tuesday, November 18, 2014 6:03 AM
To: linux-scsi@vger.kernel.org
Cc: Akinobu Mita; Akinobu Mita; Vinayak Holikatti; Dolev Raviv; Subhash
Jadavani; Yaniv Gardi; Suj
Reviewed-by: Subhash Jadavani
-Original Message-
From: Akinobu Mita [mailto:akinobu.m...@gmail.com]
Sent: Tuesday, November 18, 2014 6:03 AM
To: linux-scsi@vger.kernel.org
Cc: Akinobu Mita; Akinobu Mita; Vinayak Holikatti; Subhash Jadavani; Dolev
Raviv; Sujit Reddy Thumma; Yaniv Gardi; C
On Fri, 2014-11-21 at 10:30 +0100, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Fri, 21 Nov 2014 10:25:45 +0100
>
> The module_put() function tests whether its argument is NULL and then
> returns immediately. Thus the test around the call is not needed.
>
> This issue was detected by
On Thu, Nov 20, 2014 at 23:55:54 -0800, Joe Perches wrote:
> On Fri, 2014-11-21 at 12:52 +0530, Hariprasad Shenai wrote:
> > This patch cleanups all filter related macros/register defines that are
> > defined
> > in t4fw_api.h and the affected files.
>
> Is there any real value in the FW_FILTER_W
From: Christoph Hellwig
Date: Wed, 19 Nov 2014 22:01:35 -0800
> On Sat, Nov 15, 2014 at 08:31:00AM -0700, Jens Axboe wrote:
>> My next move would be to add more debug to the CPU map setup and teardown,
>> so that we can verify that the map that is being used above has indeed been
>> setup. Unless
From: Hannes Reinecke
Date: Fri, 21 Nov 2014 13:41:55 +0100
> CONFIG2_FENAB ('feature enable') changed definition between chip
> revisions, from 'Latch SCSI Phase' to 'Latch SCSI Phase, display
> chip ID upon reset, and enable 24 bit addresses'.
> So only enable it for am53c974 where we know what
From: Hannes Reinecke
Date: Fri, 21 Nov 2014 13:41:54 +0100
> From: Paolo Bonzini
>
> On PCscsi, the FENAB configuration also enables 24-bit DMA
> transfer lengths (and provides the chip id in TCHI after reset).
> We want to be able to enable this parameter from the DMA driver.
>
> Check if th
From: Hannes Reinecke
Date: Fri, 21 Nov 2014 13:41:53 +0100
> + if ((config4 & ESP_CONFIG4_GE1) == ESP_CONFIG4_GE1) {
Please condense this down to the more simple and straightforward:
if (x & BIT(N))
because this is always equivalent to the expression you have used:
From: Hannes Reinecke
Date: Fri, 21 Nov 2014 13:41:52 +0100
> The am53c974 has an design issue where a single byte might be
> left in the SCSI FIFO after a DMA transfer.
> As the handling code is currently untested add a WARN_ON()
> statement here.
>
> Signed-off-by: Hannes Reinecke
Acked-by:
From: Hannes Reinecke
Date: Fri, 21 Nov 2014 13:41:48 +0100
> Add new debug definitions for event and command logging.
>
> Reviewed-by: Paolo Bonzini
> Signed-off-by: Hannes Reinecke
Acked-by: David S. Miller
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the bod
From: Hannes Reinecke
Date: Fri, 21 Nov 2014 13:41:49 +0100
> A read to ESP_INTRPT will clear ESP_STATUS and ESP_SSTEP. So read
> all status registers in one go to avoid losing information.
>
> Reviewed-by: Paolo Bonzini
> Signed-off-by: Hannes Reinecke
Acked-by: David S. Miller
--
To unsubs
From: Hannes Reinecke
Date: Fri, 21 Nov 2014 13:41:47 +0100
> Use dev_printk functions for correct device annotations.
>
> Reviewed-by: Paolo Bonzini
> Signed-off-by: Hannes Reinecke
Acked-by: David S. Miller
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the bod
From: Hannes Reinecke
Date: Fri, 21 Nov 2014 13:41:46 +0100
> Add a field 'num_tags' to the esp structure to allow drivers
> to overwrite the number of avialable tags if required.
> Default is ESP_DEFAULT_TAGS.
>
> Reviewed-by: Paolo Bonzini
> Signed-off-by: Hannes Reinecke
Acked-by: David S.
From: Hannes Reinecke
Date: Fri, 21 Nov 2014 13:41:45 +0100
> Reviewed-by: Paolo Bonzini
> Signed-off-by: Hannes Reinecke
Acked-by: David S. Miller
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo inf
From: Hannes Reinecke
Date: Fri, 21 Nov 2014 13:41:50 +0100
> Using DMA for command submission has the drawback that it might
> generate additional DMA completion interrupts after the command
> has been submitted to the device.
> Additionally the am53c974 has a design flaw causing it
> to generat
On 11/21/2014 04:44 PM, Alan Stern wrote:
> Commit ac61d1955934 (scsi: set correct completion code in
> scsi_send_eh_cmnd()) introduced a bug. It changed the stored return
> value from a queuecommand call, but it didn't take into account that
> the return value was used again later on. This patch
Commit ac61d1955934 (scsi: set correct completion code in
scsi_send_eh_cmnd()) introduced a bug. It changed the stored return
value from a queuecommand call, but it didn't take into account that
the return value was used again later on. This patch fixes the bug by
changing the later usage.
There
On Fri, 21 Nov 2014, Christoph Hellwig wrote:
> > usb-storage sets wce_default_on only for devices that are marked with
> > the US_FL_WRITE_CACHE quirk flag. Currently only two devices have that
> > flag: the Seagate Portable HDD (vendor ID 0x0bc2, product ID 0x2300)
> > and the Western Digita
On 11/17/2014 10:54 AM, sumit.sax...@avagotech.com wrote:
> This patch addresses few endianness related bug fixes.
>
> Cc:
>
> Signed-off-by: Sumit Saxena
> Signed-off-by: Kashyap Desai
> ---
> drivers/scsi/megaraid/megaraid_sas_fp.c | 17 +
> drivers/scsi/megaraid/megarai
On 11/17/2014 10:54 AM, sumit.sax...@avagotech.com wrote:
> Corrected wait_event() call which was waiting for wrong completion
> status(0xFF).
>
> Cc:
>
> Signed-off-by: Sumit Saxena
> Signed-off-by: Kashyap Desai
> ---
> drivers/scsi/megaraid/megaraid_sas_base.c |2 +-
> 1 files changed,
On 11/17/2014 10:54 AM, sumit.sax...@avagotech.com wrote:
> In OCR(Online Controller Reset) path, driver sets adapter state to
> MEGASAS_HBA_OPERATIONAL before getting new RAID map.
> There will be a small window where IO will come from OS with old RAID map.
> This patch will update adapter state
On 11/17/2014 10:54 AM, sumit.sax...@avagotech.com wrote:
> In OCR(Online Controller Reset) path, driver sets adapter state to
> MEGASAS_HBA_OPERATIONAL before getting new RAID map.
> There will be a small window where IO will come from OS with old RAID map.
> This patch will update adapter state
On 11/17/2014 10:54 AM, sumit.sax...@avagotech.com wrote:
> Update MAINTAINERS list and copyright information for megaraid_sas driver.
>
> Signed-off-by: Sumit Saxena
> ---
> MAINTAINERS |9 ++---
> drivers/scsi/megaraid/megaraid_sas.h| 16 +++
On 11/17/2014 10:54 AM, sumit.sax...@avagotech.com wrote:
> Do not process any SCSI and IOCTL command further(return them with
> appropriate return values to callers),
> while driver removal is in progress/PCI shutdown is invoked.
>
> Signed-off-by: Sumit Saxena
> Signed-off-by: Kashyap Desai
>
On 11/17/2014 10:53 AM, sumit.sax...@avagotech.com wrote:
> Update driver version and remove some meta data(release date and extended
> version) about megaraid_sas driver.
>
> Signed-off-by: Sumit Saxena
> ---
> drivers/scsi/megaraid/megaraid_sas.h |4 +---
> drivers/scsi/megaraid/megar
On 11/21/2014 12:37 PM, Sumit Saxena wrote:
> On Mon, Nov 17, 2014 at 3:23 PM, wrote:
>> megaraid_sas driver changes.
>> This resent patch series has some additional changes in few patches on top
>> of last patch series.
>> [PATCH RESNED 1/7] additionally rmeoves some meta data of megaraid_sas
On 11/20/2014 03:07 PM, Christoph Hellwig wrote:
> Thanks. This should go into 3.18 and -stable, right?
>
Yes.
Thanks,
Maurizio Lombardi
On 11/20/2014 11:17 AM, Maurizio Lombardi wrote:
> In some cases, the fcoe_rx_list may contains multiple instances
> of the same skb (the so called "shar
On 21/11/2014 13:41, Hannes Reinecke wrote:
> CONFIG2_FENAB ('feature enable') changed definition between chip
> revisions, from 'Latch SCSI Phase' to 'Latch SCSI Phase, display
> chip ID upon reset, and enable 24 bit addresses'.
> So only enable it for am53c974 where we know what it's doing.
>
On 21/11/2014 13:41, Hannes Reinecke wrote:
> The am53c974 has an design issue where a single byte might be
> left in the SCSI FIFO after a DMA transfer.
> As the handling code is currently untested add a WARN_ON()
> statement here.
>
> Signed-off-by: Hannes Reinecke
> ---
> drivers/scsi/am53c
On 21/11/2014 13:41, Hannes Reinecke wrote:
> Using DMA for command submission has the drawback that it might
> generate additional DMA completion interrupts after the command
> has been submitted to the device.
> Additionally the am53c974 has a design flaw causing it
> to generate spurious inter
The am53c974 has an design issue where a single byte might be
left in the SCSI FIFO after a DMA transfer.
As the handling code is currently untested add a WARN_ON()
statement here.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/am53c974.c | 6 ++
drivers/scsi/esp_scsi.c | 29 ++
The am53c974 is a re-implementation of the tmscsim driver,
and provides the same functionality.
So remove the tmscsim driver and make am53c974 an alias to tmscsim.
Cc: Guennadi Liakhovetski
Signed-off-by: Hannes Reinecke
---
MAINTAINERS |7 +-
drivers/scsi/Kconfig| 16 -
d
The am53c974 returns the same ID as the FAS236, but implements
things slightly differently. So detect the am53c974 by checking
for ESP_CONFIG4 register.
Reviewed-by: Paolo Bonzini
Signed-off-by: Hannes Reinecke
---
drivers/scsi/am53c974.c | 2 ++
drivers/scsi/esp_scsi.c | 17 -
From: Paolo Bonzini
On PCscsi, the FENAB configuration also enables 24-bit DMA
transfer lengths (and provides the chip id in TCHI after reset).
We want to be able to enable this parameter from the DMA driver.
Check if the caller of scsi_esp_register provided a value for esp->config2.
If this is
Reviewed-by: Paolo Bonzini
Signed-off-by: Hannes Reinecke
---
drivers/scsi/esp_scsi.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/esp_scsi.h b/drivers/scsi/esp_scsi.h
index cd68805..b5862e4 100644
--- a/drivers/scsi/esp_scsi.h
+++ b/drivers/scsi/esp_scsi.h
@@
Hi all,
having found some issues with the current tmscsim driver
I looked at the code and found is really awkward to clean
up.
Seeing that the am53c974 chip is actually based on the
'ESP' chip design I've re-implemented it based on the
common esp_scsi routines. This new driver
(cunningly named 'am
This patch adds a new implementation for the Tekram DC-390T /
AMD AM53c974 SCSI controller, based on the generic
esp_scsi infrastructure.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/Kconfig| 18 ++
drivers/scsi/Makefile | 1 +
drivers/scsi/am53c974.c | 531 ++
Using DMA for command submission has the drawback that it might
generate additional DMA completion interrupts after the command
has been submitted to the device.
Additionally the am53c974 has a design flaw causing it
to generate spurious interrupts even though DMA completion
interrupts are not enab
A read to ESP_INTRPT will clear ESP_STATUS and ESP_SSTEP. So read
all status registers in one go to avoid losing information.
Reviewed-by: Paolo Bonzini
Signed-off-by: Hannes Reinecke
---
drivers/scsi/esp_scsi.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers
Add new debug definitions for event and command logging.
Reviewed-by: Paolo Bonzini
Signed-off-by: Hannes Reinecke
---
drivers/scsi/esp_scsi.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/drivers/scsi/esp_scsi.c b/drivers/scsi/esp_scsi.c
index 10a3d17..3a5d81c 100644
---
Use dev_printk functions for correct device annotations.
Reviewed-by: Paolo Bonzini
Signed-off-by: Hannes Reinecke
---
drivers/scsi/esp_scsi.c | 212
1 file changed, 106 insertions(+), 106 deletions(-)
diff --git a/drivers/scsi/esp_scsi.c b/driv
Add a field 'num_tags' to the esp structure to allow drivers
to overwrite the number of avialable tags if required.
Default is ESP_DEFAULT_TAGS.
Reviewed-by: Paolo Bonzini
Signed-off-by: Hannes Reinecke
---
drivers/scsi/esp_scsi.c | 12 ++--
drivers/scsi/esp_scsi.h | 3 +--
2 files cha
CONFIG2_FENAB ('feature enable') changed definition between chip
revisions, from 'Latch SCSI Phase' to 'Latch SCSI Phase, display
chip ID upon reset, and enable 24 bit addresses'.
So only enable it for am53c974 where we know what it's doing.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/am53c9
These disks have a broken uas implementation, the tag field of the status
iu-s is not set properly, so we need to fall-back to usb-storage for these.
Cc: sta...@vger.kernel.org # 3.16
Signed-off-by: Hans de Goede
---
drivers/usb/storage/unusual_uas.h | 7 +++
1 file changed, 7 insertions(+)
On Mon, Nov 17, 2014 at 3:23 PM, wrote:
> megaraid_sas driver changes.
> This resent patch series has some additional changes in few patches on top of
> last patch series.
> [PATCH RESNED 1/7] additionally rmeoves some meta data of megaraid_sas driver.
> [PATCH RESEND 2/7] has additional copyrig
On 21/11/2014 11:22, Hannes Reinecke wrote:
> On 11/21/2014 11:08 AM, Paolo Bonzini wrote:
>>
>>
>> On 21/11/2014 10:27, Hannes Reinecke wrote:
>>> CONFIG2_FENAB ('feature enable') changed definition between chip
>>> revisions, from 'Latch SCSI Phase' to 'Latch SCSI Phase, display
>>> chip ID upo
On 21/11/2014 11:38, Hannes Reinecke wrote:
>>> esp->msg_out_len = 0;
>>>
>>> *p++ = IDENTIFY(0, lun);
>>> @@ -648,12 +651,21 @@ static void esp_autosense(struct esp *esp, struct
>>> esp_cmd_entry *ent)
>>> esp_write_tgt_sync(esp, tgt);
>>> esp_write_tgt_config3(esp, tgt);
>>>
Hi,
On Fri, 21 Nov 2014, Hannes Reinecke wrote:
> On 11/21/2014 11:26 AM, Christoph Hellwig wrote:
> > On Fri, Nov 21, 2014 at 10:27:47AM +0100, Hannes Reinecke wrote:
> >> Hi all,
> >>
> >> having found some issues with the current tmscsim driver
> >> I looked at the code and found is really awk
On 11/21/2014 11:04 AM, Paolo Bonzini wrote:
>
>
> On 21/11/2014 10:27, Hannes Reinecke wrote:
>> The am53c974 has a design flaw causing it to throw an
>> DMA interrupt whenever a DMA transmission completed,
>> even though DMA interrupt reporting is disabled.
>> This confuses the esp routines as
On 11/21/2014 11:14 AM, Paolo Bonzini wrote:
>
>
> On 21/11/2014 10:27, Hannes Reinecke wrote:
>> This patch adds a new implementation for the Tekram DC-390T /
>> AMD AM53c974 SCSI controller, based on the generic
>> esp_scsi infrastructure.
>>
>> Signed-off-by: Hannes Reinecke
>> ---
>> driver
On 11/21/2014 11:26 AM, Christoph Hellwig wrote:
> On Fri, Nov 21, 2014 at 10:27:47AM +0100, Hannes Reinecke wrote:
>> Hi all,
>>
>> having found some issues with the current tmscsim driver
>> I looked at the code and found is really awkward to clean
>> up.
>> Seeing that the am53c974 chip is actua
On 11/21/2014 11:10 AM, Paolo Bonzini wrote:
>
>
> On 21/11/2014 10:27, Hannes Reinecke wrote:
>> The am53c974 has an design issue where a single byte might be
>> left in the SCSI FIFO after a DMA transfer.
>> As the handling code is currently untested add a WARN_ON()
>> statement here.
>>
>> Sig
On Fri, Nov 21, 2014 at 10:27:47AM +0100, Hannes Reinecke wrote:
> Hi all,
>
> having found some issues with the current tmscsim driver
> I looked at the code and found is really awkward to clean
> up.
> Seeing that the am53c974 chip is actually based on the
> 'ESP' chip design I've re-implemented
On 11/21/2014 11:08 AM, Paolo Bonzini wrote:
>
>
> On 21/11/2014 10:27, Hannes Reinecke wrote:
>> CONFIG2_FENAB ('feature enable') changed definition between chip
>> revisions, from 'Latch SCSI Phase' to 'Latch SCSI Phase, display
>> chip ID upon reset, and enable 24 bit addresses'.
>> So only en
On Fri, Nov 21, 2014 at 09:59:15AM +0100, Hannes Reinecke wrote:
> Speaking of which, what is the decision for my next round of logging
> updates?
> I _think_ I've got all things fixed (minus the suggestion from Doug,
> but this can be fixed up with the next round).
I was waiting for that to do an
Oops, hit send too early. A small nit:
On 21/11/2014 10:27, Hannes Reinecke wrote:
> +static void pci_esp_dma_drain(struct esp *esp)
> +{
> + u8 resid;
> + int lim = 1000;
> +
> +
> + if ((esp->sreg & ESP_STAT_PMASK) == ESP_DOP ||
> + (esp->sreg & ESP_STAT_PMASK) == ESP_DIP)
>
On Thu, Nov 20, 2014 at 02:16:05PM -0500, James Smart wrote:
> Looks fine
>
>
> Acked-by: James Smart
Do the other patches look fine to you too?
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info
On Thu, Nov 13, 2014 at 07:47:19PM +, venkate...@google.com wrote:
> On Thu, Nov 13, 2014 at 06:59:01PM +0100, Christoph Hellwig wrote:
> >All drivers use the implementation for ramping the queue up and down, so
> >instead of overloading the change_queue_depth method call the
> >implementation
> usb-storage sets wce_default_on only for devices that are marked with
> the US_FL_WRITE_CACHE quirk flag. Currently only two devices have that
> flag: the Seagate Portable HDD (vendor ID 0x0bc2, product ID 0x2300)
> and the Western Digital My Password HDD (vendor ID 0x1058, product ID
> 0x07
On 21/11/2014 10:27, Hannes Reinecke wrote:
> This patch adds a new implementation for the Tekram DC-390T /
> AMD AM53c974 SCSI controller, based on the generic
> esp_scsi infrastructure.
>
> Signed-off-by: Hannes Reinecke
> ---
> drivers/scsi/Kconfig| 18 ++
> drivers/scsi/Makefile |
On 21/11/2014 10:27, Hannes Reinecke wrote:
> The am53c974 returns the same ID as the FAS236, but implements
> things slightly differently. So detect the am53c974 by checking
> for ESP_CONFIG4 register.
>
> Signed-off-by: Hannes Reinecke
> ---
> drivers/scsi/am53c974.c | 2 ++
> drivers/scsi/
On 21/11/2014 10:27, Hannes Reinecke wrote:
> The am53c974 has an design issue where a single byte might be
> left in the SCSI FIFO after a DMA transfer.
> As the handling code is currently untested add a WARN_ON()
> statement here.
>
> Signed-off-by: Hannes Reinecke
> ---
> drivers/scsi/am53c
On 21/11/2014 10:27, Hannes Reinecke wrote:
> CONFIG2_FENAB ('feature enable') changed definition between chip
> revisions, from 'Latch SCSI Phase' to 'Latch SCSI Phase, display
> chip ID upon reset, and enable 24 bit addresses'.
> So only enable it for am53c974 where we know what it's doing.
>
On 21/11/2014 10:27, Hannes Reinecke wrote:
> The am53c974 has a design flaw causing it to throw an
> DMA interrupt whenever a DMA transmission completed,
> even though DMA interrupt reporting is disabled.
> This confuses the esp routines as it would register
> a DMA interrupt whenever a cdb has
On Thu, Nov 20, 2014 at 08:16:06AM +, Tim Small wrote:
> On 20/11/14 06:34, Christoph Hellwig wrote:
> > Wakko, any chance you could resend a patch to remove the mutex from the
> > ioctl path?
>
> I'm trying out some local changes which removes the ex-BKL mutex from
> sr_block_ioctl() in sr.c,
On 21/11/2014 10:27, Hannes Reinecke wrote:
> A read to ESP_INTRPT will clear ESP_STATUS and ESP_SSTEP. So read
> all status registers in one go to avoid losing information.
(ESP_STAT_TCNT is actually kept in the status register, it is cleared by
writing TCLO/MID/HI).
Reviewed-by: Paolo Bonzini
On 21/11/2014 10:27, Hannes Reinecke wrote:
> Use dev_printk functions for correct device annotations.
>
> Signed-off-by: Hannes Reinecke
> ---
> drivers/scsi/esp_scsi.c | 212
>
> 1 file changed, 106 insertions(+), 106 deletions(-)
>
> diff -
On 21/11/2014 10:27, Hannes Reinecke wrote:
> Add new debug definitions for event and command logging.
>
> Signed-off-by: Hannes Reinecke
> ---
> drivers/scsi/esp_scsi.c | 15 +++
> 1 file changed, 15 insertions(+)
>
> diff --git a/drivers/scsi/esp_scsi.c b/drivers/scsi/esp_scsi.c
On 21/11/2014 10:27, Hannes Reinecke wrote:
> Add a field 'num_tags' to the esp structure to allow drivers
> to overwrite the number of avialable tags if required.
> Default is ESP_DEFAULT_TAGS.
>
> Signed-off-by: Hannes Reinecke
> ---
> drivers/scsi/esp_scsi.c | 10 --
> drivers/scsi/
On 21/11/2014 10:27, Hannes Reinecke wrote:
> Signed-off-by: Hannes Reinecke
> ---
> drivers/scsi/esp_scsi.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/esp_scsi.h b/drivers/scsi/esp_scsi.h
> index cd68805..b5862e4 100644
> --- a/drivers/scsi/esp_scsi.
From: Markus Elfring
Date: Fri, 21 Nov 2014 10:25:45 +0100
The module_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
driver
Hi all,
having found some issues with the current tmscsim driver
I looked at the code and found is really awkward to clean
up.
Seeing that the am53c974 chip is actually based on the
'ESP' chip design I've re-implemented it based on the
common esp_scsi routines. This new driver
(cunningly named 'am
The am53c974 returns the same ID as the FAS236, but implements
things slightly differently. So detect the am53c974 by checking
for ESP_CONFIG4 register.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/am53c974.c | 2 ++
drivers/scsi/esp_scsi.c | 17 -
drivers/scsi/esp_scsi.h | 1
Use dev_printk functions for correct device annotations.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/esp_scsi.c | 212
1 file changed, 106 insertions(+), 106 deletions(-)
diff --git a/drivers/scsi/esp_scsi.c b/drivers/scsi/esp_scsi.c
index 99
Add a field 'num_tags' to the esp structure to allow drivers
to overwrite the number of avialable tags if required.
Default is ESP_DEFAULT_TAGS.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/esp_scsi.c | 10 --
drivers/scsi/esp_scsi.h | 3 +--
2 files changed, 5 insertions(+), 8 delet
CONFIG2_FENAB ('feature enable') changed definition between chip
revisions, from 'Latch SCSI Phase' to 'Latch SCSI Phase, display
chip ID upon reset, and enable 24 bit addresses'.
So only enable it for am53c974 where we know what it's doing.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/am53c9
The am53c974 has an design issue where a single byte might be
left in the SCSI FIFO after a DMA transfer.
As the handling code is currently untested add a WARN_ON()
statement here.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/am53c974.c | 6 ++
drivers/scsi/esp_scsi.c | 29 ++
Add new debug definitions for event and command logging.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/esp_scsi.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/drivers/scsi/esp_scsi.c b/drivers/scsi/esp_scsi.c
index 492c51b..fe3278e 100644
--- a/drivers/scsi/esp_scsi.c
+
The am53c974 has a design flaw causing it to throw an
DMA interrupt whenever a DMA transmission completed,
even though DMA interrupt reporting is disabled.
This confuses the esp routines as it would register
a DMA interrupt whenever a cdb has been transmitted
to the drive.
So implement an option to
A read to ESP_INTRPT will clear ESP_STATUS and ESP_SSTEP. So read
all status registers in one go to avoid losing information.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/esp_scsi.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/esp_scsi.c b/drivers/s
This patch adds a new implementation for the Tekram DC-390T /
AMD AM53c974 SCSI controller, based on the generic
esp_scsi infrastructure.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/Kconfig| 18 ++
drivers/scsi/Makefile | 1 +
drivers/scsi/am53c974.c | 523 ++
Signed-off-by: Hannes Reinecke
---
drivers/scsi/esp_scsi.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/esp_scsi.h b/drivers/scsi/esp_scsi.h
index cd68805..b5862e4 100644
--- a/drivers/scsi/esp_scsi.h
+++ b/drivers/scsi/esp_scsi.h
@@ -1,4 +1,4 @@
-/* esp_scsi.h
On 11/20/2014 04:56 PM, Christoph Hellwig wrote:
> Thanks, I've applied all patches to the drivers-for-3.19 branch.
>
> I had a few rejects due to Hannes logging changes. I think I've fixed
> them properly, but please verify it.
Speaking of which, what is the decision for my next round of loggin
From: Markus Elfring
Date: Fri, 21 Nov 2014 09:39:43 +0100
The vfree() function performs also input parameter validation. Thus the test
around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/scsi/fnic/fnic_debugfs.c |
https://bugzilla.kernel.org/show_bug.cgi?id=88591
Lei, Ni changed:
What|Removed |Added
CC||zsuranc...@163.com
--- Comment #2 from Lei, Ni
From: Markus Elfring
Date: Fri, 21 Nov 2014 09:15:10 +0100
The dst_release() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drive
86 matches
Mail list logo
