Re: [uas/3.16.1] panic in uas_data_cmplt()

2014-09-01 Thread Hans de Goede
Hi, On 09/02/2014 06:18 AM, Chunwei Chen wrote: > Dear all: > > The kernel version is 3.16.1-1-ARCH > > Today I keep getting this panic when booting up. > http://i.imgur.com/0Rx93Kr.jpg > > It might be that the UAS device was in some strange state, > because that after I unplugged and power-cyc

Re: Re: [PATCH 1/3] scsi/trace: Use macros for getting driver byte, host byte, msg byte, and status byte

2014-09-01 Thread Yoshihiro YUNOMAE
(2014/09/02 0:15), Christoph Hellwig wrote: On Mon, Sep 01, 2014 at 12:33:28PM +, Yoshihiro YUNOMAE wrote: For getting driver byte, host byte, msg byte, and status byte, macros are implemented in scsi/scsi.h, so we use it. As mentioned about three times in various previous scsi logging dis

[uas/3.16.1] panic in uas_data_cmplt()

2014-09-01 Thread Chunwei Chen
Dear all: The kernel version is 3.16.1-1-ARCH Today I keep getting this panic when booting up. http://i.imgur.com/0Rx93Kr.jpg It might be that the UAS device was in some strange state, because that after I unplugged and power-cycled the UAS, everything went normal again. Does anyone know what's

Re: potential buffer overrun in __iscsi_conn_send_pdu()

2014-09-01 Thread Mike Christie
On 9/1/14, 1:06 PM, Dan Carpenter wrote: I never heard back on this. It still looks like a very serious bug with security implications etc. Sorry about that. I must have missed the original. You are right. I should have a tested patch by tomorrow. regards, dan carpenter On Mon, Jun 24,

Re: [PATCH] scsi_debug: deadlock between completions and surprise module removal

2014-09-01 Thread Douglas Gilbert
On 14-09-01 11:36 AM, Christoph Hellwig wrote: --- a/drivers/scsi/scsi_debug.c 2014-08-26 13:24:51.646948507 -0400 +++ b/drivers/scsi/scsi_debug.c 2014-08-30 18:04:54.589226679 -0400 @@ -2743,6 +2743,13 @@ static int stop_queued_cmnd(struct scsi_ if (test_bit(k, queued_in_use_bm))

Re: potential buffer overrun in __iscsi_conn_send_pdu()

2014-09-01 Thread Dan Carpenter
I never heard back on this. It still looks like a very serious bug with security implications etc. regards, dan carpenter On Mon, Jun 24, 2013 at 06:46:31PM +0300, Dan Carpenter wrote: > My static checker complains about a possible array overflow in > __iscsi_conn_send_pdu(). > > drivers/scsi/l

Re: [Xen-devel] [PATCH V6 0/5] Add XEN pvSCSI support

2014-09-01 Thread David Vrabel
On 28/08/14 05:44, Juergen Gross wrote: > This series adds XEN pvSCSI support. With pvSCSI it is possible to use > physical > SCSI devices from a XEN domain. Applied to devel/for-linus-3.18. Thanks. Your lines in your descriptions were too long for the default git log format. I fixed this up b

Fwd: Adaptec 71605H HBA randomly failing to detect any drives at init

2014-09-01 Thread Andrew Robertson
Hi, I have an Adaptec 71605H HBA that's randomly failing to detect any drives at boot. I have two systems with this HBA, and both are showing the exact same behavior. I can reproduce this randomly about 3 out of 4 times, where most of the time it comes up where "lsscsi" shows no drives attached

Re: [PATCH] scsi_debug: deadlock between completions and surprise module removal

2014-09-01 Thread Christoph Hellwig
> --- a/drivers/scsi/scsi_debug.c 2014-08-26 13:24:51.646948507 -0400 > +++ b/drivers/scsi/scsi_debug.c 2014-08-30 18:04:54.589226679 -0400 > @@ -2743,6 +2743,13 @@ static int stop_queued_cmnd(struct scsi_ > if (test_bit(k, queued_in_use_bm)) { > sqcp

Re: [PATCH 1/3] scsi/trace: Use macros for getting driver byte, host byte, msg byte, and status byte

2014-09-01 Thread Christoph Hellwig
On Mon, Sep 01, 2014 at 12:33:28PM +, Yoshihiro YUNOMAE wrote: > For getting driver byte, host byte, msg byte, and status byte, macros are > implemented in scsi/scsi.h, so we use it. As mentioned about three times in various previous scsi logging discussions this is entirely wrong and breaks d

Re: [PATCH 13/22] scsi: use local buffer for printing the opcode

2014-09-01 Thread Hannes Reinecke
On 09/01/2014 10:57 AM, Hannes Reinecke wrote: > On 09/01/2014 12:19 AM, Christoph Hellwig wrote: >> On Thu, Aug 28, 2014 at 07:33:27PM +0200, Hannes Reinecke wrote: >>> SCSI opcode printing is tricky and needs to take into account >>> several different corner cases. So instead of trying to come >>

[PATCH 3/3] scsi/trace: Delete a duplicated decoder of SCSI command

2014-09-01 Thread Yoshihiro YUNOMAE
There is a decoder of SCSI command in constants.c, so this patch deletes it in SCSI traveevents. A decoder in traceevents uses macros, so the command name is output as "XXX_YYY_ZZZ". On the other hand, a decoder in constants uses strings, so the command name is output as "Xxx Yyy Zzz" including sp

[ PATCH -logging 0/3] scsi/trace: Delete duplicated decoders

2014-09-01 Thread Yoshihiro YUNOMAE
Hi All, This patchset deletes duplicated decoders in scsi_trace.c. Almost decoders are implemented in constants.c, so we should use them. This patchset deletes following decoders in scsi_trace.c: - hostbyte in patch [2/3] - driverbyte in patch [2/3] - SCSI command in patch [3/3] This patchset

[PATCH 2/3] scsi/trace: Delete duplicated decoders of hostbyte and driverbyte

2014-09-01 Thread Yoshihiro YUNOMAE
There are decoders of hostbyte and driverbyte in constants.c, so this patch deletes those in SCSI traveevents. Note: If CONFIG_SCSI_CONSTANTS is disabled, hostbyte, driverbyte, msgbyte, and statusbyte are output as raw format from this patch. Signed-off-by: Yoshihiro YUNOMAE Cc: Hannes Reinecke

[PATCH 1/3] scsi/trace: Use macros for getting driver byte, host byte, msg byte, and status byte

2014-09-01 Thread Yoshihiro YUNOMAE
For getting driver byte, host byte, msg byte, and status byte, macros are implemented in scsi/scsi.h, so we use it. Signed-off-by: Yoshihiro YUNOMAE Reviewed-by: Ewan D. Milne Reviewed-by: Hannes Reinecke Cc: Hannes Reinecke Cc: Doug Gilbert Cc: Martin K. Petersen Cc: Christoph Hellwig Cc:

Re: [PATCH 13/22] scsi: use local buffer for printing the opcode

2014-09-01 Thread Hannes Reinecke
On 09/01/2014 12:19 AM, Christoph Hellwig wrote: > On Thu, Aug 28, 2014 at 07:33:27PM +0200, Hannes Reinecke wrote: >> SCSI opcode printing is tricky and needs to take into account >> several different corner cases. So instead of trying to come >> up with an elaborate printk() statement we should b

Re: [PATCH 10/22] scsi: consolidate scsi_print_status()

2014-09-01 Thread Hannes Reinecke
On 09/01/2014 12:14 AM, Christoph Hellwig wrote: >> #if defined(AHA152X_DEBUG) >> -if (HOSTDATA(shpnt)->debug & debug_status) { >> -printk(DEBUG_LEAD "inbound status %02x ", CMDINFO(CURRENT_SC), >> CURRENT_SC->SCp.Status); >> -scsi_print_status(CURRENT_SC->SCp.Status);

Re: [PATCH 09/22] Use sdev as argument for scsi_print_result

2014-09-01 Thread Hannes Reinecke
On 09/01/2014 12:11 AM, Christoph Hellwig wrote: > Please also remove the now useless sd_print_result wrapper. > Done. > Otherwise looks good, > > Reviewed-by: Christoph Hellwig > Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage h...@suse.de

Re: [PATCH 08/22] scsi: dump sense buffer only for debugging

2014-09-01 Thread Hannes Reinecke
On 09/01/2014 12:09 AM, Christoph Hellwig wrote: > On Thu, Aug 28, 2014 at 07:33:22PM +0200, Hannes Reinecke wrote: >> Dumping the entire sense buffer might overwhelm the logging functions, >> so suppress it per default. > > Call me dumb, but I don't see anything in here that limits the dumps > to

Re: [PATCH 07/22] scsi: do not decode sense extras

2014-09-01 Thread Hannes Reinecke
On 09/01/2014 12:06 AM, Christoph Hellwig wrote: > On Thu, Aug 28, 2014 at 07:33:21PM +0200, Hannes Reinecke wrote: >> Currently we're only decoding sense extras for tape devices. >> And even there only for fixed format sense formats. >> As this is of rather limited use in the general case we shoul

Re: [PATCH 06/22] scsi: stop decoding if scsi_normalize_sense() fails

2014-09-01 Thread Hannes Reinecke
On 09/01/2014 12:00 AM, Christoph Hellwig wrote: > On Thu, Aug 28, 2014 at 07:33:20PM +0200, Hannes Reinecke wrote: >> If scsi_normalize_sense() fails we couldn't decode the sense >> buffer, so we should not try to interpret the result. >> We should rather dump the sense buffer instead and stop dec

Re: [PATCH 05/22] scsi: Use sdev as argument for sense code printing

2014-09-01 Thread Hannes Reinecke
On 08/31/2014 11:55 PM, Christoph Hellwig wrote: >> -scsi_extd_sense_format(unsigned char asc, unsigned char ascq) { >> +scsi_extd_sense_format(unsigned char asc, unsigned char ascq, >> + const char **fmt) { > > please move the opening brace to a new line per normal Linux style.

Re: [PATCH 04/22] scsi: introduce sdev_prefix_printk()

2014-09-01 Thread Hannes Reinecke
On 08/31/2014 11:43 PM, Christoph Hellwig wrote: > Needs a bit more description in the patch body and preferable also > in a comment next to the macro. What's the benefit of it over simply > using sdev_printk with another argument? > This is particularly useful for ULDs which do not have access t

bitte antworten

2014-09-01 Thread Dr. Martin Dustin
-- Lieber Freund, Wie geht es Ihnen heute? Ich hoffe, fein, ich bin Dr. Martin Dustin aus Harlesden , North West London, hier in England. Ich arbeite für NatWest Bank London (National Westminster Bank Plc. ) . Ich schreibe Ihnen aus meinem Büro , die von einer großen immensen Nutzen für bei