Re: [RFC 00/32] making inode time stamps y2038 ready

2014-05-31 Thread Richard Cochran
On Sat, May 31, 2014 at 12:34:12PM -0700, H. Peter Anvin wrote: > Typically they are using 64-bit signed seconds. Okay, that is what I wanted to know. Thanks, Richard -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org Mor

Re: [RFC 00/32] making inode time stamps y2038 ready

2014-05-31 Thread Richard Cochran
On Sat, May 31, 2014 at 05:23:02PM +0200, Arnd Bergmann wrote: > On Saturday 31 May 2014 16:51:15 Richard Cochran wrote: > > > > Why are some of the time stamp expiration dates marked as "never"? > > It's an approximation: Also, the term "never" might mean using arbitrarily long integers as in A

Re: [RFC 00/32] making inode time stamps y2038 ready

2014-05-31 Thread H. Peter Anvin
Typically they are using 64-bit signed seconds. On May 31, 2014 11:22:37 AM PDT, Richard Cochran wrote: >On Sat, May 31, 2014 at 05:23:02PM +0200, Arnd Bergmann wrote: >> >> It's an approximation: > >(Approximately never ;) > >> with 64-bit timestamps, you can represent close to 300 billion >>

Re: [RFC 00/32] making inode time stamps y2038 ready

2014-05-31 Thread Richard Cochran
On Sat, May 31, 2014 at 05:23:02PM +0200, Arnd Bergmann wrote: > > It's an approximation: (Approximately never ;) > with 64-bit timestamps, you can represent close to 300 billion > years, which is way past the time that our planet can sustain > life of any form[1]. Did you mean mean 64 bits wor

Re: [RFC 00/32] making inode time stamps y2038 ready

2014-05-31 Thread Arnd Bergmann
On Saturday 31 May 2014 16:51:15 Richard Cochran wrote: > On Fri, May 30, 2014 at 10:01:24PM +0200, Arnd Bergmann wrote: > > > > I picked this because it is a fairly isolated problem, as the > > inode time stamps are rarely assigned to any other time values. > > As a byproduct of this work, I docu

Re: [RFC 00/32] making inode time stamps y2038 ready

2014-05-31 Thread Richard Cochran
On Fri, May 30, 2014 at 10:01:24PM +0200, Arnd Bergmann wrote: > > I picked this because it is a fairly isolated problem, as the > inode time stamps are rarely assigned to any other time values. > As a byproduct of this work, I documented for each of the file > systems we support how long the on-d

Re: [RFC 00/32] making inode time stamps y2038 ready

2014-05-31 Thread Vyacheslav Dubeyko
Hi Arnd, On Fri, 2014-05-30 at 22:01 +0200, Arnd Bergmann wrote: [snip] > > Arnd Bergmann (32): > fs: introduce new 'struct inode_time' > uapi: add struct __kernel_timespec{32,64} > fs: introduce sys_utimens64at > fs: introduce sys_newfstat64/sys_newfstatat64 > arch: hook up new stat a

[PATCH 5/11] drivers/scsi/bfa/bfad_bsg.c: Remove useless return variables

2014-05-31 Thread Peter Senna Tschudin
This patch remove variables that are initialized with a constant, are never updated, and are only used as parameter of return. Return the constant instead of using a variable. Verified by compilation only. The coccinelle script that find and fixes this issue is: // @@ type T; constant C; identif

[PATCH 3/11] isci: Remove useless return variables

2014-05-31 Thread Peter Senna Tschudin
This patch remove variables that are initialized with a constant, are never updated, and are only used as parameter of return. Return the constant instead of using a variable. Verified by compilation only. The coccinelle script that find and fixes this issue is: // @@ type T; constant C; identif

Re: [Open-FCoE] [PATCH] bnx2fc: Improve stats update mechanism

2014-05-31 Thread Neil Horman
On Sat, May 31, 2014 at 05:13:11AM +, Eddie Wai wrote: > > > On May 30, 2014, at 7:48 PM, "Neil Horman" wrote: > > > On Fri, May 30, 2014 at 02:59:43PM -0700, Eddie Wai wrote: > >> Thanks for fixing this. The patch generally looks good, but I do have a > >> few comments. > >> > >> On Fri,

[PATCH 3/6] qla2xxx: Restrict max_lun to 16-bit for older HBAs

2014-05-31 Thread Hannes Reinecke
Older HBAs are only capable of supporting 16-bit LUNs, so we need to make sure to adjust max_lun accordingly. Signed-off-by: Hannes Reinecke Acked-by: Chad Dupuis Reviewed-by: Christoph Hellwig Reviewed-by: Ewan Milne --- drivers/scsi/qla2xxx/qla_os.c | 7 ++- 1 file changed, 6 insertions

[PATCH 1/6] scsi: Remove CONFIG_SCSI_MULTI_LUN

2014-05-31 Thread Hannes Reinecke
Obsolete; either use 'max_lun' if the host supports only a limited number of LUNs or BLIST_NOLUN if the target has problems addressing more than one LUN. Signed-off-by: Hannes Reinecke Reviewed-by: Christoph Hellwig Reviewed-by: Ewan Milne --- Documentation/scsi/tmscsim.txt | 2 -- drivers/sc

[PATCH 6/6] scsi_scan: Fixup scsilun_to_int()

2014-05-31 Thread Hannes Reinecke
scsilun_to_int() has an error which prevents it from generating correct LUN numbers for 64bit values. Also we should remove the misleading comment about portions of the LUN being ignored; the initiator should treat the LUN as an opaque value. And, finally, the example given should use the correct p

[PATCHv3 0/6] Support 64-bit LUNs

2014-05-31 Thread Hannes Reinecke
Hi all, this patchset updates the SCSI stack to support full 64-bit LUNs. The first patch is a simple fix; the next patch updates the sequential scan logic to be compliant with SPC. The third patch addresses a firmware issue with earlier qla2xxx HBAs. The next two patches update the SCSI stack and

[PATCH 5/6] scsi: use 64-bit value for 'max_luns'

2014-05-31 Thread Hannes Reinecke
Now that we're using 64-bit LUNs internally we need to increase the size of max_luns to 64 bits, too. Signed-off-by: Hannes Reinecke Reviewed-by: Christoph Hellwig Reviewed-by: Ewan Milne --- drivers/message/i2o/i2o_scsi.c | 2 +- drivers/scsi/advansys.c | 2 +- drivers/sc

[PATCH 2/6] scsi_scan: Restrict sequential scan to 256 LUNs

2014-05-31 Thread Hannes Reinecke
Sequential scan for more than 256 LUNs is very fragile as LUNs might not be numbered sequentially after that point. SAM revisions later than SCSI-3 impose a structure on LUNs larger than 256, making LUN numbers between 256 and 16384 illegal. SCSI-3, however allows for plain 64-bit numbers with no