Get back to me

I am a bank director from Hong Kong, I want you to be my partner in a business project of mutual benefit. Get back to me if interested. Thank you, Kong Hui. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordom

Re: [PATCH 6/6] [SCSI] sd: Implement copy offload support

> "Doug" == Douglas Gilbert writes: Doug, Doug> SPC-4 has downgraded the RECEIVE COPY OPERATION PARAMETERS command Doug> in favour of the new Third Party Copy (TPC) VPD page [0x8f]. If Doug> the latter is present, it should be used. Most real world Doug> implementations of XCOPY(LID1) comply

[PATCH] scsi: pm8001: pm8001_hwi.c: Fix to remove null pointer checks that could never happen

Removal of null pointer checks that could never happen Signed-off-by: Rickard Strandqvist --- drivers/scsi/pm8001/pm8001_hwi.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/pm8001/pm8001_hwi.c b/drivers/scsi/pm8001/pm8001_hwi.c index a97be01..721d059 100644

Re: [PATCH] scsi: pm8001: pm8001_hwi.c: Fix for possible null pointer dereference

Hi Quite rightly, this is what cppcheck reacts. Ok, I'll send a patch for that instead then. Best regards Rickard Strandqvist 2014-05-28 13:38 GMT+02:00 Tomas Henzl : > On 05/28/2014 01:28 PM, Christoph Hellwig wrote: >> On Sun, May 18, 2014 at 06:14:00PM +0200, Rickard Strandqvist wrote: >>>

Re: [PATCH] qla2xxx: Convert to percpu_ida session tag pre-allocation

Nicholas, Answer is below. Regards, Quinn Tran On 5/23/14 7:33 PM, "Nicholas A. Bellinger" wrote: >Hi Qlogic folks, > >A question for you below.. > >On Sat, 2014-05-24 at 00:43 +, Nicholas A. Bellinger wrote: >> From: Nicholas Bellinger >> >> This patch converts qla2xxx target code to

Re: block: remove dead code in scsi_ioctl:blk_verify_command

On 05/29/2014 01:11 PM, Dave Jones wrote: > filter gets assigned the address of blk_default_cmd_filter on > entry to this function, so the !filter condition can never be true. > > Signed-off-by: Dave Jones > > diff --git a/block/scsi_ioctl.c b/block/scsi_ioctl.c > index 26487972ac54..9c28a5b3804

block: remove dead code in scsi_ioctl:blk_verify_command

filter gets assigned the address of blk_default_cmd_filter on entry to this function, so the !filter condition can never be true. Signed-off-by: Dave Jones diff --git a/block/scsi_ioctl.c b/block/scsi_ioctl.c index 26487972ac54..9c28a5b38042 100644 --- a/block/scsi_ioctl.c +++ b/block/scsi_ioctl

[PATCH 2 12/24] hpsa: avoid unnecessary readl on every command submission

From: Stephen M. Cameron for controllers which support either of the ioaccel transport methods. Signed-off-by: Stephen M. Cameron Reviewed-by: Mike Miller Reviewed-by: Joe Handzik --- drivers/scsi/hpsa.c |7 +++ drivers/scsi/hpsa.h | 15 ++- 2 files changed, 21 insertio

[PATCH 2 22/24] hpsa: fix bad comparison of signed with unsigned in hpsa_update_scsi_devices

From: Joe Handzik rescan_hba_mode was defined as a u8 so could never be less than zero: rescan_hba_mode = hpsa_hba_mode_enabled(h); if (rescan_hba_mode < 0) goto out; Signed-off-by: Joe Handzik Signed-off-by: Stephen M. Cameron Reviewed-by: Stephen M. Cameron

[PATCH 2 16/24] hpsa: fix event filtering to prevent excessive rescans with old firmware

From: Stephen M. Cameron CTLR_STATE_CHANGE_EVENT and CTLR_STATE_CHANGE_EVENT_REDUNDANT_CNTRL do not require rescans to be initiated. Current firmware filters out these events already, but some out of date firmware doesn't, so the driver needs to filter them out too. Without this change and with

[PATCH 2 24/24] hpsa: fix handling of hpsa_volume_offline return value

From: Stephen M. Cameron Make return value an int instead of an unsigned char so that we do not lose negative error return values. Signed-off-by: Stephen M. Cameron Reviewed-by: Webb Scales Reported-by: Dan Carpenter --- drivers/scsi/hpsa.c | 12 drivers/scsi/hpsa_cmd.h |

[PATCH 2 18/24] hpsa: report check condition even if no sense data present for ioaccel2 mode

From: Stephen M. Cameron It shouldn't happen that we get a check condition with no sense data, but if it does, we shouldn't just drop the check condition on the floor. Signed-off-by: Stephen M. Cameron Reviewed-by: Justin Lindley Reviewed-by: Mike Miller --- drivers/scsi/hpsa.c |7 +-

[PATCH 2 23/24] hpsa: return -ENOMEM not -1 on kzalloc failure in hpsa_get_device_id

From: Stephen M. Cameron Signed-off-by: Stephen M. Cameron Reported-by: Dan Carpenter Reviewed-by: Mike Miller --- drivers/scsi/hpsa.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index c5b24e6..af51e7d 100644 --- a/driver

[PATCH 2 17/24] hpsa: remove bad unlikely annotation from device list updating code

From: Stephen M. Cameron Signed-off-by: Stephen M. Cameron Reviewed-by: Justin Lindley Reviewed-by: Mike Miller --- drivers/scsi/hpsa.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 8359884..9d4a0bd 100644 --- a/drive

[PATCH 2 20/24] hpsa: do not ignore failure of sense controller parameters command

From: Joe Handzik Signed-off-by: Joe Handzik Signed-off-by: Stephen M. Cameron Reviewed-by: Stephen M. Cameron --- drivers/scsi/hpsa.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index e2f85e7..b4b745b 100644 --- a/

[PATCH 2 14/24] hpsa: define extended_report_lun_entry data structure

From: Stephen M. Cameron Signed-off-by: Stephen M. Cameron Reviewed-by: Joe Handzik --- drivers/scsi/hpsa.c | 21 - drivers/scsi/hpsa_cmd.h | 12 +++- 2 files changed, 19 insertions(+), 14 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c

[PATCH 2 21/24] hpsa: remove messages about volume status VPD inquiry page not supported

From: Stephen M. Cameron They are annoying and do not help anyone. Signed-off-by: Stephen M. Cameron Reviewed-by: Justin Lindley Reviewed-by: Mike Miller --- drivers/scsi/hpsa.c | 12 +++- 1 files changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/

[PATCH 2 19/24] hpsa: fix memory leak in hpsa_hba_mode_enabled

From: Joe Handzik And while we're at it fix a magic number Signed-off-by: Joe Handzik Signed-off-by: Stephen M. Cameron Reviewed-by: Stephen M. Cameron --- drivers/scsi/hpsa.c |7 ++- drivers/scsi/hpsa.h |1 + 2 files changed, 7 insertions(+), 1 deletions(-) diff --git a/drivers

[PATCH 2 04/24] hpsa: allow passthru ioctls to work with bidirectional commands

From: Stephen M. Cameron Treat the the data direction bits as a bit mask allowing both READ and WRITE at the same time instead of testing for equality to see if it's a exclusively a READ or a WRITE. Signed-off-by: Stephen M. Cameron Reviewed-by: Mike Miller Reviewed-by: Webb Scales --- drive

[PATCH 2 03/24] hpsa: remove unused fields from struct ctlr_info

From: Stephen M. Cameron The fields "major", "max_outstanding", and "usage_count" of struct ctlr_info were not used for anything. Signed-off-by: Stephen M. Cameron Reviewed-by: Mike Miller Reviewed-by: Webb Scales --- drivers/scsi/hpsa.c |2 -- drivers/scsi/hpsa.h |3 --- 2 files cha

[PATCH 2 06/24] hpsa: use gcc aligned attribute instead of manually padding structs

From: Stephen M. Cameron Signed-off-by: Stephen M. Cameron Reviewed-by: Webb Scales --- drivers/scsi/hpsa.c |3 --- drivers/scsi/hpsa_cmd.h | 33 ++--- 2 files changed, 6 insertions(+), 30 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.

[PATCH 2 11/24] hpsa: use per-cpu variable for lockup_detected

From: Stephen M. Cameron Avoid excessive locking by using per-cpu variable for lockup_detected Signed-off-by: Stephen M. Cameron Reviewed-by: Scott Teel --- drivers/scsi/hpsa.c | 80 ++- drivers/scsi/hpsa.h |2 + 2 files changed, 54 insert

[PATCH 2 15/24] hpsa: kill annoying messages about SSD Smart Path retries

From: Stephen M. Cameron There's nothing the user can or should do about these messages, the commands are retried down the normal RAID path, and the messages just flood the logs and sap performance. Signed-off-by: Stephen M. Cameron Reviewed-by: Joe Handzik Reviewed-by: Mike Miller --- drive

[PATCH 2 07/24] hpsa: remove dev_dbg() calls from hot paths

From: Stephen M. Cameron They are not completely free of cost when disabled and when enabled emitting debug output for every command submitted produces far too much output to be useful. Signed-off-by: Stephen M. Cameron Reviewed-by: Mike Miller Reviewed-by: Webb Scales --- drivers/scsi/hpsa.

[PATCH 2 10/24] hpsa: set irq affinity hints to route MSI-X vectors across CPUs

From: Stephen M. Cameron Signed-off-by: Stephen M. Cameron Reviewed-by: Mike Miller Reviewed-by: Scott Teel --- drivers/scsi/hpsa.c | 17 - 1 files changed, 16 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 9c44f26..e8090e2 100644

[PATCH 2 05/24] hpsa: change doorbell reset delay to ten seconds

From: Justin Lindley After 3.22 firmware, PMC firmware guys tell us the previous 5 second delay after a reset now needs to be 10 secs to avoid a PCIe error due to the driver looking at the controller too soon after the reset. Signed-off-by: Justin Lindley Signed-off-by: Stephen M. Cameron Revi

[PATCH 2 13/24] hpsa: Rearrange start_io to avoid one unlock/lock sequence in main io path

From: Stephen M. Cameron Signed-off-by: Stephen M. Cameron Reviewed-by: Joe Handzik --- drivers/scsi/hpsa.c | 24 1 files changed, 16 insertions(+), 8 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index ad73017..c6ed5ea 100644 --- a/drivers/scs

[PATCH 2 09/24] hpsa: allocate reply queues individually

From: Stephen M. Cameron Now that we can allocate more than 4 reply queues (up to 64) we shouldn't try to make them share the same allocation but should allocate them separately. Signed-off-by: Stephen M. Cameron Reviewed-by: Mike Miller Reviewed-by: Scott Teel --- drivers/scsi/hpsa.c | 53

[PATCH 2 08/24] hpsa: choose number of reply queues more intelligently.

From: Stephen M. Cameron No sense having 8 or 16 reply queues if you only have 4 cpus, and likewise no sense limiting to 8 reply queues if you have many more cpus. Signed-off-by: Stephen M. Cameron Reviewed-by: Mike Miller Reviewed-by: Scott Teel --- drivers/scsi/hpsa.c |2 ++ driver

[PATCH 2 02/24] hpsa: fix missing check of kzalloc return value

From: Joe Handzik Signed-off-by: Scott Teel Signed-off-by: Joe Handzik Signed-off-by: Stephen M. Cameron Reviewed-by: Stephen M. Cameron Cc: sta...@vger.kernel.org --- drivers/scsi/hpsa.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/

[PATCH 2 00/24] Resend of May 2014 patches for hpsa driver

Not a lot of extensive changes in this set, some new PCI IDs, some small bug fixes, quieting some noisy messages, allowing more reply queues, setting irq affinity hints, and some minor locking improvments. Two patches are slightly changed since they were first sent due to reviewer comments and som

[PATCH 2 01/24] hpsa: add new Smart Array PCI IDs (May 2014)

From: Joe Handzik Signed-off-by: Scott Teel Signed-off-by: Joe Handzik Signed-off-by: Stephen M. Cameron Reviewed-by: Stephen M. Cameron Cc: sta...@vger.kernel.org --- drivers/scsi/hpsa.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/drivers/scsi/hpsa.c

Re: [PATCH v2, repost] hpsa: remove unneeded loop

On 05/29/2014 04:51 PM, scame...@beardog.cce.hp.com wrote: > On Thu, May 29, 2014 at 04:02:19PM +0200, Tomas Henzl wrote: >> Originally this was first patch in a series, but while the other patches >> were accepted, this one was forgotten. >> The code below is adapted for the latest sources. >> >>

Re: [PATCH 3/4] scsi: increase upper limit for max_sectors

2014-05-29 1:18 GMT+09:00 Elliott, Robert (Server Storage) : > >> -Original Message- >> From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- >> ow...@vger.kernel.org] On Behalf Of Akinobu Mita >> Sent: Sunday, 25 May, 2014 7:44 AM >> To: linux-scsi@vger.kernel.org >> Cc: Akinobu Mita;

Re: [PATCH v2, repost] hpsa: remove unneeded loop

On Thu, May 29, 2014 at 04:02:19PM +0200, Tomas Henzl wrote: > Originally this was first patch in a series, but while the other patches > were accepted, this one was forgotten. > The code below is adapted for the latest sources. > > The cmd_pool_bits is protected everywhere with a spinlock, > we

Re: [PATCH 6/6] [SCSI] sd: Implement copy offload support

On 14-05-28 11:52 PM, Martin K. Petersen wrote: Implement support for hardware copy offload. This initial implementation only supports EXTENDED COPY(LID1). If need be we can add support for LID4 or token copy at a later date. If a device has the 3PC flag set in the standard INQUIRY response we'l

[PATCH v2, repost] hpsa: remove unneeded loop

Originally this was first patch in a series, but while the other patches were accepted, this one was forgotten. The code below is adapted for the latest sources. The cmd_pool_bits is protected everywhere with a spinlock, we don't need the test_and_set_bit, set_bit is enough and the loop can be re

Re: Make SCSI error handler code easier to understand

On Wed, 2014-05-28 at 16:15 -0400, Joe Lawrence wrote: > On Mon, 26 May 2014 17:12:27 +0200 > Bart Van Assche wrote: > > > Every now and then someone asks how it is avoided that the SCSI error > > handler and the SCSI completion handler are invoked concurrently for > > the same SCSI command. Henc

Re: [PATCHv2 0/5] Support 64-bit LUNs

On Wed, 2014-05-28 at 03:56 -0700, Christoph Hellwig wrote: > James, can you take a look at this series? I would be great to get it > merged for 3.16! Remind me how we're planning to fix the conversion bug in scsilun_to_int, it doesn't seem to be in the patch series anymore... I remember there we